From: Aaron Nyholm
---
cpukit/dev/flash/flashdev.c | 902
cpukit/include/dev/flash/flashdev.h | 459 ++
spec/build/cpukit/librtemscpu.yml | 4 +
3 files changed, 1365 insertions(+)
create mode 100644 cpukit/dev/flash/flashdev.c
create mode
I'm satisfied with the API. I have a couple minor comments on the
implementation.
On Thu, Apr 20, 2023 at 1:23 AM wrote:
>
> From: Aaron Nyholm
>
> ---
> cpukit/dev/flash/flashdev.c | 849
> cpukit/include/dev/flash/flashdev.h | 458 +++
>
Great, if you could add a note to that IOCTL to that effect before commit,
that'd be great since consumers shouldn't rely on it to alter their consumption
of the API. Otherwise, looks good to me!
Kinsey
On Apr 23, 2023, at 21:45, Aaron Nyholm
mailto:aaron.nyh...@unfoldedeffective.com>>
wrote:
Yes, it is purely informational. It just returns the 3-byte JEDEC ID.
Regards,
Aaron.
--- Original Message ---
On Monday, April 24th, 2023 at 12:35 PM, Kinsey Moore
wrote:
> I noticed that there is provision here to pass through the JEDEC ID from the
> physical device (obtained by a
I noticed that there is provision here to pass through the JEDEC ID from
the physical device (obtained by a JEDEC parameter page read, ONFI
parameter page read, or other mechanism).
Is this intended to be purely informational?
Kinsey
On Thu, Apr 20, 2023 at 2:23 AM wrote:
> From: Aaron Nyholm
From: Aaron Nyholm
---
cpukit/dev/flash/flashdev.c | 849
cpukit/include/dev/flash/flashdev.h | 458 +++
spec/build/cpukit/librtemscpu.yml | 4 +
3 files changed, 1311 insertions(+)
create mode 100644 cpukit/dev/flash/flashdev.c
create mode
Attached is next iteration for the flashdev API. The allocating of
memory used by the region functionality of the API has been moved
to the device driver to allow different device drivers to have
a different number of maximum regions.
Other small changes like fixing spelling errors were made and
On 20/4/2023 7:42 am, Gedare Bloom wrote:
> On Mon, Apr 17, 2023 at 9:55 PM Chris Johns wrote:
>>
>> On 18/4/2023 1:48 pm, Gedare Bloom wrote:
>>> On Sun, Apr 16, 2023 at 6:48 PM Aaron Nyholm
>>> wrote:
As for the RTEMS_FLASHDEV_MAX_REGIONS being set at 32 I chose the value as
it
On Mon, Apr 17, 2023 at 9:55 PM Chris Johns wrote:
>
> On 18/4/2023 1:48 pm, Gedare Bloom wrote:
> > On Sun, Apr 16, 2023 at 6:48 PM Aaron Nyholm
> > wrote:
> >> As for the RTEMS_FLASHDEV_MAX_REGIONS being set at 32 I chose the value as
> >> it seamed a good balance between memory usage and
On 18/4/2023 1:48 pm, Gedare Bloom wrote:
> On Sun, Apr 16, 2023 at 6:48 PM Aaron Nyholm
> wrote:
>> As for the RTEMS_FLASHDEV_MAX_REGIONS being set at 32 I chose the value as
>> it seamed a good balance between memory usage and function. I wanted to
>> avoid using malloc as your previous
On Sun, Apr 16, 2023 at 6:48 PM Aaron Nyholm
wrote:
>
> Hi Gedare,
>
> Thanks for the feedback you’ve provided. I have a couple questions.
>
> You suggest refactoring the callouts into another sturct, I’m happy to do so.
> I originally chose not to as I was was basing the high level structure
Hi Gedare,
Thanks for the feedback you’ve provided. I have a couple questions.
You suggest refactoring the callouts into another sturct, I’m happy to do so. I
originally chose not to as I was was basing the high level structure off the
i2c API already in RTEMS. Just clarifying it’s worth
I focused my review on the API. See below.
On Thu, Apr 6, 2023 at 1:08 AM wrote:
>
> From: Aaron Nyholm
>
[...]
> diff --git a/cpukit/include/dev/flash/flashdev.h
> b/cpukit/include/dev/flash/flashdev.h
> new file mode 100644
> index 00..5d53ea7b97
> --- /dev/null
> +++
From: Aaron Nyholm
---
cpukit/dev/flash/flashdev.c | 732
cpukit/include/dev/flash/flashdev.h | 437 +
spec/build/cpukit/librtemscpu.yml | 4 +
3 files changed, 1173 insertions(+)
create mode 100644 cpukit/dev/flash/flashdev.c
create
From: Aaron Nyholm
---
cpukit/dev/flash/flashdev.c | 732
cpukit/include/dev/flash/flashdev.h | 437 +
spec/build/cpukit/librtemscpu.yml | 4 +
3 files changed, 1173 insertions(+)
create mode 100644 cpukit/dev/flash/flashdev.c
create
Some comments below. However, I think it will be best to first re-send
just the flashdev.h file so that we can iterate on the API before you
put too much more effort into implementing it.
On Wed, Mar 15, 2023 at 8:56 PM wrote:
>
> From: Aaron Nyholm
>
> Updates #4896
I don't see a ticket with
From: Aaron Nyholm
Updates #4896
---
cpukit/dev/flash/flashdev.c | 353
cpukit/include/dev/flash/flashdev.h | 95
spec/build/cpukit/librtemscpu.yml | 4 +
3 files changed, 452 insertions(+)
create mode 100644 cpukit/dev/flash/flashdev.c
17 matches
Mail list logo
