C version of ucs2any.pl

2003-09-18 Thread Matthieu Herrb
Hi, It seems to me that the C langage version of ucs2any.pl developped by Ben Collver and other NetBSD developpers is now stable enough to be included in XFree86. I've put a patch against the current XFree86 CVS version at for those who'd like to revi

Re: C version of ucs2any.pl

2003-09-18 Thread Harold L Hunt II
Matthieu, I appreciate the notification in advance of committing something like this. I am doing a build test right now on Cygwin. I will let you know if I find any problems. Harold Matthieu Herrb wrote: Hi, It seems to me that the C langage version of ucs2any.pl developped by Ben Collver

Re: C version of ucs2any.pl

2003-09-18 Thread Harold L Hunt II
Matthieu, I found two things: 1) In ucs2any.c the libgen.h header is included only to provide basename, while a local definition of basename is provided for those platforms that don't have it. However, libgen.h is still included even on those platforms that define NEED_BASENAME. Thus, the bu

Re: C version of ucs2any.pl

2003-09-18 Thread Harold L Hunt II
Matthieu, I found another thing: In Imakefile, the SimpleProgramTarget(ucs2any) should really be something along the lines of: #if CrossCompiling SimpleHostProgramTarget(ucs2any) #else SimpleProgramTarget(ucs2any) #endif This should be fine unless the ucs2any executable is intended to be insta

Re: C version of ucs2any.pl

2003-09-18 Thread Matthias Scheler
On Thu, Sep 18, 2003 at 10:58:19PM +0200, Matthieu Herrb wrote: > It seems to me that the C langage version of ucs2any.pl developped by > Ben Collver and other NetBSD developpers is now stable enough to be > included in XFree86. Two comments: 1.) While it is stable enough it is quite slow due to e

Re: C version of ucs2any.pl

2003-09-19 Thread Harold L Hunt II
Matthieu (and Matthias), Matthias Scheler wrote: On Thu, Sep 18, 2003 at 10:58:19PM +0200, Matthieu Herrb wrote: It seems to me that the C langage version of ucs2any.pl developped by Ben Collver and other NetBSD developpers is now stable enough to be included in XFree86. Two comments: 1.) Whil

Re: C version of ucs2any.pl

2003-09-19 Thread David Dawes
On Fri, Sep 19, 2003 at 02:01:00PM -0400, Harold L Hunt II wrote: >Matthieu (and Matthias), > > >Matthias Scheler wrote: > >> On Thu, Sep 18, 2003 at 10:58:19PM +0200, Matthieu Herrb wrote: >> >>>It seems to me that the C langage version of ucs2any.pl developped by >>>Ben Collver and other NetBSD

Re: C version of ucs2any.pl

2003-09-19 Thread Harold L Hunt II
David Dawes wrote: On Fri, Sep 19, 2003 at 02:01:00PM -0400, Harold L Hunt II wrote: Matthieu (and Matthias), Matthias Scheler wrote: On Thu, Sep 18, 2003 at 10:58:19PM +0200, Matthieu Herrb wrote: It seems to me that the C langage version of ucs2any.pl developped by Ben Collver and other Ne

Re: C version of ucs2any.pl

2003-09-19 Thread David Dawes
On Fri, Sep 19, 2003 at 03:38:14PM -0400, Harold L Hunt II wrote: >David Dawes wrote: > >> On Fri, Sep 19, 2003 at 02:01:00PM -0400, Harold L Hunt II wrote: >> >>>Matthieu (and Matthias), >>> >>> >>>Matthias Scheler wrote: >>> >>> On Thu, Sep 18, 2003 at 10:58:19PM +0200, Matthieu Herrb wrote:

Re: C version of ucs2any.pl

2003-09-20 Thread Matthieu Herrb
David Dawes wrote (in a message from Friday 19) > > If it does need to be done in the includes phase, for example, because > a host version of ucs2any is needed to do the conversion when > cross-compliling, but a target version of ucs2any needs to get built > later for installation, After lo

Re: C version of ucs2any.pl

2003-09-20 Thread David Dawes
On Sat, Sep 20, 2003 at 03:56:51PM +0200, Matthieu Herrb wrote: >David Dawes wrote (in a message from Friday 19) > > > > If it does need to be done in the includes phase, for example, because > > a host version of ucs2any is needed to do the conversion when > > cross-compliling, but a target versi

Re: C version of ucs2any.pl

2003-09-21 Thread Egbert Eich
David Dawes writes: > > BTW, how are things like host vs target imake binaries handled when > cross-compiling? > Currently in most cases the installed versions are used. Only imake is compiled as HostProgramTarget(). I don't recall if a target version is ever built and installed. This should

Re: C version of ucs2any.pl

2003-09-21 Thread Craig Groeschel
> NormalProgramTarget(ucs2any, ucs2any.o, , , ) In general, please use NullParameter as a placeholder instead of space in imake macroes. On some OSs it will either cause it to throw a fit during the build or the Makefile will look ugly or both. = -- Craig Groeschel >ladder91 at yahoo dot