richardelling commented on this pull request.
> @@ -55,11 +55,10 @@ extern boolean_t zfs_free_leak_on_eio;
#defineZFS_DEBUG_DNODE_VERIFY (1 << 2)
#defineZFS_DEBUG_SNAPNAMES (1 << 3)
#defineZFS_DEBUG_MODIFY(1 << 4)
-#define
@brad-lewis pushed 1 commit.
8d8a566 9236 nuke spa_dbgmsg
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/openzfs/openzfs/pull/580/files/9e6bd4e52120bc9b0a0176656bf8753b7c121e5c..8d8a56690529bd2addca6c6602ee0ea1e1bbb8b3
@brad-lewis pushed 1 commit.
6a011e2 9236 nuke spa_dbgmsg
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/openzfs/openzfs/pull/580/files/b2e7f36afc829bb3e9ac87f479fab2e213f41a6e..6a011e28705ad106f2a2809be864d58db95bbe05
brad-lewis commented on this pull request.
> @@ -1431,6 +1433,7 @@ vdev_open(vdev_t *vd)
vd->vdev_asize = asize;
vd->vdev_max_asize = max_asize;
vd->vdev_ashift = MAX(ashift, vd->vdev_ashift);
+ vd->vdev_ashift =
yuripv commented on this pull request.
> @@ -1675,6 +1675,26 @@ function is_pool_removed #pool
return $?
}
+function wait_for_degraded
+{
+ typeset pool=$1
+ typeset timeout=${2:-30}
+ typeset t0=$SECONDS
+
+ while :; do
+ zpool status -v $pool
Closed #557 via d5f3b84d166280cacd80f02bac022e4090e96bd7.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/557#event-1507117709
--
openzfs:
Latest build still gives me the page fault from above.
Without using a cache device I get "Invalid dnode block MAC" when doing zfs
send -c -I from an unencrypted to an encrypted dataset. Core for this case is
at https://www.magentacloud.de/lnk/3MrBVdQy
A full send does work.
--
You are
don-brady approved this pull request.
LGTM
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/559#pullrequestreview-101642468
--
openzfs:
Reviewed by: Matt Ahrens
Reviewed by: Chris Williamson
Test 13 would fail because of attempts to zpool destroy -f a pool that was
still busy. Changed those calls to destroy_pool which does a retry loop, and
the problem is no longer reproducible.