richardelling commented on this pull request.


> @@ -55,11 +55,10 @@ extern boolean_t zfs_free_leak_on_eio;
 #define        ZFS_DEBUG_DNODE_VERIFY          (1 << 2)
 #define        ZFS_DEBUG_SNAPNAMES             (1 << 3)
 #define        ZFS_DEBUG_MODIFY                (1 << 4)
-#define        ZFS_DEBUG_SPA                   (1 << 5)

agree. It is more important that the existing, operable values remain <<6, <<7, 
... than <<5 is used. One disadvantage of using bitmasks. This LGTM. Thanks

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/580#discussion_r172722215
------------------------------------------
openzfs: openzfs-developer
Permalink: 
https://openzfs.topicbox.com/groups/developer/discussions/T15bf5c1e0b672170-M2d75cb6b3003fe890895794c
Delivery options: https://openzfs.topicbox.com/groups

Reply via email to