Re: [developer] Is L2ARC read process single-threaded?

2018-08-30 Thread Wojciech Kruzel via openzfs-developer
On Thursday, 30 August 2018, 18:38:48 GMT+1, Richard Elling wrote: flamegraphs sample stacks executing on CPUs. They are useless for the analysis you're looking for.ZFS knows nothing about NVMe, SATA, SCSI, or any other low-level block protocol. Nor does it care.To get to your answer,

Re: [developer] Is L2ARC read process single-threaded?

2018-08-30 Thread Richard Elling
> On Aug 30, 2018, at 7:15 AM, w.kruzel via openzfs-developer > wrote: > > The flamegraphs are here: > https://drive.google.com/open?id=1vM-5wy4s-QhV2D3hBVh5bPgaqPqEKsMa > > > There are 11 of them. > Files out.svg to

Re: [developer] Potential bug recently introduced in arc_adjust() that leads to unintended pressure on MFU eventually leading to dramatic reduction in its size

2018-08-30 Thread Richard Elling
Hi Mark, yes, this is the change I've tested on ZoL. It is a trivial, low-risk change that is needed to restore the previous behaviour. -- richard > On Aug 30, 2018, at 7:40 AM, Mark Johnston wrote: > > On Thu, Aug 30, 2018 at 09:55:27AM +0300, Paul wrote: >> 30 August 2018, 00:22:14, by

[developer] Re: Potential bug recently introduced in arc_adjust() that leads to unintended pressure on MFU eventually leading to dramatic reduction in its size

2018-08-30 Thread Mark Johnston
On Thu, Aug 30, 2018 at 09:55:27AM +0300, Paul wrote: > 30 August 2018, 00:22:14, by "Mark Johnston" : > > > On Wed, Aug 29, 2018 at 12:42:33PM +0300, Paul wrote: > > > Hello team, > > > > > > > > > It seems like a commit on Mar 23 introduced a bug: if during execution of > > > arc_adjust() >

[developer] Re[2]: Potential bug recently introduced in arc_adjust() that leads to unintended pressure on MFU eventually leading to dramatic reduction in its size

2018-08-30 Thread Paul
30 August 2018, 00:22:14, by "Mark Johnston" : > On Wed, Aug 29, 2018 at 12:42:33PM +0300, Paul wrote: > > Hello team, > > > > > > It seems like a commit on Mar 23 introduced a bug: if during execution of > > arc_adjust() > > target is reached after MRU is evicted current code continues

Re: [developer] Re: Is L2ARC read process single-threaded?

2018-08-30 Thread w.kruzel via openzfs-developer
The flamegraphs are here: https://drive.google.com/open?id=1vM-5wy4s-QhV2D3hBVh5bPgaqPqEKsMa There are 11 of them. Files out.svg to out4.svg are dtrace flamegraphs of reading when L2ARC has been in use. out5.svg to out10.svg are dtrace flamegraphs of usign nvmecontrol command - in read mode