Closed #505 via 862ff6d99c6366f6258ffce1b7f45bb10ae42fa7.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/505#event-1472496551
--
Yes. The test failure is unrelated to these changes. I'll open the RTI today;
thanks all.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/505#issuecomment-365344721
Perfect! Please RTI as soon as you can.
P.S.
I do not understand the latest build failure, seems like an infra problem:
http://jenkins.open-zfs.org/blue/organizations/jenkins/openzfs%2Fopenzfs/detail/PR-505/6/pipeline/179
--
You are receiving this because you are subscribed to this thread.
@grwilson pushed 1 commit.
1d7e2b0 all bits
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/openzfs/openzfs/pull/505/files/445e55128ca0a1cf9b0a7013d996edd50da3a0f4..1d7e2b0d0cb2416d9838f0bd25fc174f31c4be09
avg-I commented on this pull request.
> @@ -3534,11 +3545,11 @@ zio_done(zio_t *zio)
* If our children haven't all completed,
* wait for them and then repeat this pipeline stage.
*/
- if (zio_wait_for_children(zio, ZIO_CHILD_VDEV, ZIO_WAIT_DONE) ||
-
avg-I approved this pull request.
LGTM
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/505#pullrequestreview-95624832
--
openzfs-developer
@grwilson pushed 1 commit.
445e551 predefine child bits
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/openzfs/openzfs/pull/505/files/b1342b226af1aa8a39cbcbe3b59a9270765c8ef2..445e55128ca0a1cf9b0a7013d996edd50da3a0f4
Maybe even `ZIO_GANG_BIT`, etc.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/505#issuecomment-364269552
--
openzfs-developer
Archives:
@grwilson this looks good to me!
But... But! I've wondered only __just now__ if we could have best of both
approaches by pre-defining the child type bits. E.g.
```
#define ZIO_CHILD_BIT_GANGZIO_CHILD_BIT(ZIO_CHILD_GANG)
```
... or something like that.
Maybe that could help to make the code
youzhongyang commented on this pull request.
It looks good to me. Thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/505#pullrequestreview-95227067
@youzhongyang @avg-I can you take another look to make sure I've address all of
your concerns?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/505#issuecomment-364239237
Your comments are considered and I will be pushing a new commit with the
updated logic. I've tried several variations to the suggestions to find which
looks the best and has the least amount of impact. The suggested
`ZIO_CHILD_BIT` option looks the best so I've gone with that option.
--
You
so our comments will not be considered?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/505#issuecomment-364225821
--
openzfs-developer
ahrens approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/505#pullrequestreview-95183334
--
openzfs-developer
[ping]
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/505#issuecomment-361855336
--
openzfs-developer
Archives:
grwilson commented on this pull request.
> @@ -209,12 +209,13 @@ enum zio_flag {
ZIO_FLAG_CANFAIL)
enum zio_child {
- ZIO_CHILD_VDEV = 0,
- ZIO_CHILD_GANG,
- ZIO_CHILD_DDT,
- ZIO_CHILD_LOGICAL,
- ZIO_CHILD_TYPES
+ ZIO_CHILD_VDEV = 1 << 0,
Also, looks like the build error is actually a transient problem in the
infrastructure...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/505#issuecomment-353045436
Thanks for the analysis and the fix.
I guess highbit64() is not cheap, so likely the fix can be simplified.
How about this:
static boolean_t
zio_wait_for_children(zio_t *zio, uint32_t children_bits, enum zio_wait_type
wait)
{
boolean_t waiting = B_FALSE;
18 matches
Mail list logo
