Re: [OpenZFS Developer] usedbydataset > refquota ?

2014-11-17 Thread Fred Liu
Matt, Thank you so much! ^--^. See my comment below. Fred From: Matthew Ahrens [mailto:mahr...@delphix.com] Sent: 星期一, 十一月 17, 2014 15:52 To: Fred Liu Cc: z...@lists.illumos.org; developer@open-zfs.org Subject: Re: [OpenZFS Developer] usedbydataset > refquota ? On Sun, Nov 16, 2014 at 10:46

[OpenZFS Developer] Guide I wrote about recovering my raidz ZFS from FAILED state

2014-11-17 Thread Venci Vatashki
Hello, I had two disk failures on raidz1 array running on zfs-fuse. Here is guide I made during my recovery http://vvatashki.com/2014/10/zfs-recover/ . It should be useful to someone. -- Venci Vatashki ___ developer mailing list developer@open-zfs.org h

Re: [OpenZFS Developer] Jsonify outputs

2014-11-17 Thread Goulven Riou
Hi Matt, thanks for your comments on the pull request we have corrected the style error and applied your suggestions. Regarding the dataset name as a key, the json are consumed by some code and we don't know in advance what key name that we will have, so list is preferable to iter over json struct

Re: [OpenZFS Developer] Jsonify outputs

2014-11-17 Thread Matthew Ahrens
On Mon, Nov 17, 2014 at 9:39 AM, Goulven Riou wrote: > > Hi Matt, > thanks for your comments on the pull request > we have corrected the style error and applied your suggestions. > > Regarding the dataset name as a key, > the json are consumed by some code and we don't know in advance what key >

Re: [OpenZFS Developer] Jsonify outputs

2014-11-17 Thread Francois Billard
2014-11-17 18:58 GMT+01:00 Matthew Ahrens : > On Mon, Nov 17, 2014 at 9:39 AM, Goulven Riou > wrote: > >> >> Hi Matt, >> thanks for your comments on the pull request >> we have corrected the style error and applied your suggestions. >> >> Regarding the dataset name as a key, >> the json are consu

Re: [OpenZFS Developer] Jsonify outputs

2014-11-17 Thread Matthew Ahrens
On Mon, Nov 17, 2014 at 10:22 AM, Francois Billard < francois.bill...@alyseo.com> wrote: > 2014-11-17 18:58 GMT+01:00 Matthew Ahrens : > >> On Mon, Nov 17, 2014 at 9:39 AM, Goulven Riou >> wrote: >> >>> >>> Hi Matt, >>> thanks for your comments on the pull request >>> we have corrected the style

Re: [OpenZFS Developer] Review Request 127: 5311 traverse_dnode may report success when it should not

2014-11-17 Thread Will Andrews
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/127/#review337 --- Ship it! Ship It! - Will Andrews On Nov. 15, 2014, 4:38 p.m., Andriy

Re: [OpenZFS Developer] Review Request 64: 5312: Decouple libzfs from the kernel's zfs_context.h.

2014-11-17 Thread Will Andrews
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/64/#review338 --- Shouldn't the copyright be updated? Other than that, LGTM. - Will Andre

Re: [OpenZFS Developer] Review Request 126: [5310] Remove always true tests for non-NULL ds->ds_phys

2014-11-17 Thread Will Andrews
--- This is an automatically generated e-mail. To reply, visit: https://reviews.csiden.org/r/126/#review339 --- Ship it! Ship It! - Will Andrews On Nov. 16, 2014, 12:01 a.m., Justi

Re: [OpenZFS Developer] usedbydataset > refquota ?

2014-11-17 Thread Fred Liu
It looks I have typo in following: /* All of these (used, usedby*, refer, quota, refquota) include metadata (e.g. indirect blocks). [Fred]: So “quota” overrides “refquota” as in my case? Otherwise the logic should be {“used” < “referenced” < “refquota”} per this reply. */ The one I want to

Re: [OpenZFS Developer] usedbydataset > refquota ?

2014-11-17 Thread Matthew Ahrens
On Mon, Nov 17, 2014 at 8:19 PM, Fred Liu wrote: > It looks I have typo in following: > > /* > > All of these (used, usedby*, refer, quota, refquota) include metadata > (e.g. indirect blocks). > > [Fred]: So “quota” overrides “refquota” as in my case? Otherwise the logic > should be {“used” < “re