[Development] Question about tests/manual folders

2019-09-19 Thread Asmo Saarela
Hi all, I would like to understand the content and the use of the manual test assets in the Qt modules. Could you provide a few examples of how you are using, maintaining, and developing those? It seems that there are some 439 folders related to the manual tests in the repositories: /tests/man

Re: [Development] Nominating Kirill Burtsev as Approver

2019-09-19 Thread Alex Blasche
Congratulations to Kirill. Approver rights have been granted. -- Alex From: Development on behalf of Michael Bruning Sent: Thursday, 29 August 2019 14:54 To: development@qt-project.org Subject: [Development] Nominating Kirill Burtsev as Approver Hi all

Re: [Development] INTEGRITY

2019-09-19 Thread Tuukka Turunen
Or remove the wiki entry and make sure platform notes in documentation are in shape? No need for duplicated info on these basic items. Yours, Tuukka On 19/09/2019, 23.52, "Development on behalf of Kai Pastor, DG0YT" wrote: Am 19.09.19 um 10:41 schrieb Mutz, Marc via Developm

Re: [Development] INTEGRITY

2019-09-19 Thread André Pönitz
On Thu, Sep 19, 2019 at 11:37:14PM +0200, Giuseppe D'Angelo wrote: > Il 19/09/19 21:53, Kyle Edwards ha scritto: > > As a generalization of this, perhaps Qt could introduce something like > > a Q_CONSTEXPR macro, which does what we expect on platforms that > > support it, and compiles to nothing on

Re: [Development] INTEGRITY

2019-09-19 Thread Thiago Macieira
On Thursday, 19 September 2019 03:17:12 PDT Giuseppe D'Angelo via Development wrote: > On 18/09/2019 17:33, Thiago Macieira wrote: > >>> We've never required C++11 Standard Library. We've only required the > >>> core > >>> language and the integrity compiler does support it just fine. > >> > >> N

Re: [Development] INTEGRITY

2019-09-19 Thread Thiago Macieira
On Thursday, 19 September 2019 12:14:36 PDT Giuseppe D'Angelo via Development wrote: > On 19/09/2019 21:01, André Pönitz wrote: > > "Is it worth" is exactly the question that should drive this kind of > > discussion. And it can be answered_after_ evaluating, or even guessing > > the "value" of th

Re: [Development] INTEGRITY

2019-09-19 Thread Thiago Macieira
On Thursday, 19 September 2019 01:41:49 PDT Mutz, Marc via Development wrote: > > Seems like it. Like I said, we've never required the C++11 standard > > library > > and we need to be sure the feature we need is supported before we > > commit to > > it. > > https://www.qt.io/blog/2016/06/16/qt-5-7

Re: [Development] INTEGRITY

2019-09-19 Thread Giuseppe D'Angelo via Development
Il 19/09/19 21:53, Kyle Edwards ha scritto: As a generalization of this, perhaps Qt could introduce something like a Q_CONSTEXPR macro, which does what we expect on platforms that support it, and compiles to nothing on Integrity. It's already in Qt, and used: https://code.woboq.org/qt5/qtbase

Re: [Development] RFC: handling of C++ feature test macros

2019-09-19 Thread Thiago Macieira
On Thursday, 19 September 2019 06:23:26 PDT Giuseppe D'Angelo via Development wrote: > On 18/09/2019 01:37, Thiago Macieira wrote: > > Marc's proposal is that we should accept that these things are rare and > > simply correct when they do happen. Since our code is tested with the > > currently lat

Re: [Development] RFC: handling of C++ feature test macros

2019-09-19 Thread Thiago Macieira
On Thursday, 19 September 2019 06:28:01 PDT Giuseppe D'Angelo via Development wrote: > Thanks! This would also bring up the question on whether it's of any > importance what values the feature-testing macros are defined to There are some features that got updated to newer standards in C++14 and

Re: [Development] INTEGRITY

2019-09-19 Thread Kai Pastor, DG0YT
Am 19.09.19 um 10:41 schrieb Mutz, Marc via Development: 1. List a maintainer for INTEGRITY in https://wiki.qt.io/Maintainers 2. That maintainer should either find the missing linker flag, or file a bug with Integrity 3. If there's a work-around (providing those missing functions in Qt, e.g.),

Re: [Development] INTEGRITY

2019-09-19 Thread Kyle Edwards via Development
On Thu, 2019-09-19 at 21:50 +0200, André Pönitz wrote: > Having constexpr or not on certain functions could depend on the > actual > compiler in some cases, providing the performance benefits for the  > compilers supporting it, and still keeping platforms with unsuitable > compilers alive. As a ge

Re: [Development] INTEGRITY

2019-09-19 Thread André Pönitz
On Thu, Sep 19, 2019 at 09:14:36PM +0200, Giuseppe D'Angelo via Development wrote: > On 19/09/2019 21:01, André Pönitz wrote: > > "Is it worth" is exactly the question that should drive this kind of > > discussion. > > And it can be answered_after_ evaluating, or even guessing the "value" of >

Re: [Development] INTEGRITY

2019-09-19 Thread Giuseppe D'Angelo via Development
On 19/09/2019 21:01, André Pönitz wrote: "Is it worth" is exactly the question that should drive this kind of discussion. And it can be answered_after_ evaluating, or even guessing the "value" of the available options. It's not so easy: I, for once, don't have access to INTEGRITY to do any a

Re: [Development] INTEGRITY

2019-09-19 Thread André Pönitz
On Thu, Sep 19, 2019 at 11:18:26AM +0200, Mutz, Marc via Development wrote: > But it helps nothing with all the places where we use QWaitCondition in Qt > implementation and would like to replace it with std::condition_variable + > std::mutex, because, as I explained in an earlier mail, QWaitCondit

Re: [Development] Feature request for Qt 6 : Native Notifications support

2019-09-19 Thread Marius Kittler
Am Donnerstag, 19. September 2019, 11:08:51 CEST schrieb Jay Gupta: > Hello , i have a feature request for Qt 6. Currently there is no/not good > enough notification support for Qt for android. > > It was quite difficult to implement push notification for my app in past. > > If it's possible i wo

Re: [Development] INTEGRITY

2019-09-19 Thread Ville Voutilainen
On Thu, 19 Sep 2019 at 16:40, Mutz, Marc wrote: > > This problem is under fixing; the kernel we use in our CI build simply > > doesn't support condition variables, and thus its run-time library > > doesn't have > > them either. > > That's interesting. Are you saying I just overlooked that QWaitCo

Re: [Development] RFC: handling of C++ feature test macros

2019-09-19 Thread Ville Voutilainen
On Thu, 19 Sep 2019 at 16:29, Giuseppe D'Angelo via Development wrote: > > On 19/09/2019 14:56, Ville Voutilainen wrote: > > I think Peppe's concern, while somewhat theoretical, is a valid one. > > I'll talk to SG10 about this so that > > we hopefully never run into the problem in practice. > > Th

Re: [Development] INTEGRITY

2019-09-19 Thread Mutz, Marc via Development
Hi Tuukka, Ville, On 2019-09-19 15:02, Ville Voutilainen wrote: On Thu, 19 Sep 2019 at 14:49, Tuukka Turunen wrote: A lot of the Qt functionality works perfectly well on INTEGRITY. Even the advanced graphics such as Qt Quick, Qt 3D and Qt 3D Studio. I do not see it reasonable to claim that it

Re: [Development] RFC: handling of C++ feature test macros

2019-09-19 Thread Giuseppe D'Angelo via Development
On 19/09/2019 14:56, Ville Voutilainen wrote: I think Peppe's concern, while somewhat theoretical, is a valid one. I'll talk to SG10 about this so that we hopefully never run into the problem in practice. Thanks! This would also bring up the question on whether it's of any importance what valu

Re: [Development] RFC: handling of C++ feature test macros

2019-09-19 Thread Giuseppe D'Angelo via Development
On 18/09/2019 01:37, Thiago Macieira wrote: Marc's proposal is that we should accept that these things are rare and simply correct when they do happen. Since our code is tested with the currently latest versions of all compilers, we're fairly sure that any such macro works with the compilers that

Re: [Development] INTEGRITY

2019-09-19 Thread Ville Voutilainen
On Thu, 19 Sep 2019 at 14:49, Tuukka Turunen wrote: > > > Hi Marc, > > A lot of the Qt functionality works perfectly well on INTEGRITY. Even the > advanced graphics such as Qt Quick, Qt 3D and Qt 3D Studio. I do not see it > reasonable to claim that it is "so far behind all the other supported

Re: [Development] RFC: handling of C++ feature test macros

2019-09-19 Thread Ville Voutilainen
On Wed, 18 Sep 2019 at 09:28, Lars Knoll wrote: > > > On 18 Sep 2019, at 01:37, Thiago Macieira wrote: > > > > On Tuesday, 17 September 2019 16:05:34 PDT Giuseppe D'Angelo via Development > > wrote: > >> While I agree that at the moment it has virtually never happened, it > >> doesn't mean it cou

Re: [Development] INTEGRITY

2019-09-19 Thread Ville Voutilainen
On Thu, 19 Sep 2019 at 12:03, Mutz, Marc via Development wrote: > > 1. List a maintainer for INTEGRITY in https://wiki.qt.io/Maintainers > > That person seems to be Ville. That impression is incorrect. I was merely asked to help resolve this particular problem. ___

Re: [Development] INTEGRITY

2019-09-19 Thread Tuukka Turunen
Hi Marc, A lot of the Qt functionality works perfectly well on INTEGRITY. Even the advanced graphics such as Qt Quick, Qt 3D and Qt 3D Studio. I do not see it reasonable to claim that it is "so far behind all the other supported platforms, as well as its own claim of conformance, that the ques

Re: [Development] INTEGRITY

2019-09-19 Thread Lars Knoll
> On 19 Sep 2019, at 12:17, Giuseppe D'Angelo via Development > wrote: > > On 18/09/2019 17:33, Thiago Macieira wrote: We've never required C++11 Standard Library. We've only required the core language and the integrity compiler does support it just fine. >>> Not really, it also fails

Re: [Development] INTEGRITY

2019-09-19 Thread Giuseppe D'Angelo via Development
On 18/09/2019 17:33, Thiago Macieira wrote: We've never required C++11 Standard Library. We've only required the core language and the integrity compiler does support it just fine. Not really, it also fails on constexpr: https://codereview.qt-project.org/c/qt/qtbase/+/264550 No, it has a bug i

Re: [Development] Feature request for Qt 6 : Native Notifications support

2019-09-19 Thread Edward Welbourne
Jay Gupta (19 September 2019 11:08) wrote: > Hello , i have a feature request for Qt 6. Currently there is no/not good > enough notification support for Qt for android. > > It was quite difficult to implement push notification for my app in past. > > If it's possible i would love to have this feat

Re: [Development] INTEGRITY

2019-09-19 Thread Mutz, Marc via Development
On 2019-09-19 10:56, Lars Knoll wrote: 4. drop Integrity support (or update to a newer version) ASAP (for Qt 5.15 if not 5.14). This is a bit black and white. You’re proposing to drop all of INTEGRITY because you’re not willing to work around things on that platform for one patch that is in pr

Re: [Development] INTEGRITY

2019-09-19 Thread Heikki Halmet
Hi, Aapo is on sick leave today. << There is a flag in Coin to build tests are module build time instead of before testing. Perhaps that can somehow be combined with the DisableTests feature flag in Coin. Aapo, do << you think that would be possible? Yes, this one is already done and merged: h

[Development] Feature request for Qt 6 : Native Notifications support

2019-09-19 Thread Jay Gupta
Hello , i have a feature request for Qt 6. Currently there is no/not good enough notification support for Qt for android. It was quite difficult to implement push notification for my app in past. If it's possible i would love to have this feature thanks !! best regards Jayaditya Gupta _

Re: [Development] INTEGRITY

2019-09-19 Thread Lars Knoll
> On 19 Sep 2019, at 11:00, Mutz, Marc via Development > wrote: > > From a comment by Ville on Gerrit, I take that: > > On 2019-09-19 10:41, Mutz, Marc via Development wrote: >> So, I update my requests: >> 1. List a maintainer for INTEGRITY in https://wiki.qt.io/Maintainers > > That person

Re: [Development] INTEGRITY

2019-09-19 Thread Mutz, Marc via Development
From a comment by Ville on Gerrit, I take that: On 2019-09-19 10:41, Mutz, Marc via Development wrote: So, I update my requests: 1. List a maintainer for INTEGRITY in https://wiki.qt.io/Maintainers That person seems to be Ville. 2. That maintainer should either find the missing linker flag,

Re: [Development] INTEGRITY

2019-09-19 Thread Lars Knoll
On 19 Sep 2019, at 10:41, Mutz, Marc via Development mailto:development@qt-project.org>> wrote: On 2019-09-18 17:33, Thiago Macieira wrote: On Wednesday, 18 September 2019 08:16:46 PDT Giuseppe D'Angelo via Development wrote: > We've never required C++11 Standard Library. We've only required the

Re: [Development] INTEGRITY

2019-09-19 Thread Mutz, Marc via Development
On 2019-09-18 17:33, Thiago Macieira wrote: On Wednesday, 18 September 2019 08:16:46 PDT Giuseppe D'Angelo via Development wrote: > We've never required C++11 Standard Library. We've only required the core > language and the integrity compiler does support it just fine. Not really, it also fai

Re: [Development] INTEGRITY

2019-09-19 Thread Giuseppe D'Angelo via Development
Il 19/09/19 09:14, Simon Hausmann ha scritto: Unfortunately that will not work out of the box :-(. The tests are only compiled when runinng tests. It is not feasible to run tests on Integrity for every qtbase integration. Uhm, ok. I somehow assumed that "-nomake tests" was being passed to con

Re: [Development] INTEGRITY

2019-09-19 Thread Oswald Buddenhagen
On Thu, Sep 19, 2019 at 07:14:30AM +, Simon Hausmann wrote: Unfortunately that will not work out of the box :-(. The tests are only compiled when runinng tests. It is not feasible to run tests on Integrity for every qtbase integration. really? the task about that was marked as done just a

Re: [Development] INTEGRITY

2019-09-19 Thread Simon Hausmann
Hi, Unfortunately that will not work out of the box :-(. The tests are only compiled when runinng tests. It is not feasible to run tests on Integrity for every qtbase integration. There is a flag in Coin to build tests are module build time instead of before testing. Perhaps that can somehow