Re: [Development] GitHub Pull requests

>> In an ideal world... >> >> - Alice opens a pull request on GitHub. >> - A bot sees the PR and opens a corresponding request on Gerrit. >> - Bob comments on the Gerrit request. >> - A bot sees Bob's comment and replicates it to the GitHub PR. >> - Alice replies (on GitHub) to Bob's comment. >> -

Re: [Development] Arttu Tarkiainen as approver

+1 -- Tino Pyssysalo Senior Product Manager The Qt Company On 10.3.2020, 14.00, "Development on behalf of Katja Marttila" mailto:development-boun...@qt-project.org> on behalf of katja.martt...@qt.io> wrote: Hi all, I’d like to nominate Arttu Tarkiainen as approve

Re: [Development] Arttu Tarkiainen as approver

+1 From: Development on behalf of Katja Marttila Sent: Tuesday, March 10, 2020 1:56 PM To: development@qt-project.org Subject: [Development] Arttu Tarkiainen as approver Hi all, I’d like to nominate Arttu Tarkiainen as approver for the Qt Project. Art

Re: [Development] GitHub Pull requests

10.03.2020, 22:26, "Matthew Woehlke" : > On 10/03/2020 12.19, Cristián Maureira-Fredes wrote: >>  On 3/10/20 3:40 PM, Cristian Adam wrote: >>>  What stops us from accepting the contributions via GitHub? >>> >>>  Is it: >>> >>>   1. The CLA >>>   2. Qt Account >>> >>>  For the CLA one can simply a

Re: [Development] GitHub Pull requests

On 10/03/2020 12.19, Cristián Maureira-Fredes wrote: > On 3/10/20 3:40 PM, Cristian Adam wrote: >> What stops us from accepting the contributions via GitHub? >> >> Is it: >> >>  1. The CLA >>  2. Qt Account >> >> For the CLA one can simply add an instance of: >> >> https://github.com/cla-assistant/

Re: [Development] GitHub Pull requests

Hi, On Tue, Mar 10, 2020 at 05:08:39PM +, Zacruzin via Development wrote: > Please remove me from this email chain.Thank you! On the bottom of every mail you find a footer, liking to the website for this mailinglist: > Development mailing list > Development@qt-project.org > https://lists.qt-

Re: [Development] GitHub Pull requests

Hey hey, > On 10 Mar 2020, at 15:40, Cristian Adam wrote: > > What stops us from accepting the contributions via GitHub? The issues feature should be closed on those GitHub mirrors. As a project we use Gerrit today, and that’s where contributions should happen. If we change review platform, t

Re: [Development] GitHub Pull requests

Please remove me from this email chain.Thank you! -Original Message- From: Konstantin Tokarev To: Cristián Maureira-Fredes ; development@qt-project.org Sent: Tue, Mar 10, 2020 12:07 pm Subject: Re: [Development] GitHub Pull requests 10.03.2020, 19:25, "Cristián Maureira-Fredes" : > H

Re: [Development] GitHub Pull requests

10.03.2020, 19:25, "Cristián Maureira-Fredes" : > Hello, > > On 3/10/20 3:48 PM, Konstantin Tokarev wrote: >>  I think, lowering barrier of entry at expense of reviewers' convenience >> should >>  have its limits > > Totally agree, > so we should plan to accept patches from platform and systems >

Re: [Development] GitHub Pull requests

Hello, On 3/10/20 3:48 PM, Konstantin Tokarev wrote: I think, lowering barrier of entry at expense of reviewers' convenience should have its limits Totally agree, so we should plan to accept patches from platform and systems made for code development, like Github :) , otherwise we may end up

Re: [Development] GitHub Pull requests

Hello Cristian, On 3/10/20 3:40 PM, Cristian Adam wrote: What stops us from accepting the contributions via GitHub? Is it: 1. The CLA 2. Qt Account For the CLA one can simply add an instance of: https://github.com/cla-assistant/cla-assistant I think that's a good idea, in the past I was

Re: [Development] Qt 5.15 API review

> On 10 Mar 2020, at 14:21, Jani Heikkinen wrote: > >> -Original Message- >> From: Giuseppe D'Angelo >> Sent: tiistai 10. maaliskuuta 2020 14.48 >> To: Jani Heikkinen >> Cc: Qt development mailing list >> Subject: Re: [Development] Qt 5.15 API review >> >> Il 10/03/20 13:45, Jani Heik

Re: [Development] GitHub Pull requests

> otherwise we may end up accepting contributions from Twitter :) what is the problem if they improve the code ? On Tue, Mar 10, 2020 at 3:49 PM Konstantin Tokarev wrote: > > > 10.03.2020, 17:42, "Cristian Adam" : > > Hi, > > > > With the “GitHub issues” E-Mail thread we made sure the Issues a

Re: [Development] Arttu Tarkiainen as approver

+1 > On 10 Mar 2020, at 12:56, Katja Marttila wrote: > > Hi all, > > I’d like to nominate Arttu Tarkiainen as approver for the Qt Project. > > Arttu has been working in the installer team as a SW developer since he > joined the Qt Company about one year ago. First as a trainee and currently

Re: [Development] GitHub Pull requests

10.03.2020, 17:42, "Cristian Adam" : > Hi, > > With the “GitHub issues” E-Mail thread we made sure the Issues are gone > > from the projects. > > What about Pull requests? > > For example qtbase has 7 pull requests.  Usually people point out that > > the Qt project uses a different collaboration

[Development] GitHub Pull requests

Hi, With the “GitHub issues” E-Mail thread we made sure the Issues are gone from the projects. What about Pull requests? For example qtbase has 7 pull requests. Usually people point out that the Qt project uses a different collaboration method: https://wiki.

Re: [Development] Qt 5.15 API review

> -Original Message- > From: Giuseppe D'Angelo > Sent: tiistai 10. maaliskuuta 2020 14.48 > To: Jani Heikkinen > Cc: Qt development mailing list > Subject: Re: [Development] Qt 5.15 API review > > Il 10/03/20 13:45, Jani Heikkinen ha scritto: > > We haven't been blocking Beta (n) lately

Re: [Development] Qt 5.15 API review

Il 10/03/20 13:45, Jani Heikkinen ha scritto: We haven't been blocking Beta (n) lately because of ongoing API review. Earlier when there were only one beta we did that. After we started to deliver several beta releases we stopped to block betas because of not finalized API review. And I think

Re: [Development] Qt 5.15 API review

> -Original Message- > From: Development On Behalf Of > Giuseppe D'Angelo via Development > Sent: tiistai 10. maaliskuuta 2020 14.32 > To: development@qt-project.org > Subject: Re: [Development] Qt 5.15 API review > > Il 10/03/20 10:53, Jani Heikkinen ha scritto: > > It seems API review i

Re: [Development] Qt 5.15 API review

Il 10/03/20 10:53, Jani Heikkinen ha scritto: It seems API review is still ongoing and many reviews are missing +2: But, out of curiosity, why was the beta published when API review was still ongoing? Thanks, -- Giuseppe D'Angelo | giuseppe.dang...@kdab.com | Senior Software Engineer KDAB (F

[Development] Arttu Tarkiainen as approver

Hi all, I'd like to nominate Arttu Tarkiainen as approver for the Qt Project. Arttu has been working in the installer team as a SW developer since he joined the Qt Company about one year ago. First as a trainee and currently as full-time employee. Arttu has been focusing mainly to improve and m

Re: [Development] Qt 5.15 API review

Hi all, It seems API review is still ongoing and many reviews are missing +2: - qtbase: https://codereview.qt-project.org/c/qt/qtbase/+/289203 - qtdeclarative: https://codereview.qt-project.org/c/qt/qtdeclarative/+/289205 - qttools: https://codereview.qt-project.org/c/qt/qttools/+/289207 - qtweben

Re: [Development] mobile-to-mobile connection for p2p game

This sounds like better being asked on the interest@ mailing list. Br, Eike > On 9. Mar 2020, at 19:42, Zoltán Lutor wrote: > > Hi, > > What to use (especially in Qt/QML) for connection to (mobile) devices in p2p > game? > > E.g. one device is server, other is client, playing against each ot

[Development] Maintainers, your actions needed: Qt 5.14.2 changes files

Hi, Initial ones here: https://codereview.qt-project.org/q/message:+%2522Add+changes+file+for+Qt+5.14.2%2522 Please finalize these asap; we are targeting to release Qt 5.14.2 Tue 17th March so we need to get all these in during this week br, Jani Heikkinen Release Manager _

[Development] HEADS-UP: Branching from '5.14' to '5.14.2' done

Hi all, Branching from '5.14' to '5.14.2' is now ready and staging in '5.14.2' is restricted to release team only. So from now on all changes targeted to Qt 5.14.2 release must be done in '5.14.2' and '5.14' is for changes targeted to Qt 5.14.3 release. br, Jani __