Re: [Development] [Request] Add Info to QDebug

2013-12-23 Thread Keith Gardner
On Mon, Dec 23, 2013 at 7:42 AM, Thiago Macieira wrote: > On segunda-feira, 23 de dezembro de 2013 14:06:07, Kurt Pattyn wrote: > > > - Warning: is a notice that something went wrong, but it might not > affect > > > the application. You can disable it with QT_NO_WARNING_OUTPUT since is > > > not t

[Development] Adding support for version number comparisons

2014-05-09 Thread Keith Gardner
Greetings, I have been working on adding a class to QtCore (QVersion) to support storing version numbers, convert to/from QString, and having comparison operators. My goal was to provide an API to assist in the following use cases: - Plugin loading where there are multiple versions on the sam

Re: [Development] Adding support for version number comparisons

2014-05-10 Thread Keith Gardner
Let's not make it that complicated. If the suffix is one character, assume that it stands for a released version. If the suffix is greater than one character, assume it references a pre-released version. With this rule, comparisons will work properly. "1.0.0beta" < "1.0.0" < "1.0.0b". On Sat,

Re: [Development] Adding support for version number comparisons

2014-05-10 Thread Keith Gardner
On Sat, May 10, 2014 at 2:28 PM, Jake Petroules < jake.petrou...@petroules.com> wrote: > And what about 1.0.0b2? Wouldn't you expect that to be greater than > 1.0.0b? The problem with trying to implement one comparison algorithm is > that there are so many different versioning formats in use (at l

Re: [Development] Adding support for version number comparisons

2014-05-10 Thread Keith Gardner
> > Anyway, given that this is going to be complex, I propose we make up our > own > list and *document* it. > > I think that to come up with our own list, we need to identify the tree different types of suffixes that we are talking about: pre-release, null, and release. The null suffix is obvious

Re: [Development] Adding support for version number comparisons

2014-05-11 Thread Keith Gardner
> > >>1. Usually more condensed than the pre-release. >>2. Some projects experience multiple "releases" with the same version >>of software (1.0.0-2). >>3. Libjpeg and OpenSSL use a single letter to represent a level of >>security for some software (1.0.0g). >> >> openssl actual

Re: [Development] Adding support for version number comparisons

2014-05-12 Thread Keith Gardner
> > > >- Plugin loading where there are multiple versions on the same > system. > > >- File format validation. > > >- Executing an already installed command line application where the > > >behavior is dependent on the called application's version. > > >- Performing software inst

Re: [Development] Adding support for version number comparisons

2014-05-13 Thread Keith Gardner
> > but then there is also the semantical perspective. keith's last proposal > i saw considered only numerical segments specially. Did you intend to say suffix? What I wrote on May 11th spoke specifically to the suffix compare: >From what I have found, there are some key words that can be used

Re: [Development] Adding support for version number comparisons

2014-05-13 Thread Keith Gardner
On Tue, May 13, 2014 at 3:06 PM, Oswald Buddenhagen < oswald.buddenha...@digia.com> wrote: > On Tue, May 13, 2014 at 12:59:10PM -0500, Keith Gardner wrote: > > > but then there is also the semantical perspective. keith's last > proposal > > > i saw considere

Re: [Development] Adding support for version number comparisons

2014-05-14 Thread Keith Gardner
> > > I think that makes sense, but it would be nice if it would be easy for the > user of the class to extend the version checking himself for non-numerical > sections of the version string. That could be done in several ways I think, > for instance with an API like this: > > QVersion > { > ... >

Re: [Development] Adding support for version number comparisons

2014-05-14 Thread Keith Gardner
> > >1. Numerical groupings should be compared integers instead of > characters > >in order to properly allow for "alpha2" < "alpha11". > >2. Delimiters should only be used to denote groups of content but be > >skipped during the compare. "alpha" == "-alpha" == "~alpha" == > ".alph

Re: [Development] Adding support for version number comparisons

2014-05-14 Thread Keith Gardner
> > Well, if you use a virtual, you'd simply subclass to handle the specific > format for your project. > I haven't thought about using inheritance to simplify the compare but I think that would provide the best compromise. What are your thoughts about comparing a QVersion to a QSpecializedVersion

Re: [Development] Adding support for version number comparisons

2014-05-31 Thread Keith Gardner
On Sat, May 31, 2014 at 2:09 PM, Jake Petroules < jake.petrou...@petroules.com> wrote: > On 2014-05-31, at 03:00 PM, Thiago Macieira > wrote: > > Em sex 09 maio 2014, às 11:36:08, Keith Gardner escreveu: > > I have been working on adding a class to QtCore (QVersion) to s

Re: [Development] Adding support for version number comparisons

2014-06-02 Thread Keith Gardner
On Mon, Jun 2, 2014 at 2:36 AM, Simon Hausmann wrote: > On Saturday 31. May 2014 15.02.49 Keith Gardner wrote: > [...] > > > And then you'd use: QVersion::compare(a, b, myCompare); > > > > > > > > > Big +1 to everything. This approach should s

Re: [Development] Adding support for version number comparisons

2014-06-02 Thread Keith Gardner
On Mon, Jun 2, 2014 at 7:33 AM, Jake Petroules wrote: > On 2014-06-02, at 08:24 AM, Richard Moore wrote: > > On 2 June 2014 13:12, Keith Gardner wrote: > >> On Mon, Jun 2, 2014 at 2:36 AM, Simon Hausmann >> wrote: >> >>> >>> I suggest a name th

Re: [Development] Adding support for version number comparisons

2014-07-10 Thread Keith Gardner
On Sat, May 31, 2014 at 2:00 PM, Thiago Macieira wrote: > Em sex 09 maio 2014, às 11:36:08, Keith Gardner escreveu: > > I have been working on adding a class to QtCore (QVersion) to support > > storing version numbers, convert to/from QString, and having comparison > > opera

Re: [Development] Adding support for version number comparisons

2014-07-10 Thread Keith Gardner
On Thu, Jul 10, 2014 at 7:31 AM, Olivier Goffart wrote: > On Monday 02 June 2014 13:24:55 Richard Moore wrote: > > On 2 June 2014 13:12, Keith Gardner wrote: > > > On Mon, Jun 2, 2014 at 2:36 AM, Simon Hausmann < > simon.hausm...@digia.com> > > > > >

Re: [Development] Adding support for version number comparisons

2014-07-10 Thread Keith Gardner
On Thu, Jul 10, 2014 at 8:09 AM, Olivier Goffart wrote: > On Thursday 10 July 2014 07:53:29 Keith Gardner wrote: > > On Thu, Jul 10, 2014 at 7:31 AM, Olivier Goffart > wrote: > > > On Monday 02 June 2014 13:24:55 Richard Moore wrote: > > > > On 2 June

Re: [Development] Adding support for version number comparisons

2014-07-11 Thread Keith Gardner
On Thu, Jul 10, 2014 at 8:47 AM, Kobus Jaroslaw wrote: > Hi All, > > With the current state of QVersion (patchset 35) I see the following > issues: > 1. operator<() doesn't take the suffix into account (mentioned below) > 2. There is no handling of sub version (you cannot differentiate 5.0.0, > 5

Re: [Development] ListView + TextEdit tricky behavior

2014-09-30 Thread Keith Gardner
On Tue, Sep 30, 2014 at 7:55 AM, Matías Néstor Ares wrote: > Hi everyone! > I'm developing an app with Qt, and I'm having some issues. > I don't get a proper answer from the forums yet. > So I ask it here, sorry if it is not the correct place. > > The problem description is on this post: > http:/

Re: [Development] ListView + TextEdit tricky behavior

2014-09-30 Thread Keith Gardner
On Tue, Sep 30, 2014 at 8:35 AM, Mitch Curtis wrote: > > On 30/09/14 14:55, Matías Néstor Ares wrote: > > Hi everyone! > I'm developing an app with Qt, and I'm having some issues. > I don't get a proper answer from the forums yet. > So I ask it here, sorry if it is not the correct place. > > The

Re: [Development] Removing the -c++11 option from configure

2015-03-24 Thread Keith Gardner
> > More. That's at least a dozen in the configure script, since we need to > ensure > someone didn't pass the impossible combination -c++14 -no-c++11. > Why not make it a switch for highest language support. Instead of -no-c++11, make it -c++03. This would allow for adding -c++1z in the future

Re: [Development] RFC: RAII for property changes

2015-04-15 Thread Keith Gardner
On Wed, Apr 15, 2015 at 9:38 AM Marc Mutz wrote: > Hi André, > > On Wednesday 15 April 2015 11:49:56 André Somers wrote: > > void MyClass::setFoo(QString value) > > { > >PropertyGuard guard(this, "foo"); //foo is the name of the Q_PROPERTY > >Q_UNUSED(guard); > > > >m_foo = value; >

Re: [Development] RFC: RAII for property changes

2015-04-15 Thread Keith Gardner
> > I'd certainly be interested to seeing how you solved this, yes. Thanks! > I have made a repository for the class with an example. Sorry that there is no documentation for it. It requires C++11 support for r-value references, std::functional, and some type traits features. In addition to hav

Re: [Development] RFC: RAII for property changes

2015-04-15 Thread Keith Gardner
> > > QPropertyGuard g{this}; > > g.addProperty("a"); // use QObject::property > > g.addProperty("b", m_b); // take value member by reference > > g.addProperty(m_c, &cChanged); // ...and also slot address > > There's type erasure going on, so it will allocate memory. Allocating > memory > i

Re: [Development] RFC: RAII for property changes

2015-04-15 Thread Keith Gardner
On Wed, Apr 15, 2015 at 2:20 PM Andre Somers wrote: > On 15-4-2015 21:05, Keith Gardner wrote: > > > QPropertyGuard g{this}; >> > g.addProperty("a"); // use QObject::property >> > g.addProperty("b", m_b); // take value member by referen

Re: [Development] QVersionNumber: someone to polish and finish the API

2015-07-08 Thread Keith Gardner
> > Please take the patches starting at > https://codereview.qt-project.org/95531. > Follow the chain of dependency. > Would you like someone to pick up those changes and finish them for you? I am just asking since you started many of them but I know you have a lot on your plate. The only change

Re: [Development] QVersionNumber: someone to polish and finish the API

2015-07-08 Thread Keith Gardner
> > It's already done and approved. You just need to move qversionnumber_p.h > back > to qversionnumber.h in a separate commit and check that the patch series > still > applies. IIRC, only the unexporting was applied out-of-order, so you can > revert that one temporarily, to make the other changes

Re: [Development] QVector now has rvalue push_back (was: Re: HEADS UP: potential trouble from a recent QVector change)

2015-07-20 Thread Keith Gardner
On Mon, Jul 20, 2015 at 1:11 PM Thiago Macieira wrote: > On Monday 20 July 2015 14:06:33 Marc Mutz wrote: > > https://codereview.qt-project.org/121810 > > > > So start using qMove() or pass temporaries in your QVector::append() > calls. > > What's the difference in std::vector between an rvalue p

Re: [Development] QVector now has rvalue push_back (was: Re: HEADS UP: potential trouble from a recent QVector change)

2015-07-21 Thread Keith Gardner
On Tue, Jul 21, 2015 at 12:49 PM Gunnar Roth wrote: > > > > > void push_back(T &&t) { > > ensureCapacity(size() + 1); > > new (m_end) T(std::move(t));// move-construct > from t > > ++m_end; > why is std::move needed here? Afaik std::move(t) converts

Re: [Development] QVersionNumber: someone to polish and finish the API

2015-07-22 Thread Keith Gardner
On Wed, Jul 8, 2015 at 12:10 PM Thiago Macieira wrote: > On Wednesday 08 July 2015 12:07:20 Keith Gardner wrote: > > > Please take the patches starting at > > > https://codereview.qt-project.org/95531. > > > Follow the chain of dependency. > > > > Would

Re: [Development] Use QT_DEPRECATED_SINCE macro for specific enum values

2015-08-12 Thread Keith Gardner
On Wed, Aug 12, 2015 at 11:54 AM Denis Shienkov wrote: > > skips three making Four == 3. > > yes, and what? :) > > > > This obviously needs to be: > > Four = 4 > > Ok, seems it was a bad example with One-Four.. Let's consider another > abstract example: > > enum Foo { > A, > B, > #if QT_

[Development] QImage Support for Grayscale Images

2011-10-25 Thread Keith Gardner
Is there a plan for adding grayscale support to QImage? I know that there are enums in place in preparation for this capability. I have also looked at the bug tracker and found pages of bugs requesting this feature. I personally would like to see it implemented because I use grayscale texture

Re: [Development] Platform / compiler support

2011-11-07 Thread Keith Gardner
Hi, When specifying Visual Studio, could you specify the support for x86, IA64, and AMD64 architectures? I know that supporting a compiler is one thing, but supporting an architecture is another. Keith -Original Message- From: development-bounces+kgardner=zebraimaging@qt-project.o

Re: [Development] QLog ( Work on qDebug and friends)

2012-01-31 Thread Keith Gardner
Couldn't you have the log fill a QIODevice (file or socket) and make a QLogFile class that would perform the log file rotation? -Original Message- From: development-bounces+kgardner=zebraimaging@qt-project.org [mailto:development-bounces+kgardner=zebraimaging@qt-project.org] On B

[Development] QStringRef conversion functions

2012-06-11 Thread Keith Gardner
added into the QStringRef class. Would this be possible to add this in time for the Qt 5.0 release? If not, would it be possible to add this for Qt 5.1 release? Keith Gardner Software Engineer Zebra Imaging 9801 Metric Blvd., Suite 200 Austin, TX 78758

Re: [Development] QStringRef conversion functions

2012-06-13 Thread Keith Gardner
1850 milliseconds. I would say that there is a big payout with changing what we currently have. Thanks, Keith -Original Message- From: Girish Ramakrishnan [mailto:gir...@forwardbias.in] Sent: Monday, June 11, 2012 4:55 PM To: Keith Gardner Cc: development@qt-project.org Subjec

Re: [Development] QtCS: OpenGL session notes

2012-07-02 Thread Keith Gardner
Why don't you make an OpenGL middleware driver? Then your application will always be an OpenGL application and the middleware driver will take all of the OpenGL calls in place of the system's driver and do the translation there? The middleware driver will then contain the ANGLE code and the ap

Re: [Development] Reviews needed before android integration in two weeks

2013-02-05 Thread Keith Gardner
[snip] According to: http://en.wikipedia.org/wiki/Android_(operating_system) "Android is a Linux-based operating system ..." but on the same page says: "Android does not have a native X Window System by default nor does it support the full set of standard GNU libraries, and this makes it difficult

[Development] Conditional Deprecation Warnings

2013-10-11 Thread Keith Gardner
I had an idea about making conditional deprecation warnings for functions in Qt based on the destination platform. The idea would be to get a compile time warning when using a function on a platform that the function does not supported. An example would be calling QProcess::nativeArguments() on n

Re: [Development] Conditional Deprecation Warnings

2013-10-12 Thread Keith Gardner
> > I had an idea about making conditional deprecation warnings for functions > > in Qt based on the destination platform. > > That might be useful, actually. > > But not for this case. Trying to call nativeArguments() on a non-Windows > platform already signals the problem with a full error. It's

Re: [Development] Qt 5.2 Testing (System tray)

2013-10-14 Thread Keith Gardner
It looks like they are trying to create their own QPA plugin for Qt5. For the appmenu changes, they reference the changes they made to the Qt4 source code and are porting to a Qt5 QPA plugin. I would assume that changes for the system tray icon would also be included in the plugin. https://bugs.

Re: [Development] Conditional Deprecation Warnings

2013-10-16 Thread Keith Gardner
The Q_DECL_DEPRECATED_CONDITIONAL turned out to be more limited than I was anticipating. I think using Q_DECL_DEPRECATED_X surrounded by ifdefs would be more explicit and accurate. On Wed, Oct 16, 2013 at 8:36 AM, Olivier Goffart wrote: > On Saturday 12 October 2013 18:33:00 Keith Gard

Re: [Development] Clang (trunk) no longer builds Qt applications

2013-10-22 Thread Keith Gardner
On Tue, Oct 22, 2013 at 8:15 AM, Tobias Hunger wrote: > Hello, > > I just noticed that clang from trunk is no longer able to build Qt > applications. This is due to a change which makes clang consider "break" > statements outside of a loop body or switch statement illegal. > > Unfortunately this t