Re: [Development] File Selectors API, still for 5.1?

2013-03-28 Thread Alan Alpert
The renamed, private, dynamic selector supporting version is now on gerrit against stable: https://codereview.qt-project.org/#change,52605 for those following this change. On Tue, Mar 26, 2013 at 1:43 PM, Alan Alpert 4163654...@gmail.com wrote: On Tue, Mar 26, 2013 at 11:04 AM, Thiago Macieira

Re: [Development] File Selectors API, still for 5.1?

2013-03-26 Thread Stephen Kelly
On Monday, March 25, 2013 18:19:57 Alan Alpert wrote: More time to iterate is always welcomed. This may lead to a source-incompatible change in Plasma Packages though, ideally we'd only do that once with the existing incompatible change of KDE Frameworks 5. Would that be using the 5.1 or 5.2

Re: [Development] File Selectors API, still for 5.1?

2013-03-26 Thread Thiago Macieira
On segunda-feira, 25 de março de 2013 10.42.27, Alan Alpert wrote: This is not good enough a reason. Any new feature can only be accepted in *dev* once it's complete: that is, it is there, works, unit-tested, documented, with examples if necessary, and an initial API review has been done.

Re: [Development] File Selectors API, still for 5.1?

2013-03-26 Thread Thiago Macieira
On segunda-feira, 25 de março de 2013 18.19.57, Alan Alpert wrote: tl;dr - Okay, let's make it private for 5.1 (also works for BlackBerry) and aim to polish it for 5.2. Maintainer agrees. Go for it. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source

Re: [Development] File Selectors API, still for 5.1?

2013-03-26 Thread Alan Alpert
On Tue, Mar 26, 2013 at 11:04 AM, Thiago Macieira thiago.macie...@intel.com wrote: On segunda-feira, 25 de março de 2013 10.42.27, Alan Alpert wrote: This is not good enough a reason. Any new feature can only be accepted in *dev* once it's complete: that is, it is there, works, unit-tested,

Re: [Development] File Selectors API, still for 5.1?

2013-03-26 Thread Alan Alpert
Whoops, re-sending to dev... On Tue, Mar 26, 2013 at 1:38 PM, Alan Alpert 4163654...@gmail.com wrote: On Tue, Mar 26, 2013 at 12:32 AM, Stephen Kelly stephen.ke...@kdab.com wrote: On Monday, March 25, 2013 18:19:57 Alan Alpert wrote: More time to iterate is always welcomed. This may lead to

Re: [Development] File Selectors API, still for 5.1?

2013-03-25 Thread Alan Alpert
On Sun, Mar 24, 2013 at 9:57 AM, Thiago Macieira thiago.macie...@intel.com wrote: On sexta-feira, 22 de março de 2013 14.57.11, Alan Alpert wrote: There are a few questions left on the QFileSelectors API addition, https://codereview.qt-project.org/#change,48334 : 1) Did it miss the feature

Re: [Development] File Selectors API, still for 5.1?

2013-03-25 Thread Alan Alpert
On Sat, Mar 23, 2013 at 8:50 PM, Konstantin Ritt ritt...@gmail.com wrote: Can't it be a private API in 5.1? That's a good idea. Why didn't I think of that? That also provides more flexibility while working towards unification. If it goes in as private API, does it still fall subject to the

Re: [Development] File Selectors API, still for 5.1?

2013-03-25 Thread Stephen Kelly
On Monday, March 25, 2013 10:46:37 Alan Alpert wrote: On Sat, Mar 23, 2013 at 8:50 PM, Konstantin Ritt ritt...@gmail.com wrote: Can't it be a private API in 5.1? That's a good idea. Why didn't I think of that? That also provides more flexibility while working towards unification. If it

Re: [Development] File Selectors API, still for 5.1?

2013-03-25 Thread Alan Alpert
On Mon, Mar 25, 2013 at 11:32 AM, Stephen Kelly stephen.ke...@kdab.com wrote: On Monday, March 25, 2013 10:46:37 Alan Alpert wrote: On Sat, Mar 23, 2013 at 8:50 PM, Konstantin Ritt ritt...@gmail.com wrote: Can't it be a private API in 5.1? That's a good idea. Why didn't I think of that? That

Re: [Development] File Selectors API, still for 5.1?

2013-03-25 Thread Thiago Macieira
On segunda-feira, 25 de março de 2013 10.46.37, Alan Alpert wrote: On Sat, Mar 23, 2013 at 8:50 PM, Konstantin Ritt ritt...@gmail.com wrote: Can't it be a private API in 5.1? That's a good idea. Why didn't I think of that? That also provides more flexibility while working towards

Re: [Development] File Selectors API, still for 5.1?

2013-03-25 Thread Aaron J. Seigo
tl;dr - This is a step in a good direction. I don't think it is usable as-is for Plasma, but it could mature into such a thing. I'm unconvinced this is ready for 5.1, particularly not as public API, but could be polished into something shiny for 5.2 and now I will ramble on below ;) (as I

Re: [Development] File Selectors API, still for 5.1?

2013-03-25 Thread Alan Alpert
On Mon, Mar 25, 2013 at 4:23 PM, Aaron J. Seigo ase...@kde.org wrote: tl;dr - This is a step in a good direction. I don't think it is usable as-is for Plasma, but it could mature into such a thing. I'm unconvinced this is ready for 5.1, particularly not as public API, but could be polished into

Re: [Development] File Selectors API, still for 5.1?

2013-03-24 Thread Thiago Macieira
On sexta-feira, 22 de março de 2013 14.57.11, Alan Alpert wrote: There are a few questions left on the QFileSelectors API addition, https://codereview.qt-project.org/#change,48334 : 1) Did it miss the feature freeze for 5.1? Technically, yes. It did not merge into dev before the dev-stable

Re: [Development] File Selectors API, still for 5.1?

2013-03-23 Thread Richard Moore
On 22 March 2013 21:57, Alan Alpert 4163654...@gmail.com wrote: In one of the patch sets, the form changed from f...@selector.png to +selector/file.png . Feedback from designers in BlackBerry suggested that they were more comfortable with directories, especially when using it to swap out

Re: [Development] File Selectors API, still for 5.1?

2013-03-23 Thread Konstantin Ritt
Can't it be a private API in 5.1? In this case, I see no major reasons to block it until 5.2. Regards, Konstantin 2013/3/23 Richard Moore r...@kde.org: On 22 March 2013 21:57, Alan Alpert 4163654...@gmail.com wrote: In one of the patch sets, the form changed from f...@selector.png to

[Development] File Selectors API, still for 5.1?

2013-03-22 Thread Alan Alpert
There are a few questions left on the QFileSelectors API addition, https://codereview.qt-project.org/#change,48334 : 1) Did it miss the feature freeze for 5.1? It did not merge into dev before the dev-stable merge, so it has technically missed the freeze. But I'd like to ask for a special