On quinta-feira, 7 de junho de 2012 09.43.40, Thiago Macieira wrote:
> I've just had an idea to make this optimisation slightly more generic. I
> need to experiment a little to see if it's worth it. If it is, I'll send a
> replacement and let reviewers judge which one is better.
I've done that ex
On quinta-feira, 7 de junho de 2012 06.47.11, lars.kn...@nokia.com wrote:
> >The new optimisation does not introduce "delete value" into the reference-
> >dropping code path. That is still:
> >
> > d->destroy()
> >which does:
> >void destroy() { destroyer(this); }
> > (destroyer
On 6/7/12 12:55 AM, "ext Thiago Macieira"
wrote:
>On quarta-feira, 6 de junho de 2012 21.56.16, lars.kn...@nokia.com wrote:
>> >https://codereview.qt-project.org/26981-Optimisedeletion
>>
>> I might be wrong (getting tired), but I think this reintroduces the
>> problem with forward declared poin
On quarta-feira, 6 de junho de 2012 21.56.16, lars.kn...@nokia.com wrote:
> >https://codereview.qt-project.org/26981-Optimisedeletion
>
> I might be wrong (getting tired), but I think this reintroduces the
> problem with forward declared pointers that the first patch fixes.
It's a different soluti
On 6/6/12 6:53 PM, "ext Thiago Macieira" wrote:
>Cf. thread: Maintainer "TrustMes"
>http://lists.qt-project.org/pipermail/development/2012-April/002930.html
>http://comments.gmane.org/gmane.comp.lib.qt.devel/2953
>
>I need help again reviewing my own changes. Since I am the maintainer of
>the
>m
On 6/6/12 7:33 PM, "ext Thiago Macieira" wrote:
>On quarta-feira, 6 de junho de 2012 17.08.29, lars.kn...@nokia.com wrote:
>> Can't remember that you asked me. I can certainly review them if you
>>don't
>> have anyone else. I'll do so later tonight.
>
>I asked on IRC how you felt about reviewing
On quarta-feira, 6 de junho de 2012 17.08.29, lars.kn...@nokia.com wrote:
> Can't remember that you asked me. I can certainly review them if you don't
> have anyone else. I'll do so later tonight.
I asked on IRC how you felt about reviewing QSharedPointer changes and you
said you'd rather not do i
Can't remember that you asked me. I can certainly review them if you don't have
anyone else. I'll do so later tonight.
Cheers,
Lars
On 06.06.12 18:54 ext Thiago Macieira wrote:
Cf. thread: Maintainer "TrustMes"
http://lists.qt-project.org/pipermail/development/2012-April/002930.html
http://l
Cf. thread: Maintainer "TrustMes"
http://lists.qt-project.org/pipermail/development/2012-April/002930.html
http://comments.gmane.org/gmane.comp.lib.qt.devel/2953
I need help again reviewing my own changes. Since I am the maintainer of the
module that the changes are going to, there's no one else t
