Re: [Development] New BiC gotcha: adding noexcept

2017-12-03 Thread Allan Sandfeld Jensen
On Freitag, 1. Dezember 2017 15:41:18 CET Marc Mutz wrote: > On 2017-12-01 15:21, Marc Mutz wrote: > > Hi, > > > > I just realised: Since C++17, noexcept is part of the mangled name. > > That means that adding noexcept to an exported function is BiC now! > > This is not correct, after all. The na

Re: [Development] New BiC gotcha: adding noexcept

2017-12-01 Thread Thiago Macieira
On Friday, 1 December 2017 06:41:18 PST Marc Mutz wrote: > On 2017-12-01 15:21, Marc Mutz wrote: > > Hi, > > > > I just realised: Since C++17, noexcept is part of the mangled name. > > That means that adding noexcept to an exported function is BiC now! > > This is not correct, after all. The name

Re: [Development] New BiC gotcha: adding noexcept

2017-12-01 Thread Marc Mutz
On 2017-12-01 15:21, Marc Mutz wrote: Hi, I just realised: Since C++17, noexcept is part of the mangled name. That means that adding noexcept to an exported function is BiC now! This is not correct, after all. The name mangling of functions does not change, since you can't overload on noexcep

[Development] New BiC gotcha: adding noexcept

2017-12-01 Thread Marc Mutz
Hi, I just realised: Since C++17, noexcept is part of the mangled name. That means that adding noexcept to an exported function is BiC now! Please be aware of this when reviewing patches. Since non-template inline members of exported classes are exported, too, in MSVC Debug builds, the same