Hi all,
we are getting close to the Qt 5.6 beta and it's time for the header diff.
>From this point on we should be very careful in adding/changing newly
introduced API.
I'll send the actual header diffs as attachments in follow-up mails, it will
probably take a few hours until they actually g
diff --git a/src/location/places/qplaceeditorial.h b/src/location/places/qplaceeditorial.h
index 4a7e790..ecfe8db 100644
--- a/src/location/places/qplaceeditorial.h
+++ b/src/location/places/qplaceeditorial.h
@@ -48,7 +48,7 @@ class Q_LOCATION_EXPORT QPlaceEditorial : public QPlaceContent
public:
diff --git a/src/qmltest/quicktest.h b/src/qmltest/quicktest.h
index 49bd7ed..b317a07 100644
--- a/src/qmltest/quicktest.h
+++ b/src/qmltest/quicktest.h
@@ -35,9 +35,12 @@
#define QUICKTEST_H
#include
+#include
QT_BEGIN_NAMESPACE
+QTEST_ADD_GPU_BLACKLIST_SUPPORT_DEFS
+
Q_QUICK_TEST_EXPO
diff --git a/src/quickwidgets/qquickwidget.h b/src/quickwidgets/qquickwidget.h
index a8bf03e..5bb6b49 100644
--- a/src/quickwidgets/qquickwidget.h
+++ b/src/quickwidgets/qquickwidget.h
@@ -56,7 +56,6 @@ class Q_QUICKWIDGETS_EXPORT QQuickWidget : public QWidget
Q_PROPERTY(ResizeMode resizeMode
diff --git a/src/webchannel/qwebchannel.h b/src/webchannel/qwebchannel.h
index 0e642db..d32d017 100644
--- a/src/webchannel/qwebchannel.h
+++ b/src/webchannel/qwebchannel.h
@@ -35,8 +35,8 @@
#ifndef QWEBCHANNEL_H
#define QWEBCHANNEL_H
-#include
-#include
+#include
+#include
#include
d
diff --git a/src/render/frontend/qabstracttextureprovider.h b/src/render/frontend/qabstracttextureprovider.h
index 4121e01..436e3f8 100644
--- a/src/render/frontend/qabstracttextureprovider.h
+++ b/src/render/frontend/qabstracttextureprovider.h
@@ -190,6 +190,17 @@ public:
RGB_BP_UNSIGNED_
diff --git a/src/core/core-components/qcamera.h b/src/core/core-components/qcamera.h
index 4bf2553..e3d6b2e 100644
--- a/src/core/core-components/qcamera.h
+++ b/src/core/core-components/qcamera.h
@@ -163,6 +163,7 @@ Q_SIGNALS:
protected:
Q_DECLARE_PRIVATE(QCamera)
+QT3D_CLONEABLE(QCame
diff --git a/src/testlib/qsignalspy.h b/src/testlib/qsignalspy.h
index cfde89a..1751220 100644
--- a/src/testlib/qsignalspy.h
+++ b/src/testlib/qsignalspy.h
@@ -82,7 +82,7 @@ public:
}
if (!QMetaObject::connect(obj, sigIndex, this, memberOffset,
-Qt::DirectCo
diff --git a/src/serialport/qserialport.h b/src/serialport/qserialport.h
index 36ae788..2815ebe 100644
--- a/src/serialport/qserialport.h
+++ b/src/serialport/qserialport.h
@@ -65,9 +65,6 @@ class Q_SERIALPORT_EXPORT QSerialPort : public QIODevice
#endif
Q_PROPERTY(bool breakEnabled READ isBr
diff --git a/src/dbus/qdbusargument.h b/src/dbus/qdbusargument.h
index 42b2667..a6bc396 100644
--- a/src/dbus/qdbusargument.h
+++ b/src/dbus/qdbusargument.h
@@ -70,9 +70,15 @@ public:
QDBusArgument();
QDBusArgument(const QDBusArgument &other);
+#ifdef Q_COMPILER_RVALUE_REFS
+QDBusAr
diff --git a/src/positioning/qgeocoordinate.h b/src/positioning/qgeocoordinate.h
index a1a636d..3c08bc0 100644
--- a/src/positioning/qgeocoordinate.h
+++ b/src/positioning/qgeocoordinate.h
@@ -104,9 +104,10 @@ public:
Q_INVOKABLE QString toString(CoordinateFormat format = DegreesMinutesSeconds
diff --git a/src/multimedia/audio/qaudio.h b/src/multimedia/audio/qaudio.h
index 6395314..2ee66bc 100644
--- a/src/multimedia/audio/qaudio.h
+++ b/src/multimedia/audio/qaudio.h
@@ -51,12 +51,26 @@ namespace QAudio
enum Error { NoError, OpenError, IOError, UnderrunError, FatalError };
enum
diff --git a/src/xml/dom/qdom.h b/src/xml/dom/qdom.h
index 5a83659..f2bcf83 100644
--- a/src/xml/dom/qdom.h
+++ b/src/xml/dom/qdom.h
@@ -329,14 +329,14 @@ public:
inline QDomNode::NodeType nodeType() const { return DocumentNode; }
// Qt extensions
-bool setContent(const QByteArray&
diff --git a/src/printsupport/dialogs/qabstractprintdialog.h b/src/printsupport/dialogs/qabstractprintdialog.h
index cf55cfa..6148502 100644
--- a/src/printsupport/dialogs/qabstractprintdialog.h
+++ b/src/printsupport/dialogs/qabstractprintdialog.h
@@ -74,7 +74,7 @@ public:
Q_DECLARE_FLAGS(Pri
diff --git a/src/websockets/qwebsocket.h b/src/websockets/qwebsocket.h
index 9fdc6eb..7ee4bc6 100644
--- a/src/websockets/qwebsocket.h
+++ b/src/websockets/qwebsocket.h
@@ -36,6 +36,7 @@
#include
#include
+#include
#ifndef QT_NO_NETWORKPROXY
#include
#endif
@@ -92,6 +93,7 @@ public:
diff --git a/src/sql/kernel/qsqldriver.h b/src/sql/kernel/qsqldriver.h
index e837576..c53e1b8 100644
--- a/src/sql/kernel/qsqldriver.h
+++ b/src/sql/kernel/qsqldriver.h
@@ -83,7 +83,7 @@ public:
DB2
};
-explicit QSqlDriver(QObject *parent=0);
+explicit QSqlDriver(QObject *pa
diff --git a/src/quick/items/qquickframebufferobject.h b/src/quick/items/qquickframebufferobject.h
index 4a0248c..7fb7262 100644
--- a/src/quick/items/qquickframebufferobject.h
+++ b/src/quick/items/qquickframebufferobject.h
@@ -49,6 +49,7 @@ class Q_QUICK_EXPORT QQuickFramebufferObject : public QQ
diff --git a/src/webenginewidgets/api/qwebenginecertificateerror.h b/src/webenginewidgets/api/qwebenginecertificateerror.h
index 90b2320..7706ea3 100644
--- a/src/webenginewidgets/api/qwebenginecertificateerror.h
+++ b/src/webenginewidgets/api/qwebenginecertificateerror.h
@@ -37,10 +37,10 @@
#ifnd
diff --git a/src/bluetooth/qbluetoothlocaldevice.h b/src/bluetooth/qbluetoothlocaldevice.h
index 4587bbf..40e143a 100644
--- a/src/bluetooth/qbluetoothlocaldevice.h
+++ b/src/bluetooth/qbluetoothlocaldevice.h
@@ -113,4 +113,8 @@ private:
QT_END_NAMESPACE
+Q_DECLARE_METATYPE(QBluetoothLocalDevi
diff --git a/src/opengl/qgl.h b/src/opengl/qgl.h
index 8c55cff..99abdd2 100644
--- a/src/opengl/qgl.h
+++ b/src/opengl/qgl.h
@@ -235,7 +235,7 @@ public:
QGLContext(const QGLFormat& format);
virtual ~QGLContext();
-virtual bool create(const QGLContext* shareContext = 0);
+virtual
diff --git a/src/qml/debugger/qqmldebug.h b/src/qml/debugger/qqmldebug.h
index 559c492..5d65982 100644
--- a/src/qml/debugger/qqmldebug.h
+++ b/src/qml/debugger/qqmldebug.h
@@ -50,6 +50,8 @@ struct Q_QML_EXPORT QQmlDebuggingEnabler
QQmlDebuggingEnabler(bool printWarning = true);
static bo
diff --git a/src/network/access/qabstractnetworkcache.h b/src/network/access/qabstractnetworkcache.h
index 352daa9..326891b 100644
--- a/src/network/access/qabstractnetworkcache.h
+++ b/src/network/access/qabstractnetworkcache.h
@@ -60,9 +60,12 @@ public:
QNetworkCacheMetaData(const QNetworkCa
On Thursday 17 September 2015 12:29:27 Frederik Gladhorn wrote:
> we are getting close to the Qt 5.6 beta and it's time for the header diff.
No, it isn't.
Header diff is done close to the RC, when we deep freeze. Since there may still
be quite considerable changes coming in, we'll need to do th
: development@qt-project.org
Emne: Re: [Development] Qt 5.6.0 header diff
On Thursday 17 September 2015 12:29:27 Frederik Gladhorn wrote:
> we are getting close to the Qt 5.6 beta and it's time for the header diff.
No, it isn't.
Header diff is done close to the RC, when we deep freeze. Si
On Thursday 17 September 2015 16:19:38 Knoll Lars wrote:
> We need the difference to see where apis got added, so that we can review
> those. And that should happen now, and not when we get one to the rc.
The API review should happen now, not the header diff.
--
Thiago Macieira - thiago.macieira
5.6.0 header diff
On Thursday 17 September 2015 16:19:38 Knoll Lars wrote:
> We need the difference to see where apis got added, so that we can review
> those. And that should happen now, and not when we get one to the rc.
The API review should happen now, not the header diff.
--
Thiago Ma
On Thursday 17 September 2015 16:34:05 Knoll Lars wrote:
> And the best tool we have to identify new apis is probably a different of
> the headers... :-)
I understand that, but I don't have the time to go look for them buried in
thousands of lines of change (the Q_NULLPTR) in each and every .diff
015 6:51 PM
Til: development@qt-project.org
Kopi: Knoll Lars
Emne: Re: [Development] Qt 5.6.0 header diff
On Thursday 17 September 2015 16:34:05 Knoll Lars wrote:
> And the best tool we have to identify new apis is probably a different of
> the headers... :-)
I understand that, but I don&
On Thursday 17 September 2015 12:29:27 Frederik Gladhorn wrote:
> I'll send the actual header diffs as attachments in follow-up mails,
For next time, I think it would be a good idea to have this diff as a Gerrit
change on 5.(x-1) (just the headers), to use the commenting and approval
features of
On 21/09/15 16:10, "Marc Mutz" wrote:
>On Thursday 17 September 2015 12:29:27 Frederik Gladhorn wrote:
>> I'll send the actual header diffs as attachments in follow-up mails,
>
>For next time, I think it would be a good idea to have this diff as a
>Gerrit
>change on 5.(x-1) (just the headers), t
Hello,
this is an update, the final header diff.
Since we all agree that email is not the perfect medium for the header review
(I see some open questions in the old thread), I'd thought I'll go for an
attempt at pushing the diffs to gerrit. I'm not quite satisfied with the
outcome, ideas for im
On Thursday 21 January 2016 16:56:56 Frederik Gladhorn wrote:
> Hello,
>
> this is an update, the final header diff.
> Since we all agree that email is not the perfect medium for the header
> review (I see some open questions in the old thread), I'd thought I'll go
> for an attempt at pushing the
Looks good(nothing changed).
Regards,
Liang
From: development-bounces+liang.qi=theqtcompany@qt-project.org
on behalf of
Frederik Gladhorn
Sent: Thursday, September 17, 2015 12:56 PM
To: development@qt-project.org
Subject: [Development] Qt 5.6.0
Looks good.
Regards,
Liang
From: development-bounces+liang.qi=theqtcompany@qt-project.org
on behalf of
Frederik Gladhorn
Sent: Thursday, September 17, 2015 12:54 PM
To: development@qt-project.org
Subject: [Development] Qt 5.6.0 header diff
Also looks ok.
> On 17 Sep 2015, at 12:54, Frederik Gladhorn
> wrote:
>
> ___
> Development mailing list
> Development@qt-project.org
> http://lists.qt-project.org/mailman/listinfo/development
___
Developme
On Thursday 17 September 2015, Frederik Gladhorn wrote:
>
What is with all the Q_NULLPTR? I thought we decided not to do those. Not that
want them removed, that would be even more noise.
--- a/src/gui/painting/qpaintdevice.h
+++ b/src/gui/painting/qpaintdevice.h
static inline qreal devicePixelR
On Thursday 17 September 2015, Frederik Gladhorn wrote:
>
Please also note the new APIs in QtWebEngineCore. They are more important for
API review.
`Allan
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/li
: development@qt-project.org
Subject: [Development] Qt 5.6.0 header diff: QtLocation.diff
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
+++ b/src/testlib/qtestaccessible.h
@@ -126,7 +126,7 @@ public:
static void cleanup()
{
delete instance();
-instance() = 0;
+instance() = Q_NULLPTR;
}
this is wrong
+++ b/src/testlib/qtestmouse.h
@@ -45,6 +45,7 @@
#include
#include
#include
+#include
On Thursday 17 September 2015 14:25:25 Allan Sandfeld Jensen wrote:
> What is with all the Q_NULLPTR? I thought we decided not to do those. Not
> that want them removed, that would be even more noise.
We decided to do them for 5.6, since compilers are getting warning switches
about zero as null
On Thursday 17 September 2015 15:27:44 Milian Wolff wrote:
> +++ b/src/testlib/qtestaccessible.h
> @@ -126,7 +126,7 @@ public:
> static void cleanup()
> {
> delete instance();
> -instance() = 0;
> +instance() = Q_NULLPTR;
> }
>
> this is wrong
Why?
--
Thia
On 2015-09-17, Frederik Gladhorn wrote:
> --- a/src/corelib/tools/qbytearray.h
> +++ b/src/corelib/tools/qbytearray.h
> @@ -43,6 +43,7 @@
> #include
>=20
> #include
> +#include
>=20
> #ifdef truncate
> #error qbytearray.h must be included before any header file that defin=
> es truncate
> @
On Thursday 17 September 2015 18:17:01 Sune Vuorela wrote:
> > -// undocumented:
> > -static const quint64 MaxSize =3D (1 << 30) - sizeof(Data);
> > -
> Even though it is marked as undocumented, it does look slightly fishy to
> me.
You were not supposed to use it. If you did, your code is
Looks ok. Added move semantics and one new method. Created change
https://codereview.qt-project.org/#/c/125981/ to fix the docs of that
method.
Cheers,
Lars
On 17/09/15 12:55, "Frederik Gladhorn"
wrote:
>
___
Development mailing list
Development@qt-p
Nothing new, looks good.
On 17/09/15 12:55, "Frederik Gladhorn"
wrote:
>
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
Looks good.
On 17/09/15 12:55, "Frederik Gladhorn"
wrote:
>
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
Nothing new, looks good.
On 17/09/15 12:54, "Frederik Gladhorn"
wrote:
>
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
Nothing new here.
On 17/09/15 12:55, "Frederik Gladhorn"
wrote:
>
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
New enum QAudio::Role, an audio role property for QMediaPlayer and new
QAudioRoleControl interface.
Looks good to me, I assume the interface is for the backend, is that
correct?
Cheers,
Lars
___
Development mailing list
Development@qt-project.org
htt
No new API, looks good.
On 17/09/15 12:56, "Frederik Gladhorn"
wrote:
>
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
No new API, looks good.
On 17/09/15 12:56, "Frederik Gladhorn"
wrote:
>
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
No new API. Nice change in qsqlindex.h :)
Looks good.
On 17/09/15 12:56, "Frederik Gladhorn"
wrote:
>
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
New properties:
QQuickFramebufferObject::mirrorVertically, looks ok
QQuickPaintedItem::textureSize, not ok. It’s not versioned.
New methods:
* QQuickTextureFactory *textureFactoryForImage(const QImage &image), docs
not ok IMO.
New classes:
* QQuickImageResponse
Isn’t this class missing some w
No changes, looks good.
On 17/09/15 12:57, "Frederik Gladhorn"
wrote:
>
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
On Fri, Sep 18, 2015 at 9:36 AM, Knoll Lars wrote:
> New properties:
>
> QQuickFramebufferObject::mirrorVertically, looks ok
> QQuickPaintedItem::textureSize, not ok. It’s not versioned.
>
> New methods:
>
> * QQuickTextureFactory *textureFactoryForImage(const QImage &image), docs
> not ok IMO.
W
Op 18-9-2015 om 09:59 schreef Albert Astals Cid:
>
>> New classes:
>>
>> * QQuickImageResponse
>>
>> Isn’t this class missing some way to get the status of the response? It
>> only has an errorString() method, but no simple way to query whether it
>> was successful or not when finished() gets emitt
On 18/09/15 10:10, "André Somers" wrote:
>Op 18-9-2015 om 09:59 schreef Albert Astals Cid:
>>
>>> New classes:
>>>
>>> * QQuickImageResponse
>>>
>>> Isn’t this class missing some way to get the status of the response? It
>>> only has an errorString() method, but no simple way to query whether it
On 18/09/15 09:59, "Albert Astals Cid" wrote:
>On Fri, Sep 18, 2015 at 9:36 AM, Knoll Lars
>wrote:
>> New properties:
>>
>> QQuickFramebufferObject::mirrorVertically, looks ok
>> QQuickPaintedItem::textureSize, not ok. It’s not versioned.
>>
>> New methods:
>>
>> * QQuickTextureFactory *textureF
On Fri, Sep 18, 2015 at 10:10 AM, André Somers wrote:
> Op 18-9-2015 om 09:59 schreef Albert Astals Cid:
>>
>>> New classes:
>>>
>>> * QQuickImageResponse
>>>
>>> Isn’t this class missing some way to get the status of the response? It
>>> only has an errorString() method, but no simple way to quer
> On 18 Sep 2015, at 09:36, Knoll Lars wrote:
>
> New properties:
>
> QQuickFramebufferObject::mirrorVertically, looks ok
> QQuickPaintedItem::textureSize, not ok. It’s not versioned.
Like QQuickFramebufferObject, the object is not instantiated from QML, so the
two follow the same pattern, no
On Fri, Sep 18, 2015 at 10:39 AM, Knoll Lars
wrote:
> On 18/09/15 09:59, "Albert Astals Cid" wrote:
>
>>On Fri, Sep 18, 2015 at 9:36 AM, Knoll Lars
>>wrote:
>>> New properties:
>>>
>>> QQuickFramebufferObject::mirrorVertically, looks ok
>>> QQuickPaintedItem::textureSize, not ok. It’s not versio
On 18/09/15 10:49, "Gunnar Sletta" wrote:
>
>> On 18 Sep 2015, at 09:36, Knoll Lars
>>wrote:
>>
>> New properties:
>>
>> QQuickFramebufferObject::mirrorVertically, looks ok
>> QQuickPaintedItem::textureSize, not ok. It’s not versioned.
>
>Like QQuickFramebufferObject, the object is not instant
On 18/09/15 10:55, "Albert Astals Cid" wrote:
>On Fri, Sep 18, 2015 at 10:39 AM, Knoll Lars
> wrote:
>> On 18/09/15 09:59, "Albert Astals Cid"
>>wrote:
>>
>>>On Fri, Sep 18, 2015 at 9:36 AM, Knoll Lars
>>>
>>>wrote:
New properties:
QQuickFramebufferObject::mirrorVertically, look
Only new API is
void setPreferredSecurityFlags(QBluetooth::SecurityFlags flags);
QBluetooth::SecurityFlags preferredSecurityFlags() const;
API Looks good, but I’m wondering why the default on bluez is not Secure
as on the other platforms?
Cheers,
Lars
_
On Fri, Sep 18, 2015 at 10:59 AM, Knoll Lars
wrote:
>
>
> On 18/09/15 10:55, "Albert Astals Cid" wrote:
>
>>On Fri, Sep 18, 2015 at 10:39 AM, Knoll Lars
>> wrote:
>>> On 18/09/15 09:59, "Albert Astals Cid"
>>>wrote:
>>>
On Fri, Sep 18, 2015 at 9:36 AM, Knoll Lars
wrote:
> New pr
> On 18 Sep 2015, at 09:19, Knoll Lars wrote:
>
> Looks good to me, I assume the interface is for the backend, is that
> correct?
>
Yes that’s correct.
—
Yoann
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailma
> On 18 Sep 2015, at 10:56, Knoll Lars wrote:
>
> On 18/09/15 10:49, "Gunnar Sletta" wrote:
>
>>
>>> On 18 Sep 2015, at 09:36, Knoll Lars
>>> wrote:
>>>
>>> New properties:
>>>
>>> QQuickFramebufferObject::mirrorVertically, looks ok
>>> QQuickPaintedItem::textureSize, not ok. It’s not vers
From: Knoll Lars
>void setPreferredSecurityFlags(QBluetooth::SecurityFlags flags);
>QBluetooth::SecurityFlags preferredSecurityFlags() const;
It would be a behavior change. Prior to this API we used one default way to
connect. On all platforms this happ
On 18/09/15 12:40, "Blasche Alexander"
wrote:
>
>
>From: Knoll Lars
>
>
>>void setPreferredSecurityFlags(QBluetooth::SecurityFlags flags);
>>QBluetooth::SecurityFlags preferredSecurityFlags() const;
>
>It would be a behavior change. Prior to this API we use
On Donnerstag, 17. September 2015 09:15:06 CEST Thiago Macieira wrote:
> On Thursday 17 September 2015 15:27:44 Milian Wolff wrote:
> > +++ b/src/testlib/qtestaccessible.h
> >
> > @@ -126,7 +126,7 @@ public:
> > static void cleanup()
> > {
> >
> > delete instance();
> >
>
Only one new method in qqmldebug. Looks good.
Lars
On 17/09/15 12:57, "Frederik Gladhorn"
wrote:
>
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/development
New APIs:
Added support for redirections:
QNetworkReply::redirected() signal
QNetworkReply::InsecureRedirectError
QNetworkRequest::FollowRedirectsAttribute
These look good to me.
int QNetworkRequest::maximumRedirectsAllowed() const;
void QNetworkRequest::setMaximumRedirectsAllowed(int
maximumR
Tons of noise with Q_NULLPTR and similar changes...
New APIs:
QFileDialog::supportedSchemes property, looks good
QDesktopWidget::primaryScreenChanged signal
-> IMO this should be added as NOTIFY to the corresponding property.
qHash(QSizePolicy, uint), looks good
QMainWindow::GroupedDragging en
New QImage::pixelColor and setPixelColor methods, looking good
New QImageReader::gamma/setGamme methods, looking good
QMouseEvent has a new constructor, looks ok
Some new methods in QOpenGLFBO, looking ok to me
QColor: rgba64 support, looking ok
QPaintDevice::devicePixelRatioF, looks ok
Some ne
On 21/09/15 11:05, "Knoll Lars" wrote:
>Tons of noise with Q_NULLPTR and similar changes...
>
>New APIs:
>
>QFileDialog::supportedSchemes property, looks good
>
>QDesktopWidget::primaryScreenChanged signal
>-> IMO this should be added as NOTIFY to the corresponding property.
>
>qHash(QSizePolic
nar Sletta ; Agocs Laszlo
Subject: Re: [Development] Qt 5.6.0 header diff: QtGui.diff
New QImage::pixelColor and setPixelColor methods, looking good
New QImageReader::gamma/setGamme methods, looking good
QMouseEvent has a new constructor, looks ok
Some new methods in QOpenGLFBO, looking ok to m
rappers for more versions? What
will we call the wrapper class for OpenGL 4? Or are you planning to put
those into the extras as well?
Cheers,
Lars
>
>BR,
>Laszlo
>
>-Original Message-
>From: Knoll Lars
>Sent: 21. september 2015 12:29
>To: development@qt-project.o
pment] Qt 5.6.0 header diff: QtGui.diff
Hi Lazlo,
On 21/09/15 13:54, "Agocs Laszlo" wrote:
>As for the "extra" functions, it was seen a better choice to introduce a
>new class since there is a certain difference: the GLES 2.0 calls in
>QOpenGLFunctions are guaranteed
On 21/09/15 13:47, "Knoll Lars" wrote:
>
>
>On 21/09/15 11:05, "Knoll Lars" wrote:
>
>>Tons of noise with Q_NULLPTR and similar changes...
>>
>>New APIs:
>>
>>QFileDialog::supportedSchemes property, looks good
>>
>>QDesktopWidget::primaryScreenChanged signal
>>-> IMO this should be added as NO
APIs look good, just two doc fixes:
https://codereview.qt-project.org/#/c/126153/
https://codereview.qt-project.org/#/c/126154/
Cheers,
Lars
___
Development mailing list
Development@qt-project.org
http://lists.qt-project.org/mailman/listinfo/developm
On Monday 21 September 2015 11:05:52 Knoll Lars wrote:
> QDesktopWidget::primaryScreenChanged signal
> -> IMO this should be added as NOTIFY to the corresponding property.
The signal is missing the int argument
int primaryScreen()
-> primaryScreenChanged(int),
not: primaryScreenChange
On Fri, Oct 16, 2015 at 4:43 PM, Marc Mutz wrote:
> On Monday 21 September 2015 11:05:52 Knoll Lars wrote:
>> QDesktopWidget::primaryScreenChanged signal
>> -> IMO this should be added as NOTIFY to the corresponding property.
>
> The signal is missing the int argument
>
> int primaryScreen()
>
82 matches
Mail list logo
