[Development] Need CMake help for QNX (release-critical)

2023-09-13 Thread Thiago Macieira
Re:https://testresults.qt.io/coin/api/log/qt/qtbase/ 3cd67f71eccb54c0725e2f041d52df0f38c8db73/ LinuxUbuntu_22_04x86_64QNXQNX_710x86_64GCCqtci-linux-Ubuntu-22.04-x86_64-51- add35eUseConfigure/8747173571fbffbc9616350fba1566cc606a3003/build_1700090991/ log.txt.gz CMake said: -- Performing Test

Re: [Development] Proposal: (re)move qt5.git/_clang-format

2023-09-13 Thread Paul Wicking via Development
On 13 Sep 2023, at 16:25, Volker Hilsheimer via Development wrote: I find the input from clang-format’s sometimes helpful, sometimes annoying. And the source of the annoyance is not that clang-format points out things that I could have formatted differently, but that our pre-commit hook

[Development] Avoid QT_BEGIN_NAMESPACE..QT_END_NAMESPACE in Qt examples

2023-09-13 Thread Kai Köhne via Development
Hi, I suggest extending QUIP 13 [1] with a paragraph explaining that we shouldn't pre-declare Qt types in Qt examples: https://codereview.qt-project.org/c/meta/quips/+/503709 For the reasoning: While it's good practice to pre-declare referenced types in header files in our tools and Qt

Re: [Development] Proposal: (re)move qt5.git/_clang-format

2023-09-13 Thread Volker Hilsheimer via Development
On 13 Sep 2023, at 13:23, Ahmad Samir wrote: On 13/9/23 11:06, Ivan Solovev via Development wrote: I would therefore propose to remove the file from qt5.git: +1 from my side. I believe I simply do not have the clang-format tool installed on my system, because it usually breaks the formatting of

Re: [Development] qt6_add_shaders and static libraries

2023-09-13 Thread Ranen Ghosh via Development
Hi Alexandru. Thanks for the response. Yes, confirmed we used target names for linking (not file paths) > Are you perhaps adding the shadert to a static library in one project, and then trying to reuse the static library in a different project? Yes, this is what we are trying to do. I've

Re: [Development] Proposal: (re)move qt5.git/_clang-format

2023-09-13 Thread Ahmad Samir
On 13/9/23 11:06, Ivan Solovev via Development wrote: I would therefore propose to remove the file from qt5.git: +1 from my side. I believe I simply do not have the clang-format tool installed on my system, because it usually breaks the formatting of the patches, not improves them. One way

Re: [Development] Proposal: (re)move qt5.git/_clang-format

2023-09-13 Thread Ahmad Samir
On 13/9/23 09:13, Paul Wicking wrote: On 12 Sep 2023, at 22:33, Ahmad Samir wrote: _clang-format isn't picked up by clang-format by default, you'd have to rename it to .clang-format. clang-format reads either of them [0]. It's unnecessary to rename the configuration file. [0] -

Re: [Development] qt6_add_shaders and static libraries

2023-09-13 Thread Alexandru Croitor via Development
Hi, The object file is supposed to be automatically linked into your application when you link to the static library target. That's handled by the qt6_add_resources call that qt6_add_shaders call, and it assumes you use target names for linking, and not file paths. If it doesn't, i suspect

[Development] HEADS-UP: Branching from '6.6' to '6.6.0' done

2023-09-13 Thread Jani Heikkinen via Development
Hi! We have branched '6.6.0' from '6.6' now. So from now on all changes targeted to Qt 6.6.0 release must have 'Pick-to: 6.6.0' and '6.6' is for Qt 6.6.1. But remember, please do not try to add anything nice-to-haves in '6.6.0' anymore; we will take in only fixes for release blockers (+ of

Re: [Development] Proposal: (re)move qt5.git/_clang-format

2023-09-13 Thread Ivan Solovev via Development
> I would therefore propose to remove the file from qt5.git: +1 from my side. I believe I simply do not have the clang-format tool installed on my system, because it usually breaks the formatting of the patches, not improves them. > One way to address these problems, especially for new devs or

Re: [Development] Proposal: (re)move qt5.git/_clang-format

2023-09-13 Thread Ulf Hermann via Development
There _is_ consensus. It's in the wiki. And in older modules not infected by the _clang-format file. Discussions arise because of .clang-format, not despite it. Afaict, there never was a discussion about how faithful the _clang-format represents the Qt style before it was added. If there was

Re: [Development] Proposal: (re)move qt5.git/_clang-format

2023-09-13 Thread Paul Wicking via Development
On 12 Sep 2023, at 22:33, Ahmad Samir wrote: _clang-format isn't picked up by clang-format by default, you'd have to rename it to .clang-format. clang-format reads either of them [0]. It's unnecessary to rename the configuration file. [0] -