Re: [Development] Updating x86 SIMD support in Qt

2022-01-20 Thread Thiago Macieira
calls are behind if constexpr (UseAvx2) { or if constexpr (UseAvx256) { * the new content uses __m256i among other things without #if This is the request: if you #define __SSE2__, then you MUST provide __m256i and the 256-bit x86 intrinsics (up to and including the new ones added in AVX512

Re: [Development] Updating x86 SIMD support in Qt

2022-01-23 Thread Thiago Macieira
n fast in their OS, I say we agree and keep on wasting CPU. On Linux, we can have the multiple versions. I proposed a minimum of v2 and an option of v3, but we can always choose v1+v2+v3. But I really want v2 and v3 for the critical libraries. On macOS, the minimum today is already v2,

Re: [Development] Updating x86 SIMD support in Qt

2022-01-24 Thread Thiago Macieira
promise you not to make it a silent crash. Either QtCore or the dynamic linker would say it can't run on that machine. https://code.woboq.org/qt6/qtbase/src/corelib/global/ qsimd.cpp.html#_Z16qDumpCPUFeaturesv -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architec

Re: [Development] Implicit VFMADD support (Was: Updating x86 SIMD support in Qt)

2022-01-24 Thread Thiago Macieira
. You're out of luck if you're using MinGW, though. Compare: https://gcc.godbolt.org/z/c5385d5GY (no FMA) to: https://gcc.godbolt.org/z/jf3zhsjPf (with FMA) -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering ___

Re: [Development] Implicit VFMADD support (Was: Updating x86 SIMD support in Qt)

2022-01-24 Thread Thiago Macieira
fma and it'll do the right thing. It becomes my problem to optimise it so we get the shortest code emission, not yours. The compilers also convert *some* instances of plain multiplication followed by addition into FMA. That depends on compiler flags, often enough, because of differences in

Re: [Development] Proposing to officially allow C++20 types in Qt 6 ABIs

2022-01-27 Thread Thiago Macieira
10 is too new and we support GCC 9. See https://doc.qt.io/qt-6/supported-platforms.html. Therefore, we can't use std::span in our ABI just yet. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering _

Re: [Development] Proposing to officially allow C++20 types in Qt 6 ABIs

2022-01-27 Thread Thiago Macieira
estion. If you make it optional, then the build will succeed but the symbol will be missing. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering ___ Development mailing list Development@qt-projec

Re: [Development] Proposing to officially allow C++20 types in Qt 6 ABIs

2022-01-27 Thread Thiago Macieira
em. Only people who have a commercial interested should be required to suffer them. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] Proposing to officially allow C++20 types in Qt 6 ABIs

2022-01-27 Thread Thiago Macieira
On Thursday, 27 January 2022 13:35:54 PST Thiago Macieira wrote: > I think it's fine to make the check per OS. But we can't use the __cpp_lib > variables. Alternative: we use the __cpp_lib macros, but we assert they are set in a .cpp file for the platforms where binary compa

Re: [Development] Proposing to officially allow C++20 types in Qt 6 ABIs

2022-01-27 Thread Thiago Macieira
++17. But we default to C++20. This option would be as ABI-breaking as the feature system or choosing qreal == float. And, as the feature system, don't report bugs; send patches instead. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Clo

Re: [Development] Proposing to officially allow C++20 types in Qt 6 ABIs

2022-01-31 Thread Thiago Macieira
any issues they encounter. Don't report bugs. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] Proposing to officially allow C++20 types in Qt 6 ABIs

2022-01-31 Thread Thiago Macieira
k errors are completely meaningless to an end user. I'd say no. That was my reply to Lars just now and the gist of my opposition to Marc's initial proposal: a C++17 build of Qt is an unsupported "send patches, not bug reports" build. -- Thiago Macieira - thiago.macieira (A

Re: [Development] Proposing to officially allow C++20 types in Qt 6 ABIs

2022-01-31 Thread Thiago Macieira
build. That's our choice to make and I'll abstain from going either way. However, I do mind the ABI. It must be the same for all supported builds of Qt that use the an ABI-compatible compiler & toolchain. I am opposing a change this. -- Thiago Macieira - thiago.macieira (AT) int

Re: [Development] Heads-UP: Proposal for Qt 6.4 milestones & schedules

2022-02-03 Thread Thiago Macieira
possible to build Qt by > yourself, but binaries are not yet available. This is no longer relevant as > we have binary snapshots already before the feature freeze. In addition, > the typical (Wikipedia) definition of alpha release is before the feature > freeze, not after as we have used

Re: [Development] Monthly CI maintenance break - February (Mon 7th Feb 2022)

2022-02-08 Thread Thiago Macieira
On Tuesday, 8 February 2022 00:37:50 PST Ville-Pekka Karhu wrote: > This is now DONE Not exactly. The Squid daemon running on port 3130 on the network test server isn't up. All integrations in qtbase are currently failing. -- Thiago Macieira - thiago.macieira (AT) intel.com

Re: [Development] MinGW with UCRT and Qt

2022-02-09 Thread Thiago Macieira
there wasn't an UCRT until VS 2015, but many of the functions in question (including _get_tzname) have been available since VS 2008 or earlier. > Are there any plans to adapt to UCRT MinGW? Once it's officially supported by upstream, with default toolchain builds, we should switch.

Re: [Development] Monthly CI maintenance break - February (Mon 7th Feb 2022)

2022-02-10 Thread Thiago Macieira
his stuck integration? It's been over 17 hours: qtbase refs/builds/qtci/dev/167710 https://codereview.qt-project.org/c/qt/qtbase/+/381136 -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering _

Re: [Development] Monthly CI maintenance break - February (Mon 7th Feb 2022)

2022-02-11 Thread Thiago Macieira
he changes that are in wrong state. Thanks, I've re-staged the changes now. Hopefully we'll get some results in a few hours. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering ___

Re: [Development] Monthly CI maintenance break - February (Mon 7th Feb 2022)

2022-02-11 Thread Thiago Macieira
On Friday, 11 February 2022 07:57:23 PST Thiago Macieira wrote: > On Friday, 11 February 2022 00:25:55 PST Toni Saario wrote: > > Coin update during the maintenance introduced a bug which can leave the > > changes hanging in wrong state. > > > > A change was reverted

[Development] Using Git notes to reflect actual cherry-picks

2022-02-11 Thread Thiago Macieira
present but not 6.2, So I searched Gerrit and indeed, the change simply failed in the CI 3 weeks ago and no one pushed the button again. The scripts are pretty fast, but I've also made them work incrementally. See the attached run example. -- Thiago Macieira - thiago.macieira (AT) intel.com

Re: [Development] Requesting forward BC exception for QtWaylandCompositor in 6.2 and 5.15

2022-02-15 Thread Thiago Macieira
unsupported C++20 build wasn't supported. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] Requesting forward BC exception for QtWaylandCompositor in 6.2 and 5.15

2022-02-15 Thread Thiago Macieira
On Tuesday, 15 February 2022 09:34:35 PST Marc Mutz wrote: > 6.2 is an LTS release, is it not? Not from my point of view, it isn't. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Eng

Re: [Development] Requesting forward BC exception for QtWaylandCompositor in 6.2 and 5.15

2022-02-15 Thread Thiago Macieira
On Tuesday, 15 February 2022 10:46:15 PST Thiago Macieira wrote: > On Tuesday, 15 February 2022 09:34:35 PST Marc Mutz wrote: > > 6.2 is an LTS release, is it not? > > Not from my point of view, it isn't. Let's do it this way: 6.2.4 branching starts on Monday Feb 21st.

Re: [Development] Requesting forward BC exception for QtWaylandCompositor in 6.2 and 5.15

2022-02-15 Thread Thiago Macieira
7;t one, then it was under BC guarantees. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] Requesting forward BC exception for QtWaylandCompositor in 6.2 and 5.15

2022-02-16 Thread Thiago Macieira
d only those that > sign extra papers can. And "you" here means the company the person works for, in case their work in Qt is under their copyright. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering __

Re: [Development] Requesting forward BC exception for QtWaylandCompositor in 6.2 and 5.15

2022-02-16 Thread Thiago Macieira
tors are implemented as members, but are not const. Since > they're not const, they cannot be called with a const LHS... By the way, how often is this done? What's the exposure in the real world? The pre-6.3 implementation could be #if __cplusplus <= 2020 -- Thiago Macie

Re: [Development] Requesting forward BC exception for QtWaylandCompositor in 6.2 and 5.15

2022-02-17 Thread Thiago Macieira
e where we left off on (2), but it's unlikely that anything we > decide will be retroactively applied to Qt 6.2, isn't it? I don't have a problem about using any type in our ABI, so long as it's ALWAYS there and that no one who performed an acceptable upgrade would find a linke

Re: [Development] Using Git notes to reflect actual cherry-picks

2022-02-21 Thread Thiago Macieira
t; is optional. I haven't heard anyone volunteer to make this work. All this requires is that someone run a cron job every week and have rights to push to the refs/notes/* hierarchy. -- Thiago Macieira - thiago.macieira (AT) intel.com Soft

Re: [Development] Requesting forward BC exception for QtWaylandCompositor in 6.2 and 5.15

2022-02-22 Thread Thiago Macieira
x27;s a brown paper bag. We can blame Clang in the ChangeLog. Let's suck it > up and move on. My opinion is unchanged: don't do it for 6.2.4. After 6.2.4, the 6.2 branch becomes irrelevant for me, so I don't care what you do. -- Thiago Macieira - thiago.maciei

Re: [Development] QStandardPaths on windows

2022-03-02 Thread Thiago Macieira
On Tuesday, 1 March 2022 09:40:25 PST Scott Bloom wrote: > Is there anyway to do what I need today? No, that would be a new feature. For now, you'll have to ensure each test is run in a separate container / view of the filesystem if you're running them in parallel. -- Th

Re: [Development] Maintainance Tool

2022-03-04 Thread Thiago Macieira
the company offering them, for example). Then business rules apply. The same way that obtaining sources for (L)GPL content you got as a binary is also a business obligation and must be honoured. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud

Re: [Development] Using Git notes to reflect actual cherry-picks

2022-03-05 Thread Thiago Macieira
On Monday, 21 February 2022 17:21:30 PST Thiago Macieira wrote: > On Saturday, 12 February 2022 07:15:36 PST Tor Arne Vestbø wrote: > > Very cool! As ossi suggests, this could potentially be handled by Gerrit, > > similar to this: > > > > https://gerrit.googlesource.

Re: [Development] requesting repository for qmake2cmake tool

2022-03-07 Thread Thiago Macieira
t-filter-repo --subdirectory-filter util/cmake" of qtbase as > baseline +1 -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering ___ Development mailing list Development@qt-project.org h

[Development] Need approvals for "Make sure all private headers include at least one other" changes

2022-03-07 Thread Thiago Macieira
https://codereview.qt-project.org/q/Ib056b47dde3341ef9a5213ef677e471674b6 I'll abandon anything not approved in one week. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering ___ Develo

[Development] Requesting approval on https://codereview.qt-project.org/c/qt/qtbase/+/21156

2022-03-09 Thread Thiago Macieira
It's been 23 days since I last uploaded the patch. There are two +1 votes within 2 days of the upload, but no action since then. This is not QtCore, so I don't feel right in maintainer-approving it. So I'm requesting a +2. -- Thiago Macieira - thiago.macieira (AT) intel

Re: [Development] Renaming QLatin1String to QLatin1StringView

2022-03-11 Thread Thiago Macieira
ator""_L1 for constructing Latin-1 > string literals, to minimize the porting effort from QLatin1String to > QLatin1StringView. BTW, shouldn't this one also have a "v" somewhere, like _qsv? -- Thiago Macieira - thiago.macieira

Re: [Development] Cherry-picks lost and forgotten

2022-03-16 Thread Thiago Macieira
d, and therefore the CI has a huge backlog now to go through. Or it just fell over, because I have integrations now running for over 7 hours. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering ___

Re: [Development] Updating x86 SIMD support in Qt

2022-03-23 Thread Thiago Macieira
As far as I know, this is a problem exclusive to VirtualBox. It wouldn't affect VMWare or qemu KVM-accelerated virtualisation. I also haven't noticed it on Parallels on my Mac. It's been reported but hasn't been fixed. -- Thiago Macieira - thiago.macie

Re: [Development] Updating x86 SIMD support in Qt

2022-03-24 Thread Thiago Macieira
5 without > problems (or at least without that particular problem). This only happens if you pass -march=native for it, which will inlcude AVX2 but not the other ones. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud

Re: [Development] Proposals for changes to "Precheck" feature

2022-03-25 Thread Thiago Macieira
f you updated any of the previous changes, the pre-check would no longer work. I've resorted to pushing a dummy, WIP change with no reviewers and all my changes squashed, so I could pre-check that. In that case, I could rebase it at will too. -- Thiago Macieira - thiago.macieira (AT) i

Re: [Development] Proposals for changes to "Precheck" feature

2022-03-26 Thread Thiago Macieira
d, but the head and tail haven't (usually *because* the tail depends on the head). What would the precheck do? -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering ___ Development mailing list De

Re: [Development] Qt UDL operators

2022-04-03 Thread Thiago Macieira
ti-year process then. Step 1) stop generating this for new code Step 2) 2 years later, add the warning of deprecation (the actual code change can be done now, with the warning enabled for the N+4 minor release of Qt) -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Int

Re: [Development] [Announce] Security advisory: Recently reported zlib compression issue impacts Qt

2022-04-06 Thread Thiago Macieira
s for all those libraries yourself. Qt does not usually provide security fixes for issues in third-party content, unless they are caused by our own use of those libraries. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - I

Re: [Development] Linker script / symbols versions for private entries in Qt 6, regression from Qt 5?

2022-04-18 Thread Thiago Macieira
pstreamed and enabled by default... but there should be an opt-out for developers. Those of us who recompile Qt often and do regression testing may need to run code across the version change boundaries without recompiling. -- Thiago Macieira - thiago.macieira (AT) in

Re: [Development] Linker script / symbols versions for private entries in Qt 6, regression from Qt 5?

2022-04-19 Thread Thiago Macieira
build time I would need to build it (just ping, I'll > happily do it). Yes, it's a build-time file. We scan the private headers to get the list of class names that appear there so they can be marked as private. -- Thiago Macieira - thiago.macieira (AT) intel.com Software

Re: [Development] Linker script / symbols versions for private entries in Qt 6, regression from Qt 5?

2022-04-19 Thread Thiago Macieira
inux-pkgs/qtbase/blob/master/tell-the-truth-about-private-api.patch This helped me catch all the packages that needed rebuilding more easily. Which is a PITA because there's a circular dependency somewhere in KDE packages which required manual intervention every time. -- Thiago Macieira - t

Re: [Development] QRect::contains and undocumented(?) edge

2022-04-21 Thread Thiago Macieira
tand, then it might be a good idea. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] QFreedesktopApplication

2022-04-24 Thread Thiago Macieira
apply: can we have it without a front-end API? In fact, if it is a D-Bus API, should we have it even if the GLib event dispatchers aren't active? -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering __

Re: [Development] QFreedesktopApplication

2022-04-24 Thread Thiago Macieira
x27;s available... I don't agree with the value. Implement it directly with Qt resources. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cloud Engineering ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] QFreedesktopApplication

2022-04-25 Thread Thiago Macieira
se/-/commit/ a5314c7a8b11a8e6bee8ecf1c4dba112378e532b Yes, it's unmaintained because I don't have time for it either. And because Windows threading made me give up. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel

[Development] If you introduce new deprecation warnings, fix them before they integrate

2022-04-26 Thread Thiago Macieira
rst, then make the replacement, and only then deprecate. I've started the clean-up: https://codereview.qt-project.org/c/qt/qtserialport/+/407661 https://codereview.qt-project.org/c/qt/qtwayland/+/407662 -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel DPG Cl

Re: [Development] QTBUG-95930 / QTBUG-99546 need some attention

2022-05-09 Thread Thiago Macieira
t; like with other system DPI settings. It it's a system setting, then one should assume it's been set to the exact value that the system wanted it to be. So if they'd wanted it rounded, they'd have rounded it. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Softw

Re: [Development] QtCS2022 - Sessions and Timeslots

2022-05-19 Thread Thiago Macieira
00. I don't need to join the keynote, so I won't force people to wake up early for that one. But please bear the times in mind if you'd like me to join. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - In

Re: [Development] New Chief Maintainer

2022-05-19 Thread Thiago Macieira
; QUIP). The QUIP doesn’t explicitly require the candidate to be a > Maintainer. Sounds good. Volker, you've been nominated. Since you have not objected to it, we'll assume you're willing to be our new Overl^H^H^H^H^HChief Maintainer, correct? -- Thiago Macieira - thiago.m

Re: [Development] QtCS2022 - Sessions and Timeslots

2022-05-20 Thread Thiago Macieira
Pedro, the licence header update (lots of thanks to Lucie and Jörg on that one!), and maybe the Conan discussion. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Intel DCAI Cloud Engineering ___ Development mailin

Re: [Development] Why qrc's metadatas is the big endian?

2022-05-23 Thread Thiago Macieira
mber, but it would add code, not reduce. That is, it would make things more complex, not less. I don't think it's worth it. Byte-swapping is pretty fast. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Intel DCAI Cloud Engineering

Re: [Development] Using Git notes to reflect actual cherry-picks

2022-05-24 Thread Thiago Macieira
On Saturday, 5 March 2022 11:07:17 PDT Thiago Macieira wrote: > > All this requires is that someone run a cron job every week and have > > rights > > to push to the refs/notes/* hierarchy. > > Anyone? No one? The script here is working. https://codereview.qt-project.

Re: [Development] Reminder: Codereview scheduled maintenance break on Monday 6-Jun 7 am CET

2022-06-06 Thread Thiago Macieira
it still sets it if you edit the commit message. But I can't find the ability any more. Does anyone know where it went? -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Intel DCAI Cloud Engineering ___ Development

Re: [Development] Reminder: Codereview scheduled maintenance break on Monday 6-Jun 7 am CET

2022-06-07 Thread Thiago Macieira
On Monday, 6 June 2022 09:02:07 PDT Thiago Macieira wrote: > On Monday, 6 June 2022 01:56:14 PDT Jukka Jokiniva wrote: > > Fix was found and deployed. Maintenance break is over for Gerrit. > > The previous Gerrit had the ability to add a short description of what a > patchset

Re: [Development] Asking for a FF exception for ICU based QStringConverter

2022-06-08 Thread Thiago Macieira
d of next week for this feature? As a maintainer of the module in question, I'm ok with this. It's a new feature, but it has no new API. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Intel DCAI Cloud Engineering

Re: [Development] Asking for a FF exception for ICU based QStringConverter

2022-06-08 Thread Thiago Macieira
code using QStringConverter with non-builtin encodings will leak resources unless it's recompiled for 6.4. No source changes are necessary. I am saying that (d) is an acceptable situation because of (a) and (b), and in spite of (c). -- Thiago Macieira - thiago.macieira (AT) intel.com Clo

Re: [Development] Asking for a FF exception for ICU based QStringConverter

2022-06-09 Thread Thiago Macieira
f the version >= 6.4.0 > 2. Probably add a "TODO: remove me" in 6.x.0 (e.g. after the next LTS) Much simpler to add an overloaded constructor with an extra, dummy member. If you recompile your sources, you get the new one with the new codecs. If you don't recompile, you don&

Re: [Development] Asking for a FF exception for ICU based QStringConverter

2022-06-09 Thread Thiago Macieira
On Thursday, 9 June 2022 12:36:25 PDT Alexander Akulich wrote: > On Thu, Jun 9, 2022 at 10:14 PM Thiago Macieira > > wrote: > > Doesn't work for libraries. > > Can you explain please? Libraries don't call QCoreApplication's constructor. The application ma

Re: [Development] QML Demo has a higher memory usage than Wdiget Demo

2022-06-15 Thread Thiago Macieira
measuring here? What tool did you use? -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Intel DCAI Cloud Engineering ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] QML Demo has a higher memory usage than Wdiget Demo

2022-06-15 Thread Thiago Macieira
ed to memory mappings) and find out consumes most memory. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Intel DCAI Cloud Engineering ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] Building Qt6 from source

2022-06-19 Thread Thiago Macieira
untu 20 with a > different CMake version or other Qt version, I'd be happy to try that as > well. If you're building tests, please download using GIt. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect

Re: [Development] Building Qt6 from source

2022-06-19 Thread Thiago Macieira
u wouldn't be asking the question. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Intel DCAI Cloud Engineering ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] Rvalue pinning in Qt

2022-06-20 Thread Thiago Macieira
copy (given `s` is a view after [4]), while now it only > takes a reference. Yup. > Opinions? My only objection is to calling this by a fancy name, "rvalue pinning". Simply call what it is: take all parameters by const-lvalue and never store a ref

[Development] Windows QtTest changes free for the taking

2022-06-21 Thread Thiago Macieira
it's not QtTest and I don't have a Windows machine. Therefore, I have no way of fixing the CI failure. So those two changes are free for the taking. If no one adopts them in 2 weeks, I'll just abandon them in Gerrit. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Sof

Re: [Development] QKeySequenceEdit: Unable to assign tab

2022-06-24 Thread Thiago Macieira
d for returning null and handled properly, with something other than a warning (or worse). [*] there's an exception to this rule. Exercise left to the reader to find out what it is. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Arc

Re: [Development] Splitting Qt Network out of qtbase (was: QtBase network failures)

2022-06-25 Thread Thiago Macieira
qt.io/coin/integration/qt/qtbase/tasks/1654295531 [8] https://testresults.qt.io/coin/integration/qt/qtbase/tasks/1655717505 [9] https://testresults.qt.io/coin/integration/qt/qtbase/tasks/1647034101 -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Intel DCAI Cl

Re: [Development] Splitting Qt Network out of qtbase (was: QtBase network failures)

2022-06-26 Thread Thiago Macieira
t and simplify > tst_QFile::writeLargeDataBlock_data) after running this as admin: This is a very good idea. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Intel DCAI Cloud Engineering ___ Development mailing list Dev

Re: [Development] Splitting Qt Network out of qtbase (was: QtBase network failures)

2022-07-02 Thread Thiago Macieira
On Saturday, 25 June 2022 09:33:42 PDT Thiago Macieira wrote: > * licensing issues with the INTEGRITY compiler And now I have a URL for this one: https://testresults.qt.io/coin/integration/qt/qtbase/tasks/1656777463 -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Archit

Re: [Development] Reminder: Codereview scheduled maintenance break on Monday 6-Jun 7 am CET

2022-07-13 Thread Thiago Macieira
On Monday, 6 June 2022 09:02:07 PDT Thiago Macieira wrote: > On Monday, 6 June 2022 01:56:14 PDT Jukka Jokiniva wrote: > > Fix was found and deployed. Maintenance break is over for Gerrit. > > The previous Gerrit had the ability to add a short description of what a > patchset

Re: [Development] Proposal: move Qt provisioning scripts and 3rd party components into a dedicated repo

2022-07-14 Thread Thiago Macieira
est on how to use the bundled zlib in user code. The answer is: Don't. The bundled libraries are for Qt's use only and if you want to use it, you must have the regular library that your content can use. And if you're going to do that anyway, then you will likely wa

Re: [Development] Proposal: move Qt provisioning scripts and 3rd party components into a dedicated repo

2022-07-14 Thread Thiago Macieira
f upstream isn't willing to deal with an exotic platform, then we should reconsider this particular feature in that library. Either find another library, or develop ourselves, or don't support this feature in that configuration. > 5. Manually building and installing all 3rd pa

Re: [Development] Proposal: move Qt provisioning scripts and 3rd party components into a dedicated repo

2022-07-14 Thread Thiago Macieira
isunderstanding > what you mean by "as system libraries". The use of "system" here is Qt's meaning of it: it's not the bundled copy. They should be installed to a regular prefix of your choice, which could be /usr/local. Installing them to where your Qt build will b

[Development] Some OpenSSL auto tests fail to link with -DFEATURE_openssl_linked=ON

2022-07-16 Thread Thiago Macieira
Because they don't even try to link to the library. Since I'm not allowed to fix these tests, I'm just reporting. Those are the only auto tests in qtbase that fail to compile for me. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Intel DCAI Cl

[Development] QMetaType and non-const references

2022-07-18 Thread Thiago Macieira
e behaves subtly different whether you use it or not. The code needs to be cleaned to the point that I understand it before I will allow any new feature work for it. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Intel DCAI Cloud Engineering

Re: [Development] QMetaType and non-const references

2022-07-19 Thread Thiago Macieira
s as "Properties and method arguments or return values > of such types will still have metatypes." I agree. Yep. > > - add a way to link a T& metatype back to T's > > That may be useful. I don't have much of an opinion here. I think it goes with

Re: [Development] QMetaType and non-const references

2022-07-19 Thread Thiago Macieira
is not the name that the C++ language recognises for your type, and this should only be done for legacy reasons. typedef QMap IntMap; Q_DECLARE_METATYPE(IntMap); And you may have the string "IntMap" somewhere in your m

Re: [Development] QMetaType and non-const references

2022-07-19 Thread Thiago Macieira
; Non-default-constructible but movable is an interesting API challenge > for QVariant, but I wouldn't rule it out just yet. We don't have to > implement all of this right away, but we shouldn't take decisions now > that make such a thing impossible in the future. Fa

Re: [Development] QMetaType and non-const references

2022-07-19 Thread Thiago Macieira
.quad QtPrivate::.::getCopyCtr()::{lambda} .quad QtPrivate::::getMoveCtr()::{lambda} .quad QtPrivate::::getDtor()::{lambda} .quad QtPrivate::::equals .quad QtPrivate::::lessThan .quad 0 .quad 0 .quad

Re: [Development] QMetaType and non-const references

2022-07-19 Thread Thiago Macieira
; check that DBus, Qt Remote Objects and QML don't get accidentally broken. I've been running the tst_q*variant, tst_q*metatype and D-Bus unit tests here, only. It's pretty hard to break the very lowest levels of those two classes and still get anything to run -- you get crashes

Re: [Development] Code Review of Build File Changes

2022-07-20 Thread Thiago Macieira
code areas that only have one or two people who can ever review them (or, worse, zero) and there's a similar symptom there. I also recommend you see how documentation-only changes are reviewed, and ditto for unit-test-only changes. -- Thiago Macieira - thiago.macieira (AT) intel.com

Re: [Development] QMetaType and non-const references

2022-07-20 Thread Thiago Macieira
t/qtbase/+/422745/1/tests/auto/ corelib/kernel/qmetaobject/tst_qmetaobject.cpp [2] https://codereview.qt-project.org/c/qt/qtbase/+/422746/1/src/corelib/ kernel/qobjectdefs.h -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect

Re: [Development] Code Review of Build File Changes

2022-07-21 Thread Thiago Macieira
e, I ask in #cmake on Slack. My argument is that I don't think the hypothesis is true or at least it's not proven. Just because there was no discussion on Gerrit does not mean there was no discussion. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architec

[Development] qdoc help needed: it isn't seeing a function that is clearly there

2022-07-25 Thread Thiago Macieira
aType meta) The function exists because it's unit-tested and compiled. Why can't qdoc see it? It's a hidden friend, but that's valid C++ and clang should see it. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Int

Re: [Development] qdoc help needed: it isn't seeing a function that is clearly there

2022-07-25 Thread Thiago Macieira
work with this as well. That's messed up. I guess simply pre-declaring the function above the class so it's not a hidden friend helps. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Intel DCAI Cloud Engineering __

Re: [Development] Using Git notes to reflect actual cherry-picks

2022-07-26 Thread Thiago Macieira
qt/qtqa/scripts/gerrit/cherrypick-git-notes > ? Change to qtqa abandoned, after lack of interest from anyone else but Tor Arne. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Intel DCAI Cloud Engineering ___ Develo

Re: [Development] [Announce] Security advisory: Freetype in Qt

2022-07-27 Thread Thiago Macieira
ar that is the case. BTW, this is why we started the discussion on third-parties. If we had freetype as a separate DLL, upgrading that one would solve the problem for everything. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Int

[Development] Please avoid shell-special row names in QtTest

2022-07-27 Thread Thiago Macieira
shell. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Intel DCAI Cloud Engineering ___ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development

Re: [Development] [Announce] Security advisory: Freetype in Qt

2022-07-27 Thread Thiago Macieira
In which case, you should simply update to 2.12.1 on your own. Ignore the patches in the CVE. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Intel DCAI Cloud Engineering ___ Development mailing list Development

Re: [Development] [Announce] Security advisory: Freetype in Qt

2022-07-27 Thread Thiago Macieira
CT? Non-commercial customers shouldn't even see the option for LTS, since it's not LTS for them. There should only be "Latest releases". Yes, it means that to find Qt 5, you'll need to go look in the Archive. -- Thiago Macieira - thia

Re: [Development] [Announce] Security advisory: Freetype in Qt

2022-07-27 Thread Thiago Macieira
uot;LTS" heading, but not get a single update for the next 10 months. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect - Intel DCAI Cloud Engineering ___ Development mailing list Development@qt-project.org h

Re: [Development] Challenge: adding new method overloads when existing consumers use {} with args

2022-07-28 Thread Thiago Macieira
cial, so I don't know how we'd deal with it. I don't think this has come up for us yet. For one, the mailing list thread linked in the QUIP didn't address it. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Softwar

Re: [Development] Challenge: adding new method overloads when existing consumers use {} with args

2022-07-29 Thread Thiago Macieira
On Thursday, 28 July 2022 13:54:48 PDT Thiago Macieira wrote: > [resent with my subscribed address, which means it won't arrive in > kde-devel] [cross-posting to Qt dev ML - dunno if it'll arrive because I'm > subscribed with different addresses] Link to thread in kde-deve

Re: [Development] Proposing to add (CPU) architecture maintainers

2022-08-03 Thread Thiago Macieira
I don't think we can hope to expect any kind of performance improvements. And since we don't have them in the CI at all, we can't even confirm they still build. I think they will go to the "we'll accept patches" bin, as

Re: [Development] Proposing to add (CPU) architecture maintainers

2022-08-03 Thread Thiago Macieira
nd S/390, for some reason... Like I said in my email, we don't have the resources or knowledge to fix architectural-specific issues in those platforms, much less apply performance improvements. But we will accept patches in case we break anything. -- Thiago Macieira - thiago.macieira (AT) intel.

[Development] moc change to use C++ constructs

2022-08-04 Thread Thiago Macieira
lized That's because the libstdc++ / libbfd implementation of the C++ demangler is limited to 2048 characters of input. This is harmless and you can ignore it. It doesn't affect LLVM either. -- Thiago Macieira - thiago.macieira (AT) intel.com Cloud Software Architect

<    1   2   3   4   5   6   7   8   9   10   >