> -Original Message-
> From: Development On Behalf Of
> Hasselmann Mathias via Development
> Subject: Re: [Development] Support for *Notes and UpstreamFiles fields in
> qt_attributions.json files
>
> Hi,
>
> Just to make ensure all options are considered: How about the elephant in the
>
Hi,
Just to make ensure all options are considered: How about the elephant
in the room?
How about "simply" implementing JSONC (JSON with Comments) in Qt's JSON
parser instead?
* People wonder regularly when they learnm that there are no comments in
JSON.
* JSONC is used by popular software
Kai Köhne (15 February 2023 08:50) replied:
>>> Well, you can also achieve this by duplicating comment fields:
>>>
>>> {
>>> "Comment": "Upstream files are src/x.cpp, include/y.h",
>>> "Files": [ "x.cpp", "y_p.h"]
>>> "Comment": "Copyright info is from dist/COPYING",
>>> "Copyright":
QML supports comments, but not multi-line string literals. You can concatenate
them, though.
Sure it does. You can use ECMAScript template strings:
property string longthing: `a multi
line string`
(In fact you can also just sprinkle line breaks into your regular
On Wednesday, 15 February 2023 02:15:02 PST Ulf Hermann via Development wrote:
> Or QML, in fact:
QML supports comments, but not multi-line string literals. You can concatenate
them, though.
> That would be all nicely human-readable and easily verified with
> qmllint.
Which you also get with
On Tuesday, 14 February 2023 23:35:57 PST Kai Köhne via Development wrote:
> I'd be open to all kinds of formats if we'd start on a green field. But
> we're not, and I don't think reimplementing qtattributionsscanner + redo
> the build system integration + convert all existing
>
> -Original Message-
> From: Edward Welbourne
> Sent: Wednesday, February 15, 2023 10:45 AM
> To: Kai Köhne
> Cc: Development@qt-project.org
> Subject: Re: Support for *Notes and UpstreamFiles fields in
> qt_attributions.json
> files
>
> Kai Köhne (15 February 2023 08:50) replied:
> >
So I finally found time to look at the JSON specification [0] and find
that (in section 6) it says, of the name/value pairs in an object:
The JSON syntax does not impose any restrictions on
the strings used as names, does not require that name strings be unique,
[0] PDF linked from ECMA 404,
Or QML, in fact:
// Attribution.qml in QtAttribution module:
QtObject {
property string name
property list files
property list upstreamFiles
//
}
// Actual attribution.qml in source tree:
import QtAttribution
Attribution {
// allows comments as much as you like
Kai Köhne (15 February 2023 08:50) replied:
> did you intentionally sent this off-list?
oops - no, outlook's UI tricked me :-(
And, in fact, it just did it again, although I'm sure I hit Reply All this time.
Manually adding development to CC...
For the benefit of everyone else, my reply is
> -Original Message-
> From: Development On Behalf Of Ulf
> Hermann via Development
> Subject: Re: [Development] Support for *Notes and UpstreamFiles fields in
> qt_attributions.json files
>
> YAML is really quite terrible. If we're going to switch, let's choose
> something
> else.
>
>
YAML is really quite terrible. If we're going to switch, let's choose
something else.
Basically, YAML is extremely complex, ambiguous, and incompatible
between different versions. See for example
https://ruudvanasseldonk.com/2023/01/11/the-yaml-document-from-hell for
an in-depth explanation.
On Tuesday, 14 February 2023 07:07:00 PST Kai Köhne via Development wrote:
> First, let's agree that JSON sucks for the task at hand. It doesn't have any
> explicit support for comments, and no support for multi-line strings
> (though our implementation tolerates this).
How about switching to
Hi,
+1 to the approach suggested by Kai.
Having comments would be very helpful, but I do not think that we need a
separate comment field for each entry.
Best regards,
Ivan
From: Development on behalf of Kai Köhne
via Development
Sent: Tuesday, February 14,
Hi Eddy,
> -Original Message-
> From: Development On Behalf Of
> Edward Welbourne via Development
> Sent: Tuesday, February 14, 2023 3:14 PM
> To: Development@qt-project.org
> Subject: [Development] Support for *Notes and UpstreamFiles fields in
> qt_attributions.json files
>
> Hi all,
Hi all,
Having taken part in various third-party updates and felt a need to
leave notes for those who will do the same in future, I have run up
against JSON not having a comment format. To work round that, I propose
to allow some fields to be included in a qt_attribution.json file for
that
16 matches
Mail list logo
