Re: [PATCH v11 3/3] MIPS: dts: jz4780/ci20: Add NEMC, BCH and NAND device tree nodes

2016-01-06 Thread Brian Norris
On Mon, Jan 04, 2016 at 12:34:44PM +, Harvey Hunt wrote: > diff --git a/arch/mips/boot/dts/ingenic/ci20.dts > b/arch/mips/boot/dts/ingenic/ci20.dts > index 9fcb9e7..782258c 100644 > --- a/arch/mips/boot/dts/ingenic/ci20.dts > +++ b/arch/mips/boot/dts/ingenic/ci20.dts As I noted on patch 1, yo

Re: [PATCH v11 1/3] dt-bindings: binding for jz4780-{nand,bch}

2016-01-06 Thread Brian Norris
gt; Cc: Zubair Lutfullah Kakakhel > Cc: David Woodhouse > Cc: Brian Norris > Cc: linux-...@lists.infradead.org > Cc: devicetree@vger.kernel.org > Cc: linux-ker...@vger.kernel.org > Cc: r...@kernel.org > Signed-off-by: Harvey Hunt > Acked-by: Rob Herring > Reviewed-by: Bo

Re: [PATCH v5] mtd: support BB SRAM on ICP DAS LP-8x4x

2016-01-06 Thread Brian Norris
On Sun, Dec 20, 2015 at 01:43:58PM +0300, Sergei Ianovich wrote: > On Sat, 2015-12-19 at 21:38 -0600, Rob Herring wrote: > > On Tue, Dec 15, 2015 at 09:58:53PM +0300, Sergei Ianovich wrote: > > > +Required properties: > > > +- compatible : should be "icpdas,sram-lp8x4x" > > > > No wildcards please

Re: [RESEND PATCH] mtd: mtk-nor: adjust sequence of trigger function and assignment function

2015-12-18 Thread Brian Norris
On Fri, Dec 18, 2015 at 11:02:40AM +0800, Bayi Cheng wrote: > Move write data register before excute command to avoid > missing first byte write to nor flash > > Signed-off-by: Bayi Cheng > --- > the previous patch didn't drop the Change-Id Applied to l2-mtd.git -- To unsubscribe from this list:

Re: [PATCH v2 0/5] mtd: nand: Fix support for NAND DMA prefetch

2015-12-18 Thread Brian Norris
t'd be good if Roger can roll this into his series? Just throwing out ideas. If you want to wait on Roger's series, that's fine. FWIW, the MTD stuff all looks OK to me: Acked-by: Brian Norris > Franklin S Cooper Jr (5): > mtd: nand: omap2: Support parsing dma channel inform

Re: [PATCH linux-next 2/5] mtd: spi-nor: fix Quad SPI mode support for Spansion, Micron and Macronix

2015-12-17 Thread Brian Norris
On Mon, Dec 07, 2015 at 03:09:11PM +0100, Cyrille Pitchen wrote: > This patch reworks the support of Quad and Dual SPI protocols for Micron, > Spansion and Macronix Quad/Dual capable memories. Indeed, in the best > case, only Spansion memories are correctly supported by the current > spi-nor framew

Re: [PATCH linux-next 1/5] mtd: spi-nor: properly detect the memory when it boots in Quad or Dual mode

2015-12-17 Thread Brian Norris
(Hit send too early; a few more comments) On Mon, Dec 07, 2015 at 03:09:10PM +0100, Cyrille Pitchen wrote: > drivers/mtd/spi-nor/spi-nor.c | 52 > +++ > include/linux/mtd/spi-nor.h | 23 +-- > 2 files changed, 69 insertions(+), 6 deletion

Re: [PATCH linux-next 1/5] mtd: spi-nor: properly detect the memory when it boots in Quad or Dual mode

2015-12-17 Thread Brian Norris
Hi Cyrille, On Mon, Dec 07, 2015 at 03:09:10PM +0100, Cyrille Pitchen wrote: > The quad (or dual) mode of a spi-nor memory may be enabled at boot time by > non-volatile bits in some setting register. Also such a mode may have > already been enabled at early stage by some boot loader. > > Hence, w

Re: [PATCH linux-next 0/5] mtd: spi-nor: add driver for Atmel QSPI controller

2015-12-17 Thread Brian Norris
On Thu, Dec 17, 2015 at 04:29:01PM -0800, Brian Norris wrote: > On Tue, Dec 08, 2015 at 06:21:00AM +, Bean Huo 霍斌斌 wrote: > OK, so I think your patch is broken: > > > > commit 548cd3ab54da ("mtd: spi-nor: Add quad I/O support for Micron > > > SPI

Re: [PATCH linux-next 0/5] mtd: spi-nor: add driver for Atmel QSPI controller

2015-12-17 Thread Brian Norris
Hi Bean, On Tue, Dec 08, 2015 at 06:21:00AM +, Bean Huo 霍斌斌 wrote: > > -Original Message- > > From: Brian Norris [mailto:computersforpe...@gmail.com] > > > > I'll admit I'm a little fuzzy on the differences between dual and quad > > modes on

Re: [PATCH/RFC 0/7] ARM: dts: Add compatible property to "partitions" node

2015-12-14 Thread Brian Norris
+ real linux-mtd mailing list On Mon, Dec 14, 2015 at 1:43 PM, Brian Norris wrote: > On Mon, Dec 14, 2015 at 10:20:19PM +0100, Geert Uytterhoeven wrote: >> On Mon, Dec 14, 2015 at 8:46 PM, Brian Norris >> wrote: >> > On Mon, Dec 14, 2015 at 08:11:37PM +0100, Geert Uytt

Re: [PATCH/RFC 0/7] ARM: dts: Add compatible property to "partitions" node

2015-12-14 Thread Brian Norris
On Mon, Dec 14, 2015 at 10:20:19PM +0100, Geert Uytterhoeven wrote: > On Mon, Dec 14, 2015 at 8:46 PM, Brian Norris > wrote: > > On Mon, Dec 14, 2015 at 08:11:37PM +0100, Geert Uytterhoeven wrote: > >> As of commit e488ca9f8d4f62c2 ("doc: dt: mtd: partitions: add c

Re: [PATCH/RFC 0/7] ARM: dts: Add compatible property to "partitions" node

2015-12-14 Thread Brian Norris
st have a compatible property. The partitions are no > longer detected if it is not present. For all patches: Acked-by: Brian Norris > I marked this series as "RFC", as the abovementioned commit is not yet > upstream. Ideally, the users should be fixed first, to avoid br

Re: [PATCH for-4.4 2/2] doc: dt: mtd: partitions: add compatible property to "partitions" node

2015-12-14 Thread Brian Norris
On Mon, Dec 14, 2015 at 03:49:14PM +0100, Geert Uytterhoeven wrote: > On Wed, Dec 9, 2015 at 2:12 AM, Brian Norris > wrote: > > On Mon, Dec 07, 2015 at 09:58:35AM -0800, Brian Norris wrote: > >> On Sat, Dec 05, 2015 at 12:45:36PM +0100, Jonas Gorski wrote: > >> &g

Re: [RFC PATCH 0/7] mtd: partitions: add of_match_table support

2015-12-11 Thread Brian Norris
On Fri, Dec 11, 2015 at 09:44:37AM +0100, Geert Uytterhoeven wrote: > On Thu, Dec 10, 2015 at 9:54 PM, Brian Norris > wrote: > > IOW, I wouldn't expect MBR or GPT to work well on large raw NAND flash, > > and so I don't plan to do that sort of work myself. If you

Re: [RFC PATCH 0/7] mtd: partitions: add of_match_table support

2015-12-10 Thread Brian Norris
On Sat, Dec 05, 2015 at 12:35:42PM +0100, Jonas Gorski wrote: > On Sat, Dec 5, 2015 at 6:19 AM, Brian Norris > wrote: > > Hi, > > > > There have been several discussions [1] about adding a device tree binding > > for > > associating flash devices with the part

Re: [RFC PATCH 0/7] mtd: partitions: add of_match_table support

2015-12-10 Thread Brian Norris
On Sat, Dec 05, 2015 at 11:15:54AM +0100, Geert Uytterhoeven wrote: > On Sat, Dec 5, 2015 at 6:19 AM, Brian Norris > wrote: > > There have been several discussions [1] about adding a device tree binding > > for > > associating flash devices with the partition parser

Re: [RFC PATCH 3/7] doc: dt: mtd: partition: add on-flash format binding

2015-12-10 Thread Brian Norris
On Mon, Dec 07, 2015 at 12:36:28PM +1100, David Gibson wrote: > On Sat, Dec 05, 2015 at 10:33:30PM +0100, Michal Suchanek wrote: > > On 5 December 2015 at 12:39, Jonas Gorski wrote: > > > On Sat, Dec 5, 2015 at 6:19 AM, Brian Norris > > > wrote: >

Re: [PATCH linux-next (v2) 1/3] mtd: brcmnand: Add brcm,bcm6368-nand device tree binding

2015-12-09 Thread Brian Norris
On Wed, Dec 09, 2015 at 01:01:42PM -0800, Florian Fainelli wrote: > Le 09/12/2015 12:40, Simon Arlott a écrit : > > Add device tree binding for NAND on the BCM6368. > > > > The BCM6368 has a NAND interrupt register with combined status and enable > > registers. It also requires a clock, so add an

Re: [PATCH 1/3] mtd: brcmnand: Add brcm,bcm6368-nand device tree binding

2015-12-09 Thread Brian Norris
On Fri, Dec 04, 2015 at 09:29:55PM -, Simon Arlott wrote: > On Fri, December 4, 2015 16:04, Jonas Gorski wrote: > > On Thu, Dec 3, 2015 at 12:41 AM, Simon Arlott wrote: > >> + * "brcm,nand-bcm6368" > >> + - compatible: should contain "brcm,nand-bcm", > >> "brcm,nand-bcm6368" > >> +

Re: [PATCH for-4.4 2/2] doc: dt: mtd: partitions: add compatible property to "partitions" node

2015-12-08 Thread Brian Norris
On Mon, Dec 07, 2015 at 09:58:35AM -0800, Brian Norris wrote: > On Sat, Dec 05, 2015 at 12:45:36PM +0100, Jonas Gorski wrote: > > On Fri, Dec 4, 2015 at 3:02 AM, Brian Norris > > wrote: > > > // proposed > > > partitions { > > >

Re: [PATCH linux-next 0/5] mtd: spi-nor: add driver for Atmel QSPI controller

2015-12-07 Thread Brian Norris
+ Bean Huo Hi Cyrille, On Mon, Dec 07, 2015 at 03:09:09PM +0100, Cyrille Pitchen wrote: > Hi all, > > this series of patches adds support to the Atmel QSPI controller available > on sama5d2 SoCs. It was tested on a sama5d2 xplained ultra board with a > Micron n25q128a13 QSPI memory and a at25df

Re: [RFC PATCH 4/7] mtd: add of_match_mtd_parser() and of_mtd_match_mtd_parser() helpers

2015-12-07 Thread Brian Norris
On Sun, Dec 06, 2015 at 08:45:40PM -0600, Rob Herring wrote: > On Fri, Dec 4, 2015 at 11:19 PM, Brian Norris > wrote: > > drivers/of/of_mtd.c| 33 + > > BTW, this file should be moved to drivers/mtd/ at some point. How about s/at s

Re: [PATCH for-4.4 2/2] doc: dt: mtd: partitions: add compatible property to "partitions" node

2015-12-07 Thread Brian Norris
On Sat, Dec 05, 2015 at 12:45:36PM +0100, Jonas Gorski wrote: > On Fri, Dec 4, 2015 at 3:02 AM, Brian Norris > wrote: > > // proposed > > partitions { > > compatible = "partitions"; > > "partitions" sounds mode

[RFC PATCH 4/7] mtd: add of_match_mtd_parser() and of_mtd_match_mtd_parser() helpers

2015-12-04 Thread Brian Norris
Like the corresponding OF-based device/driver matching infrascture, let's begin to support a mtd/partition-parser matching infrastructure. Signed-off-by: Brian Norris --- drivers/of/of_mtd.c| 33 + include/linux/mtd/partitions.h | 2 ++ include/

[RFC PATCH 2/7] mtd: move partition parsers' Kconfig under a sub-menu

2015-12-04 Thread Brian Norris
For better organization. Signed-off-by: Brian Norris --- drivers/mtd/Kconfig| 134 + drivers/mtd/partitions/Kconfig | 131 2 files changed, 134 insertions(+), 131 deletions(-) create mode 100644

[RFC PATCH 1/7] mtd: move partition parsers to drivers/mtd/partitions/

2015-12-04 Thread Brian Norris
For better organization. Signed-off-by: Brian Norris --- drivers/mtd/Makefile | 8 +--- drivers/mtd/partitions/Makefile| 7 +++ drivers/mtd/{ => partitions}/afs.c | 0 drivers/mtd/{ => partitions}/ar7part.c | 0 drivers/mtd/{ => p

[RFC PATCH 5/7] mtd: partitions: factor out "match by name" handling

2015-12-04 Thread Brian Norris
This code structure is going to be imitated for a match-by-device-node implementation, so let's factor out a few functions to make this easier. Signed-off-by: Brian Norris --- drivers/mtd/mtdpart.c | 67 +++ 1 file changed, 52 insertions(+

[RFC PATCH 6/7] RFC: mtd: partitions: enable of_match_table matching

2015-12-04 Thread Brian Norris
I can report uevents? Signed-off-by: Brian Norris --- drivers/mtd/mtdpart.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c index b3100742ddf6..91eb2df0bf1e 100644 --- a/drivers/mtd/mtdpart.c +++ b/drivers/mtd/mtd

[RFC PATCH 7/7] mtd: partitions: add Google's FMAP partition parser

2015-12-04 Thread Brian Norris
Cc: David Hendricks Signed-off-by: Brian Norris --- drivers/mtd/partitions/Kconfig | 7 ++ drivers/mtd/partitions/Makefile | 1 + drivers/mtd/partitions/google_fmap.c | 226 +++ 3 files changed, 234 insertions(+) create mode 100644 drivers/mtd

[RFC PATCH 3/7] doc: dt: mtd: partition: add on-flash format binding

2015-12-04 Thread Brian Norris
/ and the AFS (ARM Flash Structure?) parser: http://patchwork.ozlabs.org/patch/537827/ Signed-off-by: Brian Norris --- .../devicetree/bindings/mtd/partition.txt | 75 -- 1 file changed, 69 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bind

[RFC PATCH 0/7] mtd: partitions: add of_match_table support

2015-12-04 Thread Brian Norris
ws. Regards, Brian [1] Trying to extend "linux,part-probe": http://patchwork.ozlabs.org/patch/475988/ For bcm47xxpart: http://patchwork.ozlabs.org/patch/475986/ For AFS: http://patchwork.ozlabs.org/patch/537827/ [2] "mtd: document linux-specific partition p

[PATCH for-4.4 1/2] mtd: ofpart: don't complain about missing 'partitions' node too loudly

2015-12-03 Thread Brian Norris
ot found on /spi@ff13/flash@0. Trying to parse direct subnodes as partitions. Cc: Michal Suchanek Signed-off-by: Brian Norris --- This one really seems like we should put it into 4.4. Basically everyone with a DT-enabled MTD using the default parsers will get this warning, even if they're not i

[PATCH for-4.4 2/2] doc: dt: mtd: partitions: add compatible property to "partitions" node

2015-12-03 Thread Brian Norris
/lists.infradead.org/pipermail/linux-mtd/2015-November/063364.html Cc: Michal Suchanek Signed-off-by: Brian Norris --- This one is more of a future proofing patch. We should probably take this for 4.4, before the binding "stabilizes" (I don't actually see any users yet), or else

Re: [PATCH v9 1/3] dt-bindings: binding for jz4780-{nand,bch}

2015-12-03 Thread Brian Norris
On Thu, Dec 03, 2015 at 03:38:12PM -0600, Rob Herring wrote: > On Thu, Dec 03, 2015 at 12:02:20PM +, Harvey Hunt wrote: > > v8 -> v9: > > - Document that partitions are represented as a child node of a NAND chip. > > Don't multiple flash chips typically get interleaved in order to get > para

Re: [PATCH v3 00/27] memory: omap-gpmc: mtd: nand: Support GPMC NAND on non-OMAP platforms

2015-12-02 Thread Brian Norris
Hi, On Thu, Dec 03, 2015 at 11:38:14AM +0530, Roger Quadros wrote: > On 03/12/15 10:39, Brian Norris wrote: > > On Fri, Sep 18, 2015 at 05:53:22PM +0300, Roger Quadros wrote: > >> We do a couple of things in this series which result in > >> cleaner device tree implem

Re: [PATCH v4 11/27] mtd: nand: omap: Clean up device tree support

2015-12-02 Thread Brian Norris
On Thu, Dec 03, 2015 at 11:27:13AM +0530, Roger Quadros wrote: > On 03/12/15 09:59, Brian Norris wrote: > > On Tue, Oct 06, 2015 at 01:35:48PM +0300, Roger Quadros wrote: > >> arch/arm/mach-omap2/gpmc-nand.c | 5 +- > >> drivers/memory/omap-gpm

Re: [PATCH v3 04/27] mtd: nand: omap2: Use gpmc_omap_get_nand_ops() to get NAND registers

2015-12-02 Thread Brian Norris
On Fri, Sep 18, 2015 at 05:53:26PM +0300, Roger Quadros wrote: > Deprecate nand register passing via platform data and use > gpmc_omap_get_nand_ops() instead. > > Signed-off-by: Roger Quadros > --- > arch/arm/mach-omap2/gpmc-nand.c | 2 -- > drivers/mtd/nand/omap2.c

Re: [PATCH v3 00/27] memory: omap-gpmc: mtd: nand: Support GPMC NAND on non-OMAP platforms

2015-12-02 Thread Brian Norris
Hi, On Fri, Sep 18, 2015 at 05:53:22PM +0300, Roger Quadros wrote: > Hi, > > We do a couple of things in this series which result in > cleaner device tree implementation, faster perfomance and > multi-platform support. As an added bonus we get new GPI/Interrupt pins > for use in the system. > >

Re: [PATCH v3 18/27] mtd: nand: omap2: Implement NAND ready using gpiolib

2015-12-02 Thread Brian Norris
(to be clear, this branch of discussion isn't directly regarding the TI changes; we can handle any generic handling afterward, as long as we get the DT binding right now) On Tue, Oct 27, 2015 at 09:28:32AM +0100, Boris Brezillon wrote: > On Mon, 26 Oct 2015 13:49:00 -0700 > Brian No

Re: [PATCH v4 11/27] mtd: nand: omap: Clean up device tree support

2015-12-02 Thread Brian Norris
Hi Roger, On Tue, Oct 06, 2015 at 01:35:48PM +0300, Roger Quadros wrote: > Move NAND specific device tree parsing to NAND driver. > > The NAND controller node must have a compatible id, register space > resource and interrupt resource. > > Signed-off-by: Roger Quadros This one's going to need

Re: [PATCH 2/3] mtd: brcmnand: Request and enable the clock if present

2015-12-02 Thread Brian Norris
Hi Simon, On Wed, Dec 02, 2015 at 11:42:44PM +, Simon Arlott wrote: > Attempt to enable a clock named "nand" as some SoCs have a clock for the > controller that needs to be enabled. > > Signed-off-by: Simon Arlott > --- > drivers/mtd/nand/brcmnand/brcmnand.c | 69 >

Re: [PATCH (v6) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand device tree binding

2015-12-02 Thread Brian Norris
On Wed, Dec 02, 2015 at 08:34:38PM +, Simon Arlott wrote: > On 02/12/15 20:21, Brian Norris wrote: > > On Wed, Dec 02, 2015 at 08:12:32PM +, Simon Arlott wrote: > >> On 02/12/15 20:00, Brian Norris wrote: > >> > On Wed, Dec 02, 2015 at 07:41:07PM +, Si

Re: [PATCH (v6) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand device tree binding

2015-12-02 Thread Brian Norris
On Wed, Dec 02, 2015 at 12:21:27PM -0800, Brian Norris wrote: > On Wed, Dec 02, 2015 at 08:12:32PM +, Simon Arlott wrote: > > Is there a patch for that method of parser detection available? > > I have something working here, but I haven't had time to finish cleaning >

Re: [PATCH (v6) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand device tree binding

2015-12-02 Thread Brian Norris
Hi Simon, On Wed, Dec 02, 2015 at 08:12:32PM +, Simon Arlott wrote: > On 02/12/15 20:00, Brian Norris wrote: > > On Wed, Dec 02, 2015 at 07:41:07PM +, Simon Arlott wrote: > >> I've created a bcm963268part driver so there won't need to be any > &

Re: [PATCH (v7) 2/2] mtd: brcmnand: Add support for the BCM63268

2015-12-02 Thread Brian Norris
Hi, On Wed, Dec 02, 2015 at 07:54:49PM +, Simon Arlott wrote: > On 02/12/15 19:18, Brian Norris wrote: > > On Wed, Nov 25, 2015 at 07:49:13PM +, Simon Arlott wrote: > >> +static int bcm63268_nand_probe(struct platform_device *pdev) > >> +{ > >>

Re: [PATCH (v6) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand device tree binding

2015-12-02 Thread Brian Norris
Hi, On Wed, Dec 02, 2015 at 07:41:07PM +, Simon Arlott wrote: > >> + nand0: nandcs@0 { > >> + compatible = "brcm,nandcs"; > >> + reg = <0>; > >> + nand-on-flash-bbt; > >> + nand-ecc-strength = <1>; > >> + nand-ecc-step-size = <512>; > >> + > >> +

Re: [PATCH (v7) 2/2] mtd: brcmnand: Add support for the BCM63268

2015-12-02 Thread Brian Norris
+ Broadcom list + Kamal Hi Simon, On Wed, Nov 25, 2015 at 07:49:13PM +, Simon Arlott wrote: > The BCM63268 has a NAND interrupt register with combined status and enable > registers. It also has a clock for the NAND controller that needs to be > enabled. > > Set up the device by enabling the

Re: [PATCH (v6) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand device tree binding

2015-12-02 Thread Brian Norris
+ Broadcom list + Kamal On Tue, Nov 24, 2015 at 08:19:37PM -, Simon Arlott wrote: > Add device tree binding for NAND on the BCM63268. > > The BCM63268 has a NAND interrupt register with combined status and enable > registers. > > Signed-off-by: Simon Arlott > --- > .../devicetree/bindings/

Re: [PATCH v3 00/27] memory: omap-gpmc: mtd: nand: Support GPMC NAND on non-OMAP platforms

2015-12-02 Thread Brian Norris
Hi Roger, On Wed, Dec 02, 2015 at 10:42:12AM +0530, Roger Quadros wrote: > On 02/12/15 08:56, Brian Norris wrote: > > On Tue, Dec 01, 2015 at 04:41:16PM +0200, Roger Quadros wrote: > >> On 30/11/15 21:54, Brian Norris wrote: > >>> But anyway, I'm not sure that

Re: [PATCH v3 00/27] memory: omap-gpmc: mtd: nand: Support GPMC NAND on non-OMAP platforms

2015-12-02 Thread Brian Norris
On Wed, Dec 02, 2015 at 07:03:17AM -0800, Tony Lindgren wrote: > * Roger Quadros [151201 21:13]: > > On 02/12/15 08:56, Brian Norris wrote: > > > > > > I'll take another pass over your patch set, but if things are looking > > > better, how do you ex

Re: [PATCH v3 00/27] memory: omap-gpmc: mtd: nand: Support GPMC NAND on non-OMAP platforms

2015-12-01 Thread Brian Norris
Hi Roger, On Tue, Dec 01, 2015 at 04:41:16PM +0200, Roger Quadros wrote: > On 30/11/15 21:54, Brian Norris wrote: > > On Tue, Oct 27, 2015 at 11:37:03AM +0200, Roger Quadros wrote: > >> On 26/10/15 23:23, Brian Norris wrote: > >>> On Fri, Sep 18, 2015 at 05:53:2

Re: [PATCH v3 00/27] memory: omap-gpmc: mtd: nand: Support GPMC NAND on non-OMAP platforms

2015-11-30 Thread Brian Norris
Hi Roger, On Tue, Oct 27, 2015 at 11:37:03AM +0200, Roger Quadros wrote: > On 26/10/15 23:23, Brian Norris wrote: > > I'm not too familiar with OMAP platforms, and I might have missed out on > > prior discussions/context, so please forgive if I'm asking silly or old &g

Re: [PATCH v8 1/2] mtd: mtk-nor: mtk serial flash controller driver

2015-11-20 Thread Brian Norris
On Wed, Nov 18, 2015 at 11:30:02AM +0800, Bayi Cheng wrote: > add spi nor flash driver for mediatek controller > > Signed-off-by: Bayi Cheng > --- > drivers/mtd/spi-nor/Kconfig | 7 + > drivers/mtd/spi-nor/Makefile | 1 + > drivers/mtd/spi-nor/mtk-quadspi.c | 486 > ++

Re: [PATCH v1 3/7] mtd: fsl-quadspi: Support both 24- and 32-bit addressed commands.

2015-11-20 Thread Brian Norris
Cory and Han, Did this series get dropped on the floor? I recall Han arguing previously that this controller is always used with two identical chips. But apparently that is not the case. If this request is not truly dead, I'd appreciate it if Han could review/test. Brian On Wed, Jul 08, 2015 at

Re: [PATCH 0/3] mtd: m25p80: fix some module and documentation issues

2015-11-19 Thread Brian Norris
On Mon, Nov 16, 2015 at 02:34:49PM -0800, Brian Norris wrote: > Hi, > > There were a few mistakes and improvements pointed out at various points in > this thread, subject: > > spi: OF module autoloading is still broken > (was: Re: m25p80: Commit "allow arbitr

Re: [PATCH 3/3] doc: dt: mtd: stop referring to driver code for spi-nor IDs

2015-11-18 Thread Brian Norris
Hi, On Tue, Nov 17, 2015 at 11:04:55AM -0300, Javier Martinez Canillas wrote: > On 11/16/2015 07:34 PM, Brian Norris wrote: > > diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt > > b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt > > index 2bee6

device_node lifetime (was: Re: [PATCH 1/7] phy: brcmstb-sata: add missing of_node_put)

2015-11-18 Thread Brian Norris
(changing subject, add devicetree@vger.kernel.org) On Tue, Nov 17, 2015 at 11:33:25PM +0100, Julia Lawall wrote: > On Tue, 17 Nov 2015, Brian Norris wrote: > > On Tue, Nov 17, 2015 at 06:48:39PM +0100, Julia Lawall wrote: > > > Is this something that should be checked for els

Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

2015-11-17 Thread Brian Norris
Hi, On Tue, Nov 17, 2015 at 12:02:29PM +0530, Vignesh R wrote: > On 11/13/2015 09:35 PM, Cyrille Pitchen wrote: > > > > In September I've sent a series of patches to enhance the support of QSPI > > flash > > memories. Patch 4 was dedicated to the m25p80 driver and set the > > rx_nbits / tx_nbits

Re: [v4 00/10] add support SATA for BMIPS_GENERIC

2015-11-16 Thread Brian Norris
ags > > Changes in v2: > - adds quirk for ncq > - adds quirk for phy interface control > - remove unused definitions in ahci_brcmstb > - combines compatible string For the drivers portions (including patch 2, if you fix the error I pointed out): Acked-by: Brian Norris -- To unsubscr

Re: [v4 02/10] ata: ahci_brcmstb: add quirk for broken ncq

2015-11-16 Thread Brian Norris
Hi, On Fri, Oct 30, 2015 at 11:01:16PM +0900, Jaedon Shin wrote: > Add quirk for broken ncq. Some chipsets (eg. BCM7349A0, BCM7445A0, > BCM7445B0, and all 40nm chipsets including BCM7425) need a workaround > disabling NCQ. > > Signed-off-by: Jaedon Shin > --- > drivers/ata/ahci_brcmstb.c | 46

[PATCH 3/3] doc: dt: mtd: stop referring to driver code for spi-nor IDs

2015-11-16 Thread Brian Norris
scribe hardware, not software. Signed-off-by: Brian Norris Cc: --- .../devicetree/bindings/mtd/jedec,spi-nor.txt | 56 -- 1 file changed, 51 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.txt b/Documentation/devicetree/bin

[PATCH 0/3] mtd: m25p80: fix some module and documentation issues

2015-11-16 Thread Brian Norris
/lists.infradead.org/pipermail/linux-mtd/2015-October/062369.html https://lkml.org/lkml/2015/11/12/574 That thread covers some other interesting issues that are still not solved, but let's fix the ones we can here in MTD right now. Regards, Brian Brian Norris (3): mtd: m25p80: fix module a

Re: [PATCH 1/3] mtd: create a partition type device tree binding

2015-11-15 Thread Brian Norris
On Sat, Nov 14, 2015 at 11:46:59AM +0100, Linus Walleij wrote: > On Fri, Nov 13, 2015 at 11:00 PM, Brian Norris > wrote: > > (...) > > (2) we should define a comptible property for the hard-coded > > partitioning case (e.g., compatible = "partitions") >

Re: [PATCH 1/3] mtd: create a partition type device tree binding

2015-11-13 Thread Brian Norris
On Fri, Nov 06, 2015 at 08:13:13AM -0600, Rob Herring wrote: > Since we now have partitions contained in a sub node, how about using > compatible for that sub node instead. I see that Linus and I spoke up in agreement on this one. I took a little look at adding of_match_table support to the core

Re: [PATCH v6 1/3] doc: dt: add documentation for Mediatek spi-nor controller

2015-11-13 Thread Brian Norris
On Fri, Nov 13, 2015 at 03:20:45PM +0800, Bayi Cheng wrote: > On Wed, 2015-11-11 at 12:38 -0800, Brian Norris wrote: > > Applied to l2-mtd.git/next (for 4.5). This will show up in > > linux-next.git after the merge window. > > > > Also squashed in a small diff (belo

Re: [PATCH] mtd: grab a reference to the MTD of_node before registering it

2015-11-12 Thread Brian Norris
On Thu, Nov 12, 2015 at 09:51:20AM +0100, Boris Brezillon wrote: > On Wed, 11 Nov 2015 16:26:04 -0800 > Brian Norris wrote: > > > We now stick the device node representing the current MTD (if any) into > > sysfs, so let's make sure we have a reference to it before doin

[PATCH v2] mtd: assign mtd->dev.of_node when creating partition devices

2015-11-11 Thread Brian Norris
From: Boris BREZILLON MTD partitions may have been created from a DT definition, and in this case the ->of_node of the struct device embedded in mtd_info should point to the DT node that was used to create the partition. Signed-off-by: Boris Brezillon Signed-off-by: Brian Norris --- v2: d

[PATCH] mtd: grab a reference to the MTD of_node before registering it

2015-11-11 Thread Brian Norris
We now stick the device node representing the current MTD (if any) into sysfs, so let's make sure we have a reference to it before doing that. Suggested-by: Boris Brezillon Signed-off-by: Brian Norris --- drivers/mtd/mtdcore.c | 4 1 file changed, 4 insertions(+) diff --git a/driver

Re: [PATCH v6 2/3] mtd: mtk-nor: mtk serial flash controller driver

2015-11-11 Thread Brian Norris
One more small comment, since you're respinning this: On Fri, Nov 06, 2015 at 11:48:08PM +0800, Bayi Cheng wrote: > diff --git a/drivers/mtd/spi-nor/mtk-quadspi.c > b/drivers/mtd/spi-nor/mtk-quadspi.c > new file mode 100644 > index 000..6582811 > --- /dev/null > +++ b/drivers/mtd/spi-nor/mtk-

Re: [PATCH v6 3/3] arm64: dts: mt8173: Add nor flash node

2015-11-11 Thread Brian Norris
On Fri, Nov 06, 2015 at 11:48:09PM +0800, Bayi Cheng wrote: > Add Mediatek nor flash node > > Signed-off-by: Bayi Cheng Acked-by: Brian Norris > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 16 > 1 file changed, 16 insertions(+) > > diff --g

Re: [PATCH v6 1/3] doc: dt: add documentation for Mediatek spi-nor controller

2015-11-11 Thread Brian Norris
On Fri, Nov 06, 2015 at 11:48:07PM +0800, Bayi Cheng wrote: > Add device tree binding documentation for serial flash with > Mediatek serial flash controller > > Signed-off-by: Bayi Cheng > --- Applied to l2-mtd.git/next (for 4.5). This will show up in linux-next.git after the merge window. Also

Re: [PATCH v6 0/3] Mediatek SPI-NOR flash driver

2015-11-11 Thread Brian Norris
On Wed, Nov 11, 2015 at 10:04:14PM +0800, Bayi Cheng wrote: > On Mon, 2015-11-09 at 18:46 -0800, Brian Norris wrote: > > I believe you didn't completely answer all my questions from v5 though. > > I'll repeat a bit here. Particularly, refer to [1]. > > I'll summ

Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

2015-11-11 Thread Brian Norris
In addition to my other comments: On Tue, Nov 10, 2015 at 10:59:55AM +0530, Vignesh R wrote: > In addition to providing direct access to SPI bus, some spi controller > hardwares (like ti-qspi) provide special memory mapped port > to accesses SPI flash devices in order to increase read performance.

Re: [PATCH] mtd: spi-nor: fsl-quadspi: add big-endian support

2015-11-11 Thread Brian Norris
+ devicetree On Wed, Nov 11, 2015 at 11:51:13AM -0600, Han Xu wrote: > On Fri, Oct 30, 2015 at 04:49:41AM -0500, Yuan Yao-B46683 wrote: (BTW Yuan, replying on top doesn't make the conversation as easy to follow) > > Although it is possible to add the endianness support in the > > regmap_mmio dri

Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

2015-11-10 Thread Brian Norris
Hi, On Wed, Nov 11, 2015 at 12:20:46PM +0530, R, Vignesh wrote: > On 11/11/2015 4:53 AM, Brian Norris wrote: > > On Tue, Nov 10, 2015 at 10:59:55AM +0530, Vignesh R wrote: > >> diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h > >> index cce80e6dc7d1..2f2c4

Re: [PATCH v3 1/5] spi: introduce mmap read support for spi flash devices

2015-11-10 Thread Brian Norris
Hi Vignesh, Sorry for the late review. I did not have time to review much back when you submitted your first RFCs for this. On Tue, Nov 10, 2015 at 10:59:55AM +0530, Vignesh R wrote: > diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h > index cce80e6dc7d1..2f2c431b8917 100644 > --- a

Re: [PATCH v4] mtd: ofpart: document the lock flag.

2015-11-10 Thread Brian Norris
On Fri, Oct 30, 2015 at 01:34:00PM -0700, Brian Norris wrote: > From: Michal Suchanek > > The lock flag of ofpart is undocumented. Add to binding doc. > > Signed-off-by: Michal Suchanek > Signed-off-by: Brian Norris > Cc: Sascha Hauer Pushed to l2-mtd.git -- To unsub

Re: [PATCH 1/3] mtd: create a partition type device tree binding

2015-11-09 Thread Brian Norris
On Fri, Nov 06, 2015 at 08:13:13AM -0600, Rob Herring wrote: > Since we now have partitions contained in a sub node, how about using > compatible for that sub node instead. That seems like a pretty good idea to me. Brian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in

Re: [PATCH v6 2/3] mtd: mtk-nor: mtk serial flash controller driver

2015-11-09 Thread Brian Norris
Hi Bayi, A few small comments. On Fri, Nov 06, 2015 at 11:48:08PM +0800, Bayi Cheng wrote: > add spi nor flash driver for mediatek controller > > Signed-off-by: Bayi Cheng > --- > drivers/mtd/spi-nor/Kconfig | 7 + > drivers/mtd/spi-nor/Makefile | 1 + > drivers/mtd/spi-nor/mtk-

Re: [PATCH v6 0/3] Mediatek SPI-NOR flash driver

2015-11-09 Thread Brian Norris
Hi Bayi, On Fri, Nov 06, 2015 at 11:48:06PM +0800, Bayi Cheng wrote: > This series is based on v4.3-rc1 and l2-mtd.git [0] and erase_sector > implementation patch [1] > > [0]: git://git.infradead.org/l2-mtd.git > [1]: http://lists.infradead.org/pipermail/linux-mtd/2015-October//062959.html > > C

Re: [PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY

2015-11-05 Thread Brian Norris
Hi, A few updates: On Tue, Nov 03, 2015 at 05:13:48PM -0800, Brian Norris wrote: > On Wed, Nov 04, 2015 at 08:48:38AM +0800, Yakir Yang wrote: > > On 11/03/2015 12:38 PM, Brian Norris wrote: > > >On Thu, Oct 29, 2015 at 09:58:38AM +0800, Yakir Yang wrote: > > >

Re: [PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY

2015-11-03 Thread Brian Norris
Hi Yakir, On Wed, Nov 04, 2015 at 08:48:38AM +0800, Yakir Yang wrote: > On 11/03/2015 12:38 PM, Brian Norris wrote: > >On Thu, Oct 29, 2015 at 09:58:38AM +0800, Yakir Yang wrote: > >(FYI, I came across this by inspection when comparing Heiko's > >'somewhat-stable&#x

Re: [PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY

2015-11-02 Thread Brian Norris
Hi Yakir, On Thu, Oct 29, 2015 at 09:58:38AM +0800, Yakir Yang wrote: > Add phy driver for the Rockchip DisplayPort PHY module. This > is required to get DisplayPort working in Rockchip SoCs. > > Reviewed-by: Heiko Stuebner > Signed-off-by: Yakir Yang > --- ... > diff --git a/drivers/phy/phy-ro

Re: [PATCH v4] doc: dt: mtd: support partitions in a special 'partitions' subnode

2015-10-30 Thread Brian Norris
On Wed, Oct 28, 2015 at 03:48:06PM -0700, Brian Norris wrote: > From: Michal Suchanek > > To avoid conflict with other drivers using subnodes of the mtd device > create only one ofpart-specific node rather than any number of > arbitrary partition subnodes. > > Signed-of

Re: [PATCH v3 5/5] mtd: ofpart: move ofpart partitions to a dedicated dt node

2015-10-30 Thread Brian Norris
On Tue, Aug 18, 2015 at 03:34:09PM -, Michal Suchanek wrote: > Parsing direct subnodes of a mtd device as partitions is unreliable > since the mtd device is also part of its bus subsystem and can contain > bus data in subnodes. > > Move ofpart data to a subnode of its own so it is clear which

[PATCH v4] mtd: ofpart: document the lock flag.

2015-10-30 Thread Brian Norris
From: Michal Suchanek The lock flag of ofpart is undocumented. Add to binding doc. Signed-off-by: Michal Suchanek Signed-off-by: Brian Norris Cc: Sascha Hauer --- It seems my reasoning here [1] was wrong (thanks Sascha!). This is a rewrite of Michal's binding doc from [2]. Note that

Re: [PATCH v5 2/3] mtd: brcmnand: Force 8bit mode before doing nand_scan_ident()

2015-10-30 Thread Brian Norris
t have to drop the upper 8 bits. That's what these two commits did for read ID and parameter page read commands: commit 3dad2344e92c6e1aeae42df1c4824f307c51bcc7 Author: Brian Norris Date: Wed Jan 29 14:08:12 2014 -0800 mtd: nand: force NAND_CMD_READID

Re: [PATCH v5 0/3] NAND support for Broadcom NS2 SoC

2015-10-30 Thread Brian Norris
On Fri, Oct 30, 2015 at 12:29:18PM +0530, Anup Patel wrote: > We enable NAND support for Broadcom NS2 SoC by reusing existing > BRCMNAND driver. > > This patchset applies on-top of "arm64: Simple additions to > NS2 DT" v1 patchset and is available in ns2_nand_v5 branch of > https://github.com/Broa

Re: [PATCH v3 2/2] arm64: dts: Add BRCM IPROC NAND DT node for NS2

2015-10-30 Thread Brian Norris
On Wed, Oct 28, 2015 at 09:08:02AM -0700, Ray Jui wrote: > On 10/28/2015 2:06 AM, Anup Patel wrote: > > > >I think for a newly created OF devices the Linux device driver framework will > >match the platform drivers in the order in which they are registered by > >module > >init functions. Now the o

Re: [PATCH v5 2/3] mtd: mtk-nor: mtk serial flash controller driver

2015-10-30 Thread Brian Norris
Hi Bayi, In reviewing your updated instructions on how to read 6 bytes of ID, I have one more question about how the PRGDATA and SHREG registers are supposed to work. On Mon, Oct 26, 2015 at 09:40:38PM +0800, Bayi Cheng wrote: [...] > +static void mt8173_nor_set_read_mode(struct mt8173_nor *mt817

Re: [PATCH 1/3] mtd: create a partition type device tree binding

2015-10-30 Thread Brian Norris
On Fri, Oct 30, 2015 at 03:00:57PM +0100, Linus Walleij wrote: > On Thu, Oct 29, 2015 at 5:29 PM, Brian Norris > wrote: > > >> +Required properties: > >> +- partition-type : the type of partition. Only one type can be specified. > > > > You're su

Re: [PATCH v4 2/3] mtd: mtk-nor: mtk serial flash controller driver

2015-10-29 Thread Brian Norris
Hi Bayi, On Fri, Oct 30, 2015 at 10:12:39AM +0800, bayi.cheng wrote: > Hi Brian, The current station is as follows. > > 1: put 0x9F to MTK_NOR_PRGDATA5_REG, and five 0x0 to > MTK_NOR_PRGDATA4_REG ~ MTK_NOR_PRGDATA0_REG, then set (1 + 5) * 8 > to MTK_NOR_CNT_REG, for this way, we can read five I

Re: [PATCH v5 2/3] mtd: mtk-nor: mtk serial flash controller driver

2015-10-29 Thread Brian Norris
Hi Bayi, (I drafted most of this before you clarified on how to read out 6 bytes of ID. So a bit of this is slightly out-of-date. Still, I think most of the comments and much of the appended patch should be useful to you.) On Mon, Oct 26, 2015 at 09:40:38PM +0800, Bayi Cheng wrote: > add spi nor

Re: [PATCH 1/3] mtd: create a partition type device tree binding

2015-10-29 Thread Brian Norris
+ devicetree-spec and others, since other non-driver-specific MTD partitioning stuff has gotten directed there [1], and this binding should probably get promoted in short order to the core mtdpart.c partitioning On Thu, Oct 29, 2015 at 01:52:30PM +0100, Linus Walleij wrote: > The Linux code in dri

Re: [PATCH v4 2/3] mtd: mtk-nor: mtk serial flash controller driver

2015-10-29 Thread Brian Norris
On Thu, Oct 29, 2015 at 09:56:31PM +0800, bayi.cheng wrote: > On Thu, 2015-10-29 at 11:28 +0800, bayi.cheng wrote: > > On Wed, 2015-10-28 at 18:52 -0700, Brian Norris wrote: > > > On Sun, Oct 18, 2015 at 10:20:35PM +0800, bayi.cheng wrote: > > > > On Fri, 2015-10-1

Re: [PATCH v4 2/3] mtd: mtk-nor: mtk serial flash controller driver

2015-10-28 Thread Brian Norris
Hi Bayi, I'm looking over your v5, and I still have a lot of comments. I'll send those soon. But I still question one of your responses here: On Sun, Oct 18, 2015 at 10:20:35PM +0800, bayi.cheng wrote: > On Fri, 2015-10-16 at 00:39 -0700, Brian Norris wrote: > > On Tue, Oc

Re: [PATCH v4] doc: dt: mtd: support partitions in a special 'partitions' subnode

2015-10-28 Thread Brian Norris
On Wed, Oct 28, 2015 at 03:48:06PM -0700, Brian Norris wrote: > From: Michal Suchanek > > To avoid conflict with other drivers using subnodes of the mtd device > create only one ofpart-specific node rather than any number of > arbitrary partition subnodes. > > Signed-of

[PATCH v4] doc: dt: mtd: support partitions in a special 'partitions' subnode

2015-10-28 Thread Brian Norris
From: Michal Suchanek To avoid conflict with other drivers using subnodes of the mtd device create only one ofpart-specific node rather than any number of arbitrary partition subnodes. Signed-off-by: Michal Suchanek Acked-by: Rob Herring Signed-off-by: Brian Norris --- .../devicetree

Re: [PATCH v3 2/2] arm64: dts: Add BRCM IPROC NAND DT node for NS2

2015-10-27 Thread Brian Norris
On Tue, Oct 27, 2015 at 05:25:32PM -0700, Ray Jui wrote: > On 10/27/2015 5:19 PM, Brian Norris wrote: > >On Fri, Oct 23, 2015 at 10:46:13AM +0530, Anup Patel wrote: > >>diff --git a/arch/arm64/boot/dts/broadcom/ns2.dtsi > >>b/arch/arm64/boot/dts/broadcom/ns2.dtsi > &

  1   2   3   4   5   >