On Wed, 2015-12-09 at 14:03 +0200, Andy Shevchenko wrote:
> On Wed, Dec 9, 2015 at 2:03 AM, Joe Perches <j...@perches.com> wrote:
> > On Tue, 2015-12-08 at 15:28 -0600, Rob Herring wrote:
> > > On Tue, Dec 8, 2015 at 11:03 AM, Joe Perches <j...@perches.com> wrote:
&g
On Wed, 2015-12-09 at 22:02 +0200, Andy Shevchenko wrote:
> On Wed, Dec 9, 2015 at 9:28 PM, Joe Perches <j...@perches.com> wrote:
[]
> > > > diff --git a/lib/hexdump.c b/lib/hexdump.c
> > > > index 992457b..49113aa 100644
> > > > --- a/lib/hexdump.c
On Wed, 2015-12-09 at 22:36 +0200, Andy Shevchenko wrote:
[]
> wondering if _NATIVE is better?
I think CPU is better myself and it's already
in use like:
include/linux/iio/iio.h-enum iio_endian {
include/linux/iio/iio.h:IIO_CPU,
include/linux/iio/iio.h-IIO_BE,
On Wed, 2015-12-09 at 01:07 +0900, Masahiro Yamada wrote:
> Trivial changes suggested by checkpatch.pl.
[]
> diff --git a/drivers/of/address.c b/drivers/of/address.c
[]
> @@ -23,7 +23,7 @@ static int __of_address_to_resource(struct device_node *dev,
> #ifdef DEBUG
> static void
On Tue, 2015-12-08 at 08:16 -0800, Joe Perches wrote:
> On Wed, 2015-12-09 at 01:07 +0900, Masahiro Yamada wrote:
> > Trivial changes suggested by checkpatch.pl.
> []
> > diff --git a/drivers/of/address.c b/drivers/of/address.c
> []
> > @@ -23,7 +23,7 @@ static int __of
On Tue, 2015-12-08 at 15:28 -0600, Rob Herring wrote:
> On Tue, Dec 8, 2015 at 11:03 AM, Joe Perches <j...@perches.com> wrote:
> > On Tue, 2015-12-08 at 08:16 -0800, Joe Perches wrote:
> > > On Wed, 2015-12-09 at 01:07 +0900, Masahiro Yamada wrote:
> >
On Thu, 2015-09-03 at 13:33 +0800, Yakir Yang wrote:
[]
> diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c
[]
> @@ -155,24 +156,22 @@ static int exynos_dp_read_edid(struct
> exynos_dp_device *dp)
> }
> exynos_dp_read_byte_from_dpcd(dp,
On Mon, 2015-08-24 at 11:18 +0900, Masahiro Yamada wrote:
This commit adds support for UniPhier outer cache controller.
All the UniPhier SoCs are equipped with the L2 cache, while the L3
cache is currently only integrated on PH1-Pro5 SoC.
style trivia:
You might add and use
#define
On Thu, 2015-07-30 at 10:47 +0100, Peter Griffin wrote:
Hi Mauro / Joe,
On Wed, 22 Jul 2015, Mauro Carvalho Chehab wrote:
Em Wed, 24 Jun 2015 18:17:37 -0700
Joe Perches j...@perches.com escreveu:
On Wed, 2015-06-24 at 16:11 +0100, Peter Griffin wrote:
This is used
On Fri, 2015-07-10 at 10:44 +0100, Srinivas Kandagatla wrote:
This patch adds just providers part of the framework just to enable easy
review.
Trivial notes:
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
+struct nvmem_device {
+ const char *name;
+ struct
On Fri, 2015-07-10 at 10:44 +0100, Srinivas Kandagatla wrote:
This patch adds just consumers part of the framework just to enable easy
review.
Trivial notes:
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
@@ -334,6 +335,7 @@ struct nvmem_device *nvmem_register(struct nvmem_config
On Fri, 2015-07-10 at 10:45 +0100, Srinivas Kandagatla wrote:
This patch adds read/write apis which are based on nvmem_device.
More trivia:
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
+static struct nvmem_device *nvmem_find(const char *name)
+{
+ struct device *d;
+
+
On Wed, 2015-06-24 at 16:11 +0100, Peter Griffin wrote:
This is used in conjunction with the STV0367 demodulator on
the STV0367-NIM-V1.0 NIM card which can be used with the STi
STB SoC's.
Barely associated to this specific patch, but for
dvb-pll.c, another thing that seems possible is to
On Tue, 2015-06-23 at 00:08 +0100, Srinivas Kandagatla wrote:
This patch adds just providers part of the framework just to enable easy
review.
[]
include/linux/nvmem-provider.h | 54 ++
Unless there are going to be users of nvmem-provider.h
outside of the drivers/nvmem directory, perhaps
On Fri, 2015-06-05 at 09:49 -0700, Dmitry Torokhov wrote:
Hi Irina,
On Thu, May 28, 2015 at 03:47:37PM +0300, Irina Tirdea wrote:
Fix alignment to match open parenthesis detected by
running checkpatch.pl --strict.
Mixed bag of changes here, but that's checkpatch for you.
Yup,
On Thu, 2015-05-21 at 21:19 -0700, Kevin Tsai wrote:
- Renamed company name.
- Removed cm32181_reg.
- Removed white space.
- Removed unused include files.
- Updated macro definitions.
- Renamed cm32181_chip pointer to chip.
Hi Kevin,
Please don't use the same title for multiple patches.
(meh, bad mousing sent the first reply too soon)
It'd also be better if this series had a cover letter
so that could be replied to and added as a merge header
instead of having to ack/nack individual patches.
--
To unsubscribe from this list: send the line unsubscribe devicetree in
the body of a
On Mon, 2015-04-20 at 10:37 -0500, Dinh Nguyen wrote:
On Thu, Apr 16, 2015 at 5:54 PM, Rob Herring robherri...@gmail.com wrote:
+arm-soc
On Thu, Apr 16, 2015 at 5:49 PM, Joe Perches j...@perches.com wrote:
Change the .dts file permissions from 755 to 644.
Signed-off-by: Joe Perches j
Documention text files shouldn't be executable.
Signed-off-by: Joe Perches j...@perches.com
---
Documentation/devicetree/bindings/mfd/tps6507x.txt | 0
1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/tps6507x.txt
b/Documentation/devicetree
Change the .dts file permissions from 755 to 644.
Signed-off-by: Joe Perches j...@perches.com
---
arch/arm/boot/dts/socfpga_arria10_socdk.dts | 0
1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/socfpga_arria10_socdk.dts
b/arch/arm/boot/dts
On Fri, 2015-04-03 at 19:01 +0200, Maxime Coquelin wrote:
This drivers adds support to the STM32 USART controller, which is a
standard serial driver.
trivia:
diff --git a/drivers/tty/serial/stm32-usart.c
b/drivers/tty/serial/stm32-usart.c
[]
+static struct uart_ops stm32_uart_ops = {
On Wed, 2015-04-01 at 13:16 -0700, Andrew Bresticker wrote:
Add a driver for the USB2.0 PHY found on the IMG Pistachio SoC.
Spelling trivia:
diff --git a/drivers/phy/phy-pistachio-usb.c b/drivers/phy/phy-pistachio-usb.c
[]
+static int pistachio_usb_phy_power_on(struct phy *phy)
+{
[]
+
On Wed, 2015-04-01 at 12:58 +0900, Ingi Kim wrote:
This patch adds a driver to support the ktd2692 flash LEDs.
ktd2692 can control flash current by ExpressWire interface.
trivia:
diff --git a/drivers/leds/leds-ktd2692.c b/drivers/leds/leds-ktd2692.c
[]
+static void
On Tue, 2015-03-31 at 21:52 -0700, Grant Likely wrote:
Thinking about this more, I'd like to suggest a different format that
gives us a nice hack on the name that makes it easy to remember:
'%pOF[...]'
'O' still means 'object', but it is also overloaded for Open Firmware.
That still
On Tue, 2015-03-24 at 23:05 +, Srinivas Kandagatla wrote:
On 24/03/15 22:36, Mark Brown wrote:
+int regmap_get_max_register(struct regmap *map)
+{
+ return map-max_register ? : -EINVAL;
+}
Please write the logic out properly, don't abuse the ternery operator.
Am happy to change
On Mon, 2015-03-16 at 20:01 +0100, LABBE Corentin wrote:
[]
diff --git a/MAINTAINERS b/MAINTAINERS
[]
@@ -10923,6 +10923,12 @@ L: linux...@kvack.org
S: Maintained
F: mm/zswap.c
+ALLWINNER SECURITY SYSTEM
+M: Corentin Labbe clabbe.montj...@gmail.com
+L:
On Thu, 2015-03-12 at 10:45 -0700, Jonathan Richardson wrote:
Add initial version of the Broadcom touchscreen driver.
style trivia:
(any of which could be fixed/improved/ignored later)
diff --git a/drivers/input/touchscreen/bcm_iproc_tsc.c
b/drivers/input/touchscreen/bcm_iproc_tsc.c
[]
On Mon, 2015-02-09 at 16:07 -0800, Scott Branden wrote:
This adds a driver for random number generator present on Broadcom
IPROC devices.
trivia:
diff --git a/drivers/char/hw_random/iproc-rng200.c
b/drivers/char/hw_random/iproc-rng200.c
[]
+static int iproc_rng200_probe(struct
On Mon, 2015-01-26 at 11:11 +, Stathis Voukelatos wrote:
On 24/01/15 21:37, Joe Perches wrote:
On Fri, 2015-01-23 at 10:07 +, Stathis Voukelatos wrote:
This patch adds support the Ethernet Packet Sniffer H/W module
developed by Linn Products Ltd and found in the IMG Pistachio SoC
On Fri, 2015-01-23 at 10:07 +, Stathis Voukelatos wrote:
This patch adds support the Ethernet Packet Sniffer H/W module
developed by Linn Products Ltd and found in the IMG Pistachio SoC.
The module allows Ethernet packets to be parsed, matched against
a user-defined pattern and
On Wed, 2015-01-21 at 19:39 +0200, Pantelis Antoniou wrote:
Hi Joe,
On Jan 21, 2015, at 19:37 , Joe Perches j...@perches.com wrote:
On Wed, 2015-01-21 at 19:06 +0200, Pantelis Antoniou wrote:
90% of the usage of device node's full_name is printing it out
in a kernel message
On Wed, 2015-01-21 at 19:06 +0200, Pantelis Antoniou wrote:
90% of the usage of device node's full_name is printing it out
in a kernel message. Preparing for the eventual delayed allocation
introduce a custom printk format specifier that is both more
compact and more pleasant to the eye.
(adding netdev)
On Wed, 2015-01-21 at 09:44 +, Russell King - ARM Linux wrote:
On Wed, Jan 21, 2015 at 08:46:29AM +0100, Robert Jarzmik wrote:
Russell King - ARM Linux li...@arm.linux.org.uk writes:
What I'd suggest (and always have done) is:
dev_err(pdev-dev, couldn't
On Wed, 2015-01-21 at 16:11 +, Russell King - ARM Linux wrote:
On Wed, Jan 21, 2015 at 08:05:21AM -0800, Joe Perches wrote:
(adding netdev)
I wasn't actually reporting that as an issue; I was using it as an
example. It's from a very old kernel (2.6.27.21) which I run on one
of my old
On Tue, 2015-01-20 at 20:06 +0200, Pantelis Antoniou wrote:
On Jan 20, 2015, at 19:59 , Joe Perches j...@perches.com wrote:
On Tue, 2015-01-20 at 16:52 +0200, Pantelis Antoniou wrote:
On Jan 20, 2015, at 16:47 , Rob Herring robherri...@gmail.com wrote:
On Tue, Jan 20, 2015 at 8:34 AM
On Tue, 2015-01-20 at 16:52 +0200, Pantelis Antoniou wrote:
Hi Rob,
On Jan 20, 2015, at 16:47 , Rob Herring robherri...@gmail.com wrote:
On Tue, Jan 20, 2015 at 8:34 AM, Pantelis Antoniou
pantelis.anton...@konsulko.com wrote:
90% of the usage of device node's full_name is printing it
On Tue, 2015-01-20 at 13:01 +0100, Arnd Bergmann wrote:
On Tuesday 20 January 2015 10:15:05 Ding Tianhong wrote:
On 2015/1/20 4:34, Arnd Bergmann wrote:
On Monday 19 January 2015 19:11:11 Alexander Graf wrote:
After hammering on the box a bit again, I'm in a situation where I get
On Wed, 2015-01-14 at 14:34 +0800, Ding Tianhong wrote:
Support Hisilicon hip04 ethernet driver, including 100M / 1000M controller.
The controller has no tx done interrupt, reclaim xmitted buffer in the poll.
Mostly trivial comments:
+++ b/drivers/net/ethernet/hisilicon/hip04_eth.c
[]
On Thu, 2015-01-08 at 14:03 -0800, Stephen Wang wrote:
This driver adds support for the internal GMACs on IPQ806x SoCs.
It supports the device-tree and will register up to 4 ethernet
interfaces.
Trivial:
You might try running the code through checkpatch.
--
To unsubscribe from this list:
On Mon, 2015-01-05 at 12:51 +0200, Daniel Baluta wrote:
On Thu, Jan 1, 2015 at 2:10 AM, Kevin Tsai kt...@capellamicro.com wrote:
CM3232 is an advanced ambient light sensor with I2C protocol interface.
The I2C slave address is internally hardwired as 0x10 (7-bit). Writing
to configure
On Mon, 2015-01-05 at 16:20 +0200, Daniel Baluta wrote:
On Mon, Jan 5, 2015 at 3:09 PM, Joe Perches j...@perches.com wrote:
On Mon, 2015-01-05 at 12:51 +0200, Daniel Baluta wrote:
On Thu, Jan 1, 2015 at 2:10 AM, Kevin Tsai kt...@capellamicro.com wrote:
CM3232 is an advanced ambient light
On Mon, 2015-01-05 at 19:50 +0200, Daniel Baluta wrote:
On Mon, Jan 5, 2015 at 6:42 PM, Joe Perches j...@perches.com wrote:
On Mon, 2015-01-05 at 16:20 +0200, Daniel Baluta wrote:
On Mon, Jan 5, 2015 at 3:09 PM, Joe Perches j...@perches.com wrote:
On Mon, 2015-01-05 at 12:51 +0200, Daniel
On Wed, 2014-12-24 at 00:22 -0800, th...@altera.com wrote:
Adds a new driver for Altera soft GPIO IP. The driver is able to
do read/write and allows GPIO to be a interrupt controller.
Some trivial comments, some not quite so trivial.
diff --git a/drivers/gpio/gpio-altera.c
On Fri, 2014-12-19 at 14:17 -0800, Jonathan Richardson wrote:
Add initial version of the Broadcom touchscreen driver.
more trivia:
diff --git a/drivers/input/touchscreen/bcm_iproc_tsc.c
b/drivers/input/touchscreen/bcm_iproc_tsc.c
[]
+static int get_tsc_config(struct device_node *np, struct
On Wed, 2014-12-17 at 17:59 -0800, Jonathan Richardson wrote:
Add initial version of the Broadcom touchscreen driver.
trivia:
diff --git a/drivers/input/touchscreen/bcm_iproc_tsc.c
b/drivers/input/touchscreen/bcm_iproc_tsc.c
+/* Bit values for REGCTL2 */
+#define TS_CONTROLLER_EN_BIT
On Wed, 2014-12-10 at 20:41 -0500, David Miller wrote:
From: Murali Karicheri m-kariche...@ti.com
Are you referring to the static code analyser sparse that is invoked
through?
You have to explicitly enable endian checking, it's not on by
default.
There don't seem to be thousands of
On Thu, 2014-12-11 at 11:32 +0530, Kishon Vijay Abraham I wrote:
On Wednesday 10 December 2014 04:16 PM, Yunzhi Li wrote:
diff --git a/drivers/phy/phy-rockchip-usb.c b/drivers/phy/phy-rockchip-usb.c
[]
+/*
+ * The higher 16-bit of this register is used for write protection
+ * only if
On Thu, 2014-12-11 at 11:57 +0530, Kishon Vijay Abraham I wrote:
Hi,
On Thursday 11 December 2014 11:42 AM, Joe Perches wrote:
On Thu, 2014-12-11 at 11:32 +0530, Kishon Vijay Abraham I wrote:
On Wednesday 10 December 2014 04:16 PM, Yunzhi Li wrote:
diff --git a/drivers/phy/phy-rockchip
On Thu, 2014-12-11 at 14:52 +0800, Yunzhi Li wrote:
On 2014/12/11 14:37, Joe Perches wrote:
On Thu, 2014-12-11 at 11:57 +0530, Kishon Vijay Abraham I wrote:
[]
So If I have to write something on bit 0, I have to set bit 16.
If I have to write something on bit 1, I have to set bit 17.
If I
On Fri, 2014-12-05 at 16:40 -0800, Ray Jui wrote:
This GPIO driver supports all 3 GPIO controllers in the Broadcom Cygnus
SoC. The 3 GPIO controllers are 1) the ASIU GPIO controller
(brcm,cygnus-asiu-gpio), 2) the chipCommonG GPIO controller
(brcm,cygnus-ccm-gpio), and 3) the ALWAYS-ON GPIO
On Fri, 2014-12-05 at 18:14 -0800, Ray Jui wrote:
On 12/5/2014 5:28 PM, Joe Perches wrote:
On Fri, 2014-12-05 at 16:40 -0800, Ray Jui wrote:
+static void bcm_cygnus_gpio_irq_handler(unsigned int irq,
+ struct irq_desc *desc)
+{
+ struct bcm_cygnus_gpio *cygnus_gpio
On Fri, 2014-12-05 at 19:41 -0800, Ray Jui wrote:
On 12/5/2014 6:34 PM, Joe Perches wrote:
On Fri, 2014-12-05 at 18:14 -0800, Ray Jui wrote:
On 12/5/2014 5:28 PM, Joe Perches wrote:
On Fri, 2014-12-05 at 16:40 -0800, Ray Jui wrote:
+for_each_set_bit(bit, val, 32
On Fri, 2014-11-21 at 01:35 +, Grant Likely wrote:
The overlay code needs to construct a new full_name from the parent name
and the node name, but the current method has to allocate and then free
an temporary string which is wasteful. Fix this problem by using vargs
to pass in a format and
On Thu, 2014-11-13 at 02:18 +, Kuninori Morimoto wrote:
Still missing is an update for checkpatch to warn when a deprecated
vendor prefix is used.
Marking it deprecated and warning with checkpatch is certainly
preferable.
I guess removing ak line from vendor-prefixes.txt is
On Tue, 2014-10-21 at 02:28 +0300, Vladimir Zapolskiy wrote:
On 19.10.2014 17:16, LABBE Corentin wrote:
Add support for the Security System included in Allwinner SoC A20.
The Security System is a hardware cryptographic accelerator that support
AES/MD5/SHA1/DES/3DES/PRNG algorithms.
[]
On Thu, 2014-10-09 at 15:44 -0700, Scott Branden wrote:
Acked-by: Jonathan Richardson jonat...@broadcom.com
Signed-off-by: Scott Branden sbran...@broadcom.com
---
MAINTAINERS | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
On Thu, 2014-09-25 at 10:03 -0400, Santosh Shilimkar wrote:
From: Sandeep Nair sandee...@ti.com
The network coprocessor (NetCP) is a hardware accelerator that processes
Ethernet packets. NetCP has a gigabit Ethernet (GbE) subsystem with a ethernet
switch sub-module to send and receive
On Wed, 2014-09-10 at 09:15 +0200, Uwe Kleine-König wrote:
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
@@ -4941,6 +4941,7 @@ sub process {
mtrr_ops|
neigh_ops|
nlmsvc_binding|
+
or
warning messages that are inappropriate for DTS files.
Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be
Acked-by: Joe Perches j...@perches.com
---
scripts/checkpatch.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts
On Tue, 2014-07-01 at 18:46 +0100, Mark Rutland wrote:
On Tue, Jul 01, 2014 at 05:36:49PM +0100, Stefan Wahren wrote:
This patch adds the Ethernet over SPI driver for the
Qualcomm QCA7000 HomePlug GreenPHY.
[]
+ memcpy(qca-net_dev-dev_addr, mac, ETH_ALEN);
I believe that it
On Fri, 2014-06-13 at 11:01 -0400, Jason Cooper wrote:
Please format the subject lines like so:
irqchip: crossbar: Set cb pointer ...
^
|
\-- note the capitalization
I suggest you don't make this a rule and focus
on more
On Fri, 2014-06-13 at 12:37 -0400, Jason Cooper wrote:
On Fri, Jun 13, 2014 at 09:14:34AM -0700, Joe Perches wrote:
On Fri, 2014-06-13 at 11:01 -0400, Jason Cooper wrote:
Please format the subject lines like so:
irqchip: crossbar: Set cb pointer
On Fri, 2014-06-13 at 22:38 +0200, Thomas Gleixner wrote:
On Fri, 13 Jun 2014, Jason Cooper wrote:
On Fri, Jun 13, 2014 at 09:48:24AM -0700, Joe Perches wrote:
On Fri, 2014-06-13 at 12:37 -0400, Jason Cooper wrote:
On Fri, Jun 13, 2014 at 09:14:34AM -0700, Joe Perches wrote:
On Fri
On Thu, 2014-06-12 at 19:05 +0530, Sricharan R wrote:
On Thursday 12 June 2014 06:40 PM, Jason Cooper wrote:
On Thu, Jun 12, 2014 at 05:23:16PM +0530, Sricharan R wrote:
diff --git a/drivers/irqchip/irq-crossbar.c
b/drivers/irqchip/irq-crossbar.c
[]
@@ -34,7 +34,8 @@ struct
On Thu, 2014-06-12 at 11:32 -0400, Jason Cooper wrote:
Hi Jason.
But bugfix backports haven't been much of an issue in
other subsystems with fairly active whitespace/style
changes.
Most of the mvebu fixes we've had that failed to apply were generally
due to a large whitespace change
On Mon, 2014-06-09 at 15:08 +0300, Stanimir Varbanov wrote:
The driver is separated by functional parts. The core part
implements a platform driver probe and remove callbaks.
The probe enables clocks, checks crypto version, initialize
and request dma channels, create done tasklet and init
On Wed, 2014-04-16 at 14:40 +0200, Antoine Ténart wrote:
Add a Driver to support the SDHCI controller of the Marvell Berlin SoCs.
This controller supports 3 sockets.
trivial notes:
diff --git a/drivers/mmc/host/sdhci-berlin.c b/drivers/mmc/host/sdhci-berlin.c
[]
+static struct sdhci_ops
On Wed, 2014-04-16 at 19:39 -0700, Iyappan Subramanian wrote:
This patch adds network driver for APM X-Gene SoC ethernet.
[]
diff --git a/drivers/net/ethernet/apm/xgene/Kconfig
b/drivers/net/ethernet/apm/xgene/Kconfig
[]
@@ -0,0 +1,10 @@
+config NET_XGENE
+ tristate APM X-Gene SoC
On Wed, 2014-04-16 at 19:39 -0700, Iyappan Subramanian wrote:
This patch adds a MAINTAINERS entry for APM X-Gene SoC
ethernet driver.
[]
diff --git a/MAINTAINERS b/MAINTAINERS
[]
@@ -686,6 +686,14 @@ S: Maintained
F: drivers/net/appletalk/
F: net/appletalk/
+APPLIED MICRO
On Tue, 2014-03-25 at 10:11 +0100, Wolfram Sang wrote:
On Tue, Mar 25, 2014 at 10:07:00AM +0100, Uwe Kleine-König wrote:
Hello,
On Mon, Mar 24, 2014 at 06:01:31PM +0100, Wolfram Sang wrote:
And checkpatch said:
WARNING: braces {} are not necessary for any arm of this statement
On Wed, 2014-03-26 at 10:56 +0530, Kedareswara rao Appana wrote:
This patch adds xilinx CAN controller support.
This driver supports both ZYNQ CANPS and Soft IP
AXI CAN controller.
Just trivial notes about dmesg logging output.
diff --git a/drivers/net/can/xilinx_can.c
On Sat, 2014-03-22 at 14:01 -0500, Vince Bridgers wrote:
See comments inline
Do please trim your comments instead of quoting the
_whole_ email.
--
To unsubscribe from this list: send the line unsubscribe devicetree in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Tue, 2014-03-18 at 15:52 +0530, Girish KS wrote:
On Mon, Mar 17, 2014 at 5:33 PM, Girish K S ks.g...@samsung.com wrote:
Hi, just some trivial notes about the patch
diff --git a/drivers/mailbox/mailbox-samsung.c
b/drivers/mailbox/mailbox-samsung.c
[]
@@ -0,0 +1,354 @@
+/*
+ *
On Tue, 2014-03-18 at 11:19 -0700, Byungho An wrote:
From: Siva Reddy siva.kal...@samsung.com
This patch adds support for Samsung 10Gb ethernet driver(sxgbe).
More trivia, nothing that should stop this from
being applied and updated later...
diff --git
On Wed, 2014-03-12 at 09:50 +0100, Maxime COQUELIN wrote:
This patch replaces the raw values with ARRAY_SIZE for assigning the
ninput_delays and noutput_delays fields of STiH416's st_pctl_data struct.
trivial note:
diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
[]
On Wed, 2014-03-12 at 15:15 -0500, Vince Bridgers wrote:
This patch adds the MSGDMA soft IP support for the Altera Triple
Speed Ethernet driver.
[]
Signed-off-by: Vince Bridgers vbridgers2...@gmail.com
---
V4: - Modify use of dev_* to netdev_* where possible
Hi again Vince.
trivia:
It'd
On Wed, 2014-03-12 at 15:15 -0500, Vince Bridgers wrote:
This patch adds miscellaneous files for the Altera Ethernet Driver,
including ethtool support.
Signed-off-by: Vince Bridgers vbridgers2...@gmail.com
---
V4: - Change names of statistics to match common usage found in most
On Wed, 2014-03-12 at 15:15 -0500, Vince Bridgers wrote:
This patch adds the main driver and header file for the Altera Triple
Speed Ethernet driver.
[]
diff --git a/drivers/net/ethernet/altera/altera_tse.h
b/drivers/net/ethernet/altera/altera_tse.h
[]
+/* MAC register Space. Note that some
(added David Miller to cc's)
On Wed, 2014-03-12 at 21:14 +, Ben Hutchings wrote:
On Tue, 2014-03-11 at 19:28 -0500, Vince Bridgers wrote:
On Tue, Mar 11, 2014 at 5:59 PM, Joe Perches j...@perches.com wrote:
On Tue, 2014-03-11 at 17:43 -0500, Vince Bridgers wrote:
This patch adds
On Wed, 2014-03-12 at 21:14 +, Ben Hutchings wrote:
These look like the statistic names specified in IEEE 802.3. I would
support a general move to using standard names for MAC stats in Ethernet
drivers, because they are quite clearly defined and widely implemented
in hardware. However,
On Wed, 2014-03-12 at 19:42 -0500, Vince Bridgers wrote:
As I was working through the V4 patch and looking at the names used by
other drivers, it occurred to me it would be useful to create a set of
standard definitions that referenced the relevant IEEE Specification
and RFC. I'm willing to
On Tue, 2014-03-11 at 17:43 -0500, Vince Bridgers wrote:
This patch adds miscellaneous files for the Altera Ethernet Driver,
including ethtool support.
trivial notes:
diff --git a/drivers/net/ethernet/altera/altera_tse_ethtool.c
b/drivers/net/ethernet/altera/altera_tse_ethtool.c
[]
+static
On Tue, 2014-03-11 at 17:43 -0500, Vince Bridgers wrote:
This patch adds the main driver and header file for the Altera Triple
Speed Ethernet driver.
trivial notes about message logging:
diff --git a/drivers/net/ethernet/altera/altera_tse_main.c
On Fri, 2014-03-07 at 14:26 +0100, Florian Vaussard wrote:
Joe: I have split your patch to perform atomic changes. I also
merged one part into one of my patch. I added your S-o-B on the
corresponding patches, I let you check if you are OK with the changes.
Could you please send a clean V4
(added some cc's)
On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote:
From: Alistair Popple alist...@popple.id.au
Date: Thu, 6 Mar 2014 14:52:25 +1100
+ out_be32(dev-reg, in_be32(dev-reg) | WKUP_ETH_RGMIIEN
+| WKUP_ETH_TX_OE | WKUP_ETH_RX_IE);
When an expression spans
On Sat, 2014-03-08 at 02:04 +0300, Dan Carpenter wrote:
On Fri, Mar 07, 2014 at 01:30:17PM -0800, j...@joshtriplett.org wrote:
On Fri, Mar 07, 2014 at 01:02:44PM -0800, Joe Perches wrote:
On Fri, 2014-03-07 at 15:41 -0500, David Miller wrote:
From: Alistair Popple alist...@popple.id.au
On Wed, 2014-03-05 at 20:28 +0900, Byungho An wrote:
From: Siva Reddy siva.kal...@samsung.com
Just a few trivial comments on a brief scan.
+/* Context descriptor structure */
+struct xgmac_tx_ctxt_desc {
+ u32 tstamp_lo:32;
+ u32 tstamp_hi:32;
I think u32 foo:32; is odd at best
and
On Mon, 2014-03-03 at 11:44 +0100, Florian Vaussard wrote:
Looking at the current documentation, the list of these generic
placeholders is pretty short:
$ git grep ',.*-' Documentation/devicetree/bindings/ | \
grep -P -o ',.*?-' | grep -P -o '.*' | sort | uniq
board
chip
chip name
On Mon, 2014-03-03 at 00:30 -0600, Andy Gross wrote:
Add the DMA engine driver for the QCOM Bus Access Manager (BAM) DMA controller
found in the MSM 8x74 platforms.
Each BAM DMA device is associated with a specific on-chip peripheral. Each
channel provides a uni-directional data transfer
Hi.
A couple of suggestions and a couple of questions.
I made the patch below against your patches to.
o Look for .compatible = foo strings in .c and .h files too
o Improve the vendor name match in vendor-prefix.txt by only
matching the exact vendor name at the beginning of lines.
I then
On Thu, 2014-02-27 at 20:56 +0100, Florian Vaussard wrote:
With a compatible string like
compatible = foo;
checkpatch will currently try to find foo in vendor-prefixes.txt,
which is wrong since the vendor prefix is empty in this specific case.
Skip the vendor test if the compatible is
On Thu, 2014-02-27 at 21:24 +0100, Florian Vaussard wrote:
On 02/27/2014 09:10 PM, Joe Perches wrote:
On Thu, 2014-02-27 at 20:56 +0100, Florian Vaussard wrote:
With a compatible string like
compatible = foo;
checkpatch will currently try to find foo in vendor-prefixes.txt,
which
On Sun, 2014-02-23 at 23:07 +0100, Sebastian Reichel wrote:
This is a driver for an A/D converter, which belongs into
drivers/iio/adc.
Please use git format-patch -M
diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c
[]
+static int twl4030_madc_read(struct iio_dev
On Thu, 2014-02-20 at 16:38 -0800, Bjorn Andersson wrote:
This bus driver supports the QUP i2c hardware controller in the Qualcomm SOCs.
The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data path
engine with input/output FIFOs and an embedded i2c mini-core. The driver
On Thu, 2014-02-13 at 11:35 +0100, Francois Romieu wrote:
Florian Fainelli f.faine...@gmail.com :
[...]
diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
[]
+static int bcmgenet_set_rx_csum(struct net_device *dev,
+
On Fri, 2014-02-07 at 11:38 -0800, Frank Rowand wrote:
On 2/6/2014 9:11 PM, Joe Perches wrote:
For patch 1, what checkpatch bug might that be?
[]
Sorry, it is patch 2, not patch 1 ([PATCH v5 02/14] clk: Add
set_rate_and_parent() op):
WARNING: Multiple spaces after return type
#188
On Thu, 2014-02-06 at 20:15 -0800, Frank Rowand wrote:
On 1/15/2014 10:47 AM, Stephen Boyd wrote:
The first breaks a reset-controller include ordering requirement. It got
an ack so I think we're ok for it to go through the clock tree.
snip
checkpatch is whining about patches
4
On Tue, 2014-02-04 at 14:42 -0600, Andy Gross wrote:
Add the DMA engine driver for the QCOM Bus Access Manager (BAM) DMA controller
found in the MSM 8x74 platforms.
trivia: fixable later.
diff --git a/drivers/dma/qcom_bam_dma.c b/drivers/dma/qcom_bam_dma.c
[]
+ /* allocate enough room to
On Sun, 2014-01-19 at 18:50 -0600, Rob Landley wrote:
On 01/19/14 13:34, Joe Perches wrote:
On Sun, 2014-01-19 at 19:07 +0100, Christophe Leroy wrote:
Pinging this watch as we got no feedback since 22 Nov, although we have
taken
into account reviews from v1 and v2.
The patch adds WAN
On Fri, 2013-12-06 at 09:56 +, Andy Whitcroft wrote:
On Wed, Dec 04, 2013 at 08:12:43AM -0800, Joe Perches wrote:
On Wed, 2013-12-04 at 10:03 -0600, Rob Herring wrote:
From: Rob Herring rob.herr...@calxeda.com
This adds a simple check that any compatible strings in DeviceTree dts
1 - 100 of 110 matches
Mail list logo
