Re: [PATCH v2] iio: health: max30100: add config for LED current

2016-01-03 Thread Jonathan Cameron
On 31/12/15 22:17, Rob Herring wrote: > On Tue, Dec 29, 2015 at 09:44:48PM -0800, Matt Ranostay wrote: >> Allow the current for both RED and IR LEDs to be set via an device tree >> property setting. >> >> This is an optional setting that is useful for applications that have a >> known glass attenua

Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver

2015-12-31 Thread Jonathan Cameron
On 23/12/15 10:27, Ludovic Desroches wrote: > On Tue, Dec 22, 2015 at 06:34:00PM +0000, Jonathan Cameron wrote: >> On 21/12/15 09:24, Ludovic Desroches wrote: >>> This driver supports the new version of the Atmel ADC device introduced >>> with the SAMA5D2 SoC family. >

Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver

2015-12-23 Thread Jonathan Cameron
On 23 December 2015 10:48:33 GMT+00:00, Ludovic Desroches wrote: >On Wed, Dec 23, 2015 at 11:27:00AM +0100, Ludovic Desroches wrote: >> On Tue, Dec 22, 2015 at 06:34:00PM +, Jonathan Cameron wrote: >> > On 21/12/15 09:24, Ludovic Desroches wrote: >> > > This d

Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver

2015-12-22 Thread Jonathan Cameron
On 21/12/15 09:24, Ludovic Desroches wrote: > This driver supports the new version of the Atmel ADC device introduced > with the SAMA5D2 SoC family. > > Signed-off-by: Ludovic Desroches A few more bits and bobs from me. Mostly looking good. Jonathan > --- > .../devicetree/bindings/iio/adc/at91_

Re: [PATCH v3 5/5] iio: health: Add driver for the TI AFE4403 heart monitor

2015-12-22 Thread Jonathan Cameron
On 14/12/15 22:36, Andrew F. Davis wrote: > Add driver for the TI AFE4403 heart rate monitor and pulse oximeter. > This device detects reflected LED light fluctuations and presents an ADC > value to the user space for further signal processing. > > Data sheet located here: > http://www.ti.com/prod

Re: [PATCH v3 4/5] Documentation: afe4403: Add DT bindings for the AFE4403 heart monitor

2015-12-22 Thread Jonathan Cameron
On 14/12/15 22:36, Andrew F. Davis wrote: > Add the TI AFE4403 heart monitor DT bindings documentation. > > Signed-off-by: Andrew F. Davis Nothing terribly controversial in here that I can spot so looks good to me. Jonathan > --- > .../devicetree/bindings/iio/health/afe4403.txt | 34 >

Re: [PATCH v3 3/5] iio: health: Add driver for the TI AFE4404 heart monitor

2015-12-22 Thread Jonathan Cameron
On 14/12/15 22:35, Andrew F. Davis wrote: > Add driver for the TI AFE4404 heart rate monitor and pulse oximeter. > This device detects reflected LED light fluctuations and presents an ADC > value to the user space for further signal processing. > > Datasheet: http://www.ti.com/product/AFE4404/data

Re: [PATCH v3 1/5] iio: Make IIO value formating function globally available.

2015-12-22 Thread Jonathan Cameron
On 14/12/15 22:35, Andrew F. Davis wrote: > Make IIO value formating function globally available to allow IIO drivers > to output values as the core does. > > Signed-off-by: Andrew F. Davis Applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play wit

Re: [PATCH v9 5/8] iio: adc: fsl,imx25-gcq driver

2015-12-12 Thread Jonathan Cameron
nnections of the ADC inputs. > > Signed-off-by: Markus Pargmann > Signed-off-by: Denis Carikli A couple of little bits inline. Fix the return of 0 on fail in probe and you can add Acked-by: Jonathan Cameron > --- > > Notes: > Changes in v7: > - Remove separate f

Re: [PATCH v5 1/4] iio: adc: add IMX7D ADC driver support

2015-12-12 Thread Jonathan Cameron
On 08/12/15 10:26, Haibo Chen wrote: > Freescale i.MX7D soc contains a new ADC IP. This patch add this ADC > driver support, and the driver only support ADC software trigger. > > Signed-off-by: Haibo Chen One significant issue, but as the fix is simple I've made it. A few formatting bits and bobs

Re: [PATCH v9 2/8] ARM: dt: Binding documentation for imx25 GCQ

2015-12-12 Thread Jonathan Cameron
kus Pargmann > > Acked-by: Rob Herring Acked-by: Jonathan Cameron > >> --- >> >> Notes: >> Changes in v9: >> - Added the dt-bindings header to this patch instead of the driver >> >> Changes in v6: >> - Changed bin

Re: [PATCH v5 3/4] ARM: dts: imx7d.dtsi: add ADC support

2015-12-12 Thread Jonathan Cameron
On 08/12/15 10:26, Haibo Chen wrote: > Add imx7d ADC support. > > Signed-off-by: Haibo Chen The driver is now working its way in the direction of linux-next via Greg KHs tree. I'm happy to take these changes as well, but would imagine they are better routed through the relevant imx trees. Jonath

Re: [PATCH v5 2/4] Documentation: add the binding file for Freescale imx7d ADC driver

2015-12-12 Thread Jonathan Cameron
On 08/12/15 10:26, Haibo Chen wrote: > The patch adds the binding file for Freescale imx7d ADC driver. > > Signed-off-by: Haibo Chen > Acked-by: Rob Herring Applied > --- > .../devicetree/bindings/iio/adc/imx7d-adc.txt | 22 > ++ > 1 file changed, 22 insertions(+) >

Re: [PATCH v2 2/2] iio: health: Add driver for the TI AFE4404 heart monitor

2015-12-12 Thread Jonathan Cameron
On 07/12/15 17:26, Andrew F. Davis wrote: > On 12/05/2015 12:21 PM, Jonathan Cameron wrote: >> On 02/12/15 19:57, Andrew F. Davis wrote: >>> Add driver for the TI AFE4404 heart rate monitor and pulse oximeter. >>> This device detects reflected LED light fluctuations an

Re: [PATCH v4 1/4] iio: adc: add IMX7D ADC driver support

2015-12-05 Thread Jonathan Cameron
On 01/12/15 08:22, Haibo Chen wrote: > Freescale i.MX7D soc contains a new ADC IP. This patch add this ADC > driver support, and the driver only support ADC software trigger. > > Signed-off-by: Haibo Chen Looks good to me. Only bit I don't like is the papering over an interrupt occuring that sho

Re: [PATCH v2 2/2] iio: health: Add driver for the TI AFE4404 heart monitor

2015-12-05 Thread Jonathan Cameron
On 02/12/15 19:57, Andrew F. Davis wrote: > Add driver for the TI AFE4404 heart rate monitor and pulse oximeter. > This device detects reflected LED light fluctuations and presents an ADC > value to the user space for further signal processing. > > Datasheet: http://www.ti.com/product/AFE4404/data

Re: [PATCH v2 1/2] Documentation: afe4404: Add DT bindings for the AFE4404 heart monitor

2015-12-05 Thread Jonathan Cameron
On 05/12/15 17:53, Andrew F. Davis wrote: > On 12/05/2015 11:38 AM, Jonathan Cameron wrote: >> On 02/12/15 19:57, Andrew F. Davis wrote: >>> Add the TI afe4404 heart monitor DT bindings documentation. >>> Create health directory created under iio. >>> >&g

Re: [PATCH v2 1/2] Documentation: afe4404: Add DT bindings for the AFE4404 heart monitor

2015-12-05 Thread Jonathan Cameron
On 02/12/15 19:57, Andrew F. Davis wrote: > Add the TI afe4404 heart monitor DT bindings documentation. > Create health directory created under iio. > > Signed-off-by: Andrew F. Davis One little point inline - otherwise this is straightforward and looks good to me. Could add cross references to

Re: [PATCH 3/5] iio: light: us5182d: Add functions for selectively enabling als and proximity

2015-11-29 Thread Jonathan Cameron
On 24/11/15 10:59, Adriana Reus wrote: > Keep track of the als and px enabled/disabled status in > order to enable them selectively. > > Signed-off-by: Adriana Reus Couple more nitpicks, but again fixed up during apply. > --- > drivers/iio/light/us5182d.c | 64 >

Re: [PATCH v3 1/4] iio: adc: add IMX7D ADC driver support

2015-11-29 Thread Jonathan Cameron
On 25/11/15 03:52, Stefan Agner wrote: > Hi Haibo, > > Some comments below: > > On 2015-11-20 07:48, Haibo Chen wrote: >> Freescale i.MX7D soc contains a new ADC IP. This patch add this ADC >> driver support, and the driver only support ADC software trigger. >> >> Signed-off-by: Haibo Chen >> --

Re: [PATCH 5/5] iio: light: us5182d: Add interrupt support and events

2015-11-29 Thread Jonathan Cameron
On 24/11/15 10:59, Adriana Reus wrote: > Add interrupt support and events for proximity. > Add two threshold events to signal rising and falling directions. > > Signed-off-by: Adriana Reus A few bits and bobs inline... > --- > drivers/iio/light/us5182d.c | 272 >

Re: [PATCH 4/5] iio: light: us8152d: Add power management support

2015-11-29 Thread Jonathan Cameron
On 24/11/15 10:59, Adriana Reus wrote: > Add power management for sleep as well as runtime pm. > > Signed-off-by: Adriana Reus Mostly fine, but a comment on a possible future tidy up inline. Applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play wi

Re: [PATCH 1/5] iio: light: us5182d: Add property for choosing default power mode

2015-11-29 Thread Jonathan Cameron
On 24/11/15 10:59, Adriana Reus wrote: > This chip supports two power modes. > 1. "one-shot" mode - the chip activates and executes one complete > conversion loop and then shuts itself down. This is the default mode > chosen for raw reads. > 2. "continuous" mode - the chip takes continuous measurem

Re: [PATCH 2/5] Documentation: devicetree: Add property for controlling power saving mode for the us5182 als sensor

2015-11-29 Thread Jonathan Cameron
On 25/11/15 23:55, Rob Herring wrote: > On Wed, Nov 25, 2015 at 11:50:30AM +0200, Adriana Reus wrote: >> >> >> On 25.11.2015 02:01, Rob Herring wrote: >>> On Tue, Nov 24, 2015 at 12:59:49PM +0200, Adriana Reus wrote: Add a property to allow changing the default power-saving mode. By defau

Re: [PATCH 2/2] dt-bindings: iio: adc: Update mcp342x binding for the mcp3421

2015-11-29 Thread Jonathan Cameron
On 27/11/15 20:15, Rob Herring wrote: > On Fri, Nov 27, 2015 at 02:52:52PM +0100, Sascha Hauer wrote: >> The mcp3421 is the single channel variant of the mcp342x family and >> can be supported by the mcp342x driver. >> >> Signed-off-by: Sascha Hauer >> Cc: devicetree@vger.kernel.org > > Acked-by:

Re: [PATCH v8 6/8] input: touchscreen: imx25 tcq driver

2015-11-21 Thread Jonathan Cameron
On 21/11/15 17:48, Jonathan Cameron wrote: > On 16/11/15 12:01, Markus Pargmann wrote: >> This is a driver for the imx25 ADC/TSC module. It controls the >> touchscreen conversion queue and creates a touchscreen input device. >> The driver currently only supports 4 wire tou

Re: [PATCH v8 6/8] input: touchscreen: imx25 tcq driver

2015-11-21 Thread Jonathan Cameron
On 16/11/15 12:01, Markus Pargmann wrote: > This is a driver for the imx25 ADC/TSC module. It controls the > touchscreen conversion queue and creates a touchscreen input device. > The driver currently only supports 4 wire touchscreens. The driver uses > a simple conversion queue of precharge, touch

Re: [PATCH v8 4/8] mfd: fsl imx25 Touchscreen ADC driver

2015-11-21 Thread Jonathan Cameron
On 21/11/15 17:02, Jonathan Cameron wrote: > On 16/11/15 12:01, Markus Pargmann wrote: >> This is the core driver for imx25 touchscreen/adc driver. The module >> has one shared ADC and two different conversion queues which use the >> ADC. The two queues are identical. Both ca

Re: [PATCH v8 4/8] mfd: fsl imx25 Touchscreen ADC driver

2015-11-21 Thread Jonathan Cameron
sure correct ADC clock depending on the IPG clock] > Signed-off-by: Juergen Borleis Looks good to me - one query on meaning of a comment inline. Acked-by: Jonathan Cameron I'm taking the view this series wants to go through the MFD tree but don't mind if it goes through IIO or input i

Re: [PATCH 2/2] iio: health: Add driver for the TI AFE4404 heart monitor

2015-11-15 Thread Jonathan Cameron
On 10/11/15 19:19, Andrew F. Davis wrote: > On 11/05/2015 01:09 PM, Jonathan Cameron wrote: >> Lars, Hartmut, Peter, >> >> This is becoming a really involved ABI discussion so I'd like some >> input on this if any of you have the time. >> >> I'

Re: [PATCH v6 2/2] iio: ti-ads8688: Add DT binding documentation

2015-11-15 Thread Jonathan Cameron
On 09/11/15 15:57, Rob Herring wrote: > On Mon, Nov 09, 2015 at 01:53:00PM +0100, Sean Nyekjaer wrote: >> Adding binding documentation for Texas Instruments ADS8688 ADC. >> >> Signed-off-by: Sean Nyekjaer >> Reviewed-by: Martin Hundebøll > > Acked-by: Rob Herring Applied to the togreg branch of

Re: [PATCH 2/2] iio: st_sensors: support open drain mode

2015-11-15 Thread Jonathan Cameron
On 13/11/15 20:18, Linus Walleij wrote: > Some types of ST Sensors can be connected to the same IRQ line > as other peripherals using open drain. Add a device tree binding > and a sensor data property to flip the right bit in the interrupt > control register to enable open drain mode on the INT lin

Re: [PATCH v2 1/4] iio: adc: add IMX7D ADC driver support

2015-11-14 Thread Jonathan Cameron
On 13/11/15 09:52, Lars-Peter Clausen wrote: > On 11/13/2015 10:39 AM, Haibo Chen wrote: > [...] +static void imx7d_adc_feature_config(struct imx7d_adc *info) +{ + info->adc_feature.clk_pre_div = IMX7D_ADC_ANALOG_CLK_PRE_DIV_4; + info->adc_feature.avg_num = IMX7D_ADC_AVERAGE_N

Re: [PATCH v2 1/4] iio: adc: add IMX7D ADC driver support

2015-11-14 Thread Jonathan Cameron
On 09/11/15 13:28, Haibo Chen wrote: > Freescale i.MX7D soc contains a new ADC IP. This patch add this ADC > driver support, and the driver only support ADC software trigger. > > Signed-off-by: Haibo Chen Hi Haibo, A few comments inline in addition to Lars' ones. One small point is that whilst

Re: IIO device indexing issue

2015-11-05 Thread Jonathan Cameron
On 04/11/15 18:53, Vesa Jääskeläinen wrote: > On 04/11/15 11:38, Lars-Peter Clausen wrote: >> On 11/02/2015 07:47 PM, Vesa Jääskeläinen wrote: >>> Hi, >>> >>> When we were using kernel 3.2 and with that board files we just got IIO >>> devices with static order so that we knew exactly what iio:devic

Re: [PATCH 2/2] iio: health: Add driver for the TI AFE4404 heart monitor

2015-11-05 Thread Jonathan Cameron
Lars, Hartmut, Peter, This is becoming a really involved ABI discussion so I'd like some input on this if any of you have the time. I'm going to be busy now until at least the weekend... On 04/11/15 21:17, Andrew F. Davis wrote: > On 11/04/2015 01:40 PM, Jonathan Cameron wrote: &

Re: [PATCH 2/2] iio: health: Add driver for the TI AFE4404 heart monitor

2015-11-04 Thread Jonathan Cameron
On 02/11/15 20:37, Andrew F. Davis wrote: > On 11/01/2015 02:52 PM, Jonathan Cameron wrote: >> On 31/10/15 16:31, Andrew F. Davis wrote: >>> Add driver for the TI AFE4404 heart rate monitor and pulse oximeter. >>> This device detects reflected LED light fluctuations an

Re: [PATCH 0/2] iio: Heart Rate Monitors

2015-11-04 Thread Jonathan Cameron
On 02/11/15 16:31, Andrew F. Davis wrote: > On 11/01/2015 12:35 PM, Jonathan Cameron wrote: >> On 31/10/15 16:31, Andrew F. Davis wrote: >>> Hello all, >>> >>> This series adds the TI AFE4404 "Ultra-small, Integrated AFE for >>> Weara

Re: [PATCH 2/2] iio: health: Add driver for the TI AFE4404 heart monitor

2015-11-01 Thread Jonathan Cameron
On 31/10/15 16:31, Andrew F. Davis wrote: > Add driver for the TI AFE4404 heart rate monitor and pulse oximeter. > This device detects reflected LED light fluctuations and presents an ADC > value to the user space for further signal processing. > > Data sheet located here: > http://www.ti.com/prod

Re: [PATCH 0/2] iio: Heart Rate Monitors

2015-11-01 Thread Jonathan Cameron
On 31/10/15 16:31, Andrew F. Davis wrote: > Hello all, > > This series adds the TI AFE4404 "Ultra-small, Integrated AFE for > Wearable, Optical Heart Rate Monitoring and Bio-Sensing". > > This work is based on previous work by Dan Murphy [0] who is working > on other tasks at the moment, so I wil

Re: [PATCHv2 1/2] Documentation: ad5592r: Added devicetree bindings documentation

2015-10-31 Thread Jonathan Cameron
On 27/10/15 16:13, Linus Walleij wrote: > On Sun, Oct 25, 2015 at 2:31 PM, Jonathan Cameron wrote: >> On 13/10/15 10:37, Paul Cercueil wrote: >>> Signed-off-by: Paul Cercueil >> Looks good to me, but as it is a little bit 'different' and we are >> def

Re: [PATCH v3 1/3] devicetree: mfd: Add binding for the TI LM3533

2015-10-31 Thread Jonathan Cameron
common enough to conclude that now. Acked-by: Jonathan Cameron > --- > > Changes since v2: > - Drop vendor prefix of vendor properties > - Specify unit of various properties > - Fix reference paths > > Changes since v1: > - Added unit to boost-freq and als-resistance

Re: [PATCH v4 1/2] iio: adc: Add TI ADS8688

2015-10-25 Thread Jonathan Cameron
ting it to IIO_VAL_INT_PLUS_MICRO and checking the val2 is 0 would work as well if you want a quick solution. Adding IIO_VAL_INT support should be fairly straightforward, though I'd bypass the string to fixedpoint convertor in this case and do it with an scanf. > > /Sean > > On

Re: [PATCHv2 1/2] Documentation: ad5592r: Added devicetree bindings documentation

2015-10-25 Thread Jonathan Cameron
On 13/10/15 10:37, Paul Cercueil wrote: > Signed-off-by: Paul Cercueil Looks good to me, but as it is a little bit 'different' and we are defining entirely new generic bindings (the channel modes stuff) I would like some more input. It might be overkill but we do of course have the pinctl framewo

Re: [PATCHv2 2/2] iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs

2015-10-25 Thread Jonathan Cameron
On 13/10/15 10:38, Paul Cercueil wrote: > This patch adds support for the AD5592R (spi) and AD5593R (i2c) > ADC/DAC devices. > > Signed-off-by: Paul Cercueil A few minor questions inline... > --- > drivers/iio/dac/Kconfig | 27 > drivers/iio/dac/Makefile | 3 +

Re: [PATCH 1/2] iio: adc: mcp320x: Deprecated compatible strings with no vendor prefix

2015-10-25 Thread Jonathan Cameron
On 14/10/15 16:27, Michael Welling wrote: > On Wed, Oct 14, 2015 at 02:54:38PM +0200, Javier Martinez Canillas wrote: >> The Microchip Analog to Digital Converter (ADC) Device Tree binding >> documents compatible strings with no vendor prefix. Since it should >> compatible strings with also a vendo

Re: [PATCH 1/2] iio: adc: mcp320x: Deprecated compatible strings with no vendor prefix

2015-10-25 Thread Jonathan Cameron
On 14/10/15 13:54, Javier Martinez Canillas wrote: > The Microchip Analog to Digital Converter (ADC) Device Tree binding > documents compatible strings with no vendor prefix. Since it should > compatible strings with also a vendor, add these to the binding doc > and mark the old ones as deprecated.

Re: [PATCH v3 2/3] iio:adc:palmas: add DT support

2015-10-25 Thread Jonathan Cameron
On 16/10/15 13:53, H. Nikolaus Schaller wrote: > From: Marek Belisko > > Code was found at: > https://android.googlesource.com/kernel/tegra/+/a90856a6626d502d42c6e7abccbdf9d730b36270%5E%21/#F1 > > Signed-off-by: Laxman Dewangan > Signed-off-by: Marek Belisko [Fixed minor typos + add > channel

Re: [PATCH v3 1/3] iio:adc: add iio driver for Palmas (twl6035/7) gpadc

2015-10-25 Thread Jonathan Cameron
igned-off-by: Pradeep Goudagunta > Signed-off-by: H. Nikolaus Schaller > Signed-off-by: Marek Belisko > Acked-by: Laxman Dewangan > Reviewed-by: Jonathan Cameron > Acked-by: Lee Jones Applied to the togreg branch of iio.git - initially pushed out as testing. Unfortunately the t

Re: [PATCH v4] iio: mma8452: support either of the available interrupt pins

2015-10-25 Thread Jonathan Cameron
On 22/10/15 19:22, Rob Herring wrote: > On Thu, Oct 15, 2015 at 8:10 AM, Martin Kepplinger wrote: >> This change is important in order for everyone to be easily able to use the >> driver for one of the supported accelerometer chips! >> >> Until now, the driver blindly assumed that the INT1 interru

Re: [PATCH v4 1/2] iio: adc: Add TI ADS8688

2015-10-11 Thread Jonathan Cameron
On 06/10/15 09:12, Sean Nyekjaer wrote: > This patch adds support for the Texas Intruments ADS8688 ADC. > > Signed-off-by: Sean Nyekjaer > Reviewed-by: Martin Hundebøll only one issue that I can see. You do need locking to protect your local buffers. A local lock in the same structure would be

Re: [PATCH 1/3] iio:adc: add iio driver for Palmas (twl6035/7) gpadc

2015-10-11 Thread Jonathan Cameron
On 04/10/15 17:04, H. Nikolaus Schaller wrote: > > Am 27.09.2015 um 17:21 schrieb Jonathan Cameron : > >> On 23/09/15 13:48, H. Nikolaus Schaller wrote: >>> This driver code was found as: >>> >>> https://android.googlesource.com/kernel/tegra/+/aaabb2

Re: [PATCH v2 1/3] iio:adc: add iio driver for Palmas (twl6035/7) gpadc

2015-10-11 Thread Jonathan Cameron
it touched that, even if only a header, Lee and Samuel should have been cc'd). One thing that slightly confuses me is there seems to be hints of support in the mfd driver already... I can't find any sign of the child device however so I guess this is fine from that point of view. Revie

Re: [PATCH 1/5] iio: adc: add IMX7D ADC driver support

2015-10-11 Thread Jonathan Cameron
On 08/10/15 11:59, Haibo Chen wrote: > Freescale i.MX7D soc contains a new ADC IP. This patch add this ADC > driver support, and the driver only support ADC software trigger. > > Signed-off-by: Haibo Chen Hi Haibo, A very nice clean driver. I've noted a few minor stylistic things inline that I w

Re: [PATCH 2/5] Documentation: add the binding file for Freescale imx7d ADC driver

2015-10-11 Thread Jonathan Cameron
On 11/10/15 14:31, Jonathan Cameron wrote: > On 08/10/15 11:59, Haibo Chen wrote: >> The patch adds the binding file for Freescale imx7d ADC driver. >> >> Signed-off-by: Haibo Chen > Couple of trivial typos.. otherwise fine. >> --- >> .../devicetree/bind

Re: [PATCH 2/5] Documentation: add the binding file for Freescale imx7d ADC driver

2015-10-11 Thread Jonathan Cameron
On 08/10/15 11:59, Haibo Chen wrote: > The patch adds the binding file for Freescale imx7d ADC driver. > > Signed-off-by: Haibo Chen Couple of trivial typos.. otherwise fine. > --- > .../devicetree/bindings/iio/adc/imx7d-adc.txt | 26 > ++ > 1 file changed, 26 insertio

Re: [PATCH 3/3] iio: ad5064: Always use external vref if there is no internal vref

2015-10-04 Thread Jonathan Cameron
On 02/10/15 13:41, Paul Cercueil wrote: > If the device does not have an internal reference, there is no > other choice but to use the external reference. In that case, > it does not make much sense to have to specify it. > > This patch ensures that the external reference is used if the > device d

Re: [PATCH 2/2] iio: dac: Add support for the AD5592R/AD5593R ADCs/DACs

2015-10-04 Thread Jonathan Cameron
On 02/10/15 13:45, Paul Cercueil wrote: > This patch adds support for the AD5592R (spi) and AD5593R (i2c) > ADC/DAC devices. > > Signed-off-by: Paul Cercueil SMBUS makes the assumption that the wire order is little endian. As such all the i2c drivers should be doing an necessary endian conversion

Re: [PATCH v3 1/2] iio:light: Add Dyna-Image AP3223 ambient light and proximity driver

2015-10-03 Thread Jonathan Cameron
On 30/09/15 02:36, Suresh Rajashekara wrote: > Minimal implementation with support for raw light and proximity reading. > > This is based on the driver provided by the vendor > (which was an input driver). Authors of the > driver from the vendor included > * John Huang > * Templeton Tsai > * Vic

Re: [PATCHv2 1/2] iio: adc: Add TI ADS868X

2015-09-29 Thread Jonathan Cameron
the driver with your comments :-) > > /Sean > > On 2015-09-27 16:38, Jonathan Cameron wrote: >> On 25/09/15 07:29, Sean Nyekjaer wrote: >>> This patch adds support for the Texas Intruments ADS868x ADC. >>> >>> Signed-off-by: Sean Nyekjaer >>> R

Re: [PATCH 2/3] iio:adc:palmas: add DT support

2015-09-27 Thread Jonathan Cameron
On 23/09/15 13:49, H. Nikolaus Schaller wrote: > From: Marek Belisko > > Code was found at: > https://android.googlesource.com/kernel/tegra/+/a90856a6626d502d42c6e7abccbdf9d730b36270%5E%21/#F1 > > Signed-off-by: Laxman Dewangan > [Fixed minor typos + add channels list to documentation] > Signed

Re: [PATCH 1/3] iio:adc: add iio driver for Palmas (twl6035/7) gpadc

2015-09-27 Thread Jonathan Cameron
On 23/09/15 13:48, H. Nikolaus Schaller wrote: > This driver code was found as: > > https://android.googlesource.com/kernel/tegra/+/aaabb2e045f31e5a970109ffdaae900dd403d17e/drivers/staging/iio/adc > > Fixed various compilation issues and test this driver on omap5 evm. > > Signed-off-by: Pradeep

Re: [PATCHv2 1/2] iio: adc: Add TI ADS868X

2015-09-27 Thread Jonathan Cameron
On 27/09/15 15:38, Jonathan Cameron wrote: > On 25/09/15 07:29, Sean Nyekjaer wrote: >> This patch adds support for the Texas Intruments ADS868x ADC. >> >> Signed-off-by: Sean Nyekjaer >> Reviewed-by: Martin Hundebøll > Hi > > The driver is fundamentally g

Re: [PATCHv2 2/2] iio: ti-ads868x: Add DT binding documentation

2015-09-27 Thread Jonathan Cameron
On 25/09/15 07:29, Sean Nyekjaer wrote: > Adding binding documentation for Texas Instruments ADS868X ADC. > > Signed-off-by: Sean Nyekjaer > Reviewed-by: Martin Hundebøll > --- > .../devicetree/bindings/iio/adc/ti-ads868x.txt | 18 > ++ > 1 file changed, 18 insertions(+

Re: [PATCHv2 1/2] iio: adc: Add TI ADS868X

2015-09-27 Thread Jonathan Cameron
On 25/09/15 07:29, Sean Nyekjaer wrote: > This patch adds support for the Texas Intruments ADS868x ADC. > > Signed-off-by: Sean Nyekjaer > Reviewed-by: Martin Hundebøll Hi The driver is fundamentally good, but I think a few small changes would make it less complex to read which is always a good

Re: [v7 PATCH 1/2] iio: light: Add support for UPISEMI uS5182d als and proximity sensor

2015-09-21 Thread Jonathan Cameron
On 16/09/15 09:14, Adriana Reus wrote: > Add support for UPISEMI us5182d als and proximity sensor. > Supports raw readings. > Data sheet for this device can be found here: > http://www.upi-semi.com/temp/uS5182D-DS-P0103-temp.pdf > > Signed-off-by: Adriana Reus Applied to the togreg branch of iio.

Re: [v7 PATCH 2/2] devicetree: Add documentation for UPISEMI us5182d ALS and Proximity sensor

2015-09-21 Thread Jonathan Cameron
On 21/09/15 16:02, Rob Herring wrote: > On 09/16/2015 03:14 AM, Adriana Reus wrote: >> Added entries in i2c/vendor-prefixes for the us5182d als and proximity >> sensor. >> Also added a documentation file for this sensor's properties. >> >> Signed-off-by: Adriana Reus >> --- >> Changes since v6:

Re: [PATCH v5 3/4] devicetree: add SGX Sensortech vendor id

2015-09-20 Thread Jonathan Cameron
On 14/09/15 04:26, Matt Ranostay wrote: > Signed-off-by: Matt Ranostay Applied. Note there was fuzz in my tree as I am lagging mainline somewhat. However it is pretty obvious how to fix up merge issues in this file so lets not worry about that ;) Jonathan > --- > Documentation/devicetree/bindin

Re: [PATCH v5 1/4] iio: chemical: Add IIO_CONCENTRATION channel type

2015-09-20 Thread Jonathan Cameron
On 14/09/15 04:26, Matt Ranostay wrote: > There are air quality sensors that report data back in parts per million > of VOC (Volatile Organic Compounds) which are usually indexed from CO2 > or another common pollutant. > > This patchset adds an IIO_CONCENTRATION type that returns a percentage > of

Re: [PATCH v5 2/4] iio: resistance: add IIO_RESISTANCE channel type

2015-09-20 Thread Jonathan Cameron
On 14/09/15 04:26, Matt Ranostay wrote: > Signed-off-by: Matt Ranostay Applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > Documentation/ABI/testing/sysfs-bus-iio | 8 > drivers/iio/industrialio-core.

Re: [PATCH 6/6] iio: mma8452: leave sysfs namings to the iio core

2015-09-12 Thread Jonathan Cameron
On 01/09/15 12:45, Martin Kepplinger wrote: > This doesn't actually change anything since the core names the sysfs folder > for the iio event attributes "events" anyways. It only leaves the job to the > core. > > Signed-off-by: Martin Kepplinger > Signed-off-by: Christoph Muellner Applied to the

Re: [PATCH 5/6] iio: mma8452: add copyright notice comment

2015-09-12 Thread Jonathan Cameron
On 01/09/15 12:45, Martin Kepplinger wrote: > Signed-off-by: Martin Kepplinger > Signed-off-by: Christoph Muellner Applied. > --- > drivers/iio/accel/mma8452.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > index 59b4455..15d

Re: [PATCH 4/6] iio: mma8452: add support for MMA8652FC and MMA8653FC

2015-09-12 Thread Jonathan Cameron
On 01/09/15 12:45, Martin Kepplinger wrote: > MMA8652FC and MMA8653FC don't provide the transient interrupt source, so > the motion interrupt source is used by providing a new iio_chan_spec > definition, so that other supported devices are not affected by this. > > Datasheets for the newly support

Re: [PATCH 3/6] iio: mma8452: add freefall / motion interrupt source

2015-09-12 Thread Jonathan Cameron
On 01/09/15 12:45, Martin Kepplinger wrote: > This adds the freefall / motion interrupt source definitions to the driver. > It is used in this series' next patch, for chips that don't support the > transient interrupt source. > > Signed-off-by: Martin Kepplinger > Signed-off-by: Christoph Muellne

Re: [PATCH 2/6] iio: mma8452: add support for MMA8453Q accelerometer chip

2015-09-12 Thread Jonathan Cameron
On 01/09/15 12:45, Martin Kepplinger wrote: > This adds support for the 10 bit version if Freescale's accelerometers > of this series. The datasheet is available at Freescale's website: > > http://cache.freescale.com/files/sensors/doc/data_sheet/MMA8453Q.pdf > > It creates a devicetree bindings f

Re: [PATCH 1/6] iio: mma8452: refactor for seperating chip specific data

2015-09-12 Thread Jonathan Cameron
On 01/09/15 12:45, Martin Kepplinger wrote: > This adds a struct mma_chip_info to hold data that will remain specific to > the chip in use. It is provided during probe() and linked in > struct of_device_id. > > Also this suggests that the driver is called "mma8452" and now handles the > MMA8452Q d

Re: [PATCH 6/6] iio: mma8452: leave sysfs namings to the iio core

2015-09-05 Thread Jonathan Cameron
On 01/09/15 12:45, Martin Kepplinger wrote: > This doesn't actually change anything since the core names the sysfs folder > for the iio event attributes "events" anyways. It only leaves the job to the > core. > > Signed-off-by: Martin Kepplinger > Signed-off-by: Christoph Muellner Good point. I

Re: [PATCH 4/6] iio: mma8452: add support for MMA8652FC and MMA8653FC

2015-09-05 Thread Jonathan Cameron
On 01/09/15 12:45, Martin Kepplinger wrote: > MMA8652FC and MMA8653FC don't provide the transient interrupt source, so > the motion interrupt source is used by providing a new iio_chan_spec > definition, so that other supported devices are not affected by this. > > Datasheets for the newly support

Re: [PATCH 3/6] iio: mma8452: add freefall / motion interrupt source

2015-09-05 Thread Jonathan Cameron
On 01/09/15 12:45, Martin Kepplinger wrote: > This adds the freefall / motion interrupt source definitions to the driver. > It is used in this series' next patch, for chips that don't support the > transient interrupt source. > > Signed-off-by: Martin Kepplinger > Signed-off-by: Christoph Muellne

Re: [PATCH 2/6] iio: mma8452: add support for MMA8453Q accelerometer chip

2015-09-05 Thread Jonathan Cameron
On 01/09/15 12:45, Martin Kepplinger wrote: > This adds support for the 10 bit version if Freescale's accelerometers > of this series. The datasheet is available at Freescale's website: > > http://cache.freescale.com/files/sensors/doc/data_sheet/MMA8453Q.pdf > > It creates a devicetree bindings f

Re: [PATCH 1/6] iio: mma8452: refactor for seperating chip specific data

2015-09-05 Thread Jonathan Cameron
On 01/09/15 12:45, Martin Kepplinger wrote: > This adds a struct mma_chip_info to hold data that will remain specific to > the chip in use. It is provided during probe() and linked in > struct of_device_id. > > Also this suggests that the driver is called "mma8452" and now handles the > MMA8452Q d

Re: [[PATCH v2] 2/2] Altera Modular ADC driver support

2015-09-05 Thread Jonathan Cameron
On 01/09/15 22:49, Chee Nouk Phoo wrote: > From: Chee Nouk Phoon > > Altera Modular ADC is soft IP that wraps the hardened ADC block in a Max10 > device. It can be configured to dual ADC mode that supports two channel > synchronous sampling or independent single ADCs. ADC sampled values will be >

Re: [[PATCH v2] 1/2] Altera Modular ADC driver device binding

2015-09-05 Thread Jonathan Cameron
On 01/09/15 22:49, Chee Nouk Phoo wrote: > From: Chee Nouk Phoon > > Altera Modular ADC is soft IP that wraps the hardened ADC block in a Max10 > device. It can be configured to dual ADC mode that supports two channel > synchronous sampling or independent single ADCs. ADC sampled values will be >

Re: [PATCH] Altera Modular ADC driver device tree binding

2015-08-31 Thread Jonathan Cameron
On 20/08/15 08:46, Chee Nouk Phoo wrote: > From: Chee Nouk Phoon > > Altera Modular ADC is soft IP that wraps the hardened ADC block in a Max1 > device. It can be configured to dual ADC mode that supports two channel > synchronous sampling or independent single ADCs. ADC sampled values will be >

Re: [PATCH v5 2/2] dt: Document Holt HI-8435 bindings

2015-08-31 Thread Jonathan Cameron
On 28/08/15 15:28, Vladimir Barinov wrote: > These bindings can be used to register Holt HI-8435 threshold detector > > Signed-off-by: Vladimir Barinov This is now trivial so I'm taking it. Applied to the togreg branch of iio.git Thanks, Jonathan > --- > Changes in version 2: > - renamed file

Re: [PATCH v5 1/2] iio: adc: hi8435: Holt HI-8435 threshold detector

2015-08-31 Thread Jonathan Cameron
On 28/08/15 15:27, Vladimir Barinov wrote: > Add Holt threshold detector driver for HI-8435 chip > > Signed-off-by: Vladimir Barinov Applied to the togreg branch of iio.git - initially pushed out as testing for the auto builders to try and break it. Thanks for you persistence with this one! I'm

Re: [PATCH v6 2/2] devicetree: Add documentation for UPISEMI us5182d ALS and Proximity sensor

2015-08-27 Thread Jonathan Cameron
On 20/08/15 11:12, Adriana Reus wrote: > Added entries in i2c/vendor-prefixes for the us5182d als and proximity sensor. > Also added a documentation file for this sensor's properties. > > Signed-off-by: Adriana Reus This isn't that trivial so I'd like some device tree maintainer input if possible

Re: [PATCH v6 1/2] iio: light: Add support for UPISEMI uS5182d als and proximity sensor

2015-08-27 Thread Jonathan Cameron
On 20/08/15 11:12, Adriana Reus wrote: > Add support for UPISEMI us5182d als and proximity sensor. > Supports raw readings. > Data sheet for this device can be found here: > http://www.upi-semi.com/temp/uS5182D-DS-P0103-temp.pdf > > Signed-off-by: Adriana Reus Applied to the togreg branch of iio.

Re: [PATCH v4 4/4] dt: Document Holt HI-8435 bindings

2015-08-27 Thread Jonathan Cameron
On 20/08/15 20:38, Vladimir Barinov wrote: > These bindings can be used to register Holt HI-8435 threshold detector > > Signed-off-by: Vladimir Barinov This is fine and trivial enough that I am not going to need a device tree ack (not that I'd complain if one showed up :) Will pick it up with t

Re: [PATCH v4 3/4] iio: adc: hi8435: Holt HI-8435 threshold detector

2015-08-27 Thread Jonathan Cameron
On 20/08/15 20:38, Vladimir Barinov wrote: > Add Holt threshold detector driver for HI-8435 chip > > Signed-off-by: Vladimir Barinov A few little bits and bobs below but basically there. Jonathan > --- > Changes in version 2: > - Added file sysfs-bus-iio-adc-hi8435 > - Changed naming from "discr

Re: [PATCH v4 2/4] dt: Add vendor prefix 'holt'

2015-08-27 Thread Jonathan Cameron
On 23/08/15 23:32, Rob Herring wrote: > On Thu, Aug 20, 2015 at 2:38 PM, Vladimir Barinov > wrote: >> Add Holt Integrated Circuits, Inc. to the list of device tree vendor >> prefixes >> >> Signed-off-by: Vladimir Barinov > > Acked-by: Rob Herring Applied to the togreg branch of iio.git. Thanks

Re: [PATCH v4 1/4] iio: Support triggered events

2015-08-27 Thread Jonathan Cameron
On 20/08/15 20:43, Vladimir Barinov wrote: > Verified event and buffer polling works concurrently on the same trigger with > hi-8435. > The buffer interface part for hi-8435 was not sent. > > On 20.08.2015 22:37, Vladimir Barinov wrote: >> Support triggered events. >> >> This is useful for chips

Re: [PATCH 13/18] iio: adc: mcp320x: Set struct spi_driver .of_match_table

2015-08-22 Thread Jonathan Cameron
On 20/08/15 23:48, Javier Martinez Canillas wrote: > Hello Michael, > > On 08/21/2015 12:29 AM, Michael Welling wrote: >> On Fri, Aug 21, 2015 at 12:02:40AM +0200, Javier Martinez Canillas wrote: >>> Hello Michael, >>> >>> On 08/20/2015 10:09 PM, Michael Welling wrote: On Thu, Aug 20, 2015 at

Re: [PATCH v3 5/7] iio: Support triggered events

2015-08-22 Thread Jonathan Cameron
On 16/08/15 21:15, Vladimir Barinov wrote: > Hi Jonathan, > > Thank you for review. > Find some comments below. > > Regards, > Vladimir > > On 16.08.2015 12:20, Jonathan Cameron wrote: >> On 29/07/15 13:57, Vladimir Barinov wrote: >>> Support triggere

Re: [PATCH v3 1/7] iio: adc: hi8435: Holt HI-8435 threshold detector

2015-08-22 Thread Jonathan Cameron
On 16/08/15 19:54, Vladimir Barinov wrote: > Hi Jonathan, > > On 16.08.2015 12:00, Jonathan Cameron wrote: >> On 11/08/15 15:37, Vladimir Barinov wrote: >>> Hi Jonathan, >>> >>> Thank you for the review. >> Sorry I was being so indecisive. Always

Re: [PATCH v3 2/2] devicetree: Add documentation for UPISEMI us5182d ALS and Proximity sensor

2015-08-18 Thread Jonathan Cameron
On 18 August 2015 16:13:02 BST, Adriana Reus wrote: > >Thank you Jonathan, I'll add a new patch set soon, added some comments >inline also. > >Adriana >On 15.08.2015 17:31, Jonathan Cameron wrote: >> On 14/08/15 10:29, Adriana Reus wrote: >>> Added ent

Re: [PATCH v3 1/2] iio: light: Add support for UPISEMI uS5182d als and proximity sensor

2015-08-18 Thread Jonathan Cameron
On 18 August 2015 16:28:20 BST, Adriana Reus wrote: >Thanks for the review, added some comments inline, next patch set >coming >soon. > >Adriana > >On 15.08.2015 17:27, Jonathan Cameron wrote: >> On 14/08/15 10:29, Adriana Reus wrote: >>> Add support f

Re: [PATCH v3 5/7] iio: Support triggered events

2015-08-16 Thread Jonathan Cameron
On 29/07/15 13:57, Vladimir Barinov wrote: > Support triggered events. > > This is useful for chips that don't have their own interrupt sources. > It allows to use generic/standalone iio triggers for those drivers. As we have concluded this is a good thing to have, I've take a closer look at it.

Re: [PATCH v3 5/7] iio: Support triggered events

2015-08-16 Thread Jonathan Cameron
Vladimir - before I forget, could you try to wrap emails to around 80 characters per line. Otherwise we end up with really tricky to read thread when some are doing so and others aren't! On 07/08/15 17:10, Vladimir Barinov wrote: > Hi Lars, > > On 07.08.2015 16:45, Lars-Peter Clausen wrote: >>

Re: [PATCH v3 1/7] iio: adc: hi8435: Holt HI-8435 threshold detector

2015-08-16 Thread Jonathan Cameron
tion first! Anyhow, I'm basically happy (now) with the events approach though I would suggest some modifications to how exactly it is done (see inline). Jonathan > > On 08.08.2015 20:56, Jonathan Cameron wrote: >> On 29/07/15 13:56, Vladimir Barinov wrote: >>> Add Ho

  1   2   3   4   5   >