Re: [PATCH 01/28] serial: earlycon: allow MEM32 I/O for DT earlycon

2015-12-02 Thread Peter Hurley
base = earlycon_map(addr, SZ_4K); >> >> + if (config_enabled(CONFIG_LIBFDT)) { >> + prop = fdt_getprop(fdt, offset, "reg-io-width", NULL); >> + if (prop) { >> + switch (be32_to_cpup(prop)) { >> + case 4: >> + port->iotype = UPIO_MEM32; >> + break; >> + } >> + } > > ...move this parsing into fdt.c where we parse the address. FWIW, all of of_setup_earlycon() should only be #ifdef CONFIG_OF_EARLY_FLATTREE Regards, Peter Hurley -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] of/fdt: fix error checking for earlycon address

2015-10-28 Thread Peter Hurley
On 10/27/2015 04:46 PM, Rob Herring wrote: > On Fri, Oct 23, 2015 at 8:15 AM, Peter Hurley <pe...@hurleysoftware.com> > wrote: >> Hi Masahiro, >> >> On 10/23/2015 07:47 AM, Masahiro Yamada wrote: >>> fdt_translate_address() returns OF_BAD_ADDR on error

Re: Which is better to specify console, "console= " or "stdout-path" ?

2015-10-28 Thread Peter Hurley
Hi Masahiro, On 10/22/2015 12:20 AM, Masahiro Yamada wrote: > 2015-10-22 1:26 GMT+09:00 Peter Hurley <pe...@hurleysoftware.com>: >> On 10/21/2015 11:38 AM, Masahiro Yamada wrote: >>> 2015-10-21 21:46 GMT+09:00 Peter Hurley <pe...@hurleysoftware.com>: >>>

Re: [PATCH] of/fdt: fix error checking for earlycon address

2015-10-23 Thread Peter Hurley
ce_size_t (which is the proper type for handling addresses as integers) and that type was propagated through early_init_dt_scan_chosen_serial => of_setup_earlycon. Regards, Peter Hurley PS - It seems that there is a new user of fdt_translate_address() in the

Re: Which is better to specify console, "console= " or "stdout-path" ?

2015-10-21 Thread Peter Hurley
On 10/21/2015 11:38 AM, Masahiro Yamada wrote: > Hi Peter. > > 2015-10-21 21:46 GMT+09:00 Peter Hurley <pe...@hurleysoftware.com>: >> On 10/21/2015 04:58 AM, Sudeep Holla wrote: >>> On 21/10/15 06:09, Masahiro Yamada wrote: >>>> I think there

Re: Which is better to specify console, "console= " or "stdout-path" ?

2015-10-21 Thread Peter Hurley
On 10/21/2015 08:54 AM, Sudeep Holla wrote: > > > On 21/10/15 13:46, Peter Hurley wrote: >> On 10/21/2015 04:58 AM, Sudeep Holla wrote: >>> On 21/10/15 06:09, Masahiro Yamada wrote: >>>> I think there exist two ways to specify the console port and baudrate

Re: Which is better to specify console, "console= " or "stdout-path" ?

2015-10-21 Thread Peter Hurley
ons specified via /chosen/stdout-path are currently ignored by earlycon. There were some hiccups getting the initial support upstream; when 4.4 hits mainline, I'll resubmit my series that implements the of_serial i/o properties and options passthrough to earlycon setup. Regards, Pete

Re: [PATCH] of/fdt: fix aliases with baudrate in earlycon

2015-10-10 Thread Peter Hurley
; Stumbled upon this while testing 32-bit ARM earlycon support. It > seems that this once already came up on the list: > https://lkml.org/lkml/2015/3/13/562 Yeah, looks like my patch got lost somewhere. https://lkml.org/lkml/2015/4/8/604 Regards, Peter Hurley > > drivers/of/fdt.c

Re: [PATCH v2 0/7] serial: 8250_omap: workaround for IP errata

2015-07-14 Thread Peter Hurley
the errata documents of those devices as well. Patch 1/7 fixes a related bug but can be applied independently. Looks good. Thanks Sekhar! For series, Reviewed-by: Peter Hurley pe...@hurleysoftware.com -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message

Re: [PATCH 5/7] tty: 8250: workaround errata on disabling UART after using DMA

2015-07-10 Thread Peter Hurley
On 07/09/2015 10:15 AM, Sekhar Nori wrote: On Thursday 09 July 2015 07:03 AM, Peter Hurley wrote: [...] @@ -1307,6 +1320,36 @@ static int omap8250_runtime_suspend(struct device *dev) return -EBUSY; } + if (priv-habit UART_ERRATA_CLOCK_DISABLE

Re: [PATCH RESEND 1/7] tty: serial: 8250: omap: fix kernel crash in suspend-to-ram

2015-07-08 Thread Peter Hurley
the runtime callbacks after the system pm callbacks? Whatever positive it brings, it's a mess at the driver level. For example, this driver has to hook prepare()/complete() so it can set local state so that it can detect when the runtime suspend is being called during system suspend. Regards, Peter

Re: [PATCH 5/7] tty: 8250: workaround errata on disabling UART after using DMA

2015-07-08 Thread Peter Hurley
it. + */ + if (device_may_wakeup(dev)) + omap8250_update_mdr1(up, priv); Should this be unconditional? Regards, Peter Hurley + } + if (up-dma up-dma-rxchan) omap_8250_rx_dma(up, UART_IIR_RX_TIMEOUT); -- To unsubscribe from this list: send

Re: [PATCH 3/7] tty: 8250: omap: introduce function to update mdr1

2015-07-08 Thread Peter Hurley
(). [1] Advisory 21 in http://www.ti.com/lit/er/sprz408b/sprz408b.pdf Regards, Peter Hurley Signed-off-by: Sekhar Nori nsek...@ti.com --- drivers/tty/serial/8250/8250_omap.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/8250

Re: [PATCH 4/7] tty: 8250: omap eliminate use of of_machine_is_compatible()

2015-07-08 Thread Peter Hurley
specific to AM335x and like SoCs. This patch does break backward DTB compatibility for users of 8250_omap driver on AM335x boards. Not ok. 8250_omap was released with 3.19 and has been the default driver for BeagleBone since 4.0. Regards, Peter Hurley However, the 8250_omap driver is new

Re: [PATCH 08/15] of_serial: support for UARTs on I/O ports

2015-05-26 Thread Peter Hurley
[ + Arnd who has been reviewing/acking of_serial.c changes ] On 05/22/2015 11:51 AM, Paul Burton wrote: If the address provided for the UART is of an I/O port rather than a regular memory address, then set the port iotype appropriately and write the address to iobase rather than mapbase.

Re: [Gta04-owner] [PATCH 0/3] tty slave device support - version 3.

2015-05-06 Thread Peter Hurley
Hi Nikolaus, On 05/06/2015 01:19 AM, Dr. H. Nikolaus Schaller wrote: Am 05.05.2015 um 21:54 schrieb Peter Hurley pe...@hurleysoftware.com: Hi Neil, On 03/18/2015 01:58 AM, NeilBrown wrote: here is version 3 of support for tty-slaves. Is there a v4 of this that I missed? We did have

Re: [tty:tty-testing 9/30] drivers/of/fdt.c:807:2: error: implicit declaration of function 'fdt_path_offset_namelen'

2015-04-28 Thread Peter Hurley
5a95cfdfaf5c (of: earlycon: Fix 'stdout-path' with ':' path terminator) through 865f9cc509db (of: earlycon: Log more helpful message if earlycon not found) from tty-testing. I'll just resend the series when the situation with the missing commit has been sorted. Regards, Peter Hurley

Re: [PATCH V2 2/4] misc: ti-st: use of_get_named_gpio_flags for nshutdown

2015-04-27 Thread Peter Hurley
in the absence of 'nshutdown_gpio'. Regards, Peter Hurley This allows the polarity to be specified using GPIO_ACTIVE_HIGH/LOW in device tree. Signed-off-by: Eric Nelson eric.nel...@boundarydevices.com --- V2 changes comments to use assert and de-assert to refer to the state of the nshutdown

Re: [PATCH V2 2/4] misc: ti-st: use of_get_named_gpio_flags for nshutdown

2015-04-27 Thread Peter Hurley
Hi Eric, On 04/27/2015 04:18 PM, Eric Nelson wrote: Hi Peter, On 04/27/2015 01:11 PM, Peter Hurley wrote: On 04/27/2015 03:27 PM, Eric Nelson wrote: Use of_get_named_gpio_flags to retrieve the nshutdown gpio connected to the BT_EN pin of the device when retrieving platform data from device

Re: [PATCH] [RFC] OF: probe order dependency aware of_platform_populate

2015-04-16 Thread Peter Hurley
On 04/15/2015 10:35 AM, Rob Herring wrote: On Wed, Apr 15, 2015 at 9:17 AM, Peter Hurley pe...@hurleysoftware.com wrote: 2. Should DT-specific drivers not be using irq_of_parse_and_map()? On probe failure irq_dispose_mapping() will be junking the mapping, thus invalidating the irq

Re: [PATCH] [RFC] OF: probe order dependency aware of_platform_populate

2015-04-15 Thread Peter Hurley
successfully. Regards, Peter Hurley -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libfdt/tests: Add fdt_path_offset_namelen() test

2015-04-07 Thread Peter Hurley
On 04/07/2015 12:49 AM, David Gibson wrote: On Sun, Apr 05, 2015 at 12:05:56AM -0400, Peter Hurley wrote: Add unit test for fdt_path_offset_namelen(). Verify partial path- descending retrieves the same node offset as fdt_subnode_offset(). Verify parsing correctness with multiple path

Re: [PATCH] libfdt/tests: Add fdt_path_offset_namelen() test

2015-04-07 Thread Peter Hurley
On 04/07/2015 07:12 AM, Peter Hurley wrote: On 04/07/2015 12:49 AM, David Gibson wrote: I did spot a case where the existing code is arguably incorrect: using fdt_path_offset_namelen(fdt, /somenode\0foo, 13) will return the same as fdt_path_offset(fdt, /somenode), although I think ideally

Re: [PATCH v6 10/15] serial: stm32-usart: Add STM32 USART Driver

2015-04-07 Thread Peter Hurley
Hi Andreas, On 04/07/2015 12:51 PM, Andreas Färber wrote: Am 07.04.2015 um 18:30 schrieb Maxime Coquelin: This drivers adds support to the STM32 USART controller, which is a standard serial driver. Tested-by: Chanwoo Choi cw00.c...@samsung.com Reviewed-by: Peter Hurley pe

Re: [PATCH V3 5/7] serial: earlycon: Set UPIO_MEM32BE based on DT properties

2015-04-06 Thread Peter Hurley
On 04/02/2015 11:35 AM, Peter Hurley wrote: On 04/02/2015 09:46 AM, Rob Herring wrote: Sorry about that. I had thought about doing the same thing. At least unifying the macros, but not necessarily the tables. If it is also extendable to other firmware interfaces like ACPI perhaps that would

Re: [PATCH] libfdt: Add fdt_path_offset_namelen()

2015-04-04 Thread Peter Hurley
On 03/13/2015 01:43 AM, David Gibson wrote: On Tue, Mar 10, 2015 at 09:47:44AM -0400, Peter Hurley wrote: Hi David, On 03/09/2015 08:17 PM, David Gibson wrote: On Fri, Mar 06, 2015 at 10:12:38AM -0500, Peter Hurley wrote: Properties may contain path names which are not NUL-terminated

Re: [PATCH] libfdt: Add fdt_path_offset_namelen()

2015-04-04 Thread Peter Hurley
On 03/13/2015 01:43 AM, David Gibson wrote: On Tue, Mar 10, 2015 at 09:47:44AM -0400, Peter Hurley wrote: Hi David, On 03/09/2015 08:17 PM, David Gibson wrote: On Fri, Mar 06, 2015 at 10:12:38AM -0500, Peter Hurley wrote: Properties may contain path names which are not NUL-terminated

[PATCH] libfdt/tests: Add fdt_path_offset_namelen() test

2015-04-04 Thread Peter Hurley
Add unit test for fdt_path_offset_namelen(). Verify partial path- descending retrieves the same node offset as fdt_subnode_offset(). Verify parsing correctness with multiple path separators, both mid-path and trailing. Signed-off-by: Peter Hurley pe...@hurleysoftware.com --- tests/Makefile.tests

Re: [PATCH v5 10/15] serial: stm32-usart: Add STM32 USART Driver

2015-04-03 Thread Peter Hurley
On 04/03/2015 01:01 PM, Maxime Coquelin wrote: This drivers adds support to the STM32 USART controller, which is a standard serial driver. Reviewed-by: Peter Hurley pe...@hurleysoftware.com PS - I saw Rob's comment about 'hw-flow-ctrl' vs 'auto-flow-control' and I'm ok with either so feel free

Re: [PATCH V3 5/7] serial: earlycon: Set UPIO_MEM32BE based on DT properties

2015-04-02 Thread Peter Hurley
On 04/02/2015 09:32 AM, Grant Likely wrote: On Sat, 28 Mar 2015 13:01:24 -0400 , Peter Hurley pe...@hurleysoftware.com wrote: Hi Grant, On 03/27/2015 09:36 PM, Grant Likely wrote: On Sun, 01 Mar 2015 17:23:11 -0500 , Peter Hurley pe...@hurleysoftware.com wrote: Hi Kevin, On 11/24

Re: [PATCH V3 5/7] serial: earlycon: Set UPIO_MEM32BE based on DT properties

2015-04-02 Thread Peter Hurley
those changes and resubmit for your review. Regards, Peter Hurley -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V3 5/7] serial: earlycon: Set UPIO_MEM32BE based on DT properties

2015-04-02 Thread Peter Hurley
Hi Kevin, On 03/28/2015 03:28 PM, Kevin Cernekee wrote: On Sat, Mar 28, 2015 at 10:01 AM, Peter Hurley pe...@hurleysoftware.com wrote: I know these got ACKs already but as you point out in the commit log, earlycon _will_ need reg-io-width, reg-offset and reg-shift. Since the distinction

Re: [PATCH V3 5/7] serial: earlycon: Set UPIO_MEM32BE based on DT properties

2015-04-02 Thread Peter Hurley
behind in that driver without breaking existing users. The idea is that an alternate 8250 driver(s) with none of the legacy baggage can be taught to share (4,64) ports with other drivers. Unfortunately, I haven't made further progress with because of other projects. Regards, Peter Hurley

Re: [PATCH V3 5/7] serial: earlycon: Set UPIO_MEM32BE based on DT properties

2015-03-28 Thread Peter Hurley
Hi Grant, On 03/27/2015 09:36 PM, Grant Likely wrote: On Sun, 01 Mar 2015 17:23:11 -0500 , Peter Hurley pe...@hurleysoftware.com wrote: Hi Kevin, On 11/24/2014 06:36 PM, Kevin Cernekee wrote: If an earlycon (stdout-path) node is being used, check for big-endian or native-endian

Re: [Gta04-owner] [PATCH 2/3] TTY: add support for tty_slave devices.

2015-03-27 Thread Peter Hurley
On 03/25/2015 05:17 PM, NeilBrown wrote: On Wed, 25 Mar 2015 12:30:00 -0400 Peter Hurley pe...@hurleysoftware.com wrote: On 03/18/2015 01:58 AM, NeilBrown wrote: + * A tty-slave is a device permanently attached to a particularly + * tty, typically wired to a UART. Why permanently

Re: [PATCH v3 10/15] serial: stm32-usart: Add STM32 USART Driver

2015-03-27 Thread Peter Hurley
doesn't really do anything right now but please use it anyway to indicate this driver has that functionality. Regards, Peter Hurley -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 1/3] TTY: use class_find_device to find port in uart_suspend/resume.

2015-03-25 Thread Peter Hurley
with tty_find_device() (and keep the function comment from tty_get_device())? Regards, Peter Hurley /** * alloc_tty_struct diff --git a/include/linux/tty.h b/include/linux/tty.h index 358a337af598..04d5f1213700 100644 --- a/include/linux/tty.h +++ b/include/linux/tty.h @@ -461,6 +461,7

Re: [PATCH 2/3] TTY: add support for tty_slave devices.

2015-03-25 Thread Peter Hurley
On 03/18/2015 01:58 AM, NeilBrown wrote: + * A tty-slave is a device permanently attached to a particularly + * tty, typically wired to a UART. Why permanently? Is that a limitation of the implementation or design? Regards, Peter Hurley -- To unsubscribe from this list: send the line

Re: [PATCH v3 10/15] serial: stm32-usart: Add STM32 USART Driver

2015-03-24 Thread Peter Hurley
Hi Maxime, On 03/24/2015 01:21 PM, Maxime Coquelin wrote: Hi Peter, 2015-03-19 18:35 GMT+01:00 Maxime Coquelin mcoquelin.st...@gmail.com: 2015-03-19 15:58 GMT+01:00 Peter Hurley pe...@hurleysoftware.com: On 03/19/2015 09:55 AM, Maxime Coquelin wrote: +static void stm32_set_termios(struct

Re: [PATCH v3 10/15] serial: stm32-usart: Add STM32 USART Driver

2015-03-24 Thread Peter Hurley
. You'll want to make sure v4 applies cleanly to Greg's tty-next branch. Regards, Peter Hurley + #endif /* _UAPILINUX_SERIAL_CORE_H */ -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [REGRESSION] of: Fix premature bootconsole disable with 'stdout-path' breaks console on tty0

2015-03-19 Thread Peter Hurley
in the specification is a barrier, and it would be helpful to your cause if Microsoft cited the patent numbers, but you could also just explain these in your cover letter at submission time. Regards, Peter Hurley -- To unsubscribe from this list: send the line unsubscribe devicetree in the body

Re: [PATCH v3 10/15] serial: stm32-usart: Add STM32 USART Driver

2015-03-19 Thread Peter Hurley
today. You have to admit that's basically an unintelligible mess; how would anyone ever be able to refactor and replace that with a common divider implementation? At the very least, please comment on the formula and format. Regards, Peter Hurley -- To unsubscribe from this list: send the line

Re: [REGRESSION] of: Fix premature bootconsole disable with 'stdout-path' breaks console on tty0

2015-03-18 Thread Peter Hurley
On 03/17/2015 08:13 PM, Jon Masters wrote: Hi Peter, On 03/17/2015 01:47 PM, Peter Hurley wrote: On 03/17/2015 12:48 PM, Jon Masters wrote: On 03/16/2015 03:46 PM, Peter Hurley wrote: On 03/16/2015 02:35 PM, Hans de Goede wrote: To be clear about my aarch64 remark, that relates

Re: [REGRESSION] of: Fix premature bootconsole disable with 'stdout-path' breaks console on tty0

2015-03-17 Thread Peter Hurley
On 03/17/2015 03:44 PM, Peter Hurley wrote: On 03/17/2015 03:35 PM, Andreas Schwab wrote: Peter Hurley pe...@hurleysoftware.com writes: It doesn't boot? It boots right into user space, but the initrd doesn't like something (perhaps the missing console) and exits. Note that the framebuffer

Re: [REGRESSION] of: Fix premature bootconsole disable with 'stdout-path' breaks console on tty0

2015-03-17 Thread Peter Hurley
Hi Jon, On 03/17/2015 12:48 PM, Jon Masters wrote: On 03/16/2015 03:46 PM, Peter Hurley wrote: On 03/16/2015 02:35 PM, Hans de Goede wrote: To be clear about my aarch64 remark, that relates to the behavior of aarch64 acpi using machines, those will also output to both a serial tty and tty0

Re: [REGRESSION] of: Fix premature bootconsole disable with 'stdout-path' breaks console on tty0

2015-03-17 Thread Peter Hurley
On 03/17/2015 03:35 PM, Andreas Schwab wrote: Peter Hurley pe...@hurleysoftware.com writes: It doesn't boot? It boots right into user space, but the initrd doesn't like something (perhaps the missing console) and exits. Note that the framebuffer console does work, but all I see

Re: [REGRESSION] of: Fix premature bootconsole disable with 'stdout-path' breaks console on tty0

2015-03-17 Thread Peter Hurley
On 03/17/2015 10:20 AM, Peter Hurley wrote: On 03/17/2015 09:43 AM, Hans de Goede wrote: Hi, On 17-03-15 14:30, Rob Herring wrote: On Tue, Mar 17, 2015 at 3:20 AM, Hans de Goede hdego...@redhat.com wrote: snip TBH I do not understand why we're even arguing here, AFAICT the behavior

[PATCH] Revert of: Fix premature bootconsole disable with 'stdout-path'

2015-03-17 Thread Peter Hurley
This reverts commit 2fa645cb2703d9b3786d850db815414dfeefa51d. The assumption that at least 1 preferred console will be registered when the stdout-path property is set is invalid, which can result in _no_ consoles. Signed-off-by: Peter Hurley pe...@hurleysoftware.com --- drivers/of/base.c | 4

Re: [REGRESSION] of: Fix premature bootconsole disable with 'stdout-path' breaks console on tty0

2015-03-17 Thread Peter Hurley
, and this is what I'm working right now. 2. Hans' use-case was _already broken_ even before this patch; _any_ driver that adds a preferred console before the vt console driver will cause this problem. So again, this needs to be fixed regardless. Regards, Peter Hurley -- To unsubscribe from this list

Re: [REGRESSION] of: Fix premature bootconsole disable with 'stdout-path' breaks console on tty0

2015-03-16 Thread Peter Hurley
On 03/16/2015 08:35 PM, Andreas Schwab wrote: Peter Hurley pe...@hurleysoftware.com writes: On 03/16/2015 08:19 PM, Andreas Schwab wrote: Peter Hurley pe...@hurleysoftware.com writes: I don't see this as a regression, but rather a misconfiguration. It breaks booting on PowerMac

Re: [REGRESSION] of: Fix premature bootconsole disable with 'stdout-path' breaks console on tty0

2015-03-16 Thread Peter Hurley
On 03/16/2015 08:19 PM, Andreas Schwab wrote: Peter Hurley pe...@hurleysoftware.com writes: I don't see this as a regression, but rather a misconfiguration. It breaks booting on PowerMac. It doesn't boot? -- To unsubscribe from this list: send the line unsubscribe devicetree in the body

Re: [REGRESSION] of: Fix premature bootconsole disable with 'stdout-path' breaks console on tty0

2015-03-16 Thread Peter Hurley
configuration changes. Regards, Peter Hurley -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [REGRESSION] of: Fix premature bootconsole disable with 'stdout-path' breaks console on tty0

2015-03-16 Thread Peter Hurley
On 03/16/2015 02:35 PM, Hans de Goede wrote: Hi, On 16-03-15 19:23, Peter Hurley wrote: On 03/16/2015 02:12 PM, Hans de Goede wrote: Hi, On 16-03-15 18:49, Peter Hurley wrote: Hi Hans, On 03/16/2015 12:31 PM, Hans de Goede wrote: Hi All, While updating my local working tree to 4.0

Re: [REGRESSION] of: Fix premature bootconsole disable with 'stdout-path' breaks console on tty0

2015-03-16 Thread Peter Hurley
On 03/16/2015 02:12 PM, Hans de Goede wrote: Hi, On 16-03-15 18:49, Peter Hurley wrote: Hi Hans, On 03/16/2015 12:31 PM, Hans de Goede wrote: Hi All, While updating my local working tree to 4.0-rc4 this morning I noticed that I no longer get console / kernel messages output

Re: [REGRESSION] of: Fix premature bootconsole disable with 'stdout-path' breaks console on tty0

2015-03-16 Thread Peter Hurley
this breakage. Regards, Peter Hurley -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: chosen/stdout-path and userland (Re: Can't boot kernel v4.0-rc2 on Koelsch)

2015-03-12 Thread Peter Hurley
, is the original reporter of this problem even interested in upgrading their userspace, even if this is fixed in Linaro eventually? What about other Linaro users? I think the only reasonable course here is to continue to support console= in /chosen/bootargs. Regards, Peter Hurley -- To unsubscribe from

Re: chosen/stdout-path and userland (Re: Can't boot kernel v4.0-rc2 on Koelsch)

2015-03-11 Thread Peter Hurley
Hi Geert, On 03/11/2015 09:23 AM, Geert Uytterhoeven wrote: Hi Peter, On Wed, Mar 11, 2015 at 2:05 PM, Peter Hurley pe...@hurleysoftware.com wrote: The first console listed is the primary console. tty0 is not resolved to its underlying tty device name. Are you sure about that? Isn't

Re: [PATCH] libfdt: Add fdt_path_offset_namelen()

2015-03-10 Thread Peter Hurley
Hi David, On 03/09/2015 08:17 PM, David Gibson wrote: On Fri, Mar 06, 2015 at 10:12:38AM -0500, Peter Hurley wrote: Properties may contain path names which are not NUL-terminated. For example, the 'stdout-path' property allows the form 'path:options', where the ':' character terminates

[PATCH] libfdt: Add fdt_path_offset_namelen()

2015-03-06 Thread Peter Hurley
limits the path name to 'namelen' characters. Reimplement fdt_path_offset() as a trivial wrapper. Signed-off-by: Peter Hurley pe...@hurleysoftware.com --- libfdt/fdt_ro.c| 22 ++ libfdt/libfdt.h| 11 +++ libfdt/version.lds | 1 + 3 files changed, 26 insertions

Re: [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path()

2015-03-06 Thread Peter Hurley
On 03/06/2015 01:11 PM, Peter Hurley wrote: On 03/06/2015 11:52 AM, Leif Lindholm wrote: [...] Could you give the below a spin, and if it works for you, send me the above tests as a full patch so that I can post both as a series? Will do as soon as I finish testing. All passed with your

Re: [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path()

2015-03-06 Thread Peter Hurley
On 03/06/2015 11:52 AM, Leif Lindholm wrote: Hi Peter, On Wed, Mar 04, 2015 at 10:45:02AM -0500, Peter Hurley wrote: The path parsing gets lost if the string after ':' contains '/'. Doh! Hardly. I only noticed because I had to implement the corresponding algorithm for earlycon and FDT

Re: [PATCH] libfdt: Teach fdt_path_offset() about ':' path separator

2015-03-05 Thread Peter Hurley
[ +cc Greg KH ] On 03/05/2015 10:23 AM, Rob Herring wrote: On Wed, Mar 4, 2015 at 10:44 AM, Peter Hurley pe...@hurleysoftware.com wrote: stdout-path defines ':' as a path separator and commit 75c28c09af99a (of: add optional options parameter to of_find_node_by_path()) added the necessary

Re: [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path()

2015-03-04 Thread Peter Hurley
option path test failed [1.365610] ### dt-test ### FAIL of_selftest_find_node_by_name():115 option alias path test failed Regards, Peter Hurley --- % --- diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 41a4a13..07ba5aa 100644 --- a/drivers/of/unittest.c +++ b/drivers

[PATCH] libfdt: Teach fdt_path_offset() about ':' path separator

2015-03-04 Thread Peter Hurley
options string support to the stdout-path property, which broke earlycon. Add the same support to fdt_path_offset() so earlycon can parse and process stdout-path properties containing an options string. Cc: Leif Lindholm leif.lindh...@linaro.org Cc: sta...@vger.kernel.org # 3.19+ Signed-off-by: Peter

Re: [PATCH V3 3/7] of: Document {little,big,native}-endian bindings

2015-03-02 Thread Peter Hurley
On 03/02/2015 09:56 AM, Kevin Cernekee wrote: On Mon, Mar 2, 2015 at 5:14 AM, Peter Hurley pe...@hurleysoftware.com wrote: On 11/24/2014 06:36 PM, Kevin Cernekee wrote: These apply to newly converted drivers, like serial8250/libahci/... The examples were adapted from the regmap bindings

Re: [PATCH V3 3/7] of: Document {little,big,native}-endian bindings

2015-03-02 Thread Peter Hurley
On 03/02/2015 11:28 AM, Kevin Cernekee wrote: On Mon, Mar 2, 2015 at 8:08 AM, Peter Hurley pe...@hurleysoftware.com wrote: On 03/02/2015 09:56 AM, Kevin Cernekee wrote: On Mon, Mar 2, 2015 at 5:14 AM, Peter Hurley pe...@hurleysoftware.com wrote: On 11/24/2014 06:36 PM, Kevin Cernekee wrote

Re: [PATCH V3 5/7] serial: earlycon: Set UPIO_MEM32BE based on DT properties

2015-03-01 Thread Peter Hurley
be permanently stuck with the 'big-endian' property == UPIO_MEM32BE which could impact future designs. [/rant] Regards, Peter Hurley return 0; } return -ENODEV; diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c index a514ee6..548f7d7 100644

[PATCH] of: Fix premature bootconsole disable with 'stdout-path'

2015-03-01 Thread Peter Hurley
. Requires: console: Fix console name size mismatch Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Peter Hurley pe...@hurleysoftware.com --- drivers/of/base.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index 36536b6..83dc8a6

Re: [PATCH -next 00/13] Extensible console matching direct earlycon

2015-03-01 Thread Peter Hurley
[ +cc devicetree, Mark Rutland, Grant Likely ] On 02/26/2015 09:58 AM, Rob Herring wrote: On Thu, Feb 26, 2015 at 8:48 AM, Peter Hurley pe...@hurleysoftware.com wrote: Hi Rob, On 02/24/2015 03:20 PM, Rob Herring wrote: On Tue, Feb 24, 2015 at 1:53 PM, Peter Hurley pe...@hurleysoftware.com

Re: [PATCH v3 3/3] of: support passing console options with stdout-path

2015-02-26 Thread Peter Hurley
Hi Andrew, On 02/26/2015 08:46 AM, Andrew Lunn wrote: On Thu, Feb 26, 2015 at 06:55:22AM -0500, Peter Hurley wrote: On 11/27/2014 12:56 PM, Leif Lindholm wrote: Support specifying console options (like with console=ttyXN,options) by appending them to the stdout-path property after

Re: [PATCH v3 3/3] of: support passing console options with stdout-path

2015-02-26 Thread Peter Hurley
recognize ':' as a path terminator. It's simple enough to fix this directly in early_init_dt_scan_chosen_serial() but perhaps it would better to teach fdt_path_offset() to recognize ':'? Regards, Peter Hurley Signed-off-by: Leif Lindholm leif.lindh...@linaro.org --- drivers/of/base.c |9

Re: [PATCH 3/4] arm: am33xx: DT quirks for am33xx based beaglebone variants

2015-02-23 Thread Peter Hurley
/arch/arm/mach-omap2/am33xx-dt-quirks.c [...] + * Note that we rely on the bootloader setting up the muxes + * (which is the case for u-boot). Regards, Peter Hurley -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 2/4] of: DT quirks infrastructure

2015-02-20 Thread Peter Hurley
On 02/19/2015 09:41 AM, Pantelis Antoniou wrote: Hi Frank, On Feb 19, 2015, at 04:08 , Frank Rowand frowand.l...@gmail.com wrote: On 2/18/2015 6:59 AM, Pantelis Antoniou wrote: Implement a method of applying DT quirks early in the boot sequence. A DT quirk is a subtree of the boot DT that

Re: [PATCH 2/4] of: DT quirks infrastructure

2015-02-20 Thread Peter Hurley
, your QA process will not change at all == same cost. Regards, Peter Hurley -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/4] of: DT quirks infrastructure

2015-02-20 Thread Peter Hurley
On 02/20/2015 09:35 AM, Ludovic Desroches wrote: On Fri, Feb 20, 2015 at 09:21:38AM -0500, Peter Hurley wrote: On 02/19/2015 12:38 PM, Pantelis Antoniou wrote: On Feb 19, 2015, at 19:30 , Frank Rowand frowand.l...@gmail.com wrote: On 2/19/2015 9:00 AM, Pantelis Antoniou wrote: Hi Frank

Re: [PATCH 2/4] of: DT quirks infrastructure

2015-02-20 Thread Peter Hurley
On 02/20/2015 10:02 AM, Pantelis Antoniou wrote: Hi Peter, On Feb 20, 2015, at 17:00 , Peter Hurley pe...@hurleysoftware.com wrote: On 02/20/2015 09:35 AM, Ludovic Desroches wrote: On Fri, Feb 20, 2015 at 09:21:38AM -0500, Peter Hurley wrote: On 02/19/2015 12:38 PM, Pantelis Antoniou wrote

Re: [PATCH 2/4] of: DT quirks infrastructure

2015-02-20 Thread Peter Hurley
On 02/20/2015 10:38 AM, Pantelis Antoniou wrote: Hi Peter, On Feb 20, 2015, at 17:24 , Peter Hurley pe...@hurleysoftware.com wrote: On 02/20/2015 10:02 AM, Pantelis Antoniou wrote: Hi Peter, On Feb 20, 2015, at 17:00 , Peter Hurley pe...@hurleysoftware.com wrote: On 02/20/2015 09:35 AM

Re: [PATCH 2/4] of: DT quirks infrastructure

2015-02-20 Thread Peter Hurley
with 4GB eMMC/microSD so naturally the argument for space-savings with DTBs doesn't fly. That has since been clarified so no need to rehash that. Regards, Peter Hurley -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2 1/4] tty: serial: Add 8250 earlycon to support noinit option

2015-02-01 Thread Peter Hurley
the ttyS console will expect line settings for console match. Regards, Peter Hurley Signed-off-by: Eddie Huang eddie.hu...@mediatek.com --- drivers/tty/serial/8250/8250_early.c | 7 --- drivers/tty/serial/earlycon.c| 17 - include/linux/serial_8250.h | 2

Re: [PATCH v2 1/4] tty: serial: Add 8250 earlycon to support noinit option

2015-02-01 Thread Peter Hurley
On 02/01/2015 11:27 AM, Peter Hurley wrote: Hi Eddie, On 01/12/2015 08:08 AM, Eddie Huang wrote: Add earlycon support not only baudrate option, but also add noinit option. If use noinit option, 8250 earlycon will not init serial hardware and use loader setting. I see this went

Re: [PATCH v2 1/4] tty: serial: Add 8250 earlycon to support noinit option

2015-02-01 Thread Peter Hurley
On 02/01/2015 10:16 PM, Eddie Huang wrote: Hi Peter, On Sun, 2015-02-01 at 13:26 -0500, Peter Hurley wrote: On 02/01/2015 11:27 AM, Peter Hurley wrote: Hi Eddie, On 01/12/2015 08:08 AM, Eddie Huang wrote: Add earlycon support not only baudrate option, but also add noinit option. If use

Re: [PATCH v2 1/4] tty: serial: Add 8250 earlycon to support noinit option

2015-02-01 Thread Peter Hurley
On 02/01/2015 09:45 PM, Eddie Huang wrote: Hi Peter, On Sun, 2015-02-01 at 11:27 -0500, Peter Hurley wrote: Hi Eddie, On 01/12/2015 08:08 AM, Eddie Huang wrote: Add earlycon support not only baudrate option, but also add noinit option. If use noinit option, 8250 earlycon will not init

Re: [PATCH v2 1/4] tty: serial: Add 8250 earlycon to support noinit option

2015-02-01 Thread Peter Hurley
On 02/02/2015 12:33 AM, Eddie Huang wrote: Hi Peter, On Sun, 2015-02-01 at 21:24 -0800, Greg Kroah-Hartman wrote: On Mon, Feb 02, 2015 at 12:15:31AM -0500, Peter Hurley wrote: On 02/01/2015 11:28 PM, Greg Kroah-Hartman wrote: On Sun, Feb 01, 2015 at 10:45:12PM -0500, Peter Hurley wrote

Re: [PATCH v2 1/4] tty: serial: Add 8250 earlycon to support noinit option

2015-02-01 Thread Peter Hurley
On 02/01/2015 11:28 PM, Greg Kroah-Hartman wrote: On Sun, Feb 01, 2015 at 10:45:12PM -0500, Peter Hurley wrote: On 02/01/2015 10:16 PM, Eddie Huang wrote: I'll respin proper patches on top of Greg's tty-testing branch with reverts for the noinit options. I noticed that one of the noinit

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-30 Thread Peter Hurley
On 01/30/2015 09:08 AM, Russell King - ARM Linux wrote: On Fri, Jan 30, 2015 at 07:03:03AM -0500, Peter Hurley wrote: On 01/30/2015 05:18 AM, Thierry Reding wrote: -ENODEV is certainly not the correct return value if a resource is not available. It translates to no such device, but the device

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-30 Thread Peter Hurley
On 01/30/2015 10:49 AM, Russell King - ARM Linux wrote: On Fri, Jan 30, 2015 at 10:32:54AM -0500, Peter Hurley wrote: Before you say consistency, I think you should look at the stats below. IOW, if you want to change the error code return from probe() for consistency's sake, a tree-wide patch

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-30 Thread Peter Hurley
On 01/30/2015 05:18 AM, Thierry Reding wrote: On Thu, Jan 29, 2015 at 04:05:53PM +, Russell King - ARM Linux wrote: On Thu, Jan 29, 2015 at 10:49:34AM -0500, Peter Hurley wrote: Hi Varka, On 01/29/2015 10:26 AM, Varka Bhadram wrote: This check is not required. It will be done

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-29 Thread Peter Hurley
On 01/29/2015 11:05 AM, Russell King - ARM Linux wrote: On Thu, Jan 29, 2015 at 10:49:34AM -0500, Peter Hurley wrote: Hi Varka, On 01/29/2015 10:26 AM, Varka Bhadram wrote: This check is not required. It will be done by devm_ioremap_resource() I disagree. devm_ioremap_resource() interprets

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-29 Thread Peter Hurley
@spreadtrum.com Signed-off-by: Orson Zhai orson.z...@spreadtrum.com Signed-off-by: Chunyan Zhang chunyan.zh...@spreadtrum.com Acked-by: Arnd Bergmann a...@arndb.de Reviewed-by: Peter Hurley pe...@hurleysoftware.com --- drivers/tty/serial/Kconfig | 18 + drivers/tty/serial/Makefile

Re: [PATCH v10 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-29 Thread Peter Hurley
On 01/29/2015 11:04 AM, Varka Bhadram wrote: Hi Peter, On Thursday 29 January 2015 09:19 PM, Peter Hurley wrote: Hi Varka, On 01/29/2015 10:26 AM, Varka Bhadram wrote: Hi, On Wednesday 28 January 2015 04:38 PM, Chunyan Zhang wrote: Add a full sc9836-uart driver for SC9836 SoC which

Re: [PATCH v8 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-27 Thread Peter Hurley
Hi Chunyan, Minor but important fixes below. And for the v9 version, please only use To: for Greg Kroah-Hartman gre...@linuxfoundation.org All other recipients should only be Cc: Regards, Peter Hurley On 01/27/2015 02:56 AM, Chunyan Zhang wrote: Add a full sc9836-uart driver for SC9836 SoC

Re: [PATCH v9 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-27 Thread Peter Hurley
On 01/27/2015 09:47 PM, Chunyan Zhang wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. Reviewed-by: Peter Hurley pe...@hurleysoftware.com -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v7 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-23 Thread Peter Hurley
Hi Chunyan, Just the minor fix to zeroing the stack local in sprd_set_termios() and using dev_get_drvdata() in sprd_suspend()/sprd_resume(). Regards, Peter Hurley On 01/23/2015 08:01 AM, Chunyan Zhang wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum

Re: [PATCH v6 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-23 Thread Peter Hurley
On 01/23/2015 02:23 AM, Lyra Zhang wrote: Hi, Peter Many thanks to you for reviewing so carefully and giving us so many suggestions and so clear explanations. :) I'll address all of your comments and send an updated patch soon. On Fri, Jan 23, 2015 at 11:57 AM, Peter Hurley pe

Re: [PATCH v6 2/2] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-22 Thread Peter Hurley
Hi Chunyan, On 01/22/2015 08:35 AM, Chunyan Zhang wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. Looking good. Comments below. This patch also replaced the spaces between the macros and their values

Re: [PATCH v5 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2015-01-16 Thread Peter Hurley
across suspend/resume? The serial core calls your set_termios() handler upon resume (either for the console or if a tty is open) so you should be reprogramming the hardware there based on the termios settings. Regards, Peter Hurley + + uart_suspend_port(sprd_uart_driver, port

Re: [PATCH 1/3] TTY: add support for tty slave devices.

2014-12-16 Thread Peter Hurley
for the functionality you describe but I think that design will end up subsystem-agnostic. Regards, Peter Hurley -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] TTY: add slave driver to power-on device via a regulator.

2014-12-12 Thread Peter Hurley
On 12/12/2014 12:27 AM, NeilBrown wrote: On Thu, 11 Dec 2014 18:32:52 -0500 Peter Hurley pe...@hurleysoftware.com wrote: On 12/11/2014 04:59 PM, NeilBrown wrote: The regulator is identified in devicetree as 'vdd-supply' Signed-off-by: NeilBrown ne...@suse.de tty_* is only for tty core

Re: [PATCH 1/3] TTY: add support for tty slave devices.

2014-12-12 Thread Peter Hurley
On 12/12/2014 12:23 AM, NeilBrown wrote: On Thu, 11 Dec 2014 18:18:37 -0500 Peter Hurley pe...@hurleysoftware.com wrote: On 12/11/2014 04:59 PM, NeilBrown wrote: A tty slave is a device connected via UART. It may need a driver to, for example, power the device on when the tty is opened

Re: [PATCH 1/3] TTY: add support for tty slave devices.

2014-12-11 Thread Peter Hurley
device imply power management and a platform device? iow, what happens when someone else wants to have a child device that does something different? 2) why is this tied to the tty core and not the serial core if this is only for UART? Regards, Peter Hurley Signed-off-by: NeilBrown ne

  1   2   >