Re: [PATCH linux-next 1/5] mtd: spi-nor: properly detect the memory when it boots in Quad or Dual mode

2016-01-04 Thread Cyrille Pitchen
Hi Brian, Le 18/12/2015 02:55, Brian Norris a écrit : > Hi Cyrille, > > On Mon, Dec 07, 2015 at 03:09:10PM +0100, Cyrille Pitchen wrote: [...] >> + >> +/* Set this protocol for all commands. */ >> +nor->reg_proto = configs[i].proto; >> +

Re: [PATCH linux-next 1/5] mtd: spi-nor: properly detect the memory when it boots in Quad or Dual mode

2015-12-18 Thread Cyrille Pitchen
Hi Brian, I will be on vacation till 2016 January, 4th. I will try to answer your questions as soon as possible. Best regards, Cyrille Le 18/12/2015 02:55, Brian Norris a écrit : > Hi Cyrille, > > On Mon, Dec 07, 2015 at 03:09:10PM +0100, Cyrille Pitchen wrote: >> The quad (or dual) mode of a

Re: [PATCH linux-next 1/5] mtd: spi-nor: properly detect the memory when it boots in Quad or Dual mode

2015-12-17 Thread Brian Norris
(Hit send too early; a few more comments) On Mon, Dec 07, 2015 at 03:09:10PM +0100, Cyrille Pitchen wrote: > drivers/mtd/spi-nor/spi-nor.c | 52 > +++ > include/linux/mtd/spi-nor.h | 23 +-- > 2 files changed, 69 insertions(+), 6 deletion

Re: [PATCH linux-next 1/5] mtd: spi-nor: properly detect the memory when it boots in Quad or Dual mode

2015-12-17 Thread Brian Norris
Hi Cyrille, On Mon, Dec 07, 2015 at 03:09:10PM +0100, Cyrille Pitchen wrote: > The quad (or dual) mode of a spi-nor memory may be enabled at boot time by > non-volatile bits in some setting register. Also such a mode may have > already been enabled at early stage by some boot loader. > > Hence, w

[PATCH linux-next 1/5] mtd: spi-nor: properly detect the memory when it boots in Quad or Dual mode

2015-12-07 Thread Cyrille Pitchen
The quad (or dual) mode of a spi-nor memory may be enabled at boot time by non-volatile bits in some setting register. Also such a mode may have already been enabled at early stage by some boot loader. Hence, we should not guess the spi-nor memory is always configured for the regular SPI 1-1-1 pro