Re: [PATCH v10 03/10] qcom: spm: Add Subsystem Power Manager driver

2014-11-26 Thread Stephen Boyd
On 11/21/2014 10:03 AM, Lina Iyer wrote: + +static const struct platform_device_info qcom_cpuidle_info = { nitpick, why two spaces between info and qcom here? + .name = "qcom_cpuidle", + .id = -1, + .data = &lpm_ops, + .size_data = sizeof(lpm_ops), +}; This st

[PATCH v10 03/10] qcom: spm: Add Subsystem Power Manager driver

2014-11-21 Thread Lina Iyer
SPM is a hardware block that controls the peripheral logic surrounding the application cores (cpu/l$). When the core executes WFI instruction, the SPM takes over the putting the core in low power state as configured. The wake up for the SPM is an interrupt at the GIC, which then completes the rest