Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-12-03 Thread Lyra Zhang
2014-12-03 17:50 GMT+08:00 Arnd Bergmann : > On Wednesday 03 December 2014 17:17:13 Lyra Zhang wrote: > >> 2014-11-27 2:29 GMT+08:00 Murali Karicheri : >> > How about sorting this includes? asm/irq.h go first followed linux/ in >> > alphabatical order? >> >> There are a few compile warnings if I m

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-12-03 Thread Lyra Zhang
2014-12-03 18:11 GMT+08:00 Russell King - ARM Linux : > On Wed, Dec 03, 2014 at 10:50:17AM +0100, Arnd Bergmann wrote: >> On Wednesday 03 December 2014 17:17:13 Lyra Zhang wrote: >> >> > 2014-11-27 2:29 GMT+08:00 Murali Karicheri : >> > > How about sorting this includes? asm/irq.h go first followed

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-12-03 Thread Russell King - ARM Linux
On Wed, Dec 03, 2014 at 10:50:17AM +0100, Arnd Bergmann wrote: > On Wednesday 03 December 2014 17:17:13 Lyra Zhang wrote: > > > 2014-11-27 2:29 GMT+08:00 Murali Karicheri : > > > How about sorting this includes? asm/irq.h go first followed linux/ in > > > alphabatical order? > > > > There are a f

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-12-03 Thread Arnd Bergmann
On Wednesday 03 December 2014 17:17:13 Lyra Zhang wrote: > 2014-11-27 2:29 GMT+08:00 Murali Karicheri : > > How about sorting this includes? asm/irq.h go first followed linux/ in > > alphabatical order? > > There are a few compile warnings if I moved asm/irq.h to the top of > all included files.

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-12-03 Thread Lyra Zhang
2014-11-27 2:29 GMT+08:00 Murali Karicheri : > > On 11/25/2014 07:16 AM, Chunyan Zhang wrote: >> >> Add a full sc9836-uart driver for SC9836 SoC which is based on the >> spreadtrum sharkl64 platform. >> This driver also support earlycon. >> >> [...] >> >> +++ b/drivers/tty/serial/sprd_serial.c >>

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-11-28 Thread Orson Zhai
Hi, Alan, Thanks for your comments! Some question for them below, On 2014年11月26日 20:33, One Thousand Gnomes wrote: +213 = /dev/ttySPX0 SPRD serial port 0 + ... +216 = /dev/ttySPX3 SPRD serial port 3 Please use dynamic al

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-11-27 Thread Arnd Bergmann
On Thursday 27 November 2014 23:23:17 Lyra Zhang wrote: > > Yes, I saw this way in other serial drivers. > But, if then, there are two questions for me: > 1. Why did some serial drivers need an UN_SHARED irq? A lot of drivers were written before we had shared IRQs, or were copied from old drivers

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-11-27 Thread One Thousand Gnomes
> Yes, I saw this way in other serial drivers. > But, if then, there are two questions for me: > 1. Why did some serial drivers need an UN_SHARED irq? > 2. How can we choose a right way? If your hardware can support sharing an IRQ then shared is the right way - along with the test Arnd suggested.

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-11-27 Thread Lyra Zhang
2014-11-27 20:57 GMT+08:00 Arnd Bergmann : > On Thursday 27 November 2014 19:59:46 Lyra Zhang wrote: >> 2014-11-27 2:29 GMT+08:00 Murali Karicheri : >> > On 11/25/2014 07:16 AM, Chunyan Zhang wrote: >> >> >> >> Add a full sc9836-uart driver for SC9836 SoC which is based on the >> >> >> +#include >>

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-11-27 Thread Arnd Bergmann
On Thursday 27 November 2014 19:59:46 Lyra Zhang wrote: > 2014-11-27 2:29 GMT+08:00 Murali Karicheri : > > On 11/25/2014 07:16 AM, Chunyan Zhang wrote: > >> > >> Add a full sc9836-uart driver for SC9836 SoC which is based on the > > >> +#include > > > > How about sorting this includes? asm/irq.h g

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-11-27 Thread Lyra Zhang
2014-11-27 2:29 GMT+08:00 Murali Karicheri : > On 11/25/2014 07:16 AM, Chunyan Zhang wrote: >> >> Add a full sc9836-uart driver for SC9836 SoC which is based on the >> +#include > > How about sorting this includes? asm/irq.h go first followed linux/ in > alphabatical order? >> +static irqreturn_t

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-11-27 Thread Lyra Zhang
2014-11-26 17:48 GMT+08:00 Tobias Klauser : > On 2014-11-25 at 13:16:58 +0100, Chunyan Zhang > wrote: >> --- [...] >> + >> +config SERIAL_SPRD_CONSOLE >> +bool "SPRD UART console support" >> +depends on SERIAL_SPRD=y >> +select SERIAL_CORE_CONSOLE >> + select SERIAL_E

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-11-27 Thread Lyra Zhang
2014-11-26 4:03 GMT+08:00 Greg KH : > On Tue, Nov 25, 2014 at 08:16:58PM +0800, Chunyan Zhang wrote: >> Add a full sc9836-uart driver for SC9836 SoC which is based on the >> spreadtrum sharkl64 platform. >> This driver also support earlycon. >> >> Signed-off-by: Chunyan Zhang >> Signed-off-by: Ors

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-11-26 Thread Murali Karicheri
On 11/25/2014 07:16 AM, Chunyan Zhang wrote: Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. Signed-off-by: Chunyan Zhang Signed-off-by: Orson Zhai Originally-by: Lanqing Liu --- Documentation/devices.txt

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-11-26 Thread One Thousand Gnomes
> + 213 = /dev/ttySPX0 SPRD serial port 0 > + ... > + 216 = /dev/ttySPX3 SPRD serial port 3 Please use dynamic allocation or give a very very good reason why you can't > +config SERIAL_SPRD_NR > +int "Maximum number of sprd

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-11-26 Thread Tobias Klauser
On 2014-11-25 at 13:16:58 +0100, Chunyan Zhang wrote: > Add a full sc9836-uart driver for SC9836 SoC which is based on the > spreadtrum sharkl64 platform. > This driver also support earlycon. > > Signed-off-by: Chunyan Zhang > Signed-off-by: Orson Zhai > Originally-by: Lanqing Liu > --- > Do

Re: [PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-11-25 Thread Greg KH
On Tue, Nov 25, 2014 at 08:16:58PM +0800, Chunyan Zhang wrote: > Add a full sc9836-uart driver for SC9836 SoC which is based on the > spreadtrum sharkl64 platform. > This driver also support earlycon. > > Signed-off-by: Chunyan Zhang > Signed-off-by: Orson Zhai > Originally-by: Lanqing Liu Som

[PATCH v3 5/5] tty/serial: Add Spreadtrum sc9836-uart driver support

2014-11-25 Thread Chunyan Zhang
Add a full sc9836-uart driver for SC9836 SoC which is based on the spreadtrum sharkl64 platform. This driver also support earlycon. Signed-off-by: Chunyan Zhang Signed-off-by: Orson Zhai Originally-by: Lanqing Liu --- Documentation/devices.txt|3 + drivers/tty/serial/Kconfig