Re: [PATCH RFC 3/3] Altera TSE: Add Altera Triple Speed Ethernet (TSE) Driver

2014-03-09 Thread Ben Hutchings
On Sun, 2014-03-02 at 14:42 -0600, Vince Bridgers wrote: [] --- /dev/null +++ b/drivers/net/ethernet/altera/altera_msgdma.c [...] +void msgdma_reset(struct altera_tse_private *priv) +{ + int counter; + struct msgdma_csr *txcsr = + (struct msgdma_csr

RE: [PATCH RFC 3/3] Altera TSE: Add Altera Triple Speed Ethernet (TSE) Driver

2014-03-04 Thread David Laight
From: Of Vince Bridgers Hello Florian, thank you for taking the time to comments. My responses inline. On Sun, Mar 2, 2014 at 6:59 PM, Florian Fainelli f.faine...@gmail.com wrote: Hello Vince, It might help reviewing the patches by breaking the patches into: - the SGDMA bits - the

Re: [PATCH RFC 3/3] Altera TSE: Add Altera Triple Speed Ethernet (TSE) Driver

2014-03-03 Thread Vince Bridgers
Hello Florian, thank you for taking the time to comments. My responses inline. On Sun, Mar 2, 2014 at 6:59 PM, Florian Fainelli f.faine...@gmail.com wrote: Hello Vince, It might help reviewing the patches by breaking the patches into: - the SGDMA bits - the MSGDMA bits - the Ethernet MAC

Re: [PATCH RFC 3/3] Altera TSE: Add Altera Triple Speed Ethernet (TSE) Driver

2014-03-03 Thread Florian Fainelli
2014-03-03 10:21 GMT-08:00 Vince Bridgers vbridgers2...@gmail.com: Hello Florian, thank you for taking the time to comments. My responses inline. On Sun, Mar 2, 2014 at 6:59 PM, Florian Fainelli f.faine...@gmail.com wrote: Hello Vince, It might help reviewing the patches by breaking the

Re: [PATCH RFC 3/3] Altera TSE: Add Altera Triple Speed Ethernet (TSE) Driver

2014-03-03 Thread Vince Bridgers
On Mon, Mar 3, 2014 at 12:38 PM, Florian Fainelli f.faine...@gmail.com wrote: 2014-03-03 10:21 GMT-08:00 Vince Bridgers vbridgers2...@gmail.com: Hello Florian, thank you for taking the time to comments. My responses inline. On Sun, Mar 2, 2014 at 6:59 PM, Florian Fainelli

Re: [PATCH RFC 3/3] Altera TSE: Add Altera Triple Speed Ethernet (TSE) Driver

2014-03-02 Thread Florian Fainelli
Hello Vince, It might help reviewing the patches by breaking the patches into: - the SGDMA bits - the MSGDMA bits - the Ethernet MAC driver per-se BTW, it does look like the SGDMA code could/should be a dmaengine driver? Le 02/03/2014 12:42, Vince Bridgers a écrit : [snip] +