Re: [PATCH 2/4] of: Add support for linking device tree blobs into vmlinux

2010-11-15 Thread Dirk Brandewie
On 11/13/2010 09:25 PM, Grant Likely wrote: On Thu, Nov 11, 2010 at 04:03:48PM -0800, dirk.brande...@gmail.com wrote: From: Dirk Brandewie This patch adds support for linking device tree blobs into vmlinux. The device tree blobs are placed in the init.data section. Signed-off-by: Dirk Brandewi

Re: [PATCH 2/2] powerpc: pcm030/032: add pagesize to dts

2010-11-15 Thread Anton Vorontsov
On Mon, Nov 15, 2010 at 06:25:16PM +0100, Wolfram Sang wrote: > Signed-off-by: Wolfram Sang > --- > arch/powerpc/boot/dts/pcm030.dts |1 + > arch/powerpc/boot/dts/pcm032.dts |3 ++- > 2 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/boot/dts/pcm030.dts > b/

Re: [PATCH 3/3] x86: OLPC: speed up device tree creation during boot (v2)

2010-11-15 Thread H. Peter Anvin
On 11/14/2010 11:02 PM, Ingo Molnar wrote: > > * H. Peter Anvin wrote: > >> What? What is wrong with static variables in functions? It really doesn't >> seem >> to be a good idea to make them file-scope if they don't need to be. > > They are very easy to overlook and mix up with regular sta

[PATCH 2/2] powerpc: pcm030/032: add pagesize to dts

2010-11-15 Thread Wolfram Sang
Signed-off-by: Wolfram Sang --- arch/powerpc/boot/dts/pcm030.dts |1 + arch/powerpc/boot/dts/pcm032.dts |3 ++- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/boot/dts/pcm030.dts b/arch/powerpc/boot/dts/pcm030.dts index 8a4ec30..e7c36bc 100644 --- a/arch/power

[PATCH 1/2] misc: at24: parse OF-data, too

2010-11-15 Thread Wolfram Sang
Information about the pagesize and read-only-status may also come from the devicetree. Parse this data, too, and act accordingly. While we are here, change the initialization printout a bit. write_max is useful to know to detect performance bottlenecks, the rest is superfluous. Signed-off-by: Wolf

Re: [PATCH 2/2] powerpc: pcm030/032: add pagesize to dts

2010-11-15 Thread Mitch Bradley
On 11/15/2010 7:32 AM, Anton Vorontsov wrote: On Mon, Nov 15, 2010 at 06:25:16PM +0100, Wolfram Sang wrote: Signed-off-by: Wolfram Sang --- arch/powerpc/boot/dts/pcm030.dts |1 + arch/powerpc/boot/dts/pcm032.dts |3 ++- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/a

Re: [PATCH 2/2] powerpc: pcm030/032: add pagesize to dts

2010-11-15 Thread Anton Vorontsov
On Mon, Nov 15, 2010 at 11:06:44AM -1000, Mitch Bradley wrote: [...] > >>eep...@52 { > >>compatible = "catalyst,24c32"; > >>reg =<0x52>; > >>+ pagesize =<32>; > > > >I think you'd better drop the p

Re: [sodaville] [PATCH 2/4] of: Add support for linking device tree blobs into vmlinux

2010-11-15 Thread H. Peter Anvin
On 11/15/2010 08:37 AM, Dirk Brandewie wrote: >> >> To match other definitions in this file, this should be defined with >> parentheses: #define KERNEL_DTB() >> >>> + . = ALIGN(32); \ >>> + VMLINUX_SYMBOL(__dtb_start) = .;

Re: [PATCH 1/2] misc: at24: parse OF-data, too

2010-11-15 Thread Grant Likely
On Mon, Nov 15, 2010 at 10:25 AM, Wolfram Sang wrote: > Information about the pagesize and read-only-status may also come from > the devicetree. Parse this data, too, and act accordingly. While we are > here, change the initialization printout a bit. write_max is useful to > know to detect perform

Re: [PATCH 2/2] powerpc: pcm030/032: add pagesize to dts

2010-11-15 Thread Grant Likely
On Mon, Nov 15, 2010 at 2:24 PM, Anton Vorontsov wrote: > On Mon, Nov 15, 2010 at 11:06:44AM -1000, Mitch Bradley wrote: > [...] >> >>                    eep...@52 { >> >>                            compatible = "catalyst,24c32"; >> >>                            reg =<0x52>; >> >>+                

Re: [PATCH 2/2] powerpc: pcm030/032: add pagesize to dts

2010-11-15 Thread Mitch Bradley
In general I think it's better to report parameter values directly, instead of inferring them from manufacturer and part numbers. That way you at least have a fighting chance of avoiding a kernel upgrade when a part changes. Of course, that only works when the device tree is exported from the

Re: [PATCH 2/2] powerpc: pcm030/032: add pagesize to dts

2010-11-15 Thread Wolfram Sang
> > >I think you'd better drop the pagesize property altogether, and > > >instead make the compatible string more specific (if needed at > > >all. are there any 'catalyst,24c32' chips with pagesize != 32?) > > > > Microchip makes a 24c32 part that looks pretty similar to the > > catalyst part, but

Re: [PATCH 2/2] powerpc: pcm030/032: add pagesize to dts

2010-11-15 Thread David Gibson
On Mon, Nov 15, 2010 at 12:17:51PM -1000, Mitch Bradley wrote: > In general I think it's better to report parameter values directly, > instead of inferring them from manufacturer and part numbers. That > way you at least have a fighting chance of avoiding a kernel upgrade > when a part changes. I

Re: Device tree with early buffer allocations and aliased memory

2010-11-15 Thread David VomLehn
On Tue, Nov 09, 2010 at 10:25:37PM -0600, Grant Likely wrote: > On Wed, Nov 03, 2010 at 01:50:37PM -0700, David VomLehn wrote: ... > Further note: The memory node must only contain memory ranges that > will actually be used by the operating system as system RAM. If it is > dedicated to DMA buffer

Re: [PATCH 4/4] of/fdt: add kernel command line option for dtb_compat string

2010-11-15 Thread H. Peter Anvin
On 11/13/2010 10:22 PM, Grant Likely wrote: > > 'char' is completely bogus in this context. Either void or struct > boot_param_header would be more accurate and useful. I believe you > can do: > > extern void __dtb_start; > extern_void __dtb_end; > > And then reference the addresse

[PATCH 0/2] Adding DTB's to architecture independent vmlinux

2010-11-15 Thread dirk . brandewie
From: Dirk Brandewie This patch set adds support for linking an arbitrary number of device tree blobs into the kernel image and allow passing the "compatible" string for the platform on the kernel command line. Patch 1/2: modifies asm-generic/vmlinux.lds.h to add linking .dtb.init.rodata section

[PATCH 1/2] of: Add support for linking device tree blobs into vmlinux

2010-11-15 Thread dirk . brandewie
From: Dirk Brandewie This patch adds support for linking device tree blobs into vmlinux. The device tree blobs are placed in the init.data section. Signed-off-by: Dirk Brandewie --- include/asm-generic/vmlinux.lds.h | 19 +-- scripts/Makefile.lib | 17 +

[PATCH 2/2] of/fdt: add kernel command line option for dtb_compat string

2010-11-15 Thread dirk . brandewie
From: Dirk Brandewie Add support for specifying a "compatible" string from the kernel command line and functions for the platform to find the compatible blob present in the kernel image if any. Signed-off-by: Dirk Brandewie --- Documentation/kernel-parameters.txt |7 drivers/of/fdt.c

Re: [PATCH 1/2] of: Add support for linking device tree blobs into vmlinux

2010-11-15 Thread Grant Likely
On Mon, Nov 15, 2010 at 08:01:20PM -0800, dirk.brande...@gmail.com wrote: > From: Dirk Brandewie > > This patch adds support for linking device tree blobs into > vmlinux. The device tree blobs are placed in the init.data > section. > > Signed-off-by: Dirk Brandewie > --- > include/asm-generic/

Re: [PATCH 1/2] of: Add support for linking device tree blobs into vmlinux

2010-11-15 Thread Dirk Brandewie
On 11/15/2010 08:41 PM, Grant Likely wrote: On Mon, Nov 15, 2010 at 08:01:20PM -0800, dirk.brande...@gmail.com wrote: From: Dirk Brandewie This patch adds support for linking device tree blobs into vmlinux. The device tree blobs are placed in the init.data section. Signed-off-by: Dirk Brandewi

Re: [PATCH 1/2] of: Add support for linking device tree blobs into vmlinux

2010-11-15 Thread Grant Likely
On Mon, Nov 15, 2010 at 10:06 PM, Dirk Brandewie wrote: > On 11/15/2010 08:41 PM, Grant Likely wrote: >> >> On Mon, Nov 15, 2010 at 08:01:20PM -0800, dirk.brande...@gmail.com wrote: >>> >>> From: Dirk Brandewie >>> >>> This patch adds support for linking device tree blobs into >>> vmlinux. The dev

Re: [PATCH 1/2] of: Add support for linking device tree blobs into vmlinux

2010-11-15 Thread Dirk Brandewie
On 11/15/2010 09:17 PM, Grant Likely wrote: On Mon, Nov 15, 2010 at 10:06 PM, Dirk Brandewie wrote: On 11/15/2010 08:41 PM, Grant Likely wrote: On Mon, Nov 15, 2010 at 08:01:20PM -0800, dirk.brande...@gmail.com wrote: From: Dirk Brandewie This patch adds support for linking device tree bl

Re: [PATCH 1/2] of: Add support for linking device tree blobs into vmlinux

2010-11-15 Thread Grant Likely
On Mon, Nov 15, 2010 at 10:28 PM, Dirk Brandewie wrote: > On 11/15/2010 09:17 PM, Grant Likely wrote: >> >> On Mon, Nov 15, 2010 at 10:06 PM, Dirk Brandewie >>  wrote: >>> >>> On 11/15/2010 08:41 PM, Grant Likely wrote: On Mon, Nov 15, 2010 at 08:01:20PM -0800, dirk.brande...@gmail.com

Re: [PATCH 2/2] of/fdt: add kernel command line option for dtb_compat string

2010-11-15 Thread Grant Likely
On Mon, Nov 15, 2010 at 08:01:21PM -0800, dirk.brande...@gmail.com wrote: > From: Dirk Brandewie > > Add support for specifying a "compatible" string from the kernel > command line and functions for the platform to find the compatible > blob present in the kernel image if any. > > Signed-off-by:

Re: [PATCH 4/4] of/fdt: add kernel command line option for dtb_compat string

2010-11-15 Thread Grant Likely
On Mon, Nov 15, 2010 at 04:27:06PM -0800, H. Peter Anvin wrote: > On 11/13/2010 10:22 PM, Grant Likely wrote: > > > > 'char' is completely bogus in this context. Either void or struct > > boot_param_header would be more accurate and useful. I believe you > > can do: > > > > extern void __dt

Re: Device tree with early buffer allocations and aliased memory

2010-11-15 Thread Grant Likely
On Mon, Nov 15, 2010 at 03:10:08PM -0800, David VomLehn wrote: > On Tue, Nov 09, 2010 at 10:25:37PM -0600, Grant Likely wrote: > > On Wed, Nov 03, 2010 at 01:50:37PM -0700, David VomLehn wrote: > ... > > Further note: The memory node must only contain memory ranges that > > will actually be used b