Re: dtc symbolic constants - not in the preprocessor?

2012-04-24 Thread Stephen Warren
On 04/19/2012 06:11 AM, David Gibson wrote: > On Tue, Apr 17, 2012 at 08:44:23PM -0600, Stephen Warren wrote: >> So, David has been leaning towards a simple text-based preprocessor as >> the means to add symbolic constants to dtc. Depending on exactly how >> much advanced expression support the dtc

Re: [RFC] pinctrl: enhance reporting of errors when loading from DT

2012-04-24 Thread Stephen Warren
On 04/24/2012 10:53 AM, John Crispin wrote: > There are a few places in the api where the code simply returns -EINVAL when > it finds an error. An example is pinmux_map_to_setting() which now reports an > error if we try to match a group with a function that it does not support. > > The reporting

[PATCH 8/8 v2] ARM: Tegra: Add support for TPS65910 PMIC

2012-04-24 Thread Rhyland Klein
Add support for the tps65910 pmic on cardhu. Signed-off-by: Rhyland Klein --- v2: updated to move the ext-sleep-control into the regulator nodes arch/arm/boot/dts/tegra-cardhu.dts | 91 1 files changed, 91 insertions(+), 0 deletions(-) diff --git a/arch/

[PATCH 7/8 v2] mfd: tps65910-irq: Add devicetree init support

2012-04-24 Thread Rhyland Klein
Add support for initializing when boot using devicetree. The main difference is that the irq_base will not be setup, so it needs to be manually handled. Signed-off-by: Rhyland Klein --- v2: split off irq specific changes based on previous review comments drivers/mfd/tps65910-irq.c | 21 +

[PATCH 6/8 v2] regulator: tps65910 regulator: add device tree support

2012-04-24 Thread Rhyland Klein
Add devicetree based initialization support for TI tps65910 regulators. Signed-off-by: Rhyland Klein --- v2: split off regulator specific dt initialization made use of new function to match regulator nodes to names to fill in init_data drivers/regulator/tps65910-regulator.c | 106

[PATCH 5/8 v2] mfd: tps65910: Add device-tree support

2012-04-24 Thread Rhyland Klein
Add device tree based initialization support for TI's tps65910 pmic. Signed-off-by: Rhyland Klein --- v2: split mfd portion into single change to add dt support added of_node to config before calling regulator_register removed passing pdata to mfd_cell child devices removed use_dt

[PATCH 4/8 v2] regulator: tps65910: Add device tree bindings

2012-04-24 Thread Rhyland Klein
Add device tree bindings for TI's tps65910 pmic. Signed-off-by: Rhyland Klein --- v2: Moved ext-sleep-control into regulator nodes Documentation/devicetree/bindings/mfd/tps65910.txt | 133 1 files changed, 133 insertions(+), 0 deletions(-) create mode 100644 Documentatio

[PATCH 3/8 v2] mfd: tps65910: Commonize regmap access through header

2012-04-24 Thread Rhyland Klein
This change removes the read/write callback functions in favor of common regmap accessors inside the header file. This change also makes use of regmap_read/write for single register access which maps better onto what this driver actually needs. Signed-off-by: Rhyland Klein --- v2: implemented sw

[PATCH 2/8 v2] regulator: add node validation checks

2012-04-24 Thread Rhyland Klein
This change adds some validation logic to the logic for parsing nodes for regulator init data. The idea is to catch nodes that are defined but not used which likely means invalid nodes. Signed-off-by: Rhyland Klein --- v2: split off some node validation checks from original patch which implement

[PATCH 1/8 v2] regulator: add generic of node parsing for regulators

2012-04-24 Thread Rhyland Klein
As more regulators are moved to support dt, more drivers are going to need to do lookups to find nodes associated with specific regulators. Add this helper function which will find all the regulator_init_data for a series of regulators and do some minimal dt validation checks. Signed-off-by: Rhyla

[PATCH 0/8 v2] Update TPS65910 to boot using devicetree

2012-04-24 Thread Rhyland Klein
This patch set updates the tps65910 driver to boot using devicetree. This patch set now includes an addition to the of_regulator code which will parse out all the regulator init data for a device given a list of the regulator names it is expecting and a pointer to the array of where to store the p

Re: [PATCH 01/13] regulator: Fix DT node name checking in max8997-pmic

2012-04-24 Thread Olof Johansson
On Tue, Apr 24, 2012 at 3:56 PM, Olof Johansson wrote: > Hi, > > > On Thu, Apr 12, 2012 at 08:45:20PM +0200, Karol Lewandowski wrote: >> Avoid hard lockup when someone provides non-supported regulator >> name. >> >> Signed-off-by: Karol Lewandowski >> Signed-off-by: Kyungmin Park >> Cc: Thomas A

Re: [PATCH 01/13] regulator: Fix DT node name checking in max8997-pmic

2012-04-24 Thread Olof Johansson
Hi, On Thu, Apr 12, 2012 at 08:45:20PM +0200, Karol Lewandowski wrote: > Avoid hard lockup when someone provides non-supported regulator > name. > > Signed-off-by: Karol Lewandowski > Signed-off-by: Kyungmin Park > Cc: Thomas Abraham What is this supposed to apply against? It doesn't match a

Re: [PATCH V2] i2c: Add generic I2C multiplexer using pinctrl API

2012-04-24 Thread Stephen Warren
On 04/24/2012 02:09 PM, Wolfram Sang wrote: >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/i2c/pinctrl-i2cmux.txt >> @@ -0,0 +1,79 @@ >> +Pinctrl-based I2C Bus Mux >> + >> +This binding describes an I2C bus multiplexer that uses pin multiplexing to >> +route the I2C signals, and repres

Re: [PATCH v2 1/3] ARM: tegra: Add AHB driver

2012-04-24 Thread Felipe Balbi
On Tue, Apr 24, 2012 at 01:49:22PM -0600, Stephen Warren wrote: > On 04/24/2012 06:16 AM, Felipe Balbi wrote: > > On Tue, Apr 24, 2012 at 03:05:14PM +0300, Hiroshi DOYU wrote: > >> The AHB Bus conforms to the AMBA Specification (Rev 2.0) Advanced > >> High-performance Bus (AHB) architecture. > ...

Re: [PATCH V2] i2c: Add generic I2C multiplexer using pinctrl API

2012-04-24 Thread Wolfram Sang
> --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/pinctrl-i2cmux.txt > @@ -0,0 +1,79 @@ > +Pinctrl-based I2C Bus Mux > + > +This binding describes an I2C bus multiplexer that uses pin multiplexing to > +route the I2C signals, and represents the pin multiplexing configuration > +using th

Re: [PATCH v2 1/3] ARM: tegra: Add AHB driver

2012-04-24 Thread Russell King - ARM Linux
On Tue, Apr 24, 2012 at 03:05:14PM +0300, Hiroshi DOYU wrote: > The AHB Bus conforms to the AMBA Specification (Rev 2.0) Advanced > High-performance Bus (AHB) architecture. > > The AHB Arbiter controls AHB bus master arbitration. This effectively > forms a second level of arbitration for access to

Re: [PATCH v2 1/3] ARM: tegra: Add AHB driver

2012-04-24 Thread Stephen Warren
On 04/24/2012 06:16 AM, Felipe Balbi wrote: > On Tue, Apr 24, 2012 at 03:05:14PM +0300, Hiroshi DOYU wrote: >> The AHB Bus conforms to the AMBA Specification (Rev 2.0) Advanced >> High-performance Bus (AHB) architecture. ... >> +static int __init tegra_ahb_init(void) >> +{ >> +return platform_d

[PATCH V2] i2c: Add generic I2C multiplexer using pinctrl API

2012-04-24 Thread Stephen Warren
From: Stephen Warren This is useful for SoCs whose I2C module's signals can be routed to different sets of pins at run-time, using the pinctrl API. +-+ +-+ | dev | | dev | ++ +-+ +-

Re: [PATCH 2/2] of/i2c: implement of_find_i2c_adapter_by_node

2012-04-24 Thread Wolfram Sang
On Tue, Apr 17, 2012 at 12:43:34PM -0600, Stephen Warren wrote: > From: Stephen Warren > > This finds the struct i2c_adapter * for a given device tree node. Just > like of_find_i2c_device_by_node. > > Signed-off-by: Stephen Warren Applied to my i2c-next. As it is outside of drivers/i2c/ an ack

Re: [PATCH 1/2] i2c: implement i2c_verify_adapter

2012-04-24 Thread Wolfram Sang
> Wolfram, since the other I2C mux changes are going through your tree, > could you please merge this series too; they are a dependency for my > pinctrl-based I2C mux. Thanks! Applied to next. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solution

Re: [PATCH 1/2] i2c: implement i2c_verify_adapter

2012-04-24 Thread Stephen Warren
On 04/17/2012 12:49 PM, Jean Delvare wrote: > Hi Stephen, > > On Tue, 17 Apr 2012 12:43:33 -0600, Stephen Warren wrote: >> From: Stephen Warren >> >> This converts a struct device * to a struct i2c_adapter * while verifying >> that the device really is an I2C adapter. Just like i2c_verify_client.

[RFC] pinctrl: enhance reporting of errors when loading from DT

2012-04-24 Thread John Crispin
There are a few places in the api where the code simply returns -EINVAL when it finds an error. An example is pinmux_map_to_setting() which now reports an error if we try to match a group with a function that it does not support. The reporting of errors in pinconf_check_ops and pinmux_check_ops no

Re: [PATCH v2 3/3] ARM: imx6q: switch to use pinctrl driver

2012-04-24 Thread Jean-Christophe PLAGNIOL-VILLARD
On 22:04 Tue 24 Apr , Dong Aisheng wrote: > On Tue, Apr 24, 2012 at 08:46:34PM +0800, Jean-Christophe PLAGNIOL-VILLARD > wrote: > > On 22:58 Fri 20 Apr , Dong Aisheng wrote: > > > From: Dong Aisheng > > > > > > Signed-off-by: Dong Aisheng > > > > > > --- > > > This is not a formal patc

Re: [PATCH V2 1/4] devicetree: Document Intersil Corporation vendor prefix

2012-04-24 Thread Rob Landley
On 04/23/2012 12:16 PM, Stephen Warren wrote: > On 04/23/2012 06:11 AM, Laxman Dewangan wrote: >> Signed-off-by: Laxman Dewangan > > I assume this patch will go through the devictree git tree. Grant/Rob, > let me know if you want me to take it through the Tegra tree. > Device tree seems reasona

[RFC] pinctrl: enhance reporting of errors when loading from DT

2012-04-24 Thread John Crispin
There are a few places in the api where the code simply returns -EINVAL when it finds an error. An example is pinmux_map_to_setting() which now reports an error if we try to match a group with a function that it does not support. The reporting of errors in pinconf_check_ops and pinmux_check_ops no

Re: [PATCH 1/2] i2c-s3c2410: Rework device type handling

2012-04-24 Thread Wolfram Sang
On Tue, Apr 24, 2012 at 10:40:49AM +0200, Karol Lewandowski wrote: > On 23.04.2012 20:20, Wolfram Sang wrote: > > Hi! > > >> -static inline int s3c24xx_i2c_is2440(struct s3c24xx_i2c *i2c) > >> +static inline unsigned int s3c24xx_get_device_quirks(struct > >> platform_device *pdev) > >> { > >> -

Re: [PATCH v2] dt: fsl-fec.txt: Fix GPIO number comment

2012-04-24 Thread Shawn Guo
On 24 April 2012 21:24, Fabio Estevam wrote: > Fix the comment for the GPIO number used for PHY reset. > > Signed-off-by: Fabio Estevam Acked-by: Shawn Guo David, Rob, Let me know if you want the patch to go through arm-soc tree. Regards, Shawn > --- > Changes since v1: > - Keep 'local-mac-

Re: [PATCH v2 3/3] ARM: imx6q: switch to use pinctrl driver

2012-04-24 Thread Dong Aisheng
On Tue, Apr 24, 2012 at 08:46:34PM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 22:58 Fri 20 Apr , Dong Aisheng wrote: > > From: Dong Aisheng > > > > Signed-off-by: Dong Aisheng > > > > --- > > This is not a formal patch and is only used for test > > since before the pinctrl core ha

Re: [PATCH v2 3/3] ARM: imx6q: switch to use pinctrl driver

2012-04-24 Thread Jean-Christophe PLAGNIOL-VILLARD
On 22:58 Fri 20 Apr , Dong Aisheng wrote: > From: Dong Aisheng > > Signed-off-by: Dong Aisheng > > --- > This is not a formal patch and is only used for test > since before the pinctrl core handle dummy state is in, > enable pinctrl in driver will break other platforms. > > ChangeLog v1->v

Re: [PATCH V2] pinctrl: fix signed vs unsigned conditionals inside pinmux_map_to_setting

2012-04-24 Thread Linus Walleij
On Mon, Apr 23, 2012 at 7:01 PM, John Crispin wrote: > pinmux_map_to_setting() uses setting->data.mux.func/group to store the return > code of pinmux_func_name_to_selector/pinctrl_get_group_selector(). However, > struct pinctrl_setting_mux defines these elements as unsigned, resulting in > all >

Re: [PATCH v2 1/3] ARM: tegra: Add AHB driver

2012-04-24 Thread Felipe Balbi
On Tue, Apr 24, 2012 at 03:05:14PM +0300, Hiroshi DOYU wrote: > The AHB Bus conforms to the AMBA Specification (Rev 2.0) Advanced > High-performance Bus (AHB) architecture. > > The AHB Arbiter controls AHB bus master arbitration. This effectively > forms a second level of arbitration for access to

Re: [PATCH] dt: sgtl5000.txt: Add description for 'reg' field

2012-04-24 Thread Mark Brown
On Tue, Apr 24, 2012 at 01:11:09AM -0300, Fabio Estevam wrote: > Add description for 'reg' field. Applied, thanks. signature.asc Description: Digital signature ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs

Re: [PATCH v2 3/3] ARM: imx6q: switch to use pinctrl driver

2012-04-24 Thread Dong Aisheng
On Tue, Apr 24, 2012 at 05:51:17PM +0800, Richard Zhao wrote: > > --- a/drivers/mmc/host/sdhci-esdhc-imx.c > > +++ b/drivers/mmc/host/sdhci-esdhc-imx.c > > @@ -24,6 +24,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include "sdhci-pltfm.h" > > #include "sdhci

Re: [PATCH v2 3/3] ARM: imx6q: switch to use pinctrl driver

2012-04-24 Thread Richard Zhao
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c > +++ b/drivers/mmc/host/sdhci-esdhc-imx.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include > #include > #include "sdhci-pltfm.h" > #include "sdhci-esdhc.h" > @@ -68,6 +69,7 @@ struct pltfm_imx_data { > int flags; > u

Re: [PATCH v2 3/3] ARM: imx6q: switch to use pinctrl driver

2012-04-24 Thread Dong Aisheng
On Tue, Apr 24, 2012 at 11:08:41AM +0200, Wolfram Sang wrote: > On Tue, Apr 24, 2012 at 10:56:43AM +0200, Linus Walleij wrote: > > On Fri, Apr 20, 2012 at 4:58 PM, Dong Aisheng wrote: > > > > > From: Dong Aisheng > > > > > > Signed-off-by: Dong Aisheng > > > > > > --- > > > This is not a formal

Re: [PATCH v2 3/3] ARM: imx6q: switch to use pinctrl driver

2012-04-24 Thread Wolfram Sang
On Tue, Apr 24, 2012 at 10:56:43AM +0200, Linus Walleij wrote: > On Fri, Apr 20, 2012 at 4:58 PM, Dong Aisheng wrote: > > > From: Dong Aisheng > > > > Signed-off-by: Dong Aisheng > > > > --- > > This is not a formal patch and is only used for test > > since before the pinctrl core handle dummy

Re: [PATCH v2 3/3] ARM: imx6q: switch to use pinctrl driver

2012-04-24 Thread Dong Aisheng
Hi Linus, On Tue, Apr 24, 2012 at 10:56:43AM +0200, Linus Walleij wrote: > On Fri, Apr 20, 2012 at 4:58 PM, Dong Aisheng wrote: > > > From: Dong Aisheng > > > > Signed-off-by: Dong Aisheng > > > > --- > > This is not a formal patch and is only used for test > > since before the pinctrl core ha

Re: [PATCH v2 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver

2012-04-24 Thread Linus Walleij
On Fri, Apr 20, 2012 at 4:58 PM, Dong Aisheng wrote: > From: Dong Aisheng > > The driver has mux and config support while the gpio is still > not supported. > For select input setting, the driver will handle it internally > and do not need user to take care of it. > > The pinctrl-imx core driver

Re: [PATCH v2 3/3] ARM: imx6q: switch to use pinctrl driver

2012-04-24 Thread Linus Walleij
On Fri, Apr 20, 2012 at 4:58 PM, Dong Aisheng wrote: > From: Dong Aisheng > > Signed-off-by: Dong Aisheng > > --- > This is not a formal patch and is only used for test > since before the pinctrl core handle dummy state is in, > enable pinctrl in driver will break other platforms. > > ChangeLog

Re: [PATCH 1/2] i2c-s3c2410: Rework device type handling

2012-04-24 Thread Karol Lewandowski
On 23.04.2012 20:20, Wolfram Sang wrote: Hi! >> -static inline int s3c24xx_i2c_is2440(struct s3c24xx_i2c *i2c) >> +static inline unsigned int s3c24xx_get_device_quirks(struct platform_device >> *pdev) >> { >> -struct platform_device *pdev = to_platform_device(i2c->dev); >> -enum s3c24xx

Re: [PATCH 3/3] ARM: imx6q: switch to use pinctrl driver

2012-04-24 Thread Dong Aisheng
On Tue, Apr 24, 2012 at 04:23:34PM +0800, Linus Walleij wrote: > On Mon, Apr 16, 2012 at 5:35 AM, Dong Aisheng > wrote: > > On Sun, Apr 15, 2012 at 03:37:54PM +0800, Shawn Guo wrote: > >> On Sun, Apr 15, 2012 at 12:03:16PM +0800, Dong Aisheng wrote: > >> ... > >> > For MX3 and MX5, before their pi

Re: [PATCH 3/3] ARM: imx6q: switch to use pinctrl driver

2012-04-24 Thread Linus Walleij
On Mon, Apr 16, 2012 at 5:35 AM, Dong Aisheng wrote: > On Sun, Apr 15, 2012 at 03:37:54PM +0800, Shawn Guo wrote: >> On Sun, Apr 15, 2012 at 12:03:16PM +0800, Dong Aisheng wrote: >> ... >> > For MX3 and MX5, before their pinctrl driver are available, user may >> > need to define a dummy in dt to a

[PATCH] mtd: mxc_nand: fix several sparse warnings about incorrect address space

2012-04-24 Thread Uwe Kleine-König
Signed-off-by: Uwe Kleine-König --- drivers/mtd/nand/mxc_nand.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c index 1041bb1..ec5ba8b 100644 --- a/drivers/mtd/nand/mxc_nand.c +++ b/drivers/mt

Re: [PATCH 03/10] mtd: mxc_nand: move function pointers to a per-SOC struct

2012-04-24 Thread Uwe Kleine-König
Hello Sascha, On Tue, Apr 24, 2012 at 09:24:57AM +0200, Sascha Hauer wrote: > On Mon, Apr 23, 2012 at 11:23:35AM +0200, Uwe Kleine-König wrote: > > This prepares switching to platform ids and of-tree probing. > > > > Signed-off-by: Uwe Kleine-König > > --- > > drivers/mtd/nand/mxc_nand.c | 197

Re: [PATCH 03/10] mtd: mxc_nand: move function pointers to a per-SOC struct

2012-04-24 Thread Sascha Hauer
On Mon, Apr 23, 2012 at 11:23:35AM +0200, Uwe Kleine-König wrote: > This prepares switching to platform ids and of-tree probing. > > Signed-off-by: Uwe Kleine-König > --- > drivers/mtd/nand/mxc_nand.c | 197 > ++- > 1 file changed, 118 insertions(+), 79