Re: [PATCH v3 4/4] leds: leds-pwm: Add device tree bindings

2012-12-10 Thread Thierry Reding
On Mon, Dec 10, 2012 at 11:00:37AM +0100, Peter Ujfalusi wrote: [...] > +LED sub-node properties: > +- pwms : PWM property, please refer to: > + Documentation/devicetree/bindings/pwm/pwm.txt Instead of only referring to the generic PWM binding document, this should probably explain what the PWM

Re: [PATCH v3 2/4] leds: leds-pwm: Preparing the driver for device tree support

2012-12-10 Thread Thierry Reding
On Mon, Dec 10, 2012 at 11:00:35AM +0100, Peter Ujfalusi wrote: > In order to be able to add device tree support for leds-pwm driver we need > to rearrange the data structures used by the drivers. > > Signed-off-by: Peter Ujfalusi > --- > drivers/leds/leds-pwm.c | 39 +++-

Re: [PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-10 Thread Thierry Reding
On Mon, Dec 10, 2012 at 11:00:34AM +0100, Peter Ujfalusi wrote: > Update the driver to use the new API for requesting pwm so we can take > advantage of the pwm_lookup table to find the correct pwm to be used for the > LED functionality. > If the devm_get_pwm fails we fall back to legacy mode to try

Re: [PATCH v3 3/4] pwm: core: Export of_pwm_request() so client drivers can also use it

2012-12-10 Thread Thierry Reding
On Mon, Dec 10, 2012 at 11:00:36AM +0100, Peter Ujfalusi wrote: > Allow client driver to use of_pwm_request() to get the pwm they need. This > is needed for drivers which handle more than one pwm separately, like > leds-pwm driver which have: Hi Peter, I really was hoping that we didn't have to e

Re: [PATCH 1/2] arm: mvebu: add RTC support for Armada 370 and Armada XP

2012-12-10 Thread Andrew Lunn
On Mon, Dec 10, 2012 at 11:37:23PM +0100, Thomas Petazzoni wrote: > Dear Grant Likely, > > On Mon, 10 Dec 2012 21:47:55 +, Grant Likely wrote: > > > > Maybe an explicit status = "okay" here? > > > > Only necessary if it is typical for the device to get disabled. I don't > > add status="okay"

Re: [PATCH 1/6] ARM: sunxi: Add pinctrl driver for Allwinner SoCs

2012-12-10 Thread Linus Walleij
On Mon, Dec 10, 2012 at 11:08 PM, Maxime Ripard wrote: > This IP has 8 banks of 32 bits, with a number of pins actually useful > for each of these banks varying from one to another, and depending on > the SoC used on the board. > > This driver only implements the pinctrl part, the gpio part will

Re: [PATCH v3 4/4] leds: leds-pwm: Add device tree bindings

2012-12-10 Thread Grant Likely
On Mon, 10 Dec 2012 11:00:37 +0100, Peter Ujfalusi wrote: > Support for device tree booted kernel. > > For usage see: > Documentation/devicetree/bindings/leds/leds-pwm.txt > > Signed-off-by: Peter Ujfalusi Acked-by: Grant Likely The other patches in this series look good to. g. __

Re: pci and pcie device-tree binding - range No cells

2012-12-10 Thread Rob Herring
On 12/10/2012 11:15 AM, Thomas Petazzoni wrote: > Dear Michal Simek, > > On Mon, 10 Dec 2012 17:05:13 +0100, Michal Simek wrote: > >> CC: Thomas: I think it will be interesting to see this discussion >> because you are using size-cell/address-cells equal 1. >> http://www.spinics.net/lists/arm-ker

Re: [PATCH v3 3/4] pwm: core: Export of_pwm_request() so client drivers can also use it

2012-12-10 Thread Grant Likely
On Mon, 10 Dec 2012 11:00:36 +0100, Peter Ujfalusi wrote: > Allow client driver to use of_pwm_request() to get the pwm they need. This > is needed for drivers which handle more than one pwm separately, like > leds-pwm driver which have: > > pwmleds { > compatible = "pwm-leds"; > kpad

Re: pci and pcie device-tree binding - range No cells

2012-12-10 Thread Mitch Bradley
On 12/10/2012 12:38 PM, Benjamin Herrenschmidt wrote: > On Mon, 2012-12-10 at 21:43 +, Grant Likely wrote: >>> Sorry for my pci ignorance (have never got hw for mb/zynq) >>> I just want to get better overview how we should we our drivers to >> be compatible. >>> >>> Does it mean that pci is sup

Re: [PATCH] mtd: nand: davinci: fix the binding documentation

2012-12-10 Thread Grant Likely
On Fri, 7 Dec 2012 14:39:34 +0530, "Kumar, Anil" wrote: > Since the aemif driver conversion to DT along with > its movement to drivers/ folder is not yet done, > fix NAND binding documentation to have NAND specific > DT details only. > > Signed-off-by: Kumar, Anil Applied, thanks. g. > --- >

Re: [PATCH v2 3/3] leds: leds-pwm: Add device tree bindings

2012-12-10 Thread Grant Likely
On Fri, 7 Dec 2012 15:04:51 +0100, Peter Ujfalusi wrote: > On 12/07/2012 02:34 PM, Grant Likely wrote: > > It really needs to look like this: > > > > pwmleds { > > compatible = "pwm-leds"; > > kpad { > > label = "omap4::keypad"; > > max-brightness = <127>; > >

Re: pci and pcie device-tree binding - range No cells

2012-12-10 Thread Benjamin Herrenschmidt
On Mon, 2012-12-10 at 21:43 +, Grant Likely wrote: > > Sorry for my pci ignorance (have never got hw for mb/zynq) > > I just want to get better overview how we should we our drivers to > be compatible. > > > > Does it mean that pci is supposed be always 64 bit wide? > > And there is no option

Re: RFC: New release for DTC?

2012-12-10 Thread Simon Glass
Hi, On Sat, Nov 17, 2012 at 4:00 PM, Grant Likely wrote: > On Sat, 17 Nov 2012 12:50:07 -0500, Mike Frysinger wrote: >> On Thursday 23 August 2012 21:36:25 David Gibson wrote: >> > On Thu, Aug 23, 2012 at 08:15:39PM +0200, Yann E. MORIN wrote: >> > > Following advice from Jon Loeliger, I would s

Re: [PATCH 1/2] arm: mvebu: add RTC support for Armada 370 and Armada XP

2012-12-10 Thread Thomas Petazzoni
Dear Grant Likely, On Mon, 10 Dec 2012 21:47:55 +, Grant Likely wrote: > > Maybe an explicit status = "okay" here? > > Only necessary if it is typical for the device to get disabled. I don't > add status="okay" properties unless it is to enable a device previously > disabled with status="dis

Re: [PATCH 0/2] sparc: Enable OF functionality for sparc for i2c and spi

2012-12-10 Thread Grant Likely
On Fri, 07 Dec 2012 12:30:57 -0500 (EST), David Miller wrote: > From: Grant Likely > Date: Tue, 4 Dec 2012 21:49:26 + > > > On Tue, Dec 4, 2012 at 9:10 PM, David Miller wrote: > >> From: Grant Likely > >> Date: Tue, 4 Dec 2012 14:44:57 + > >> > >>> On Tue, Dec 4, 2012 at 2:09 PM, Andr

Re: [PATCH 2/2] rtc: rtc-mv: Add the device tree binding documentation

2012-12-10 Thread Grant Likely
On Mon, 10 Dec 2012 08:39:14 -0500, Jason Cooper wrote: > On Mon, Dec 10, 2012 at 11:42:02AM +0100, Gregory CLEMENT wrote: > > The support was already written, but the binding documentation was > > lacking. > > Thanks for doing this, Gregory. I missed this the first time around > when we added t

Re: [PATCH 1/2] arm: mvebu: add RTC support for Armada 370 and Armada XP

2012-12-10 Thread Grant Likely
On Mon, 10 Dec 2012 16:28:19 +0100, Thomas Petazzoni wrote: > Dear Gregory CLEMENT, > > On Mon, 10 Dec 2012 11:42:01 +0100, Gregory CLEMENT wrote: > > > + rtc@10300 { > > + compatible = "marvell,orion-rtc"; > > + reg = <0xd0010300 0x20>; > > +

Re: pci and pcie device-tree binding - range No cells

2012-12-10 Thread Grant Likely
On Mon, 10 Dec 2012 09:21:51 -0600, Rob Herring wrote: > On 12/10/2012 09:05 AM, Michal Simek wrote: > > On 12/10/2012 03:26 PM, Rob Herring wrote: > >> On 12/10/2012 06:20 AM, Michal Simek wrote: > >>> Hi Grant and others, > >>> > >>> I have a question regarding number of cells in ranges property

Re: pci and pcie device-tree binding - range No cells

2012-12-10 Thread Grant Likely
On Mon, 10 Dec 2012 16:37:26 +0100, Michal Simek wrote: > On 12/10/2012 04:21 PM, Rob Herring wrote: > > On 12/10/2012 09:05 AM, Michal Simek wrote: > >> On 12/10/2012 03:26 PM, Rob Herring wrote: > >>> On 12/10/2012 06:20 AM, Michal Simek wrote: > Hi Grant and others, > > I have a

Re: [PATCH V3 2/3] dmaengine: dw_dmac: Enhance device tree support

2012-12-10 Thread Arnd Bergmann
On Monday 10 December 2012, Arnd Bergmann wrote: > The build bug is not the problem however, but the abuse of the > API is. Andy, are you sure you understood what this does when > you gave you Reviewed-by comment? > Ah, I just saw that Andy had the right intuition when commenting on it at first,

Re: [PATCH V3 2/3] dmaengine: dw_dmac: Enhance device tree support

2012-12-10 Thread Arnd Bergmann
On Tuesday 16 October 2012, Viresh Kumar wrote: > dw_dmac driver already supports device tree but it used to have its platform > data passed the non-DT way. > > This patch does following changes: > - pass platform data via DT, non-DT way still takes precedence if both are > used. > - create gener

[PATCH] of: Support a PCI device that is compatible with 'simple-bus'

2012-12-10 Thread Jason Gunthorpe
The intended use for this feature is to let a PCI device declare itself a 'simple-bus' and then describe additional devices (such as GPIOs, I2C, etc) nested below itself. The devices nested below the PCI device will use 'reg' addressing with the 5 dw format used by PCI. This is for embedded cases

[PATCH RFC 12/12] ARM: dts: Add camera device nodes nodes for PQ board

2012-12-10 Thread Sylwester Nawrocki
This patch adds all nodes for camera devices on example Exynos4412 SoC based board. This is all what's required in the board dts file to enable rear facing camera (S5C73M3 sensor). The aliases node contains entries required for the camera processing data path entity drivers. The sensor nodes use

[PATCH RFC 11/12] ARM: dts: Add camera pinctrl nodes for Exynos4x12 SoCs

2012-12-10 Thread Sylwester Nawrocki
Add separate nodes for the CAMCLK pin and turn off pull-up on camera port A. Default driver strength for CAMCLK pin is increased to maximum. The driver strength change can be moved to board specific part if it is considered more appropriate. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungm

[PATCH RFC 10/12] ARM: dts: Add FIMC and MIPI CSIS device nodes for Exynos4x12

2012-12-10 Thread Sylwester Nawrocki
Add common camera node and fimc nodes specific to Exynos4212 and Exynos4412 SoCs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- arch/arm/boot/dts/exynos4x12.dtsi | 36 1 file changed, 36 insertions(+) diff --git a/arch/arm/boot/dts/ex

[PATCH RFC 09/12] ARM: dts: Add ISP power domain node for Exynos4x12

2012-12-10 Thread Sylwester Nawrocki
The ISP power domain is a common power domain for fimc-lite and fimc-is (ISP) devices. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- arch/arm/boot/dts/exynos4x12.dtsi |5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/b

[PATCH RFC 08/12] ARM: dts: Add camera node exynos4.dtsi

2012-12-10 Thread Sylwester Nawrocki
This adds common FIMC device nodes for all Exynos4 SoCs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- arch/arm/boot/dts/exynos4.dtsi | 64 1 file changed, 64 insertions(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/bo

[PATCH RFC 07/12] ARM: EXYNOS4: Add OF_DEV_AUXDATA for FIMC, FIMC-LITE and CSIS

2012-12-10 Thread Sylwester Nawrocki
Add these temporary OF_DEV_AUXDATA entries so we can use clocks before common clock framework support for Exynos4 is available. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- arch/arm/mach-exynos/mach-exynos4-dt.c | 16 1 file changed, 16 insertions(+) di

[PATCH RFC 06/12] s5p-fimc: Use pinctrl API for camera ports configuration

2012-12-10 Thread Sylwester Nawrocki
Before the camera ports can be used the pinmux needs to be configured properly. This patch adds a function to get the pinctrl states and to set default camera port pinmux state during the media driver's probe(). The camera port(s) are configured for video bus operation in this way. "inactive" pinc

[PATCH RFC 05/12] s5p-fimc: Add device tree based sensors registration

2012-12-10 Thread Sylwester Nawrocki
The sensor (I2C and/or SPI client) devices are instantiated by their corresponding control bus controllers. Since their master clock is often provided by a video bus receiver (host interface) or other than I2C/SPI controller device, the drivers of those client devices are not accessing hardware in

[PATCH RFC 04/12] s5p-fimc: Instantiate media device from device tree

2012-12-10 Thread Sylwester Nawrocki
The platform sub-devices are looked up and registered to the top level driver, similarly as it is done in non-dt case. When any sub-device is not yet initialized and ready the main driver's probe() will be deferred. This patch adds matching table for the common media device driver associated with

[PATCH RFC 03/12] s5p-fimc: Add device tree support for FIMC-LITE

2012-12-10 Thread Sylwester Nawrocki
This patch add support for instantiation FIMC-LITE platform devices from device tree. Device tree aliases are used to specify the IP hardware instance. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- .../devicetree/bindings/media/soc/samsung-fimc.txt | 16 + drivers/med

[PATCH RFC 02/12] s5p-fimc: Add device tree support for FIMC devices

2012-12-10 Thread Sylwester Nawrocki
This patch adds support for devicetree based instantiation of FIMC (s5p-fimc, s5pv210-fimc, exynos4-fimc platform) devices. The FIMC IP features include colorspace conversion and scaling (mem-to-mem) and parallel/MIPI CSI2 bus video capture interface. Multiple SoC revision specific parameters are

[PATCH RFC 01/12] s5p-csis: Add device tree support

2012-12-10 Thread Sylwester Nawrocki
s5p-csis is platform device driver for MIPI-CSI frontend to the FIMC (camera host interface DMA engine and image processor). This patch adds support for instantiating the MIPI-CSIS devices from DT and parsing all SoC and board specific properties from device tree. Signed-off-by: Sylwester Nawrocki

[PATCH RFC 00/12] Device tree support for Exynos4 SoC camera drivers

2012-12-10 Thread Sylwester Nawrocki
This patch series adds support for Samsung Exynos4 SoC camera subsystem drivers. It depends on the video input interfaces bindings and the V4L2 OF parsing helpers. Full tree containing these patches can be browsed at: http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/v3.7-rc8

[PATCH RFC 13/13] v4l2-of: Replace "remote" property with "remote-endpoint"

2012-12-10 Thread Sylwester Nawrocki
As agreed (I hope I'm not wrong) on the LMML use "remote-endpoint" property instead of "remote". Also add kerneldoc description for the function. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/v4l2-core/v4l2-of.c | 12 +--- 1 file changed, 9 insertion

[PATCH RFC 12/13] v4l2-of: Corrected v4l2_of_parse_link() function declaration

2012-12-10 Thread Sylwester Nawrocki
v4l2_of_parse_link() return value type is int, not void. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- include/media/v4l2-of.h |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/include/media/v4l2-of.h b/include/media/v4l2-of.h index 9b036e6..686d

[PATCH RFC 11/13] v4l2-of: Add v4l2_of_parse_data_lanes() function

2012-12-10 Thread Sylwester Nawrocki
Put the data-lanes property parsing code and make a separate function out of it, so it can be used in drivers that don't need all features packed in v4l2_of_parse_link(). Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- drivers/media/v4l2-core/v4l2-of.c | 48

[PATCH RFC 10/13] v4l2-of: Support variable length of data-lanes property

2012-12-10 Thread Sylwester Nawrocki
Based on code from Guennadi Liakhovetski . Add data_lanes property which relects the number of active data lanes, that is length of the data-lanes array. Previously we assumed the data-lanes array had fixed length which doesn't match the binding semantics. Signed-off-by: Sylwester Nawrocki ---

[PATCH RFC 09/13] media: add a V4L2 OF parser

2012-12-10 Thread Sylwester Nawrocki
From: Guennadi Liakhovetski Add a V4L2 OF parser, implementing bindings, documented in Documentation/devicetree/bindings/media/v4l2.txt. Signed-off-by: Guennadi Liakhovetski --- drivers/media/v4l2-core/Makefile |3 + drivers/media/v4l2-core/v4l2-of.c | 190 +++

[PATCH RFC 08/13] media: add V4L2 DT binding documentation

2012-12-10 Thread Sylwester Nawrocki
From: Guennadi Liakhovetski This patch adds a document, describing common V4L2 device tree bindings. Co-authored-by: Sylwester Nawrocki Signed-off-by: Guennadi Liakhovetski --- Documentation/devicetree/bindings/media/v4l2.txt | 162 ++ 1 file changed, 162 insertions(+) c

[PATCH RFC 07/13] of: Add empty of_get_next_child() function definition

2012-12-10 Thread Sylwester Nawrocki
Add an empty of_get_next_child() function definition so users can be build when CONFIG_OF is disabled and are not required to exclude OF specific parts explicitly with #ifdefs. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- include/linux/of.h |7 +++ 1 file changed,

[PATCH RFC 06/13] of: Add empty of_find_device_by_node() function definition

2012-12-10 Thread Sylwester Nawrocki
This allows users to be compiled without excluding this function call with preprocessor directives when CONFIG_OF_DEVICE is disabled. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- include/linux/of_platform.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/incl

[PATCH RFC 05/13] of: Add empty for_each_available_child_of_node() macro definition

2012-12-10 Thread Sylwester Nawrocki
Add this empty macro definition so users can be compiled without excluding this macro call with preprocessor directives when CONFIG_OF is disabled. Signed-off-by: Sylwester Nawrocki Signed-off-by: Kyungmin Park --- include/linux/of.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/inc

[PATCH RFC 04/13] OF: make a function pointer argument const

2012-12-10 Thread Sylwester Nawrocki
From: Guennadi Liakhovetski The "struct device_node *" argument of of_parse_phandle_*() can be const. Signed-off-by: Guennadi Liakhovetski --- drivers/of/base.c |4 ++-- include/linux/of.h |6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/of/base.c b/dr

[PATCH RFC 03/13] OF: define of_*_cmp() macros also if CONFIG_OF isn't set

2012-12-10 Thread Sylwester Nawrocki
From: Guennadi Liakhovetski of_*_cmp() macros do not depend on any OF functions and can be defined also if CONFIG_OF isn't set. Also include linux/string.h, required by those macros. Signed-off-by: Guennadi Liakhovetski --- include/linux/of.h | 15 --- 1 file changed, 8 insertion

[PATCH RFC 02/13] of: add a dummy inline function for when CONFIG_OF is not defined

2012-12-10 Thread Sylwester Nawrocki
From: Guennadi Liakhovetski If CONFIG_OF isn't defined, no declaration of of_get_parent will be found and compilation can fail. This patch adds a dummy inline function definition to fix the problem. Signed-off-by: Guennadi Liakhovetski --- include/linux/of.h |5 + 1 file changed, 5 ins

[PATCH RFC 01/13] i2c: add dummy inline functions for when CONFIG_OF_I2C(_MODULE) isn't defined

2012-12-10 Thread Sylwester Nawrocki
From: Guennadi Liakhovetski If CONFIG_OF_I2C and CONFIG_OF_I2C_MODULE are undefined no declaration of of_find_i2c_device_by_node and of_find_i2c_adapter_by_node will be available. Add dummy inline functions to avoid compilation breakage. Signed-off-by: Guennadi Liakhovetski --- include/linux/o

[PATCH RFC 00/13] Common video input interfaces bindings and V4L2 OF helpers

2012-12-10 Thread Sylwester Nawrocki
Hi all, This series is an update of work on common bindings for video capture interfaces [1], [2] originally started by Guennadi. I took the liberty of resending the original patches and adding my changes on top of it. I just noticed there were some comments to the v5 of the bindings documentatio

Re: [PATCH] mtd: cfi_cmdset_0002: Support Persistent Protection Bits (PPB) locking

2012-12-10 Thread Stefan Roese
On 12/10/2012 04:00 PM, Artem Bityutskiy wrote: > On Fri, 2012-12-07 at 08:22 +0100, Stefan Roese wrote: >> + /* >> +* Wait for some time as unlocking of all sectors takes quite long >> +*/ >> + timeo = jiffies + (2 * HZ); /* 2s max (un)locking */ > > Please, use ms

Re: pci and pcie device-tree binding - range No cells

2012-12-10 Thread Thomas Petazzoni
Dear Michal Simek, On Mon, 10 Dec 2012 17:05:13 +0100, Michal Simek wrote: > CC: Thomas: I think it will be interesting to see this discussion > because you are using size-cell/address-cells equal 1. > http://www.spinics.net/lists/arm-kernel/msg211839.html Thanks for Cc'ing me. The thing is tha

Re: [PATCH] OF: update coherent_dma_mask

2012-12-10 Thread Rob Herring
On 12/10/2012 06:09 AM, Subash Patel wrote: > This patch is tested in ARM:exynos5250 with LPAE enabled. The > coherent_dma_mask > needs to be defined to DMA_BIT_MASK(64) as dma-mapping API's check it against > 64-bit mask. > > Signed-off-by: Subash Patel > --- > drivers/of/platform.c |2 +-

Re: pci and pcie device-tree binding - range No cells

2012-12-10 Thread Michal Simek
On 12/10/2012 05:02 PM, Rob Herring wrote: On 12/10/2012 09:37 AM, Michal Simek wrote: On 12/10/2012 04:21 PM, Rob Herring wrote: On 12/10/2012 09:05 AM, Michal Simek wrote: On 12/10/2012 03:26 PM, Rob Herring wrote: On 12/10/2012 06:20 AM, Michal Simek wrote: Hi Grant and others, I have a

Re: pci and pcie device-tree binding - range No cells

2012-12-10 Thread Michal Simek
On 12/10/2012 04:52 PM, David Laight wrote: Does it mean that pci is supposed be always 64 bit wide? And there is no option to have just 32bit values. I certainly believe that all PCIe (not PCI) transfers are nominally multiples of 64bit data. And PCI? That powerpc/pci-common code was designe

Re: pci and pcie device-tree binding - range No cells

2012-12-10 Thread Rob Herring
On 12/10/2012 09:37 AM, Michal Simek wrote: > On 12/10/2012 04:21 PM, Rob Herring wrote: >> On 12/10/2012 09:05 AM, Michal Simek wrote: >>> On 12/10/2012 03:26 PM, Rob Herring wrote: On 12/10/2012 06:20 AM, Michal Simek wrote: > Hi Grant and others, > > I have a question regarding

Re: pci and pcie device-tree binding - range No cells

2012-12-10 Thread Michal Simek
On 12/10/2012 04:21 PM, Rob Herring wrote: On 12/10/2012 09:05 AM, Michal Simek wrote: On 12/10/2012 03:26 PM, Rob Herring wrote: On 12/10/2012 06:20 AM, Michal Simek wrote: Hi Grant and others, I have a question regarding number of cells in ranges property for pci and pcie nodes. Linux pci/

Re: [PATCH 1/2] arm: mvebu: add RTC support for Armada 370 and Armada XP

2012-12-10 Thread Thomas Petazzoni
Dear Gregory CLEMENT, On Mon, 10 Dec 2012 11:42:01 +0100, Gregory CLEMENT wrote: > + rtc@10300 { > + compatible = "marvell,orion-rtc"; > + reg = <0xd0010300 0x20>; > + interrupts = <50>; > + }; Maybe an explicit

Re: pci and pcie device-tree binding - range No cells

2012-12-10 Thread Rob Herring
On 12/10/2012 09:05 AM, Michal Simek wrote: > On 12/10/2012 03:26 PM, Rob Herring wrote: >> On 12/10/2012 06:20 AM, Michal Simek wrote: >>> Hi Grant and others, >>> >>> I have a question regarding number of cells in ranges property >>> for pci and pcie nodes. >>> >>> Linux pci/pcie powerpc DTSes co

Re: pci and pcie device-tree binding - range No cells

2012-12-10 Thread Michal Simek
On 12/10/2012 03:26 PM, Rob Herring wrote: On 12/10/2012 06:20 AM, Michal Simek wrote: Hi Grant and others, I have a question regarding number of cells in ranges property for pci and pcie nodes. Linux pci/pcie powerpc DTSes contain 7 cells (xpedite5370.dts, sequoia.dts, etc) but also 6 cells f

Re: [PATCH] mtd: cfi_cmdset_0002: Support Persistent Protection Bits (PPB) locking

2012-12-10 Thread Artem Bityutskiy
On Fri, 2012-12-07 at 08:22 +0100, Stefan Roese wrote: > + /* > +* Wait for some time as unlocking of all sectors takes quite long > +*/ > + timeo = jiffies + (2 * HZ); /* 2s max (un)locking */ Please, use msecs_to_jiffies() instead. > + for (;;) { > +

Re: pci and pcie device-tree binding - range No cells

2012-12-10 Thread Rob Herring
On 12/10/2012 06:20 AM, Michal Simek wrote: > Hi Grant and others, > > I have a question regarding number of cells in ranges property > for pci and pcie nodes. > > Linux pci/pcie powerpc DTSes contain 7 cells (xpedite5370.dts, > sequoia.dts, etc) > but also 6 cells format too (mpc832x_mds.dts) >

Re: [PATCH 0/2] add RTC support for Armada 370 and Armada XP

2012-12-10 Thread Gregory CLEMENT
On 12/10/2012 03:01 PM, Thomas Petazzoni wrote: > Dear Gregory CLEMENT, > > On Mon, 10 Dec 2012 11:42:00 +0100, Gregory CLEMENT wrote: > >> This small patchset adds RTC support for Armada 370 and Armada XP. It >> was succesfully tested on the evaluation board. The second patch add >> the lacking

Re: [PATCH V4 0/2] Add DT support for i2s

2012-12-10 Thread Mark Brown
On Mon, Dec 10, 2012 at 04:30:50PM +0530, Padma Venkat wrote: > Could you please explain me in more detail about "single DT link > automatically expanded into two DAI links". > How this can be done? The device tree should only represent the single physical link that exists and the handling of the

Re: [PATCH 0/2] add RTC support for Armada 370 and Armada XP

2012-12-10 Thread Thomas Petazzoni
Dear Gregory CLEMENT, On Mon, 10 Dec 2012 11:42:00 +0100, Gregory CLEMENT wrote: > This small patchset adds RTC support for Armada 370 and Armada XP. It > was succesfully tested on the evaluation board. The second patch add > the lacking documentation for the device tree binding. This serie is >

Re: [PATCH 2/2] rtc: rtc-mv: Add the device tree binding documentation

2012-12-10 Thread Jason Cooper
On Mon, Dec 10, 2012 at 11:42:02AM +0100, Gregory CLEMENT wrote: > The support was already written, but the binding documentation was > lacking. Thanks for doing this, Gregory. I missed this the first time around when we added the DT bindings to the rtc driver. thx, Jason. > > Signed-off-by:

pci and pcie device-tree binding - range No cells

2012-12-10 Thread Michal Simek
Hi Grant and others, I have a question regarding number of cells in ranges property for pci and pcie nodes. Linux pci/pcie powerpc DTSes contain 7 cells (xpedite5370.dts, sequoia.dts, etc) but also 6 cells format too (mpc832x_mds.dts) Here is shown 6 cells ranges format and describe http://devi

Re: [PATCH V4 0/2] Add DT support for i2s

2012-12-10 Thread Padma Venkat
Hi Mark, On Sun, Dec 9, 2012 at 12:56 PM, Mark Brown wrote: > On Sat, Dec 08, 2012 at 10:07:54AM +0530, Padma Venkat wrote: > >> Samsung i2s driver registers the platform device twice one for the >> samsung-i2s.0,1 or 2 and two for samsung-i2s.4(which actually doesn't >> represent any H/W periphe

Re: [PATCH 0/2] add RTC support for Armada 370 and Armada XP

2012-12-10 Thread Andrew Lunn
On Mon, Dec 10, 2012 at 11:42:00AM +0100, Gregory CLEMENT wrote: > Hello Jason, > > This small patchset adds RTC support for Armada 370 and Armada XP. It > was succesfully tested on the evaluation board. The second patch add > the lacking documentation for the device tree binding. This serie is >

[PATCH 2/2] rtc: rtc-mv: Add the device tree binding documentation

2012-12-10 Thread Gregory CLEMENT
The support was already written, but the binding documentation was lacking. Signed-off-by: Gregory CLEMENT --- .../devicetree/bindings/rtc/orion-rtc.txt | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/orion-rtc.txt d

[PATCH 1/2] arm: mvebu: add RTC support for Armada 370 and Armada XP

2012-12-10 Thread Gregory CLEMENT
The Armada 370 and Armada XP Socs have the same controller that the one used in the orion platforms. This patch enables the selection of rtc-mv with mvebu platform, and updates the device tree for these SoCs. --- arch/arm/boot/dts/armada-370-xp.dtsi |6 ++ drivers/rtc/Kconfig

[PATCH 0/2] add RTC support for Armada 370 and Armada XP

2012-12-10 Thread Gregory CLEMENT
Hello Jason, This small patchset adds RTC support for Armada 370 and Armada XP. It was succesfully tested on the evaluation board. The second patch add the lacking documentation for the device tree binding. This serie is 3.9 material. Thanks, Gregory CLEMENT (2): arm: mvebu: add RTC support f

[PATCH v3 4/4] leds: leds-pwm: Add device tree bindings

2012-12-10 Thread Peter Ujfalusi
Support for device tree booted kernel. For usage see: Documentation/devicetree/bindings/leds/leds-pwm.txt Signed-off-by: Peter Ujfalusi --- .../devicetree/bindings/leds/leds-pwm.txt | 46 drivers/leds/leds-pwm.c| 124 + 2 files

[PATCH v3 3/4] pwm: core: Export of_pwm_request() so client drivers can also use it

2012-12-10 Thread Peter Ujfalusi
Allow client driver to use of_pwm_request() to get the pwm they need. This is needed for drivers which handle more than one pwm separately, like leds-pwm driver which have: pwmleds { compatible = "pwm-leds"; kpad { label = "omap4::keypad"; pwms = <&t

[PATCH v3 1/4] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-10 Thread Peter Ujfalusi
Update the driver to use the new API for requesting pwm so we can take advantage of the pwm_lookup table to find the correct pwm to be used for the LED functionality. If the devm_get_pwm fails we fall back to legacy mode to try to get the pwm. Signed-off-by: Peter Ujfalusi --- drivers/leds/leds-

[PATCH v3 2/4] leds: leds-pwm: Preparing the driver for device tree support

2012-12-10 Thread Peter Ujfalusi
In order to be able to add device tree support for leds-pwm driver we need to rearrange the data structures used by the drivers. Signed-off-by: Peter Ujfalusi --- drivers/leds/leds-pwm.c | 39 +++ 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a

[PATCH v3 0/4] leds: leds-pwm: Device tree support

2012-12-10 Thread Peter Ujfalusi
Hello, Changes since v2: - rebased on top of linux-next - DT bindings now alligned with Grant's request - exporting of_pwm_request() from PWM core to allow clean DT bindings - DT binding documentation changed to reflect the changes Changes since v1: - As suggested by Bryan Wu: the legacy pwm_requ

Re: [PATCHv15 3/7] video: add of helper for display timings/videomode

2012-12-10 Thread Steffen Trumtrar
Hi, On Fri, Dec 07, 2012 at 03:12:48PM +0100, Philipp Zabel wrote: > Hi, > > Am Montag, den 26.11.2012, 18:56 +0200 schrieb Tomi Valkeinen: > > On 2012-11-26 18:10, Steffen Trumtrar wrote: > > > Hi, > > > > > > On Mon, Nov 26, 2012 at 04:38:36PM +0200, Tomi Valkeinen wrote: > > > > >>> +optiona

Re: [PATCHv15 3/7] video: add of helper for display timings/videomode

2012-12-10 Thread Tomi Valkeinen
On 2012-12-07 16:12, Philipp Zabel wrote: > Hi, > > Am Montag, den 26.11.2012, 18:56 +0200 schrieb Tomi Valkeinen: >> So what does the pixelclk-inverted mean? Normally the SoC drives pixel >> data on rising edge, and the panel samples it at falling edge? And >> vice-versa for inverted? Or the oth

Re: [RFC PATCH 2/3] regulator: max77686: Add support for various operating modes

2012-12-10 Thread Abhilash Kesavan
Adding missed Cc's On Mon, Dec 10, 2012 at 1:49 PM, Abhilash Kesavan wrote: > Mark Brown opensource.wolfsonmicro.com> writes: > > [...] >> Binding documenation is mandatory for any new OF properties, please add >> this. > Patch 3/3 of this series adds documentation for the max77686-opmode proper