Re: [RFC 3/5] ARM: CTI: Convert CTI helpers to AMBA bus driver

2012-12-21 Thread Pratik Patel
On Fri, Dec 21, 2012 at 02:27:03PM -0800, Pratik Patel wrote: > On Wed, Dec 12, 2012 at 03:43:06PM -0600, Jon Hunter wrote: > > + > > +/** > > + * cti_irq_ack - acknowledges the CTI trigger output > > + * @cti: CTI instance > > + * > > + * Acknowledges the CTI trigger output by writting to the appr

Re: [RFC 3/5] ARM: CTI: Convert CTI helpers to AMBA bus driver

2012-12-21 Thread Pratik Patel
On Wed, Dec 12, 2012 at 03:43:06PM -0600, Jon Hunter wrote: > + > +/** > + * cti_irq_ack - acknowledges the CTI trigger output > + * @cti: CTI instance > + * > + * Acknowledges the CTI trigger output by writting to the appropriate > + * bit in the CTI interrupt acknowledge register. > + */ > +int c

Re: CoreSight framework and drivers

2012-12-21 Thread Pratik Patel
On Thu, Dec 20, 2012 at 04:54:38PM -0600, Jon Hunter wrote: > > On 12/20/2012 01:51 PM, Pratik Patel wrote: > > On Thu, Dec 20, 2012 at 11:46:13AM -0600, Jon Hunter wrote: > >> > >> On 12/19/2012 03:24 PM, Pratik Patel wrote: > >> > >> [snip] > >> > >>> Currently we use the CoreSight virtual bus t

Re: CoreSight framework and drivers

2012-12-21 Thread Pratik Patel
On Thu, Dec 20, 2012 at 11:40:11PM +, Russell King - ARM Linux wrote: > On Thu, Dec 20, 2012 at 04:54:38PM -0600, Jon Hunter wrote: > > On 12/20/2012 01:51 PM, Pratik Patel wrote: > > > Ok, so are you referring to making CoreSight devices register > > > with AMBA bus instead of platform bus kee

Re: CoreSight framework and drivers

2012-12-21 Thread Pratik Patel
On Thu, Dec 20, 2012 at 09:16:15PM +0100, Jean Pihet wrote: > Hi Pratik, > > On Thu, Dec 20, 2012 at 8:51 PM, Pratik Patel wrote: > > On Thu, Dec 20, 2012 at 11:46:13AM -0600, Jon Hunter wrote: > >> > >> On 12/19/2012 03:24 PM, Pratik Patel wrote: > >> > >> [snip] > >> > >> > Currently we use the

RE: [PATCH] ipmi: add new kernel options to prevent automatic ipmi init

2012-12-21 Thread Evans, Robert
I have made a few observations in the past few days: 1) Unique IPMI device ID's did not seem to make a difference. Stratus still could not hot remove one of the KCS interfaces. 2) From what I see in IPMI spec section 20.1, having unique device ID's is not required: Controllers that implement

Re: [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver

2012-12-21 Thread Doug Anderson
Vivek, On Fri, Dec 21, 2012 at 12:16 AM, Vivek Gautam wrote: > Hi all, > > > On Wed, Dec 19, 2012 at 7:20 PM, Vivek Gautam > wrote: >> CC: Doug Anderson >> >> >> On Sat, Dec 15, 2012 at 12:53 PM, Grant Likely >> wrote: >>> On Thu, 13 Dec 2012 22:06:01 +0530, Vivek Gautam >>> wrote: dif

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-21 Thread Doug Anderson
On Fri, Dec 21, 2012 at 12:14 AM, Vivek Gautam wrote: > On Wed, Dec 19, 2012 at 7:16 PM, Vivek Gautam > wrote: >> >> On Sat, Dec 15, 2012 at 12:50 PM, Grant Likely >> wrote: >>> On Thu, 13 Dec 2012 20:22:26 +0530, Vivek Gautam >>> wrote: Using chip specific compatible string as it should

Re: [PATCH v3] usb: phy: samsung: Add support to set pmu isolation

2012-12-21 Thread Doug Anderson
Vivek, Nothing really serious below and things look good to me, but figured I'd put a few nits in (sorry!). On Fri, Dec 21, 2012 at 12:16 AM, Vivek Gautam wrote: > diff --git a/Documentation/devicetree/bindings/usb/samsung-usbphy.txt > b/Documentation/devicetree/bindings/usb/samsung-usbphy.txt

Re: [PATCH] RFC: input: Extend matrix-keypad device tree binding

2012-12-21 Thread Rob Herring
On 12/20/2012 03:41 PM, Simon Glass wrote: > Hi Dmitry, > > On Thu, Dec 20, 2012 at 1:13 PM, Dmitry Torokhov > wrote: >> Hi Simon, >> >> On Thu, Dec 20, 2012 at 12:23:58PM -0800, Simon Glass wrote: >>> >>> For the key repeat feature, we need to set this after the input device >>> is registered. S

Re: [PATCHv16 0/7] of: add display helper

2012-12-21 Thread Leela Krishna Amudala
Hello All, Any comments for this patch set..? Best Wishes, Leela Krishna Amudala. On Tue, Dec 18, 2012 at 10:34 PM, Steffen Trumtrar wrote: > > Hi! > > Finally, right in time before the end of the world on friday, v16 of the > display helpers. > > Changes since v15: > - move include/linu

Re: [PATCH v6 0/7] watchdog: dt: add support for the timeout-sec dt property

2012-12-21 Thread Wim Van Sebroeck
Hi Fabio, > > Hi all, > > this patchset add the timeout-sec property to the watchdog core, > > to the at91sam9_wdt driver and on all framework enabled watchdog driver > > with dt support. > > The at91sam9_wdt is tested on evk-pr3, > > the other drivers are compile tested only. > > > > This patchse

Re: [PATCH V5 2/2] ASoC: SAMSUNG: Add DT support for i2s

2012-12-21 Thread Padma Venkat
Hi, On Wed, Dec 19, 2012 at 10:39 PM, Mark Brown wrote: > On Wed, Dec 19, 2012 at 01:24:14PM +, Grant Likely wrote: >> On Thu, 13 Dec 2012 16:12:53 +0530, Padmavathi Venna >> wrote: > >> > +- compatible : "samsung,samsung-i2s" > >> Isn't that kind of redundant? :-) > >> The format of the c

Re: [PATCH v6 0/7] watchdog: dt: add support for the timeout-sec dt property

2012-12-21 Thread Fabio Porcedda
On Thu, Nov 22, 2012 at 1:51 PM, Fabio Porcedda wrote: > Hi all, > this patchset add the timeout-sec property to the watchdog core, > to the at91sam9_wdt driver and on all framework enabled watchdog driver > with dt support. > The at91sam9_wdt is tested on evk-pr3, > the other drivers are compile

Re: [PATCH] usb: phy: samsung: Add support for USB 3.0 phy for exynos5250

2012-12-21 Thread Vivek Gautam
Hi Felipe, On Wed, Dec 19, 2012 at 1:25 PM, Felipe Balbi wrote: > Hi, > > On Wed, Dec 19, 2012 at 11:52:01AM +0530, Vivek Gautam wrote: >> >>> @@ -736,7 +1035,41 @@ static int __devinit samsung_usbphy_probe(struct >> >>> platform_device *pdev) >> >>> >> >>> sphy->clk = clk; >> >>> >> >>>

[PATCH v5 7/7] leds: leds-pwm: Add device tree bindings

2012-12-21 Thread Peter Ujfalusi
The DT binding for the pwm-leds devices are similar to the gpio-leds type. LEDs are represented as sub-nodes of the pwm-leds device. The code for handling the DT boot is based on the code found in the leds-gpio driver and adapted to use PWMs instead of GPIOs. To avoid having custom cleanup code in

[PATCH v5 6/7] leds: leds-pwm: Simplify cleanup code

2012-12-21 Thread Peter Ujfalusi
The code looks more nicer if we use: while (i--) instead: if (i > 0) for (i = i - 1; i >= 0; i--) Signed-off-by: Peter Ujfalusi --- drivers/leds/leds-pwm.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c index

[PATCH v5 5/7] pwm: Add devm_of_pwm_get() as exported API for users

2012-12-21 Thread Peter Ujfalusi
When booted with DT users can use devm version of of_pwm_get() to benefit from automatic resource release. Signed-off-by: Peter Ujfalusi --- drivers/pwm/core.c | 30 ++ include/linux/pwm.h | 9 + 2 files changed, 39 insertions(+) diff --git a/drivers/pwm/co

[PATCH v5 4/7] pwm: core: Rename of_pwm_request() to of_pwm_get() and export it

2012-12-21 Thread Peter Ujfalusi
Allow client driver to use of_pwm_get() to get the PWM they need. This is needed for drivers which handle more than one PWM separately, like leds-pwm driver, which have: pwmleds { compatible = "pwm-leds"; kpad { label = "omap4::keypad"; pwms = <&twl_

[PATCH v5 3/7] pwm: Correct parameter name in header for *pwm_get() functions

2012-12-21 Thread Peter Ujfalusi
To synchronize the header file definition and the actual code. In the code the consumer parameter is named as con_id, change the header file and replace consumer -> con_id in the parameter list. Signed-off-by: Peter Ujfalusi --- include/linux/pwm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 de

[PATCH v5 2/7] leds: leds-pwm: Preparing the driver for device tree support

2012-12-21 Thread Peter Ujfalusi
In order to be able to add device tree support for leds-pwm driver we need to rearrange the data structures used by the drivers. Signed-off-by: Peter Ujfalusi --- drivers/leds/leds-pwm.c | 39 +++ 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a

[PATCH v5 1/7] leds: leds-pwm: Convert to use devm_get_pwm

2012-12-21 Thread Peter Ujfalusi
Update the driver to use the new API for requesting pwm so we can take advantage of the pwm_lookup table to find the correct pwm to be used for the LED functionality. Signed-off-by: Peter Ujfalusi --- drivers/leds/leds-pwm.c | 19 ++- include/linux/leds_pwm.h | 2 +- 2 files ch

[PATCH v5 0/7] leds: leds-pwm: Device tree support

2012-12-21 Thread Peter Ujfalusi
Hello, Changes since v4: - Commit message for patch #7 (DT binding for the leds-pwm driver) has been updated Changes since v3: Addressed comments from Thierry Redding: - DT binding documentation for leds-pwm updated - of_pwm_request() renamed as of_pwm_get() - introduction of devm_of_pwm_get()

Re: [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver

2012-12-21 Thread Vivek Gautam
Hi all, On Wed, Dec 19, 2012 at 7:20 PM, Vivek Gautam wrote: > CC: Doug Anderson > > > On Sat, Dec 15, 2012 at 12:53 PM, Grant Likely > wrote: >> On Thu, 13 Dec 2012 22:06:01 +0530, Vivek Gautam >> wrote: >>> Adding EHCI device tree node for Exynos5250 along with >>> the device base adress an

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-21 Thread Vivek Gautam
Hi all, On Wed, Dec 19, 2012 at 7:16 PM, Vivek Gautam wrote: > CC: Doug Anderson > > > On Sat, Dec 15, 2012 at 12:50 PM, Grant Likely > wrote: >> On Thu, 13 Dec 2012 20:22:26 +0530, Vivek Gautam >> wrote: >>> Using chip specific compatible string as it should be. >>> So fixing this for ehci-s

[PATCH v3] usb: phy: samsung: Add support to set pmu isolation

2012-12-21 Thread Vivek Gautam
Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautam --- .../devicetree/bindings/usb/samsung-usbphy.txt | 28 drivers/usb/phy/samsung-usbphy.c | 145 +--- 2 files c

[PATCH v3] usb: phy: samsung: Add support to set pmu isolation

2012-12-21 Thread Vivek Gautam
Changes from v2: - Removed the phandle type of device node properties, instead using sub-nodes now. - Removed the property 'samsung,enable-mask' since it is SoC dependent (SoCs like S5PV210 and S3C64XX have different bits to enable/disable phy controller in comparison to exysno4210 onwar