On Sunday 06 January 2013 04:48 AM, Dmitry Torokhov wrote:
On Sat, Jan 05, 2013 at 04:50:58PM +0530, Laxman Dewangan wrote:
HI Dmitry,
Thanks for quick review.
I will take care of your comment in next version. Some have my answer.
On Saturday 05 January 2013 01:36 PM, Dmitry Torokhov wrote:
This patch series:
- fix build warning,
- use devm_* for allocation,
- make column/rows configuration through DT and
- remove the rarely used key mapping table.
Changes from V1:
- renames the rows and pins property array.
- nit cleanups.
Changes from V2:
- remove the error checks changes
Fix the following build warning when building driver with CONFIG_PM_SLEEP
not selected.
tegra-kbc.c:360:13: warning: 'tegra_kbc_set_keypress_interrupt' defined but not
used [-Wunused-function]
Signed-off-by: Laxman Dewangan ldewan...@nvidia.com
---
Changes from V1, V2 and V3:
None
Use devm_* for memory, clock, irq, input device allocation. This reduces
code for freeing these resources.
Signed-off-by: Laxman Dewangan ldewan...@nvidia.com
---
Changes from V1: None
Changes from V2:
- remove the error checks changes from original.
- return -EBUSY when reg mapping fail.
-
The NVIDIA's Tegra KBC has maximum 24 pins to make matrix keypad.
Any pin can be configured as row or column. The maximum column pin
can be 8 and maximum row pin can be 16.
Remove the assumption that all first 16 pins will be used as row
and remaining as columns and Add the property for
Tegra KBC driver have the default key mapping for 16x8 configuration.
The key mapping can be provided through platform data or through DT
and the mapping varies from platform to platform, hence this default
mapping is not so useful. Remove the default mapping to reduce the code
lines of the
Hi David
Από το iPhone μου
6 Ιαν 2013, 5:58, ο/η David Gibson da...@gibson.dropbear.id.au έγραψε:
On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote:
After fixing the is_printable bug the test suite fails.
Fix it with this patch
Signed-off-by: Pantelis Antoniou
Hi Folks
I'm moving the cpuidle code for Kirkwood into drivers/cpuidle. I'm
following the way cpuidle-calxeda.c instantiates the driver, it uses
module_init(calxeda_cpuidle_init) and calxeda_cpuidle_init() uses
of_machine_is_compatible(calxeda,highbank) so only loading the
driver in a
On Sun, Jan 06, 2013 at 02:18:05PM +0100, Andrew Lunn wrote:
I'm moving the cpuidle code for Kirkwood into drivers/cpuidle. I'm
following the way cpuidle-calxeda.c instantiates the driver, it uses
module_init(calxeda_cpuidle_init) and calxeda_cpuidle_init() uses
On Sun, Jan 06, 2013 at 01:41:13PM +, Russell King - ARM Linux wrote:
On Sun, Jan 06, 2013 at 02:18:05PM +0100, Andrew Lunn wrote:
I'm moving the cpuidle code for Kirkwood into drivers/cpuidle. I'm
following the way cpuidle-calxeda.c instantiates the driver, it uses
On Sat, Jan 05, 2013 at 12:06:58AM -0800, Dmitry Torokhov wrote:
On Sat, Jan 05, 2013 at 01:15:08PM +0530, Laxman Dewangan wrote:
[...]
@@ -735,25 +738,16 @@ static int tegra_kbc_probe(struct platform_device
*pdev)
spin_lock_init(kbc-lock);
setup_timer(kbc-timer,
On Sun, Jan 06, 2013 at 08:27:39PM +0100, Thierry Reding wrote:
On Sat, Jan 05, 2013 at 12:06:58AM -0800, Dmitry Torokhov wrote:
On Sat, Jan 05, 2013 at 01:15:08PM +0530, Laxman Dewangan wrote:
[...]
@@ -735,25 +738,16 @@ static int tegra_kbc_probe(struct platform_device
*pdev)
The function davinci_i2c_remove in drivers/i2c/busses/i2c-davinci.c
contains the following code:
put_device(pdev-dev);
clk_disable_unprepare(dev-clk);
clk_put(dev-clk);
dev-clk = NULL;
davinci_i2c_write_reg(dev, DAVINCI_I2C_MDR_REG, 0);
Device tree can store multiple strings in a single property.
We didn't handle that case properly.
Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com
Applied.
Thanks,
jdl
___
devicetree-discuss mailing list
The method used did not account for multi-part strings.
Signed-off-by: Pantelis Antoniou pa...@antoniou-consulting.com
Applied.
Plese consider a follow-up patch to address David's concerns.
Thanks,
jdl
___
devicetree-discuss mailing list
tests will need fdt type definitions provided in a subsequent patch
to libfdt_env.h. Since libfdt.h includes libfdt_env.h in the right
order anyway, just remove the fdt.h include.
Signed-off-by: Kim Phillips kim.phill...@freescale.com
Applied.
Thanks,
jdl
in order to get the upcoming fdt type definitions.
Signed-off-by: Kim Phillips kim.phill...@freescale.com
Applied.
Thanks,
jdl
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
Projects such as linux and u-boot run sparse on libfdt. libfdt
contains the notion of endianness via usage of endian conversion
functions such as fdt32_to_cpu. As such, in order to pass endian
checks, libfdt has to annotate its fdt variables such that sparse
can warn when mixing bitwise and
libfdt/fdt.c:104:28: warning: incorrect type in argument 1 (different base
types)
libfdt/fdt.c:104:28:expected restricted fdt32_t [usertype] x
libfdt/fdt.c:104:28:got unsigned int const [unsigned] [usertype] noident
libfdt/fdt.c:124:40: warning: incorrect type in argument 1
The 'deprecated' warning is in there for more than 4 years now
and nobody seemed to be confused enough to vote it out. Let's
drop the warning then.
This reverts commit 315c5d095ebdf29f1912186e76ab9f95e694b18a.
Signed-off-by: Horst Kronstorfer hkron...@frequentis.com
Applied.
Thanks,
From: Stephen Warren swar...@nvidia.com
Not all /bin/echo implementations support the -e option. Instead, use
printf, which appears to be more widely available than /bin/echo -e.
See commit eaec1db fdtget-runtest.sh: Fix failures when /bin/sh isn't
bash for history.
I have tested this
On Wed, Jun 27, 2012 at 08:22:57AM -0500, Jon Loeliger wrote:
[ Forwarded to devicetree dev list for comment. --jdl ]
Yeah, I guess that makes sense.
--- Forwarded Message
Subject: [PATCH] Allow simple cross-compilation of library
To: j...@jdl.com
From: Christoffer
Hi David
=CE=91=CF=80=CF=8C =CF=84=CE=BF iPhone =CE=BC=CE=BF=CF=85
6 =CE=99=CE=B1=CE=BD 2013, 5:58, =CE=BF/=CE=B7 David Gibson da...@gibson.dr=
opbear.id.au =CE=AD=CE=B3=CF=81=CE=B1=CF=88=CE=B5:
On Fri, Jan 04, 2013 at 09:16:08PM +0200, Pantelis Antoniou wrote:
After fixing the
On Wed, Dec 19, 2012 at 9:18 PM, Maxime Ripard
maxime.rip...@free-electrons.com wrote:
The Allwinner SoCs have an IP module that handle both the muxing and the
GPIOs.
Sorry for very slow review :-( :-(
include/linux/pinctrl/pinconf-generic.h|1 +
Can you break this into a
On Mon, Dec 31, 2012 at 12:23:50PM +0100, Guennadi Liakhovetski wrote:
sh7372_add_early_devices_dt() and sh7372_add_standard_devices_dt() are
defined as global functions in arch/arm/mach-shmobile/setup-sh7372.c,
but their declarations are missing. Add them to common.h, where similar
functions
Hi,
This series makes da8xx-fb driver (device found on DaVinci and AM335x)
capable of handling runtime timing configuration by adding fb_set_par.
The last change adds actual fb_set_par support. Other preceeding
changes makes the way clear for it as well as does certain cleanup's
on the way.
Check whether struct fb_var_screeninfo fields are sane, if not
update it to be within allowed limits.
If user sends down buggy var values, this will bring those within
allowable limits. And fb_set_par is not supposed to change var
values, fb_check_var has to ensure that values are proper.
lcd_reset function doesn't require any arguement, remove it.
Signed-off-by: Afzal Mohammed af...@ti.com
---
drivers/video/da8xx-fb.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index 89446aa..c8e97de 100644
---
modedb structure is now used to store panel information, run modedb
helper over it for initial update of var information instead of
equating each fields.
While at it, remove redundant update of bits_per_pixel.
Note: pixclock is overridden with proper value using an existing code
as currently
modedb helper now updates var information based on the detected
panel, remove the unnecessary initialization.
Signed-off-by: Afzal Mohammed af...@ti.com
---
drivers/video/da8xx-fb.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/drivers/video/da8xx-fb.c
store current videomode and controller data so that reconfiguring can
be done easily. Reconfiguring would be required in fb_set_par, which
is going to be added soon.
If these details are not stored, the work probe does to retrieve these
information would have to repeated at the place of
store lcd clk rate always, i.e. irrespective of whether CPUFREQ is
enabled or not. This can be used to get clk rate directly instead of
enquiring with clock framework with clk handle every time.
Signed-off-by: Afzal Mohammed af...@ti.com
---
drivers/video/da8xx-fb.c |4 +---
1 file changed,
Use the new modedb field to store pix clk. Reorganize existing clock
divider functions with names now corresponding to what they do, add
common function prefix.
Fix existing panel modedb pixclock to be in ps instead of Hz. This
needed a change in the way clock divider is calculated. As modedb
store struct device pointer so that dev_dbg/err can be used outside
of probe.
Signed-off-by: Afzal Mohammed af...@ti.com
---
drivers/video/da8xx-fb.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index 19ee560..663b3c5 100644
---
Update var pixclock with the value that is configurable in hardware.
This lets user know the actual pixclock.
Signed-off-by: Afzal Mohammed af...@ti.com
---
drivers/video/da8xx-fb.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/video/da8xx-fb.c
fb_set_par helps in runtime configuration of lcd controller like
changing resolution, pixel clock etc. (eg. using fbset utility)
Reconfigure lcd controller based on information passed by framework.
Enable raster back if it was already enabled.
As fb_set_par would get invoked indirectly from
Hi,
This series adds DT support to da8xx-fb driver (device found on
DaVinci and AM335x SoC's). It does certain cleanup's in the process.
This makes use of Steffen Trumtrar's v16 of display timing DT support.
Testing has been done on AM335x SoC based boards like AM335x EVM and
AM335x EVM-SK. It
From: Manjunathappa, Prakash prakash...@ti.com
Set only LCD_V2_TFT_24BPP_MODE bit for 24bpp and LCD_V2_TFT_24BPP_UNPACK
bit along with LCD_V2_TFT_24BPP_MODE for 32bpp configuration.
Patch is tested on am335x-evm for 24bpp and da850-evm for 16bpp
configurations.
Signed-off-by: Manjunathappa,
interrupt handler is checking for sync lost interrupt, but it was not
enabled, enable it.
Signed-off-by: Afzal Mohammed af...@ti.com
---
drivers/video/da8xx-fb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index
Replace existing resource handling in the driver with managed device
resource.
Signed-off-by: Afzal Mohammed af...@ti.com
---
drivers/video/da8xx-fb.c | 35 ++-
1 file changed, 6 insertions(+), 29 deletions(-)
diff --git a/drivers/video/da8xx-fb.c
Move panel detection to a separate function, this helps in readability
as well as makes DT support cleaner.
Signed-off-by: Afzal Mohammed af...@ti.com
---
drivers/video/da8xx-fb.c | 42 ++
1 file changed, 26 insertions(+), 16 deletions(-)
diff --git
Ensure that platform data is present before checking whether platform
callback is present (the one used to control backlight). So far this
was not an issue as driver was purely non-DT triggered, but now DT
support has been added.
Signed-off-by: Afzal Mohammed af...@ti.com
---
Ensure that platform data contains pointer for lcd_ctrl_config.
Signed-off-by: Afzal Mohammed af...@ti.com
---
drivers/video/da8xx-fb.c |5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index e119ec8..32ce385 100644
---
Obtain fb_videomode details for the connected lcd panel using the
display timing details present in DT.
Signed-off-by: Afzal Mohammed af...@ti.com
---
.../devicetree/bindings/video/fb-da8xx.txt | 20
drivers/video/da8xx-fb.c | 16
This driver is DT probe-able, hence ensure presence of platform data
only for non-DT boot.
Signed-off-by: Afzal Mohammed af...@ti.com
---
drivers/video/da8xx-fb.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index
strcut lcd_ctrl_config information required for driver is currently
obtained via platform data. To handle DT probing, create
lcd_ctrl_config and populate it with default values, these values are
sufficient for the panels so far used with this controller to work.
Signed-off-by: Afzal Mohammed
Hi,
This series add DT sources for AM335x SoC as well as AM335x based
boards.
As pinmux is an SoC specific detail rather than IP specific one,
addition of pin control has been done in a separate patch from
the one in which display timings are added. Also it may aid in
debugging in case of any
Add lcdc node.
Signed-off-by: Afzal Mohammed af...@ti.com
---
arch/arm/boot/dts/am33xx.dtsi |8
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index c2f14e8..432d4bb8 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++
Update lcdc node with panel timings (typical) for AM335X-EVM.
Signed-off-by: Afzal Mohammed af...@ti.com
---
arch/arm/boot/dts/am335x-evm.dts | 20
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index
Update pin mux information for lcd panel on AM335X-EVM
Signed-off-by: Afzal Mohammed af...@ti.com
---
arch/arm/boot/dts/am335x-evm.dts | 35 ++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/am335x-evm.dts
Update lcdc node with panel timings (typical) for AM335X-EVMSK.
Signed-off-by: Afzal Mohammed af...@ti.com
---
arch/arm/boot/dts/am335x-evmsk.dts | 20
1 file changed, 20 insertions(+)
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts
b/arch/arm/boot/dts/am335x-evmsk.dts
Update pin mux information for lcd panel on AM335X-EVMSK.
Signed-off-by: Afzal Mohammed af...@ti.com
---
arch/arm/boot/dts/am335x-evmsk.dts | 35 ++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/am335x-evmsk.dts
Hi Steffen,
On Tue, Dec 18, 2012 at 22:34:14, Steffen Trumtrar wrote:
Add helper to get fb_videomode from devicetree.
drivers/video/fbmon.c | 42 ++
include/linux/fb.h|4
This breaks DaVinci (da8xx_omapl_defconfig), following change was
Hi Steffen,
On Tue, Dec 18, 2012 at 22:34:09, Steffen Trumtrar wrote:
Finally, right in time before the end of the world on friday, v16 of the
display helpers.
After another big bang, your series in the previous world was tried ;)
This series has been tested on DA850 EVM, AM335x EVM, EVM-SK
On Mon, Jan 07, 2013 at 06:23:54AM +, Mohammed, Afzal wrote:
Hi Steffen,
On Tue, Dec 18, 2012 at 22:34:09, Steffen Trumtrar wrote:
Finally, right in time before the end of the world on friday, v16 of the
display helpers.
After another big bang, your series in the previous world
55 matches
Mail list logo
