Re: [PATCH v1 02/12] input: matrix-keymap: func call coding style nit

2013-06-22 Thread Gerhard Sittig
On Sat, Jun 22, 2013 at 04:18 +0200, Marek Vasut wrote: ret = matrix_keypad_map_key(input_dev, rows, cols, row_shift, key); if (ret) return ret; Now that you return correct error codes from above, you should propagate them through. Will do, queued for v2. Thank you for reviewing

Re: [PATCH v1 01/12] input: matrix-keypad: update devicetree binding doc

2013-06-22 Thread Gerhard Sittig
Let me first thank you for reviewing the set and for providing so much feedback! Then let me give a little background: The first part of the series with the doc update doesn't introduce anything new into the driver, it just makes the document catch up with what the driver already does. And the

Re: [PATCH v1 04/12] input: matrix-keypad: push/pull, separate polarity

2013-06-22 Thread Gerhard Sittig
On Fri, Jun 21, 2013 at 15:34 -0600, Stephen Warren wrote: On 06/21/2013 12:09 PM, Gerhard Sittig wrote: extend the device tree adjustable hardware configuration: - allow for differing polarity of the row and column GPIO pins - optionally fully drive column output pins instead of the

[PATCH 0/2] media: i2c: ths8200: Feature enhancement

2013-06-22 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com The first patch of the series adds supports for asynchronous subdev registration for ths8200 driver, and the second patch of the series adds OF support the driver. Lad, Prabhakar (2): media: i2c: ths8200: support asynchronous probing media:

[PATCH 1/2] media: i2c: ths8200: support asynchronous probing

2013-06-22 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch supports both synchronous and asynchronous ths8200 subdevice probing. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- drivers/media/i2c/ths8200.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git

[PATCH 2/2] media: i2c: ths8200: add OF support

2013-06-22 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com add OF support for the ths8200 driver. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- .../devicetree/bindings/media/i2c/ths8200.txt | 19 +++ drivers/media/i2c/ths8200.c|9 +

Re: [PATCH v1 07/12] input: keypad-matrix: introduce polling support

2013-06-22 Thread Gerhard Sittig
On Fri, Jun 21, 2013 at 15:38 -0600, Stephen Warren wrote: On 06/21/2013 12:09 PM, Gerhard Sittig wrote: detecting changes in the key press status may not work reliably in interrupt driven mode (see the documentation part of the change for details) add support to poll the matrix in

Re: [PATCH v1 08/12] input: keypad-matrix: tell GPIO pins from matrix lines

2013-06-22 Thread Gerhard Sittig
On Fri, Jun 21, 2013 at 15:41 -0600, Stephen Warren wrote: On 06/21/2013 12:09 PM, Gerhard Sittig wrote: diff --git a/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt b/Documentation/devicetree/bindings/input/gpio-matrix-keypad.txt +The driver assumes that all

Re: [PATCH v6 4/8] ARM: Add .init_platform() callback to machine descriptor

2013-06-22 Thread Tomasz Figa
On Friday 21 of June 2013 16:12:15 Arnd Bergmann wrote: On Friday 21 June 2013, Tomasz Figa wrote: To me, this new hook is strictly equivalent to init_irq. What do we gain exactly? I didn't think init_irq was going away... I know init_irq is not pretty, and we tend to overload it

Re: [PATCH v1 10/12] input: keypad_matrix: use usleep_range() for scan delay

2013-06-22 Thread Gerhard Sittig
On Fri, Jun 21, 2013 at 16:00 -0600, Stephen Warren wrote: On 06/21/2013 12:09 PM, Gerhard Sittig wrote: querying keyboards isn't a time critical task and does not depend on exact timing in the microseconds order -- the timeouts and delays are arbitrary choices or educated guesses at best

Re: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-06-22 Thread Lars-Peter Clausen
On 06/22/2013 01:55 PM, Jonathan Cameron wrote: On 06/20/2013 07:57 PM, Alexandre Belloni wrote: The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable gain and sampling rates. Sorry, somewhat low on time today so only a quick review. 1) Missing userspace ABI

Re: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-06-22 Thread Jonathan Cameron
On 06/20/2013 07:57 PM, Alexandre Belloni wrote: The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable gain and sampling rates. Sorry, somewhat low on time today so only a quick review. 1) Missing userspace ABI documentation. Also, perhaps min_conversions is a little

Re: [PATCH 2/2] regulator: palmas: model SMPS10 as two regulators

2013-06-22 Thread Laxman Dewangan
On Friday 21 June 2013 07:30 PM, Kishon Vijay Abraham I wrote: On Friday 21 June 2013 06:55 PM, Laxman Dewangan wrote: On Thursday 20 June 2013 08:56 PM, Kishon Vijay Abraham I wrote: Hi, On Thursday 20 June 2013 08:14 PM, Laxman Dewangan wrote: Have you added the regulator supply entries?

Re: [PATCHv2 1/3] iio: Add Nuvoton NAU7802 ADC driver

2013-06-22 Thread Lars-Peter Clausen
On 06/22/2013 03:07 PM, Alexandre Belloni wrote: On 22/06/2013 14:02, Lars-Peter Clausen wrote: On 06/22/2013 01:55 PM, Jonathan Cameron wrote: On 06/20/2013 07:57 PM, Alexandre Belloni wrote: The Nuvoton NAU7802 ADC is a 24-bit 2-channels I2C ADC, with adjustable gain and sampling rates.

Re: [PATCH v1 02/12] input: matrix-keymap: func call coding style nit

2013-06-22 Thread Marek Vasut
Dear Gerhard Sittig, On Sat, Jun 22, 2013 at 04:18 +0200, Marek Vasut wrote: ret = matrix_keypad_map_key(input_dev, rows, cols, row_shift, key); if (ret) return ret; Now that you return correct error codes from above, you should propagate them through. Will do, queued for

[PATCH v7 5/8] ARM: s3c64xx: Add board file for boot using Device Tree

2013-06-22 Thread Tomasz Figa
This patch adds board file that will be used to boot S3C64xx-based boards using Device Tree. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- arch/arm/mach-s3c64xx/Kconfig | 16 +++ arch/arm/mach-s3c64xx/Makefile | 1 + arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c | 85

Re: [PATCH v6 4/8] ARM: Add .init_platform() callback to machine descriptor

2013-06-22 Thread Tomasz Figa
Hi Kukjin, On Friday 21 of June 2013 02:35:20 Tomasz Figa wrote: Most ARM platforms have parts that should be initialized as early as possible, which usually means as soon as memory management (kmalloc, ioremap) starts to work, However, currently there is no appropriate callback in

Re: [PATCH] Bump version number to 1.4.0

2013-06-22 Thread Jon Loeliger
How about if nobody objects, a release is made by the end of the week? Works for me. Great! I didn't see any objections, and the week is basically over. Are we good for a release today? I get it, thanks. I also have to have time to do it. jdl

[PATCH RFC v3] media: OF: add video sync endpoint property

2013-06-22 Thread Prabhakar Lad
From: Lad, Prabhakar prabhakar.cse...@gmail.com This patch adds video sync properties as part of endpoint properties and also support to parse them in the parser. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cc: Hans Verkuil hans.verk...@cisco.com Cc: Laurent Pinchart