Re: [PATCH v2] regulator: pfuze100: add pfuze100 regulator driver

2013-07-14 Thread Shawn Guo
On Mon, Jul 15, 2013 at 02:40:39PM +0800, Robin Gong wrote: > > > +static const struct of_device_id pfuze_dt_ids[] = { > > > + { .compatible = "fsl,pfuze100", .data = (void *)PFUZE_ID_PFUZE100}, > > > > You do not use .data in the driver at all, and can just drop it. > > > good catch. .driver_data

Re: [PATCHv2] am33xx: cpsw: default to ethernet hwaddr from efuse if not defined in dt

2013-07-14 Thread Peter Korsgaard
> "Mark" == Mark Jackson writes: Hi, Mark> On 08/07/13 13:42, Mark Jackson wrote: >> On 18/01/13 05:14, Mugunthan V N wrote: >>> On 1/18/2013 3:48 AM, Peter Korsgaard wrote: When booting with CONFIG_ARM_APPENDED_DTB (either because of using an old U-Boot, not wanting the hassl

Re: [PATCH V3 1/3] dts: change Marvell prefix to 'marvell'

2013-07-14 Thread Jason Cooper
On Sat, Jul 13, 2013 at 12:56:25PM -0700, Olof Johansson wrote: > On Wed, Jul 10, 2013 at 2:50 PM, Jason Cooper wrote: > > On Wed, Jul 10, 2013 at 10:08:50PM +0800, Haojian Zhuang wrote: > >> On Wed, Jul 10, 2013 at 8:24 PM, Jason Cooper wrote: > >> > On Wed, Jul 10, 2013 at 04:19:46PM +0800, Hao

Re: [PATCH v2] regulator: pfuze100: add pfuze100 regulator driver

2013-07-14 Thread Shawn Guo
The patch looks good. Comments below are mostly random coding style nitpicks. On Fri, Jul 12, 2013 at 12:54:15PM +0800, Robin Gong wrote: > Add pfuze100 regulator driver. > > Signed-off-by: Robin Gong > --- > .../devicetree/bindings/regulator/pfuze100.txt | 113 + > drivers/regulator/

Re: [PATCH v2] media: i2c: adv7343: add OF support

2013-07-14 Thread Sylwester Nawrocki
Hi Prabhakar, On 07/13/2013 01:12 PM, Prabhakar Lad wrote: From: "Lad, Prabhakar" add OF support for the adv7343 driver. Signed-off-by: Lad, Prabhakar --- Changes for v2: 1: Fixed naming of properties. .../devicetree/bindings/media/i2c/adv7343.txt | 54 drivers/

Re: [PATCH v2 2/2] media: i2c: tvp7002: add OF support

2013-07-14 Thread Sylwester Nawrocki
Hi Prabhakar, On 07/12/2013 06:43 AM, Prabhakar Lad wrote: On Fri, Jul 12, 2013 at 3:34 AM, Sylwester Nawrocki wrote: On 07/11/2013 07:09 PM, Prabhakar Lad wrote: [...] And include/media/tvp70002.h: * fid_polarity: * 0 -> the field ID output is set to logic 1 f

Re: [PATCH V3 1/3] dts: change Marvell prefix to 'marvell'

2013-07-14 Thread Arnd Bergmann
On Thursday 11 July 2013, Neil Zhang wrote: > > > > To do this properly, the drivers are going to have to be compatible > > > > with the old and the new names, and the binding docs updated to > > > > reflect the legacy name and the preferred name. > > > > > > Properly would be as above. You can sto

Re: [PATCH RFC v3] media: OF: add video sync endpoint property

2013-07-14 Thread Sylwester Nawrocki
Hi Prabhakar, On 07/12/2013 06:29 AM, Prabhakar Lad wrote: On Fri, Jul 12, 2013 at 2:45 AM, Sylwester Nawrocki wrote: On 07/11/2013 01:41 PM, Prabhakar Lad wrote: [...] diff --git a/drivers/media/v4l2-core/v4l2-of.c b/drivers/media/v4l2-core/v4l2-of.c index aa59639..1a54530 100644 --- a/dri

Re: [Ksummit-2013-discuss] [ATTEND] Handling of devicetree bindings

2013-07-14 Thread Guenter Roeck
On Sun, Jul 14, 2013 at 01:46:45AM +0200, Linus Walleij wrote: > On Sat, Jul 13, 2013 at 10:49 PM, Guenter Roeck wrote: > > On Sat, Jul 13, 2013 at 08:26:47PM +0100, Wolfram Sang wrote: > > >> I think the KS would be a good opportunity to present the status quo, > >> show some rules of thumb and

[PATCH RFC v2 4/5] dma: mpc512x: register for device tree channel lookup

2013-07-14 Thread Gerhard Sittig
register the controller for device tree based lookup of DMA channels (non-fatal for backwards compatibility with older device trees), provide the '#dma-cells' property in the shared mpc5121.dtsi file, and introduce a bindings document for the MPC512x DMA controller Signed-off-by: Gerhard Sittig -

[PATCH RFC v2 3/5] dma: of: Add common xlate function for matching by channel id

2013-07-14 Thread Gerhard Sittig
From: Lars-Peter Clausen This patch adds a new common OF dma xlate callback function which will match a channel by it's id. The binding expects one integer argument which it will use to lookup the channel by the id. Unlike of_dma_simple_xlate this function is able to handle a system with multip

[PATCH RFC v2 5/5] HACK mmc: mxcmmc: enable clocks for the MPC512x

2013-07-14 Thread Gerhard Sittig
Q&D HACK to enable SD card support without correct COMMON_CLK support, best viewed with 'git diff -w -b', NOT acceptable for mainline (NAKed) Signed-off-by: Gerhard Sittig --- drivers/mmc/host/mxcmmc.c | 41 +++-- 1 file changed, 27 insertions(+), 14 deletio

[PATCH RFC v2 2/5] dma: mpc512x: add support for peripheral transfers

2013-07-14 Thread Gerhard Sittig
From: Alexander Popov introduce support for slave s/g transfer preparation and the associated device control callback in the MPC512x DMA controller driver, which adds support for data transfers between memory and peripheral I/O to the previously supported mem-to-mem transfers refuse to prepare c

[PATCH RFC v2 1/5] dma: mpc512x: re-order mpc8308 specific instructions

2013-07-14 Thread Gerhard Sittig
it's rather unexpected to have the MPC8308 specific code in the 'else' branch so distant from the "is MPC8308?" check concentrate the test and the specific code for MPC8308 in the 'if' branch and handle MPC512x in the 'else' branch; use a symbolic channel count which in combination with the re-ord

[PATCH RFC v2 0/5] MPC512x DMA slave s/g support, OF DMA lookup

2013-07-14 Thread Gerhard Sittig
this series - introduces slave s/g support (that's support for DMA transfers which involve peripherals in contrast to mem-to-mem transfers) - adds device tree based lookup support for DMA channels - combines floating patches and related feedback which already covered several aspects of what the

Re: [PATCH RFC 1/8] powerpc: mpc512x_dma: add support for data transfers between memory and i/o memory

2013-07-14 Thread Gerhard Sittig
On Sun, Jul 14, 2013 at 12:05 +0200, Lars-Peter Clausen wrote: > > On 07/12/2013 05:26 PM, Gerhard Sittig wrote: > [...] > ] > > + if (mchan->tcd_nunits) > > + tcd->nbytes = mchan->tcd_nunits * 4; > > + else > > + tcd->nbytes = 64; > > Just

Re: [PATCH RFC 5/8] dma: mpc512x: use symbolic specifiers for DMA channels

2013-07-14 Thread Gerhard Sittig
On Sun, Jul 14, 2013 at 10:50 +0200, Arnd Bergmann wrote: > > On Saturday 13 July 2013, Gerhard Sittig wrote: > > > > [ ... ] > > > > Thank you for the feedback. > > > > OK, so not adding the dt-bindings header leads to no change in > > the DTS nodes, which in turn collapses 5/8 into something

Re: [PATCH RFC 1/8] powerpc: mpc512x_dma: add support for data transfers between memory and i/o memory

2013-07-14 Thread Lars-Peter Clausen
On 07/12/2013 05:26 PM, Gerhard Sittig wrote: [...] ] > + if (mchan->tcd_nunits) > + tcd->nbytes = mchan->tcd_nunits * 4; > + else > + tcd->nbytes = 64; Just wondering where does the magic 64 come from? __

Re: [PATCH RFC 5/8] dma: mpc512x: use symbolic specifiers for DMA channels

2013-07-14 Thread Lars-Peter Clausen
On 07/14/2013 10:50 AM, Arnd Bergmann wrote: > On Saturday 13 July 2013, Gerhard Sittig wrote: >> [ MPC8308 knowledge required, see below ] >> >> On Sat, Jul 13, 2013 at 09:17 +0200, Arnd Bergmann wrote: >>> >>> On Friday 12 July 2013, Gerhard Sittig wrote: +++ b/include/dt-bindings/dma/mpc512

Re: [PATCH RFC 5/8] dma: mpc512x: use symbolic specifiers for DMA channels

2013-07-14 Thread Arnd Bergmann
On Saturday 13 July 2013, Gerhard Sittig wrote: > [ MPC8308 knowledge required, see below ] > > On Sat, Jul 13, 2013 at 09:17 +0200, Arnd Bergmann wrote: > > > > On Friday 12 July 2013, Gerhard Sittig wrote: > > > +++ b/include/dt-bindings/dma/mpc512x-dma.h > > > @@ -0,0 +1,21 @@ > > > +/* > > >