Re: [RFC] [PATCH] ARM: tegra: emc: device tree bindings

2011-10-17 Thread Anton Staaf
On Mon, Oct 17, 2011 at 10:52 AM, Olof Johansson o...@lixom.net wrote: First cut at device tree bindings for the EMC tables on tegra. Note that I have a prerequisite patch that changes the tegra2_emc code to be a platform driver; but I wanted to do a sanity-check of my device tree usage here

Re: [PATCH v4 3/3] dtc: Add support for variable sized elements

2011-10-11 Thread Anton Staaf
On Tue, Oct 11, 2011 at 7:44 AM, David Gibson da...@gibson.dropbear.id.au wrote: On Tue, Sep 27, 2011 at 11:11:38AM -0700, Anton Staaf wrote: Elements of size 8, 16, 32, and 64 bits are supported.  The new /bits/ syntax was selected so as to not pollute the reserved keyword space with uint8

Re: [PATCH v4 3/3] dtc: Add support for variable sized elements

2011-10-11 Thread Anton Staaf
On Tue, Oct 11, 2011 at 8:22 AM, Jon Loeliger j...@jdl.com wrote: Signed-off-by: Anton Staaf robot...@chromium.org What the hell, I think I've convinced myself that /bits/ is good enough. Thanks David, I haven't thought of anything more appropriate either. I'm looking forward

[PATCH v4 0/3] Variable sized array element support

2011-10-11 Thread Anton Staaf
- Rename non-terminal celllistprefix to arrayprefix - Rename semantic variable celllist to array - Update documentation to use array and element instead of cell list and cell Anton Staaf (3): libfdt: Add fdt16_to_cpu utility function dtc: Add data_append_integer function dtc: Add support

[PATCH v4 1/3] libfdt: Add fdt16_to_cpu utility function

2011-10-11 Thread Anton Staaf
This utility routine will be used in the variable size cell literal append code. It is a straightforward adaptation of the fdt32_to_cpu function. Signed-off-by: Anton Staaf robot...@chromium.org Acked-by: David Gibson da...@gibson.dropbear.id.au Cc: Jon Loeliger j...@jdl.com Cc: David Gibson da

[PATCH v4 2/3] dtc: Add data_append_integer function

2011-10-11 Thread Anton Staaf
and data_append_addr to use data_append_integer. Signed-off-by: Anton Staaf robot...@chromium.org Acked-by: David Gibson da...@gibson.dropbear.id.au Cc: David Gibson da...@gibson.dropbear.id.au Cc: Jon Loeliger j...@jdl.com Cc: Grant Likely grant.lik...@secretlab.ca --- data.c | 39

[PATCH v4 3/3] dtc: Add support for variable sized elements

2011-10-11 Thread Anton Staaf
-off-by: Anton Staaf robot...@chromium.org Acked-by: David Gibson da...@gibson.dropbear.id.au Cc: Jon Loeliger j...@jdl.com Cc: David Gibson da...@gibson.dropbear.id.au Cc: Grant Likely grant.lik...@secretlab.ca --- Documentation/dts-format.txt | 34 +++- dtc-lexer.l

Re: [PATCH v4 0/3] Variable sized array element support

2011-10-11 Thread Anton Staaf
' to last two) Changes in v4: - Only add phandle reference marker when element size is 32-bits - Rename non-terminal celllistprefix to arrayprefix - Rename semantic variable celllist to array - Update documentation to use array and element instead of cell list and cell Anton Staaf (3

Re: [PATCH v3 3/3] dtc: Add support for variable sized cells

2011-09-27 Thread Anton Staaf
On Mon, Sep 26, 2011 at 5:58 PM, David Gibson da...@gibson.dropbear.id.au wrote: On Mon, Sep 26, 2011 at 01:48:31PM -0700, Anton Staaf wrote: On Sun, Sep 25, 2011 at 4:04 AM, David Gibson da...@gibson.dropbear.id.au wrote: On Fri, Sep 23, 2011 at 11:02:54AM -0700, Anton Staaf wrote

Re: [PATCH v3 3/3] dtc: Add support for variable sized cells

2011-09-27 Thread Anton Staaf
On Mon, Sep 26, 2011 at 5:55 PM, David Gibson da...@gibson.dropbear.id.au wrote: On Mon, Sep 26, 2011 at 10:15:48AM -0700, Anton Staaf wrote: On Sun, Sep 25, 2011 at 4:04 AM, David Gibson da...@gibson.dropbear.id.au wrote: On Fri, Sep 23, 2011 at 11:02:54AM -0700, Anton Staaf wrote: [snip

[PATCH v4 3/3] dtc: Add support for variable sized elements

2011-09-27 Thread Anton Staaf
-off-by: Anton Staaf robot...@chromium.org Cc: Jon Loeliger j...@jdl.com Cc: David Gibson da...@gibson.dropbear.id.au Cc: Grant Likely grant.lik...@secretlab.ca --- Documentation/dts-format.txt | 34 +++- dtc-lexer.l |6 +++ dtc-parser.y | 70

[PATCH v4 1/3] libfdt: Add fdt16_to_cpu utility function

2011-09-27 Thread Anton Staaf
This utility routine will be used in the variable size cell literal append code. It is a straightforward adaptation of the fdt32_to_cpu function. Signed-off-by: Anton Staaf robot...@chromium.org Cc: Jon Loeliger j...@jdl.com Cc: David Gibson da...@gibson.dropbear.id.au Cc: Grant Likely grant.lik

Re: [PATCH v3 3/3] dtc: Add support for variable sized cells

2011-09-26 Thread Anton Staaf
On Sun, Sep 25, 2011 at 4:04 AM, David Gibson da...@gibson.dropbear.id.au wrote: On Fri, Sep 23, 2011 at 11:02:54AM -0700, Anton Staaf wrote: Cells of size 8, 16, 32, and 64 bits are supported.  The new /bits/ syntax was selected so as to not pollute the reserved keyword space with uint8

[PATCH v3 0/3] Variable sized cell support

2011-09-23 Thread Anton Staaf
data_append_integer - Rewrite data_append_cell|addr in terms of data_append_integer - Minor cosmetic change to property names in test case (added 'b' to last two) Anton Staaf (3): libfdt: Add fdt16_to_cpu utility function dtc: Add data_append_integer function dtc: Add support for variable sized cells

[PATCH v3 1/3] libfdt: Add fdt16_to_cpu utility function

2011-09-23 Thread Anton Staaf
This utility routine will be used in the variable size cell literal append code. It is a straightforward adaptation of the fdt32_to_cpu function. Signed-off-by: Anton Staaf robot...@chromium.org Cc: Jon Loeliger j...@jdl.com Cc: David Gibson da...@gibson.dropbear.id.au Cc: Grant Likely grant.lik

[PATCH v3 2/3] dtc: Add data_append_integer function

2011-09-23 Thread Anton Staaf
and data_append_addr to use data_append_integer. Signed-off-by: Anton Staaf robot...@chromium.org Cc: David Gibson da...@gibson.dropbear.id.au Cc: Jon Loeliger j...@jdl.com Cc: Grant Likely grant.lik...@secretlab.ca --- data.c | 39 --- dtc.h |1 + 2 files changed, 33

Re: [PATCH 0/3] Variable sized cell support

2011-09-22 Thread Anton Staaf
On Wed, Sep 21, 2011 at 7:26 PM, David Gibson da...@gibson.dropbear.id.au wrote: On Wed, Sep 21, 2011 at 01:42:08PM -0700, Anton Staaf wrote: This patch set adds, tests, and documents support for variable sized cells in cell arrays.  The new syntax is:     property = /size/ [8|16|32|64] 0x00

Re: [PATCH 2/3] dtc: Add data_append_literal function

2011-09-22 Thread Anton Staaf
On Wed, Sep 21, 2011 at 7:33 PM, David Gibson da...@gibson.dropbear.id.au wrote: On Wed, Sep 21, 2011 at 01:42:10PM -0700, Anton Staaf wrote: This function deals with appending literals of various sizes (8, 16 32, and 64 bit currently).  It handles endianess conversions and verifies

Re: [PATCH 3/3] dtc: Add support for variable sized cells

2011-09-22 Thread Anton Staaf
On Wed, Sep 21, 2011 at 7:42 PM, David Gibson da...@gibson.dropbear.id.au wrote: On Wed, Sep 21, 2011 at 01:42:11PM -0700, Anton Staaf wrote: Cells of size 8, 16, 32, and 64 bits are supported.  The new /size/ syntax was selected so as to not pollute the reserved keyword space with uint8

[PATCH v2 0/3] Variable sized cell support

2011-09-22 Thread Anton Staaf
derived from TEST_VALUE_1 - data_append_literal renamed to data_append_integer - be_ removed from values in data_append_integer - len renamed to bits in data_append_integer Anton Staaf (3): libfdt: Add fdt16_to_cpu utility function dtc: Add data_append_integer function dtc: Add support for variable

[PATCH v2 1/3] libfdt: Add fdt16_to_cpu utility function

2011-09-22 Thread Anton Staaf
This utility routine will be used in the variable size cell literal append code. It is a straightforward adaptation of the fdt32_to_cpu function. Signed-off-by: Anton Staaf robot...@chromium.org Cc: Jon Loeliger j...@jdl.com Cc: David Gibson da...@gibson.dropbear.id.au Cc: Grant Likely grant.lik

[PATCH v2 2/3] dtc: Add data_append_integer function

2011-09-22 Thread Anton Staaf
This function deals with appending integers of various sizes (8, 16 32, and 64 bit currently). It handles endianess conversions and verifies that the given integer is not larger than the specified size. Signed-off-by: Anton Staaf robot...@chromium.org Cc: David Gibson da...@gibson.dropbear.id.au

Re: [PATCH v2 2/3] dtc: Add data_append_integer function

2011-09-22 Thread Anton Staaf
On Thu, Sep 22, 2011 at 5:19 PM, David Gibson da...@gibson.dropbear.id.au wrote: On Thu, Sep 22, 2011 at 11:25:26AM -0700, Anton Staaf wrote: This function deals with appending integers of various sizes (8, 16 32, and 64 bit currently).  It handles endianess conversions and verifies

Re: [PATCH 2/3] dtc: Add data_append_literal function

2011-09-22 Thread Anton Staaf
On Thu, Sep 22, 2011 at 5:13 PM, David Gibson da...@gibson.dropbear.id.au wrote: On Thu, Sep 22, 2011 at 10:57:58AM -0700, Anton Staaf wrote: On Wed, Sep 21, 2011 at 7:33 PM, David Gibson da...@gibson.dropbear.id.au wrote: On Wed, Sep 21, 2011 at 01:42:10PM -0700, Anton Staaf wrote: [snip

Re: [PATCH v4 2/3] dtc: Support character literals in cell lists

2011-09-21 Thread Anton Staaf
On Mon, Sep 19, 2011 at 8:34 PM, David Gibson da...@gibson.dropbear.id.au wrote: On Mon, Sep 19, 2011 at 07:54:09PM -0700, Anton Staaf wrote: On Mon, Sep 19, 2011 at 5:59 PM, David Gibson da...@gibson.dropbear.id.au wrote: On Mon, Sep 19, 2011 at 09:45:34AM -0700, Anton Staaf wrote: On Sun

[PATCH 0/3] Variable sized cell support

2011-09-21 Thread Anton Staaf
patch sets modify the same locations in the parser. You do not need to apply the character literal support in bytestrings patch however. Anton Staaf (3): libfdt: Add fdt16_to_cpu utility function dtc: Add data_append_literal function dtc: Add support for variable sized cells Documentation

[PATCH 2/3] dtc: Add data_append_literal function

2011-09-21 Thread Anton Staaf
This function deals with appending literals of various sizes (8, 16 32, and 64 bit currently). It handles endianess conversions and verifies that the given literal is not larger than the specified size. Signed-off-by: Anton Staaf robot...@chromium.org Cc: David Gibson da...@gibson.dropbear.id.au

Re: [PATCH v2 3/3] dtc: Support character literals in bytestrings

2011-09-12 Thread Anton Staaf
On Sun, Sep 11, 2011 at 10:09 PM, Anton Staaf robot...@chromium.org wrote: On Sun, Sep 11, 2011 at 5:48 PM, David Gibson da...@gibson.dropbear.id.au wrote: On Fri, Sep 09, 2011 at 11:37:51AM -0700, Anton Staaf wrote: On Fri, Sep 9, 2011 at 12:25 AM, David Gibson da...@gibson.dropbear.id.au

Re: [PATCH v2 3/3] dtc: Support character literals in bytestrings

2011-09-09 Thread Anton Staaf
On Thu, Sep 8, 2011 at 6:01 AM, David Gibson da...@gibson.dropbear.id.au wrote: On Thu, Sep 08, 2011 at 12:07:16AM -0700, Grant Likely wrote: On Thu, Sep 08, 2011 at 01:51:49PM +1000, David Gibson wrote: On Wed, Sep 07, 2011 at 04:15:40PM -0700, Anton Staaf wrote: With this patch

Re: [PATCH v3 2/3] dtc: Support character literals in cell lists

2011-09-09 Thread Anton Staaf
On Thu, Sep 8, 2011 at 6:12 PM, David Gibson da...@gibson.dropbear.id.au wrote: On Thu, Sep 08, 2011 at 02:39:16PM -0700, Anton Staaf wrote: With this patch the following property assignment:     property = 0x12345678 'a' '\r' 100; is equivalent to:     property = 0x12345678 0x0061

Re: [PATCH v3 2/3] dtc: Support character literals in cell lists

2011-09-09 Thread Anton Staaf
On Fri, Sep 9, 2011 at 12:03 AM, David Gibson da...@gibson.dropbear.id.au wrote: On Thu, Sep 08, 2011 at 11:40:59PM -0700, Anton Staaf wrote: On Thu, Sep 8, 2011 at 6:12 PM, David Gibson da...@gibson.dropbear.id.au wrote: On Thu, Sep 08, 2011 at 02:39:16PM -0700, Anton Staaf wrote

Re: [PATCH v3 3/3] dtc: Support character literals in bytestrings

2011-09-09 Thread Anton Staaf
On Fri, Sep 9, 2011 at 12:01 AM, David Gibson da...@gibson.dropbear.id.au wrote: On Thu, Sep 08, 2011 at 11:37:21PM -0700, Anton Staaf wrote: On Thu, Sep 8, 2011 at 6:15 PM, David Gibson da...@gibson.dropbear.id.au wrote: On Thu, Sep 08, 2011 at 02:39:17PM -0700, Anton Staaf wrote

Re: [PATCH v2 3/3] dtc: Support character literals in bytestrings

2011-09-09 Thread Anton Staaf
On Fri, Sep 9, 2011 at 12:25 AM, David Gibson da...@gibson.dropbear.id.au wrote: On Thu, Sep 08, 2011 at 11:30:42PM -0700, Anton Staaf wrote: On Thu, Sep 8, 2011 at 6:01 AM, David Gibson da...@gibson.dropbear.id.au wrote: On Thu, Sep 08, 2011 at 12:07:16AM -0700, Grant Likely wrote: On Thu

[PATCH v4 0/3] Support character literals

2011-09-09 Thread Anton Staaf
patch Anton Staaf (3): dtc: Refactor character literal parsing code dtc: Support character literals in cell lists dtc: Support character literals in bytestrings Documentation/dts-format.txt |7 ++- data.c | 85 ++-- dtc-lexer.l

[PATCH v4 3/3] dtc: Support character literals in bytestrings

2011-09-09 Thread Anton Staaf
With this patch the following property assignment: property = ['a' 2b '\r']; is equivalent to: property = [61 2b 0d]; Signed-off-by: Anton Staaf robot...@chromium.org Cc: Jon Loeliger j...@jdl.com Cc: David Gibson da...@gibson.dropbear.id.au Cc: Grant Likely grant.lik...@secretlab.ca

[PATCH v4 2/3] dtc: Support character literals in cell lists

2011-09-09 Thread Anton Staaf
With this patch the following property assignment: property = 0x12345678 'a' '\r' 100; is equivalent to: property = 0x12345678 0x0061 0x000D 0x0064 Signed-off-by: Anton Staaf robot...@chromium.org Cc: Jon Loeliger j...@jdl.com Cc: David Gibson da...@gibson.dropbear.id.au

[PATCH v4 1/3] dtc: Refactor character literal parsing code

2011-09-09 Thread Anton Staaf
Move the parsing of hex, octal and escaped characters from data.c to util.c where it can be used for character literal parsing within strings as well as for stand alone C style character literals. Signed-off-by: Anton Staaf robot...@chromium.org Cc: Jon Loeliger j...@jdl.com Cc: David Gibson da

Re: [PATCH v2 0/3] Support character literals

2011-09-08 Thread Anton Staaf
On Wed, Sep 7, 2011 at 10:03 PM, David Gibson da...@gibson.dropbear.id.au wrote: On Thu, Sep 08, 2011 at 01:18:42PM +1000, David Gibson wrote: On Wed, Sep 07, 2011 at 04:15:37PM -0700, Anton Staaf wrote:     These patches add simple and escaped character literal parsing support to the dtc

Re: [PATCH v2 1/3] dtc: Refactor character literal parsing code

2011-09-08 Thread Anton Staaf
On Wed, Sep 7, 2011 at 8:22 PM, David Gibson da...@gibson.dropbear.id.au wrote: On Wed, Sep 07, 2011 at 04:15:38PM -0700, Anton Staaf wrote: Move the parsing of hex, octal and escaped characters from data.c to util.c where it can be used for character literal parsing within strings as well

Re: [PATCH v2 3/3] dtc: Support character literals in bytestrings

2011-09-08 Thread Anton Staaf
On Thu, Sep 8, 2011 at 12:07 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Thu, Sep 08, 2011 at 01:51:49PM +1000, David Gibson wrote: On Wed, Sep 07, 2011 at 04:15:40PM -0700, Anton Staaf wrote: With this patch the following property assignment:     property = ['a' 2b '\r

Re: [PATCH v2 2/3] dtc: Support character literals in cell lists

2011-09-08 Thread Anton Staaf
On Wed, Sep 7, 2011 at 8:47 PM, David Gibson da...@gibson.dropbear.id.au wrote: On Wed, Sep 07, 2011 at 04:15:39PM -0700, Anton Staaf wrote: With this patch the following property assignment:     property = 0x12345678 'a' '\r' 100; is equivalent to:     property = 0x12345678 0x0061

[PATCH v3 0/3] Support character literals

2011-09-08 Thread Anton Staaf
normal and escaped literal support for bytestrings into single patch Anton Staaf (3): dtc: Refactor character literal parsing code dtc: Support character literals in cell lists dtc: Support character literals in bytestrings Documentation/dts-format.txt |7 ++- data.c

[PATCH v3 1/3] dtc: Refactor character literal parsing code

2011-09-08 Thread Anton Staaf
Move the parsing of hex, octal and escaped characters from data.c to util.c where it can be used for character literal parsing within strings as well as for stand alone C style character literals. Signed-off-by: Anton Staaf robot...@chromium.org Cc: Jon Loeliger j...@jdl.com Cc: David Gibson da

[PATCH v3 2/3] dtc: Support character literals in cell lists

2011-09-08 Thread Anton Staaf
With this patch the following property assignment: property = 0x12345678 'a' '\r' 100; is equivalent to: property = 0x12345678 0x0061 0x000D 0x0064 Signed-off-by: Anton Staaf robot...@chromium.org Cc: Jon Loeliger j...@jdl.com Cc: David Gibson da...@gibson.dropbear.id.au

[PATCH v2 0/3] Support character literals

2011-09-07 Thread Anton Staaf
literal support for bytestrings into single patch Anton Staaf (3): dtc: Refactor character literal parsing code dtc: Support character literals in cell lists dtc: Support character literals in bytestrings Documentation/dts-format.txt |7 ++- Documentation/manual.txt |7 ++- data.c

[PATCH v2 2/3] dtc: Support character literals in cell lists

2011-09-07 Thread Anton Staaf
With this patch the following property assignment: property = 0x12345678 'a' '\r' 100; is equivalent to: property = 0x12345678 0x0061 0x000D 0x0064 Signed-off-by: Anton Staaf robot...@chromium.org Cc: Jon Loeliger j...@jdl.com Cc: David Gibson da...@gibson.dropbear.id.au

[PATCH v2 1/3] dtc: Refactor character literal parsing code

2011-09-07 Thread Anton Staaf
Move the parsing of hex, octal and escaped characters from data.c to util.c where it can be used for character literal parsing within strings as well as for stand alone C style character literals. Signed-off-by: Anton Staaf robot...@chromium.org Cc: Jon Loeliger j...@jdl.com Cc: David Gibson da

Re: [PATCH 0/2] Character literal parsing

2011-07-20 Thread Anton Staaf
On Wed, Jul 20, 2011 at 6:42 AM, David Gibson da...@gibson.dropbear.id.au wrote: On Fri, Jun 24, 2011 at 01:22:13PM -0700, Anton Staaf wrote: On Fri, Jun 24, 2011 at 1:02 PM, David Brown dav...@codeaurora.org wrote: Does this mean that the dtc inside the kernel is going to be the required

Re: [PATCH 1/2] Add character literal parsing in bytestrings

2011-07-20 Thread Anton Staaf
On Wed, Jul 20, 2011 at 6:40 AM, David Gibson da...@gibson.dropbear.id.au wrote: On Thu, Jun 23, 2011 at 04:20:38PM -0700, Anton Staaf wrote: This adds support for parsing simple (non-escaped) 'x' character literal syntax in bytestrings.  For example:     property = ['a' 2b 'c

Re: [PATCH 0/2] Character literal parsing

2011-06-28 Thread Anton Staaf
Jon, what are your feelings on the proposed patch? I'd love to get an indication either way, should I continue to pursue this? Thanks, Anton On Fri, Jun 24, 2011 at 2:47 PM, Anton Staaf robot...@google.com wrote: On Fri, Jun 24, 2011 at 2:34 PM, Grant Likely grant.lik

Re: [PATCH 0/2] Character literal parsing

2011-06-24 Thread Anton Staaf
On Fri, Jun 24, 2011 at 2:17 PM, Jon Loeliger j...@jdl.com wrote: Your question makes me think that there are two device tree compilers There is one device tree compiler. The main upstream repository is here: git://git.jdl.com/software/dtc.git There is a snapshot of that which is

Re: [PATCH 0/2] Character literal parsing

2011-06-24 Thread Anton Staaf
On Fri, Jun 24, 2011 at 2:11 PM, David Brown dav...@codeaurora.org wrote: Also, the dts form is defined in the ePAPR documents, and this would be a (minor) divergence from that. Thanks for the pointer, I had not read the ePAPR docs, I scanned them (will read in more depth later) and didn't

Re: [PATCH 0/2] Character literal parsing

2011-06-24 Thread Anton Staaf
On Fri, Jun 24, 2011 at 2:34 PM, Grant Likely grant.lik...@secretlab.cawrote: On Fri, Jun 24, 2011 at 3:11 PM, David Brown dav...@codeaurora.org wrote: On Fri, Jun 24 2011, Anton Staaf wrote: On Fri, Jun 24, 2011 at 1:02 PM, David Brown dav...@codeaurora.org wrote: Does

[PATCH 0/2] Character literal parsing

2011-06-23 Thread Anton Staaf
-- Anton Staaf (2): Add character literal parsing in bytestrings Add escaped character support to character literals Documentation/dts-format.txt |5 +- Documentation/manual.txt |7 ++- data.c | 77 + dtc-lexer.l

[PATCH 2/2] Add escaped character support to character literals

2011-06-23 Thread Anton Staaf
This adds support for escaped characters in character literals using '\r', '\012' and '\x4a' style escapes. Signed-off-by: Anton Staaf robot...@chromium.org Cc: Jon Loeliger j...@jdl.com --- Documentation/manual.txt |4 +- data.c | 77