[PATCH 13/34] usb: dwc3: omap: fix dwc3 binding match table

2011-11-24 Thread Felipe Balbi
From: Sebastian Andrzej Siewior Trivial patch, no functional changes. [ ba...@ti.com : fixed up Documentation based on what we actually want to achieve ] Signed-off-by: Felipe Balbi --- Documentation/devicetree/bindings/usb/dwc3.txt | 66 drivers/usb/dwc3

[PATCH 12/34] usb: dwc3: core: add DeviceTree match table

2011-11-24 Thread Felipe Balbi
in the long run we will have DeviceTree creating all devices for us. Adding a match table here is the first step towards that goal. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/core.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/usb/dwc3/core.c b

[RFC/PATCH] usb: dwc3: omap: convert pdata to of property

2012-01-25 Thread Felipe Balbi
Convert our platform_data usage to OF property, keep the legacy pdata for a while until the complete conversion is done. Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/dwc3-omap.c | 34 ++ 1 files changed, 22 insertions(+), 12 deletions(-) diff --git a

[PATCH] scripts: dtc: fix compile warnings

2012-01-26 Thread Felipe Balbi
but not used [-Wunused-but-set-variable] Signed-off-by: Felipe Balbi --- scripts/dtc/dtc.c |5 + scripts/dtc/flattree.c |2 -- 2 files changed, 1 insertions(+), 6 deletions(-) diff --git a/scripts/dtc/dtc.c b/scripts/dtc/dtc.c index 451c92d..2ef5e2e 100644 --- a/scripts

Re: [PATCH 8/9] usb: dwc3: gadget: dynamically re-size TxFifos

2012-01-26 Thread Felipe Balbi
Hi, On Wed, Jan 25, 2012 at 10:54:56AM -0800, Paul Zimmerman wrote: > On Wed, 25 Jan 2012, Felipe Balbi wrote: > > > > > You probably don't want a module parameter. Maybe we could enable this > > > > depending > > > > on the PCI ID, or from pl

Re: [PATCH] I2C: OMAP: fix build breakage when CONFIG_OF is not set

2012-02-08 Thread Felipe Balbi
are prepared to get NULL > pointers if CONFIG_OF is not defined, we can simply define it to NULL. > > Cc: Benoit Cousson > Signed-off-by: Luciano Coelho after fixing the commit log, you can add: Reviewed-by: Felipe Balbi if you want. > --- > drivers/i2c/busses/i2c-omap.c |

Re: kirkwood devicetree respin

2012-03-21 Thread Felipe Balbi
On Wed, Mar 21, 2012 at 10:09:40AM +, Arnd Bergmann wrote: > On Wednesday 21 March 2012, Haojian Zhuang wrote: > > The driver isn't used by any other platform. It's only used in > > arch-pxa & arch-mmp. > > > > I can't find the original mail. But I remembered that maintainer said > > the drive

Re: kirkwood devicetree respin

2012-03-21 Thread Felipe Balbi
On Wed, Mar 21, 2012 at 01:17:38PM +, Arnd Bergmann wrote: > On Wednesday 21 March 2012, Felipe Balbi wrote: > > I have explained an easy way to achieve that to Alan Stern, but he did > > not like it. Basically, we should add a platform_device to ehci-hcd.ko > > and m

Re: kirkwood devicetree respin

2012-03-22 Thread Felipe Balbi
On Wed, Mar 21, 2012 at 08:06:12PM +, Paul Zimmerman wrote: > > From: linux-usb-ow...@vger.kernel.org > > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Felipe Balbi > > Sent: Wednesday, March 21, 2012 6:23 AM > > > > On Wed, Mar 21, 2012 at 01:17:3

[PATCH] of: address: use resource_size helper

2011-06-08 Thread Felipe Balbi
that should be the approved way of calculating the size of resources. No functional changes. Signed-off-by: Felipe Balbi --- drivers/of/address.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/of/address.c b/drivers/of/address.c index deefc0c..6e7b2cf 100644

Re: [PATCH 3/4] dt: omap3: add generic board file for dt support

2011-07-21 Thread Felipe Balbi
Hi, On Thu, Jul 21, 2011 at 02:25:03PM +0530, Rajendra Nayak wrote: > On 7/20/2011 3:04 AM, Grant Likely wrote: > >On Mon, Jul 18, 2011 at 02:07:10AM -0700, Tony Lindgren wrote: > >>* Grant Likely [110716 22:08]: > >>> > >>>The way I see it, you've got two options: > >>> > >>>1) modify the of_pla

Re: [PATCH 3/4] dt: omap3: add generic board file for dt support

2011-07-21 Thread Felipe Balbi
Hi, On Thu, Jul 21, 2011 at 03:03:24PM +0530, Rajendra Nayak wrote: > >IMHO, all omap_hwmod_*_data.c files become pretty much useless if we > >move completely to DT. All hwmod data is passing today, can be passed > >via DT and in a similar Hierarchical manner. > > Would the data representation be

Re: [PATCH] OMAP: omap_device: replace _find_by_pdev() with to_omap_device()

2011-07-22 Thread Felipe Balbi
familiar to the existing to_platform_device() > used when getting a platform_device pointer from a struct device pointer. > FWIW: you can use either Reported-by: Felipe Balbi or Reviewed-by: Felipe Balbi thanks for posting the patch Kevin. -- balbi signature.asc Descripti

Re: [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices

2011-07-22 Thread Felipe Balbi
On Thu, Jul 21, 2011 at 04:52:14PM -0700, Kevin Hilman wrote: > For converting from struct device to platform_device, and from > platform_device to struct device, there are existing macros. Use > them instead of manual use of container_of(). > > Signed-off-by: Kevin Hilman > --- > arch/arm/plat

Re: [RFC/PATCH 2/7] OMAP3: beagle: don't touch omap_device internals

2011-07-22 Thread Felipe Balbi
Hi, On Thu, Jul 21, 2011 at 04:52:13PM -0700, Kevin Hilman wrote: > Board code should not touch omap_device internals. To get the MPU/IVA > devices, > use existing APIs: omap2_get_mpu_device(), omap2_get_iva_device(). > > Signed-off-by: Kevin Hilman > --- > arch/arm/mach-omap2/board-omap3beag

[PATCH 2/2] arm: omap: mark dt_compat __initconst

2011-07-22 Thread Felipe Balbi
we have a special section for const data which is only needed during init, that's __initconst. Use that instead of __initdata which is for non-const data. Cc: Grant Likely Signed-off-by: Felipe Balbi --- arch/arm/mach-omap2/board-igep0020.c|2 +- arch/arm/mach-omap2/board-igep0

[PATCH 1/2] of: address: use resource_size helper

2011-07-22 Thread Felipe Balbi
that should be the approved way of calculating the size of resources. No functional changes. Cc: Grant Likely Signed-off-by: Felipe Balbi --- drivers/of/address.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/of/address.c b/drivers/of/address.c index deefc0c

Re: [RFC/PATCH 2/7] OMAP3: beagle: don't touch omap_device internals

2011-07-28 Thread Felipe Balbi
Hi, On Thu, Jul 28, 2011 at 02:57:03PM +0200, Cousson, Benoit wrote: > Hi Nishanth, > > On 7/28/2011 7:53 AM, Menon, Nishanth wrote: > >On 11:57-20110722, Felipe Balbi wrote: > >[...] > >>> /* Custom OPP enabled for all xM versions */ > >>> if

Re: [RFC/PATCH 2/7] OMAP3: beagle: don't touch omap_device internals

2011-07-29 Thread Felipe Balbi
hi, On Fri, Jul 29, 2011 at 08:49:34AM -0500, Nishanth Menon wrote: > From f03490456e24f72ca5272303c95a6f0b212494d5 Mon Sep 17 00:00:00 2001 > From: Nishanth Menon > Date: Wed, 27 Jul 2011 15:02:32 -0500 > Subject: [PATCH 1/2] OMAP: PM: omap_device: add omap_hwmod_name_get_odev > > An API which

Re: [RFC/PATCH 2/7] OMAP3: beagle: don't touch omap_device internals

2011-08-01 Thread Felipe Balbi
Hi, On Fri, Jul 29, 2011 at 06:07:17PM -0500, Menon, Nishanth wrote: > On Fri, Jul 29, 2011 at 09:05, Felipe Balbi wrote: > > > >> +} > >> +EXPORT_SYMBOL(omap_hwmod_name_get_odev); > > > > maybe EXPORT_SYMBOL_GPL() ?? Not sure we want non-GPL code to acce

Re: [RFC/PATCH 7/7] WIP: HACK/RFC: omap_device: begin to decouple platform_device from omap_device

2011-08-01 Thread Felipe Balbi
Hi, On Mon, Aug 01, 2011 at 04:44:20PM +0100, Grant Likely wrote: > On Mon, Aug 1, 2011 at 4:42 PM, Kevin Hilman wrote: > > Russell King - ARM Linux writes: > > > >> On Sat, Jul 30, 2011 at 08:58:07PM -0600, Grant Likely wrote: > >>> On Sat, Jul 30, 2011 at 01:03:32PM +0100, Russell King - ARM L

Re: [RFC/PATCH 7/7] WIP: HACK/RFC: omap_device: begin to decouple platform_device from omap_device

2011-08-01 Thread Felipe Balbi
Hi, On Mon, Aug 01, 2011 at 03:11:57PM -0700, Kevin Hilman wrote: > Russell King - ARM Linux writes: > > > Help the typechecker do its job. As we have only one (at the moment...) > > And make it: > > > > +struct omap_device; > > > > struct pdev_archdata { > > +#ifdef CONFIG_ARCH_OMAP > > + s

Re: [PATCH] dt: remove of_alias_get_id() reference

2011-08-04 Thread Felipe Balbi
On Thu, Aug 04, 2011 at 11:30:27AM +0100, Grant Likely wrote: > of_alias_get_id() is broken and being reverted. Remove the reference > to it and replace with a single incrementing id number. > > There is no risk of regression here on the imx driver since the imx > change to use of_alias_get_id()

Re: [PATCH] dt: remove of_alias_get_id() reference

2011-08-04 Thread Felipe Balbi
On Thu, Aug 04, 2011 at 12:42:41PM +0100, Grant Likely wrote: > On Thu, Aug 4, 2011 at 11:33 AM, Felipe Balbi wrote: > > On Thu, Aug 04, 2011 at 11:30:27AM +0100, Grant Likely wrote: > >> of_alias_get_id() is broken and being reverted.  Remove the reference > >> to i

Re: How to handle named resources with DT?

2011-08-12 Thread Felipe Balbi
Hi, On Fri, Aug 12, 2011 at 01:02:18PM +1000, David Gibson wrote: > > That seems to be pretty straightforward to implement, and as soon as > > it is useful even for a couple of drivers, it worth adding it. > > > > It is anyway better than having to add a custom property to get the > > information

Re: [RFC] OMAP3+: boards: Fix the __initconst build error for devicetree/test branch

2011-08-19 Thread Felipe Balbi
HI, On Fri, Aug 19, 2011 at 04:24:00PM +0200, Cousson, Benoit wrote: > Hi Grant, > > The current devicetree/test branch is broken due to the introduction > of the __initconst for dt_compat table. > > My original basic fix is the following one, but Felipe figured out the > root cause. So it can b

Re: How to handle named resources with DT?

2011-08-24 Thread Felipe Balbi
Hi, On Wed, Aug 24, 2011 at 12:15:03PM -0700, Kevin Hilman wrote: > Grant Likely writes: > > > On Fri, Aug 12, 2011 at 9:09 AM, Cousson, Benoit wrote: > >> On 8/12/2011 4:35 PM, Arnd Bergmann wrote: > > [...] > > >> > >>> I think it's much easier to change the existing users of _byname over

Re: How to handle named resources with DT?

2011-08-30 Thread Felipe Balbi
Hi, On Tue, Aug 30, 2011 at 12:29:12PM +1000, David Gibson wrote: > So, I actually agree that in the long term getting resource names in > the DT would be a generally good thing. > > But doing so is a *huge* change in one of the very core semantics of > all the DT bindings. It's not something th

Re: [PATCH 5/9] usb: add phy connection by phy-mode

2012-11-16 Thread Felipe Balbi
Hi, On Wed, Nov 14, 2012 at 05:19:06PM +0100, Michael Grzeschik wrote: > This patch makes it possible to set the connection of the usbphy to the > soc. It is derived from the oftree bindings for the ethernetphy and adds > similar helperfunctions. > > Signed-off-by: Michael Grzeschik > Signed-off

Re: [PATCH 5/9] usb: add phy connection by phy-mode

2012-11-16 Thread Felipe Balbi
Hi, On Wed, Nov 14, 2012 at 05:19:06PM +0100, Michael Grzeschik wrote: > This patch makes it possible to set the connection of the usbphy to the > soc. It is derived from the oftree bindings for the ethernetphy and adds > similar helperfunctions. > > Signed-off-by: Michael Grzeschik > Signed-off

Re: [PATCH 5/9] usb: add phy connection by phy-mode

2012-11-16 Thread Felipe Balbi
Hi, On Fri, Nov 16, 2012 at 12:44:19PM +0100, Marc Kleine-Budde wrote: > >> diff --git a/drivers/of/of_usbphy.c b/drivers/of/of_usbphy.c > >> new file mode 100644 > >> index 000..2e71f7b > >> --- /dev/null > >> +++ b/drivers/of/of_usbphy.c > >> @@ -0,0 +1,49 @@ > >> +/* > >> + * OF helpers for

Re: [PATCH 1/3] i2c: exynos5: add High Speed I2C controller driver

2012-11-27 Thread Felipe Balbi
Hi, On Tue, Nov 27, 2012 at 06:30:34PM +0530, Naveen Krishna Chatradhi wrote: > diff --git a/drivers/i2c/busses/i2c-exynos5.c > b/drivers/i2c/busses/i2c-exynos5.c > new file mode 100644 > index 000..5983aa9 > --- /dev/null > +++ b/drivers/i2c/busses/i2c-exynos5.c > @@ -0,0 +1,758 @@ > +/* lin

[PATCH 1/2] spi: omap2: disable DMA requests before complete()

2012-12-12 Thread Felipe Balbi
No actual errors have been found for completing before disabling DMA request lines, but it just looks more semantically correct that on our DMA callback we quiesce the whole thing before stating transfer is finished. Signed-off-by: Felipe Balbi --- drivers/spi/spi-omap2-mcspi.c | 8 1

[PATCH 2/2] spi: devicetree: add support for loopback mode

2012-12-12 Thread Felipe Balbi
there are a few spi master drivers which make use of that flag but there is no way to pass it through devicetree. This patch just creates a way to pass SPI_LOOP via devicetree. Signed-off-by: Felipe Balbi --- Documentation/devicetree/bindings/spi/spi-bus.txt | 2 ++ drivers/spi/spi.c

Re: [PATCH 2/2] spi: devicetree: add support for loopback mode

2012-12-15 Thread Felipe Balbi
On Sat, Dec 15, 2012 at 12:32:24AM +, Grant Likely wrote: > On Wed, 12 Dec 2012 10:46:00 +0200, Felipe Balbi wrote: > > there are a few spi master drivers which make > > use of that flag but there is no way to pass it > > through devicetree. > > > > This

Re: [PATCH] usb: phy: samsung: Add support for USB 3.0 phy for exynos5250

2012-12-18 Thread Felipe Balbi
On Tue, Dec 18, 2012 at 08:40:26PM +0530, Vivek Gautam wrote: > Adding support for USB3.0 phy for dwc3 controller on > exynos5250 SOC. > > Signed-off-by: Vivek Gautam > --- > drivers/usb/phy/samsung-usbphy.c | 339 > +- let's make the phy names standard from

Re: [PATCH] usb: phy: samsung: Add support for USB 3.0 phy for exynos5250

2012-12-19 Thread Felipe Balbi
Hi, On Wed, Dec 19, 2012 at 11:52:01AM +0530, Vivek Gautam wrote: > >>> @@ -736,7 +1035,41 @@ static int __devinit samsung_usbphy_probe(struct > >>> platform_device *pdev) > >>> > >>> sphy->clk = clk; > >>> > >>> - return usb_add_phy(&sphy->phy, USB_PHY_TYPE_USB2); > >>> + sphy->has

Re: [PATCH 3/9] ARM: tegra: # of CPU cores detection w/ & w/o HAVE_ARM_SCU

2012-12-20 Thread Felipe Balbi
Hi, On Thu, Dec 20, 2012 at 11:44:01AM +0200, Hiroshi Doyu wrote: > The method to detect the number of CPU cores on Cortex-A9 MPCore and > Cortex-A15 MPCore is different. On Cortex-A9 MPCore we can get this > information from the Snoop Control Unit(SCU). On Cortex-A15 MPCore we > have to read it f

Re: [PATCH 3/9] ARM: tegra: # of CPU cores detection w/ & w/o HAVE_ARM_SCU

2012-12-20 Thread Felipe Balbi
Hi, On Thu, Dec 20, 2012 at 12:21:36PM +0100, Hiroshi Doyu wrote: > Felipe Balbi wrote @ Thu, 20 Dec 2012 11:06:25 +0100: > ... > > > @@ -149,7 +154,26 @@ done: > > > */ > > > static void __init tegra_smp_init_cpus(void) > > > { > > > - u

Re: [PATCH 1/2] i2c: exynos5: add High Speed I2C controller driver

2012-12-27 Thread Felipe Balbi
kgyun Ko > Signed-off-by: Naveen Krishna Chatradhi > --- > Changes since v1: > Fixed the comments from Felipe Balbi and Thomas Abraham. > > drivers/i2c/busses/Kconfig |7 + > drivers/i2c/busses/Makefile |1 + >

Re: [PATCH 2/2] i2c-exynos5: add debugfs support for registers

2012-12-27 Thread Felipe Balbi
On Tue, Dec 25, 2012 at 04:55:55PM +0530, Naveen Krishna Chatradhi wrote: > This patch replaces the dev_vdbg with debugfs function calls > in i2c-exynos5.c driver. > > Signed-off-by: Naveen Krishna Chatradhi merge with previous -- balbi signature.asc Description: Digital signature __

Re: [PATCH 2/2] i2c-exynos5: add debugfs support for registers

2012-12-27 Thread Felipe Balbi
On Tue, Dec 25, 2012 at 04:55:55PM +0530, Naveen Krishna Chatradhi wrote: > This patch replaces the dev_vdbg with debugfs function calls > in i2c-exynos5.c driver. > > Signed-off-by: Naveen Krishna Chatradhi > --- > Changes since v1: > The debugfs implementation is a sugge

Re: [PATCH 2/2] ARM: dts: omap: Add omap-usb2 dt data

2013-01-10 Thread Felipe Balbi
m I wrote: > >>>Add omap-usb2 data node in omap4 device tree file. Since omap-usb2 is > >>>connected to ocp2scp, omap-usb2 dt data is added as a child node > >>>of ocp2scp. > >>> > >>>Acked-by: Felipe Balbi > >>>Signed-off-by: Kish

Re: [PATCH v5 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-11 Thread Felipe Balbi
Hi, On Fri, Jan 11, 2013 at 06:10:48PM +0530, Vivek Gautam wrote: > Hi Doug, > > Sorry!! for the delayed response. > > > On Thu, Dec 20, 2012 at 4:31 AM, Doug Anderson wrote: > > Vivek, > > > > I don't really have a good 1 foot view about how all of the USB > > bits fit together, but a fe

Re: [RFC PATCH 0/7] usb: musb: add driver for control module

2013-01-15 Thread Felipe Balbi
Hi, On Tue, Jan 15, 2013 at 08:09:22PM +0530, kishon wrote: > Hi Arnd, > > On Tuesday 15 January 2013 07:11 PM, Arnd Bergmann wrote: > >On Tuesday 15 January 2013, Kishon Vijay Abraham I wrote: > >>Added a new driver for the usb part of control module. This has an API > >>to power on the USB2 phy

Re: [RFC PATCH 0/7] usb: musb: add driver for control module

2013-01-15 Thread Felipe Balbi
On Wed, Jan 16, 2013 at 11:31:32AM +0530, kishon wrote: > Hi Ravi, > > On Tuesday 15 January 2013 09:36 PM, B, Ravi wrote: > >>Hi, > >> > >>On Tue, Jan 15, 2013 at 08:09:22PM +0530, kishon wrote: > >>>Hi Arnd, > >>> > >>>On Tuesday 15 January 2013 07:11 PM, Arnd Bergmann wrote: > On Tuesday 15

Re: [RFC PATCH 0/7] usb: musb: add driver for control module

2013-01-18 Thread Felipe Balbi
Hi, On Tue, Jan 15, 2013 at 02:12:51PM +0530, Kishon Vijay Abraham I wrote: > Added a new driver for the usb part of control module. This has an API > to power on the USB2 phy and an API to write to the mailbox depending on > whether MUSB has to act in host mode or in device mode. > > Writing to

Re: [RFC PATCH 1/6] usb: otg: Add an API to bind the USB controller and PHY

2013-01-18 Thread Felipe Balbi
On Thu, Jan 17, 2013 at 04:44:52PM +0530, kishon wrote: > >>@@ -171,6 +188,11 @@ static inline void devm_usb_put_phy(struct device > >>*dev, struct usb_phy *x) > >> { > >> } > >> > >>+static inline struct usb_phy_bind *usb_bind_phy(const char *dev_name, u8 > >>index, > >>+

Re: [RFC PATCH 0/6] USB: Add multiple PHYs of same type

2013-01-18 Thread Felipe Balbi
On Wed, Jan 16, 2013 at 08:30:56PM +0530, Kishon Vijay Abraham I wrote: > New platforms are being added which has multiple PHY's (of same type) and > which has multiple USB controllers. The binding information has to be > present in the PHY library (otg.c) in order for it to return the > appropriat

Re: [PATCH 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-18 Thread Felipe Balbi
Hi, On Fri, Jan 18, 2013 at 03:10:42PM +0530, Kishon Vijay Abraham I wrote: > Added a new driver for the usb part of control module. This has an API > to power on the USB2 phy and an API to write to the mailbox depending on > whether MUSB has to act in host mode or in device mode. > > Writing to

Re: [PATCH 2/4] ARM: OMAP: devices: create device for usb part of control module

2013-01-18 Thread Felipe Balbi
On Fri, Jan 18, 2013 at 03:10:43PM +0530, Kishon Vijay Abraham I wrote: > A seperate driver has been added to handle the usb part of control > module. A device for the above driver is created here, using the register > address information to be used by the driver for powering on the PHY and > for w

Re: [PATCH 4/4] drivers: usb: start using the control module driver

2013-01-18 Thread Felipe Balbi
Hi, On Fri, Jan 18, 2013 at 03:10:45PM +0530, Kishon Vijay Abraham I wrote: > Start using the control module driver for powering on the PHY and for > writing to the mailbox instead of writing to the control module > registers on their own. > > Signed-off-by: Kishon Vijay Abraham I > --- > Docum

Re: [PATCH 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-18 Thread Felipe Balbi
Hi, On Fri, Jan 18, 2013 at 05:40:04PM +0530, kishon wrote: > >>+void omap_control_usb_host_mode(struct device *dev) > >>+{ > >>+ u32 val; > >>+ struct omap_control_usb *control_usb = dev_get_drvdata(dev); > >>+ > >>+ val = AVALID | VBUSVALID; > >>+ > >>+ writel(val, control_usb->otghs_con

Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-01-18 Thread Felipe Balbi
Hi, On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote: > This patch-set enables the samsung-usbphy driver on exynos5250, > which enables the support for USB2 type and USB3 type phys. > The corresponding phy driver patches are available at: > 1) https://lkml.org/lkml/2012/12/18/201 > 2

Re: [PATCH 0/2] ARM: Exynos5250: Enabling samsung usb phy

2013-01-18 Thread Felipe Balbi
On Fri, Jan 18, 2013 at 03:10:13PM +0200, Felipe Balbi wrote: > Hi, > > On Tue, Dec 18, 2012 at 09:09:40PM +0530, Vivek Gautam wrote: > > This patch-set enables the samsung-usbphy driver on exynos5250, > > which enables the support for USB2 type and USB3 type phys. >

Re: [PATCH v6 3/4] USB: ehci-s5p: Add phy driver support

2013-01-18 Thread Felipe Balbi
On Fri, Jan 11, 2013 at 08:32:29PM +0530, Vivek Gautam wrote: > Adding the phy driver to ehci-s5p. Keeping the platform data > for continuing the smooth operation for boards which still uses it > > Signed-off-by: Vivek Gautam > Acked-by: Jingoo Han Missing Alan's Acked-by here. -- balbi sig

Re: [PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-18 Thread Felipe Balbi
Hi, On Mon, Jan 14, 2013 at 05:52:15PM +0530, Vivek Gautam wrote: > This patch adds host phy support to samsung-usbphy driver and > further adds support for samsung's exynos5250 usb-phy. > > Signed-off-by: Praveen Paneri > Signed-off-by: Vivek Gautam Missing Kukjim's Acked-by here -- balbi

Re: [PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-18 Thread Felipe Balbi
On Fri, Jan 18, 2013 at 07:51:08PM +0530, Vivek Gautam wrote: > Hi Felipe, > > > On Fri, Jan 18, 2013 at 6:46 PM, Felipe Balbi wrote: > > Hi, > > > > On Mon, Jan 14, 2013 at 05:52:15PM +0530, Vivek Gautam wrote: > >> This patch adds host phy support to

Re: [PATCH v7 2/4] usb: phy: samsung: Add host phy support to samsung-phy driver

2013-01-18 Thread Felipe Balbi
On Fri, Jan 18, 2013 at 07:59:52PM +0530, Vivek Gautam wrote: > HI Balbi, > > > On Fri, Jan 18, 2013 at 7:52 PM, Felipe Balbi wrote: > > On Fri, Jan 18, 2013 at 07:51:08PM +0530, Vivek Gautam wrote: > >> Hi Felipe, > >> > >> > >> On Fri, J

Re: [RESEND PATCH v9 0/2] usb: phy: samsung: Introducing usb phy driver for samsung SoCs

2013-01-18 Thread Felipe Balbi
Hi, On Fri, Jan 18, 2013 at 02:30:21PM +0530, Praveen Paneri wrote: > Changes from v8: > Resending this patch series after rebasing to the latest usb-next branch. > Rewording inline comments for better readability. > Removed IS_ENABLED(CONFIG_OF) as pdev->dev.of_node is enough to check for dt > s

Re: [PATCH v3 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2013-01-21 Thread Felipe Balbi
Hi, On Mon, Jan 21, 2013 at 12:15:10PM +0530, Vivek Gautam wrote: > Hi Felipe, > > > On Mon, Jan 14, 2013 at 6:29 PM, Vivek Gautam > wrote: > > Changes from v2: > > - Renaming 'samsung-usbphy.c' driver to 'samsung-usb2.c' indicating > >usb 2.0 phy controller's driver for Samsung's SoCs. >

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-22 Thread Felipe Balbi
Hi, On Tue, Jan 22, 2013 at 11:18:55AM +0530, Vivek Gautam wrote: > On Tue, Jan 22, 2013 at 11:05 AM, Kukjin Kim wrote: > > Sylwester Nawrocki wrote: > >> > >> On 12/24/2012 09:13 AM, Vivek Gautam wrote: > >> These two changes look good to me. For both of them: > >> > >> Reviewed-

Re: [PATCH v6 0/4] Adding usb2.0 host-phy support for exynos5250

2013-01-22 Thread Felipe Balbi
HI, On Mon, Jan 21, 2013 at 09:23:28PM -0800, Kukjin Kim wrote: > Vivek Gautam wrote: > > > > Changes from v5: > > - Rebased on top of latest patches: > > usb: phy: samsung: Introducing usb phy driver for hsotg (v9) > > usb: phy: samsung: Add support to set pmu isolation (v6) > >

Re: [PATCH v6 0/4] Adding usb2.0 host-phy support for exynos5250

2013-01-22 Thread Felipe Balbi
On Tue, Jan 22, 2013 at 02:45:26PM +0530, Vivek Gautam wrote: > Hi Felipe, > > > On Tue, Jan 22, 2013 at 2:20 PM, Felipe Balbi wrote: > > HI, > > > > On Mon, Jan 21, 2013 at 09:23:28PM -0800, Kukjin Kim wrote: > >> Vivek Gautam wrote: > >> >

Re: [PATCH v6 0/4] Adding usb2.0 host-phy support for exynos5250

2013-01-22 Thread Felipe Balbi
HI, On Tue, Jan 22, 2013 at 11:29:47AM +0200, Felipe Balbi wrote: > On Tue, Jan 22, 2013 at 02:45:26PM +0530, Vivek Gautam wrote: > > Hi Felipe, > > > > > > On Tue, Jan 22, 2013 at 2:20 PM, Felipe Balbi wrote: > > > HI, > > > > > > On M

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-23 Thread Felipe Balbi
Hi, On Tue, Jan 22, 2013 at 02:04:56PM -0800, Kukjin Kim wrote: > Felipe Balbi wrote: > > Hi, > > > Hi Felipe, > > [...] > > > > Right, DWC has version number, but that being the kind of USB controller > > > (USB 2.0 and USB 3.0) > > > &g

Re: [PATCH v2 2/4] ARM: OMAP: devices: create device for usb part of control module

2013-01-23 Thread Felipe Balbi
Hi, On Mon, Jan 21, 2013 at 07:38:26PM +0530, Kishon Vijay Abraham I wrote: > A seperate driver has been added to handle the usb part of control > module. A device for the above driver is created here, using the register > address information to be used by the driver for powering on the PHY and >

Re: [PATCH v2 2/2] usb: dwc3-exynos: Fix compatible strings for the device

2013-01-24 Thread Felipe Balbi
Hi, On Thu, Jan 24, 2013 at 01:32:13PM -0800, Greg KH wrote: > On Thu, Jan 24, 2013 at 07:15:30PM +0530, Vivek Gautam wrote: > > Using specific chip in compatible strings. Newer SOCs can claim > > device by using older string in the compatible list. > > > > Signed-off-by: Vivek Gautam > > Acked-

Re: [PATCH v1 1/8] usb: otg: palmas-usb: make palmas-usb as a comparator driver

2013-01-24 Thread Felipe Balbi
Hi, On Fri, Jan 25, 2013 at 08:42:24AM +0530, Kishon Vijay Abraham I wrote: > palmas-usb is made as a comparator driver to omap usb2 phy, so that > omap usb can make use of palmas for srp and also to set vbus. > > Signed-off-by: Kishon Vijay Abraham I doesn't apply. palmas-usb isn't in mainline

Re: [PATCH v3 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-24 Thread Felipe Balbi
On Thu, Jan 24, 2013 at 09:32:46PM -0800, Stephen Warren wrote: > On 01/24/2013 06:19 PM, Kishon Vijay Abraham I wrote: > > Added a new driver for the usb part of control module. This has an API > > to power on the USB2 phy and an API to write to the mailbox depending on > > whether MUSB has to act

Re: [PATCH v3 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-25 Thread Felipe Balbi
hi, On Fri, Jan 25, 2013 at 02:12:41PM +0530, kishon wrote: > On Friday 25 January 2013 01:18 PM, Felipe Balbi wrote: > >On Thu, Jan 24, 2013 at 09:32:46PM -0800, Stephen Warren wrote: > >>On 01/24/2013 06:19 PM, Kishon Vijay Abraham I wrote: > >>>Added a new driv

Re: [PATCH v1 1/8] usb: otg: palmas-usb: make palmas-usb as a comparator driver

2013-01-25 Thread Felipe Balbi
On Fri, Jan 25, 2013 at 02:14:07PM +0530, kishon wrote: > On Friday 25 January 2013 01:13 PM, Felipe Balbi wrote: > >Hi, > > > >On Fri, Jan 25, 2013 at 08:42:24AM +0530, Kishon Vijay Abraham I wrote: > >>palmas-usb is made as a comparator driver to omap usb2 phy, so

Re: [PATCH v4 4/4] drivers: usb: start using the control module driver

2013-01-25 Thread Felipe Balbi
Hi, On Fri, Jan 25, 2013 at 03:54:00PM +0530, Kishon Vijay Abraham I wrote: > Start using the control module driver for powering on the PHY and for > writing to the mailbox instead of writing to the control module > registers on their own. > > Signed-off-by: Kishon Vijay Abraham I > --- > Docum

Re: [PATCH v4 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-25 Thread Felipe Balbi
On Fri, Jan 25, 2013 at 11:01:41AM +, Mark Rutland wrote: > On Fri, Jan 25, 2013 at 10:23:57AM +, Kishon Vijay Abraham I wrote: > > Added a new driver for the usb part of control module. This has an API > > to power on the USB2 phy and an API to write to the mailbox depending on > > whether

Re: [PATCH v2 0/6] ARM: dts: omap: add dt data for dwc3

2013-01-25 Thread Felipe Balbi
a2ab7052569cd88acc6383c4b1a8e8a482) > > Did enumeration testing on omap5 evm. I have gone quickly through this series and it looks already to me: Reviewied-by: Felipe Balbi > Kishon Vijay Abraham I (6): > ARM: dts: omap5: Add omap control usb data > ARM: dts: omap5: Add ocp

Re: [PATCH v4 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-25 Thread Felipe Balbi
Hi, On Fri, Jan 25, 2013 at 12:29:43PM +, Mark Rutland wrote: > > > > + depending upon omap4 or omap5. > > > > + - reg-names: The names of the register addresses corresponding to the > > > > registers > > > > + filled in "reg". > > > > + - ti,type: This is used to differentiate whether th

Re: [PATCH v4 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-25 Thread Felipe Balbi
Hi, On Fri, Jan 25, 2013 at 04:14:02PM +, Mark Rutland wrote: > On Fri, Jan 25, 2013 at 02:59:28PM +0000, Felipe Balbi wrote: > > Hi, > > > > On Fri, Jan 25, 2013 at 12:29:43PM +, Mark Rutland wrote: > > > > > > + depending upon omap4 or omap5.

Re: [PATCH,RFC] usb: add devicetree helpers for determining dr_mode and phy_type

2013-01-29 Thread Felipe Balbi
Hi, On Tue, Jan 29, 2013 at 07:40:23PM +0530, kishon wrote: > On Tuesday 29 January 2013 07:23 PM, Wolfram Sang wrote: > >>>+ err = of_property_read_string(np, "phy_type", &phy_type); > >>>+ if (err < 0) > >>>+ return USBPHY_INTERFACE_MODE_NA; > >> > >>Why don't we use a u32 property ty

Re: [PATCH v4 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller

2013-01-30 Thread Felipe Balbi
On Tue, Jan 29, 2013 at 10:01:52PM -0800, Kukjin Kim wrote: > Vivek Gautam wrote: > > > > Adding PHY driver support for USB 3.0 controller for Samsung's > > SoCs. > > > > Signed-off-by: Vivek Gautam > > --- > > > > Changes from v3: > > - Making SAMSUNG_USB3PHY dependent on SAMSUNG_USBPHY. > >

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-01-31 Thread Felipe Balbi
On Thu, Jan 31, 2013 at 09:00:37PM +0530, Vivek Gautam wrote: > Hi Felipe, > > > On Thu, Jan 31, 2013 at 8:55 PM, Felipe Balbi wrote: > > Hi, > > > > On Thu, Jan 31, 2013 at 08:53:27PM +0530, Vivek Gautam wrote: > >> >> Moreover, SoCs having

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-02-01 Thread Felipe Balbi
On Fri, Feb 01, 2013 at 11:54:01AM +0530, Vivek Gautam wrote: > Hi Balbi, > > > On Fri, Feb 1, 2013 at 11:52 AM, Vivek Gautam > wrote: > > Hi Kishon, > > > > > > On Fri, Feb 1, 2013 at 10:51 AM, kishon wrote: > >> Hi, > >> > >

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-02-01 Thread Felipe Balbi
Hi, On Fri, Feb 01, 2013 at 02:23:28PM +0530, Vivek Gautam wrote: > >> > On Thu, Jan 31, 2013 at 08:53:27PM +0530, Vivek Gautam wrote: > >> > >> Moreover, SoCs having multiple dwc3 controllers will have multiple > >> PHYs, which eventually be added using usb_add_phy_

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-01 Thread Felipe Balbi
Hi, On Fri, Feb 01, 2013 at 10:52:46PM +0300, Sergei Shtylyov wrote: > Hello. > > On 02/01/2013 09:49 PM, Matt Porter wrote: > > >>> Move mach-davinci/dma.c to common/edma.c so it can be used > >>> by OMAP (specifically AM33xx) as well. > > >> I think this should rather go to drivers/dma/? > >

Re: [PATCH v7 01/10] ARM: davinci: move private EDMA API to arm/common

2013-02-01 Thread Felipe Balbi
hi, On Fri, Feb 01, 2013 at 11:49:11PM +0300, Sergei Shtylyov wrote: > > good point, do you wanna send some patches ? > >I have already sent them countless times and even stuck CPPI 4.1 support > (in > arch/arm/common/cppi41.c) in Russell's patch system. TI requested to remove > the > patch

Re: kirkwood devicetree respin

2012-03-27 Thread Felipe Balbi
Hi, On Thu, Mar 22, 2012 at 06:28:26PM +, Paul Zimmerman wrote: > > > > context, toggle clocks, set pads in safe mode (when needed) and so on. > > > > > > > > But fair enough, both ways would work fine. > > > > > > I would also recommend your/Alan's approach to this over Felipe's way. > > > We

Re: [PATCH] mmc: omap_hsmmc: Get rid of of_have_populated_dt() usage

2012-04-11 Thread Felipe Balbi
On Wed, Apr 11, 2012 at 03:33:13PM +0530, Rajendra Nayak wrote: > @@ -1564,7 +1564,7 @@ static void omap_hsmmc_set_ios(struct mmc_host *mmc, > struct mmc_ios *ios) >* can't be allowed when booting with device >* tree. >*/ > -

Re: [PATCH] mmc: omap_hsmmc: Get rid of of_have_populated_dt() usage

2012-04-11 Thread Felipe Balbi
On Wed, Apr 11, 2012 at 03:54:28PM +0530, Rajendra Nayak wrote: > On Wednesday 11 April 2012 03:39 PM, Felipe Balbi wrote: > >On Wed, Apr 11, 2012 at 03:33:13PM +0530, Rajendra Nayak wrote: > >>@@ -1564,7 +1564,7 @@ static void omap_hsmmc_set_ios(struct mmc_host *mmc, >

Re: [PATCH] mmc: omap_hsmmc: Get rid of of_have_populated_dt() usage

2012-04-11 Thread Felipe Balbi
On Wed, Apr 11, 2012 at 03:59:55PM +0530, Rajendra Nayak wrote: > On Wednesday 11 April 2012 03:56 PM, Felipe Balbi wrote: > >On Wed, Apr 11, 2012 at 03:54:28PM +0530, Rajendra Nayak wrote: > >>On Wednesday 11 April 2012 03:39 PM, Felipe Balbi wrote: > >>>On Wed, Ap

Re: [PATCH v2 1/3] ARM: tegra: Add AHB driver

2012-04-24 Thread Felipe Balbi
AHB bus. > > Signed-off-by: Hiroshi DOYU > Cc: Felipe Balbi > Cc: Arnd Bergmann > --- > Update: > - Use platform_device to get info from dt dynamically.(Felipe/Arnd) > --- > arch/arm/mach-tegra/Makefile|1 + > arch/arm/mach-tegra/tegra-ahb.c | 285 > +++

Re: [PATCH v2 1/3] ARM: tegra: Add AHB driver

2012-04-24 Thread Felipe Balbi
On Tue, Apr 24, 2012 at 01:49:22PM -0600, Stephen Warren wrote: > On 04/24/2012 06:16 AM, Felipe Balbi wrote: > > On Tue, Apr 24, 2012 at 03:05:14PM +0300, Hiroshi DOYU wrote: > >> The AHB Bus conforms to the AMBA Specification (Rev 2.0) Advanced > >> High-perform

Re: [PATCH v2 1/3] ARM: tegra: Add AHB driver

2012-04-25 Thread Felipe Balbi
he AHB pre-fetch > > > logic can be configured to enhance performance for devices doing > > > sequential access. Each AHB master is assigned to either the high or > > > low priority bin. Both Tegra20/30 have this AHB bus. > > > > > > Signed-off-by: Hiroshi

Re: [PATCHv3 1/4] ARM: tegra: Add AHB driver

2012-04-25 Thread Felipe Balbi
> > Some of configuration param could be passed from DT too. > > Signed-off-by: Hiroshi DOYU > Cc: Felipe Balbi > Cc: Arnd Bergmann > --- > v4: > Fixed the comments from Felipe/Russell. > This is now located under drivers/platform/arm. > v3: > Use platform_d

Re: [PATCH v2 01/12] usb: otg: add notify_connect_change callback

2012-05-21 Thread Felipe Balbi
On Mon, May 21, 2012 at 05:23:46PM +0800, Richard Zhao wrote: > This let usb phy driver has a chance to change hw settings when connect > status change. > > Signed-off-by: Richard Zhao > --- > include/linux/usb/otg.h | 13 + > 1 files changed, 13 insertions(+), 0 deletions(-) > >

Re: [PATCH v2 01/12] usb: otg: add notify_connect_change callback

2012-05-21 Thread Felipe Balbi
On Mon, May 21, 2012 at 05:36:16PM +0800, Richard Zhao wrote: > On Mon, May 21, 2012 at 12:26:36PM +0300, Felipe Balbi wrote: > > On Mon, May 21, 2012 at 05:23:46PM +0800, Richard Zhao wrote: > > > This let usb phy driver has a chance to change hw settings when connect &

Re: [PATCH 1/1] USB: Chipidea: Create a menu in Kconfig to choose driver bindings

2012-05-22 Thread Felipe Balbi
On Tue, May 22, 2012 at 05:40:34PM +0800, Richard Zhao wrote: > On Tue, May 22, 2012 at 12:21:31PM +0300, Felipe Balbi wrote: > > On Tue, May 22, 2012 at 05:08:55PM +0800, Richard Zhao wrote: > > > On Tue, May 22, 2012 at 11:58:05AM +0300, Felipe Balbi wrote: > > > >

Re: [PATCH v2 05/12] usb: chipidea: add imx driver binding

2012-05-22 Thread Felipe Balbi
Hi, On Tue, May 22, 2012 at 12:56:52PM +0300, Alexander Shishkin wrote: > > Do you think it's a good idea to let user select binding driver directly > > and the binding driver config depends on chipidea config? > > I don't have a strong opinion on this, although I prefer it the way it > is now, b

Re: [PATCH v2 05/12] usb: chipidea: add imx driver binding

2012-05-22 Thread Felipe Balbi
On Tue, May 22, 2012 at 06:31:40PM +0800, Richard Zhao wrote: > On Tue, May 22, 2012 at 01:06:26PM +0300, Felipe Balbi wrote: > > Hi, > > > > On Tue, May 22, 2012 at 12:56:52PM +0300, Alexander Shishkin wrote: > > > > Do you think it's a good idea to l

Re: [PATCH v2 05/12] usb: chipidea: add imx driver binding

2012-05-22 Thread Felipe Balbi
On Tue, May 22, 2012 at 09:52:59PM +0800, Shawn Guo wrote: > On Tue, May 22, 2012 at 01:35:17PM +0300, Felipe Balbi wrote: > > My suggestion to Alex is to remove all dependencies for at least a > > couple of merge windows and only add dependencies for stuff which > > actual

Re: [PATCH v2 05/12] usb: chipidea: add imx driver binding

2012-05-23 Thread Felipe Balbi
On Wed, May 23, 2012 at 04:02:21PM +0300, Alexander Shishkin wrote: > Richard Zhao writes: > > > On Tue, May 22, 2012 at 01:41:30PM +0300, Alexander Shishkin wrote: > >> Felipe Balbi writes: > >> > >> > On Tue, May 22, 2012 at 06:31:40PM +0800, Richar

Re: [PATCH v3 00/12] add imx usb driver for mx28/6x

2012-06-04 Thread Felipe Balbi
On Mon, Jun 04, 2012 at 08:46:11AM +0800, Richard Zhao wrote: > Hi Guys, > > The merge window was closed. Do you have time to check whether the > patch series is ok to pick up? The drivers/ part looks fine to me. -- balbi signature.asc Description: Digital signature __

  1   2   3   4   >