Re: Please revert commit dc9372808412edbc653a675a526c2ee6c0c14a91

2011-11-22 Thread Grant Likely
On Tue, Nov 22, 2011 at 3:11 PM, Benjamin Herrenschmidt wrote: > Hi Linus ! > > Please, revert commit dc9372808412edbc653a675a526c2ee6c0c14a91 > > "of/irq: of_irq_find_parent: check for parent equal to child" > > This breaks some powerpc platforms at least. The practice of having a > node provide

Re: [RFC 6/8] of: add clock providers

2011-11-30 Thread Grant Likely
On Mon, Nov 21, 2011 at 8:37 AM, Shawn Guo wrote: > On Tue, Nov 08, 2011 at 06:19:41PM -0700, Grant Likely wrote: >> +struct clk *of_clk_get_by_name(struct device_node *np, const char *name) >> +{ >> +     int index = 0; >> + >> +     if (name) >> +        

Re: [RFC PATCH] microblaze/irq: Change NO_IRQ to 0

2011-12-07 Thread Grant Likely
On Wed, Dec 7, 2011 at 7:41 AM, Rob Herring wrote: > From: Grant Likely > > As has been discussed many times[1], Using NO_IRQ set to anything other > than 0 is bug waiting to happen since many drivers follow the pattern > "if (!irq)" for testing whether or not an irq has

[PATCH] dt/device: Fix auxdata matching to handle entries without a name override

2011-12-12 Thread Grant Likely
There is no requirement to override name entries in auxdata. Fix the entry matching to use .compatible instead of .name to find the end of the list. Signed-off-by: Grant Likely --- drivers/of/platform.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/of

Initial DT clock bindings

2011-12-12 Thread Grant Likely
Hi everyone, Here's my second posting of initial device tree bindings for clocks. I'm a lot happier with how this is looking now, and Versatile is pretty much entirely converted. In fact, the realview, integrator and vexpress platforms are pretty close now too. Just for fun I went and converted

[RFC v2 1/9] arm/versatile*: merge all versatile struct clk definitions

2011-12-12 Thread Grant Likely
tion. I'd rather include the module pointer unconditionally, and if other agree then I'll remove the #ifdef Signed-off-by: Grant Likely Cc: Russell King Cc: Mike Turquette --- arch/arm/mach-integrator/include/mach/clkdev.h | 19 --- arch/arm/mach-realview/include/ma

[RFC v2 3/9] of: Add of_property_match_string() to find index into a string list

2011-12-12 Thread Grant Likely
Add a helper function for finding the index of a string in a string list property. This helper is useful for bindings that use a separate *-name property for attaching names to tuples in another property such as 'reg' or 'gpios'. Signed-off-by: Grant Likely --- arch/ar

[RFC v2 5/9] dt/clock: Add handling for fixed clocks and a clock node setup iterator

2011-12-12 Thread Grant Likely
Signed-off-by: Grant Likely --- drivers/of/clock.c | 43 +++ include/linux/of_clk.h |4 2 files changed, 47 insertions(+), 0 deletions(-) diff --git a/drivers/of/clock.c b/drivers/of/clock.c index 6519e96..1c189b4 100644 --- a/drivers/of

[RFC v2 6/9] arm/dt: add devicetree support to sp804 timer support

2011-12-12 Thread Grant Likely
This patch adds support to the sp804 code for retrieving timer configuration from the device tree. sp804 channels can be used as a clock event device or a clock source. Signed-off-by: Grant Likely Cc: Russell King --- arch/arm/common/timer-sp.c | 72

[RFC v2 4/9] of: add clock providers

2011-12-12 Thread Grant Likely
e some code, but it should be trivial) - Add ability to inherit clocks from parent nodes by using an empty 'clock-ranges' property. Useful for busses. I could use some feedback on the new property name, 'clock-ranges' doesn't feel right to me. Si

[RFC v2 2/9] arm/versatile*: Consolidate clk_ops and setvco implementations.

2011-12-12 Thread Grant Likely
write without preserving some of the bits in the old value. Russell, if this will break Integrator, then I can do it slightly differently to avoid the problem. Signed-off-by: Grant Likely Cc: Russell King Cc: Mike Turquette --- arch/arm/mach-integrator/impd1.c | 30

[RFC v2 7/9] arm/dt: Common plat-versatile support for icst and sp804 based system clocks

2011-12-12 Thread Grant Likely
Signed-off-by: Cc: Russell King --- arch/arm/plat-versatile/clock.c | 130 ++ arch/arm/plat-versatile/include/plat/clock.h |3 + 2 files changed, 133 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-versatile/clock.c b/arch/arm/plat-versatile/cl

[RFC v2 9/9] arm/highbank: Use clock binding common support code

2011-12-12 Thread Grant Likely
This patch makes the Calxeda Highbank platform use the common DT clock binding support code for setting up timers and fixed clocks. Signed-off-by: Grant Likely Cc: Rob Herring --- arch/arm/Kconfig |1 + arch/arm/boot/dts/highbank.dts | 32

[RFC v2 8/9] dt/arm: versatile add clock parsing

2011-12-12 Thread Grant Likely
Signed-off-by: Grant Likely Cc: Russell King Cc: Mike Turquette --- arch/arm/boot/dts/versatile-ab.dts | 79 arch/arm/mach-versatile/core.c | 39 +-- arch/arm/mach-versatile/versatile_dt.c | 39 +++- 3 files changed

Re: [RFC v2 6/9] arm/dt: add devicetree support to sp804 timer support

2011-12-12 Thread Grant Likely
On Dec 12, 2011 4:54 PM, "Rob Herring" wrote: > > Grant, > > On 12/12/2011 04:02 PM, Grant Likely wrote: > > This patch adds support to the sp804 code for retrieving timer > > configuration from the device tree. sp804 channels can be used as > >

Re: [RFC v2 4/9] of: add clock providers

2011-12-13 Thread Grant Likely
On Mon, Dec 12, 2011 at 4:29 PM, Jamie Iles wrote: > Hi Grant, > > I'm still going through these and trying to digest them but a couple of > quick questions/comments. > > Jamie > > On Mon, Dec 12, 2011 at 03:02:04PM -0700, Grant Likely wrote: >> diff --git

Re: [RFC v2 4/9] of: add clock providers

2011-12-13 Thread Grant Likely
On Tue, Dec 13, 2011 at 11:01 AM, Rob Herring wrote: > Grant, > > On 12/13/2011 11:54 AM, Grant Likely wrote: >> On Mon, Dec 12, 2011 at 4:29 PM, Jamie Iles wrote: >>> Hi Grant, >>> >>> I'm still going through these and trying to digest th

Re: [PATCH 1/9] dt: add empty of_get_node/of_put_node functions

2011-12-14 Thread Grant Likely
On Wed, Dec 14, 2011 at 8:28 AM, Rob Herring wrote: > From: Rob Herring > > Add empty of_get_node/of_put_node functions for !CONFIG_OF builds. > > Signed-off-by: Rob Herring > Cc: Grant Likely Looks good. > --- >  include/linux/of.h |   29 ++--

Re: [PATCH 2/9] irq: check domain hwirq range for DT translate

2011-12-14 Thread Grant Likely
On Wed, Dec 14, 2011 at 8:28 AM, Rob Herring wrote: > From: Rob Herring > > A DT node may have more than 1 domain associated with it, so make sure > the hwirq number is within range when doing DT translation. > > Signed-off-by: Rob Herring > Cc: Thomas Gleixner A

Re: [PATCH 3/9] irq: convert generic-chip to use irq_domain

2011-12-14 Thread Grant Likely
 irq_cnt; > +       struct irq_domain       *domain; Instead of making domain a pointer, why not embed the structure inside irq_chip_generic? I don't see a reason for keeping it separate. After changing that you can add my Acked-by for this patch. g. -- Grant Likely, B.Sc., P.Eng. Secret

Re: [PATCH 4/9] gpio: pl061: use chained_irq_* functions in irq handler

2011-12-14 Thread Grant Likely
On Wed, Dec 14, 2011 at 8:28 AM, Rob Herring wrote: > From: Rob Herring > > Use chained_irq_enter/exit helper functions instead of direct pointer > accesses. This is needed for generic irq chip conversion. > > Signed-off-by: Rob Herring > Cc: Grant Likely Acked-by: Grant

Re: [PATCH 5/9] gpio: pl061: convert to use 0 for no irq

2011-12-14 Thread Grant Likely
On Wed, Dec 14, 2011 at 8:28 AM, Rob Herring wrote: > From: Rob Herring > > We don't want drivers using NO_IRQ, so remove its use. For now, 0 or > -1 means no irq until platforms are converted to use 0. > > Signed-off-by: Rob Herring > Cc: Grant Likely Acked-by:

Re: [PATCH 6/9] ARM: realview: convert pl061 no irq to 0 instead of -1

2011-12-14 Thread Grant Likely
On Wed, Dec 14, 2011 at 8:28 AM, Rob Herring wrote: > From: Rob Herring > > Drivers should use 0 for no irq, so convert realview platforms pl061 > platform_data over to use 0. > > Signed-off-by: Rob Herring > Cc: Russell King Acked-by: Grant Likely > --- &

Re: [PATCH 7/9] gpio: pl061: convert to use generic irq chip

2011-12-14 Thread Grant Likely
to indicate > this is fine. > > Signed-off-by: Rob Herring > Cc: Grant Likely Acked-by: Grant Likely > Cc: Linus Walleij > --- >  drivers/gpio/Kconfig      |    1 + >  drivers/gpio/gpio-pl061.c |   74 > - >  2 files cha

Re: [PATCH 3/9] irq: convert generic-chip to use irq_domain

2011-12-14 Thread Grant Likely
On Wed, Dec 14, 2011 at 2:23 PM, Rob Herring wrote: > > > On 12/14/2011 03:14 PM, Grant Likely wrote: >> On Wed, Dec 14, 2011 at 8:28 AM, Rob Herring wrote: >>> From: Rob Herring >>> >>> Add irq domain support to irq generic-chip. This enables users

Re: [PATCH 8/9] gpio: pl061: enable interrupts with DT style binding

2011-12-14 Thread Grant Likely
On Wed, Dec 14, 2011 at 8:28 AM, Rob Herring wrote: > From: Rob Herring > > Enable DT interrupt binding support for pl061 gpio lines. If the gpio > node has an interrupt-controller property, then it will be setup to > handle interrupts on gpio lines. > > Signed-off-by: Rob

Re: [PATCH 9/9] ARM: highbank: add interrupt properties to gpio nodes

2011-12-14 Thread Grant Likely
On Wed, Dec 14, 2011 at 8:28 AM, Rob Herring wrote: > From: Rob Herring > > Add interrupt-controller properties to pl061 gpio nodes so gpio lines can > function as interrupts. > > Signed-off-by: Rob Herring Acked-by: Grant Likely > --- >  arch/arm/boot/dts/highbank.d

Re: [PATCH 3/9] irq: convert generic-chip to use irq_domain

2011-12-15 Thread Grant Likely
On Thu, Dec 15, 2011 at 6:56 AM, Rob Herring wrote: > Shawn, > > On 12/15/2011 07:39 AM, Rob Herring wrote: >> On 12/14/2011 11:55 PM, Shawn Guo wrote: >>> On Thu, Dec 15, 2011 at 01:25:20PM +0800, Shawn Guo wrote: On Wed, Dec 14, 2011 at 09:28:52AM -0600, Rob Herring wrote: > From: Rob H

Re: [PATCH 3/9] irq: convert generic-chip to use irq_domain

2011-12-15 Thread Grant Likely
On Thu, Dec 15, 2011 at 9:17 AM, Rob Herring wrote: > On 12/15/2011 09:55 AM, Grant Likely wrote: >> On Thu, Dec 15, 2011 at 6:56 AM, Rob Herring wrote: >>> Shawn, >>> >>> On 12/15/2011 07:39 AM, Rob Herring wrote: >>>> On 12/14/2011 11:55 PM, Shaw

Re: [RFC v2 4/9] of: add clock providers

2011-12-15 Thread Grant Likely
On Thu, Dec 15, 2011 at 8:13 AM, Shawn Guo wrote: > On Thu, Dec 15, 2011 at 08:23:17AM -0600, Rob Herring wrote: >> >> >> On 12/15/2011 07:51 AM, Shawn Guo wrote: >> > On Tue, Dec 13, 2011 at 10:54:58AM -0700, Grant Likely wrote: >> >> On Mon, Dec 12, 201

Re: [PULL] Devicetree for 3.3

2011-12-28 Thread Grant Likely
   3 + >  11 files changed, 124 insertions(+), 29 deletions(-) >  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-designware.txt >  create mode 100644 > Documentation/devicetree/bindings/i2c/trivial-devices.txt -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v2 0/4] irq/of: Cleanup and Enchance irq_domain support.

2011-12-30 Thread Grant Likely
first have a patch that just allows irq domains to be enabled on > MIPS. It collides because of multiple versions of irq_create_of_mapping. I'm working on this. I made some poor decisions when first implementing irq_domain which have made it difficult to bring into sync with powerpc. Right

Re: [PATCH 1/2] PM / Domains: Add OF support

2012-01-01 Thread Grant Likely
On Mon, Dec 26, 2011 at 08:13:19PM +0100, Rafael J. Wysocki wrote: > Hi, > > On Monday, December 12, 2011, Thomas Abraham wrote: > > A device node pointer is added to generic pm domain structure to associate > > the domain with a node in the device tree. > > That sounds fine except for one thing:

Re: [PATCH] Input: keyboard - add device tree bindings for simple key matrixes

2012-01-01 Thread Grant Likely
On Wed, Dec 28, 2011 at 11:06:02PM -0800, Olof Johansson wrote: > On Wed, Dec 28, 2011 at 11:01 PM, Stephen Warren wrote: > > Can we deprecate the Samsung format, and only allow it for that Samsung > > device (and allow both there), and require a single format for any other > > keyboard? > > I'm

Re: [PATCH v2 1/2] Input: tegra-kbc - add device tree bindings

2012-01-02 Thread Grant Likely
On Thu, Dec 29, 2011 at 01:23:08AM -0800, Dmitry Torokhov wrote: > On Wed, Dec 28, 2011 at 10:00:06PM -0800, Stephen Warren wrote: > > Dmitry Torokhov wrote at Tuesday, December 27, 2011 11:49 PM: > > > On Tue, Dec 27, 2011 at 10:19:29PM -0800, Olof Johansson wrote: > > > > This adds a simple devic

Re: [PATCH v2 1/2] Input: tegra-kbc - add device tree bindings

2012-01-02 Thread Grant Likely
delay in milliseconds before repeat starts > +- ghost-filter : enable ghost filtering for this device > +- wakeup-source : configure keyboard as a wakeup source for suspend/resume I'd like to see a "tegra," prefix on these custom properties, but otherwise the binding looks okay

Re: [PATCH 1/4] block: xsysace: Don't use NO_IRQ

2012-01-02 Thread Grant Likely
On Wed, Dec 21, 2011 at 03:32:09PM +0100, Michal Simek wrote: > Drivers shouldn't use NO_IRQ. Microblaze and PPC > define NO_IRQ as 0 and this reference will be removed > in near future. > > Signed-off-by: Michal Simek > CC: Grant Likely > CC: Rob Herring > CC:

Re: [PATCH 2/4] net: ethernet: xilinx: Don't use NO_IRQ in xilinx

2012-01-02 Thread Grant Likely
mit_signer:7/10=70%) > CC: Stephen Rothwell (commit_signer:1/10=10%) > CC: Grant Likely > CC: Ryan Mallon > --- Acked-by: Grant Likely > drivers/net/ethernet/xilinx/ll_temac_main.c |2 +- > drivers/net/ethernet/xilinx/xilinx_emaclite.c |2 +- > 2 files changed, 2 i

Re: [PATCH 3/4] input: xilinx_ps2: Don't use NO_IRQ

2012-01-02 Thread Grant Likely
On Wed, Dec 21, 2011 at 03:32:11PM +0100, Michal Simek wrote: > Drivers shouldn't use NO_IRQ. Microblaze and PPC > define NO_IRQ as 0 and this reference will be removed > in near future. > > Signed-off-by: Michal Simek > CC: Grant Likely > CC: Rob Herring > CC:

Re: [PATCH 4/4] microblaze: Remove NO_IRQ from architecture

2012-01-02 Thread Grant Likely
On Wed, Dec 21, 2011 at 03:32:12PM +0100, Michal Simek wrote: > NO_IRQ shouldn't be used by any driver. All Microblaze > drivers are fixed that's why NO_IRQ can be removed. > > Signed-off-by: Michal Simek > CC: Grant Likely > CC: Benjamin Herrenschmidt > CC

Re: [PATCH] Input: mpu3050: add of_match table for device-tree probing

2012-01-02 Thread Grant Likely
On Tue, Dec 27, 2011 at 09:14:31AM -0800, Olof Johansson wrote: > On Tue, Dec 27, 2011 at 8:07 AM, Rob Herring wrote: > > On 12/23/2011 09:58 AM, Olof Johansson wrote: > >> Hi, > >> > >> On Fri, Dec 23, 2011 at 1:22 AM, Dmitry Torokhov > >> wrote: > >>> Hi Olof, > >>> > >>> On Thu, Dec 22, 2011 a

Re: [PATCH 1/6] drivers/gpio/gpio-tegra.c: use devm_request_and_ioremap

2012-01-02 Thread Grant Likely
On Tue, Dec 27, 2011 at 03:01:26PM +0100, Julia Lawall wrote: > From: Julia Lawall Merged, thanks. g. > > Reimplement a call to devm_request_mem_region followed by a call to ioremap > or ioremap_nocache by a call to devm_request_and_ioremap. > > The semantic patch that makes this transformati

Re: [PATCH v2] gpio: pl061: convert to use generic irq chip

2012-01-02 Thread Grant Likely
nd testing seem to indicate > this is fine. > > Signed-off-by: Rob Herring > Acked-by: Grant Likely > Cc: Linus Walleij What does this apply against? It doesn't apply cleanly. g. > --- > v2: > - put struct irq_chip_generic pointer into struct pl061_gpio inst

Re: [PATCH] staging:iio: ak8975: add of_match table for device-tree probing

2012-01-02 Thread Grant Likely
On Thu, Dec 22, 2011 at 06:46:42PM -0800, Olof Johansson wrote: > Just like isl29018; trivial addition. Using both asahi-kasei,ak8975 and > the non-prefixed version (I couldn't figure out if Asahi Kasei had a > stock symbol to use, I only found numerical indexes for their stock info). > > Signed-o

Re: [PATCH] staging:iio: isl29018: add of_match table for device-tree probing

2012-01-02 Thread Grant Likely
On Thu, Dec 22, 2011 at 06:44:43PM -0800, Olof Johansson wrote: > As simple as can be right now; just one ID and no custom properties to parse. > > Signed-off-by: Olof Johansson Acked-by: Grant Likely > --- > drivers/staging/iio/light/isl29018.c |7 +++ >

Re: [PATCH 7/9] arm/tegra: emc: device tree bindings

2012-01-02 Thread Grant Likely
On Thu, Dec 22, 2011 at 04:17:46PM -0800, Olof Johansson wrote: > Device tree bindings for the EMC tables on tegra. > > Signed-off-by: Olof Johansson > Cc: Rob Herring > Cc: devicetree-discuss@lists.ozlabs.org Okay by me. Acked-by: Grant Likely > --- > .../devicetr

Re: [PATCH v4 03/12] mfd: twl-core: Add initial DT support for twl4030/twl6030

2012-01-02 Thread Grant Likely
On Thu, Dec 22, 2011 at 03:56:37PM +0100, Benoit Cousson wrote: > Add initial device-tree support for twl familly chips. > The current version is missing the regulator entries due > to the lack of DT regulator bindings for the moment. > Only the simple sub-modules that do not depend on > platform_d

Re: [PATCH 2/2] ARM: Exynos: Hook up power domains to generic power domain infrastructure

2012-01-03 Thread Grant Likely
On Tue, Jan 03, 2012 at 01:53:28PM +0530, Thomas Abraham wrote: > Hi Sylwester, > > On 3 January 2012 03:49, Sylwester Nawrocki wrote: > > Hi Thomas, > > > > thank you for clarifying. > > > > On 01/02/2012 03:14 AM, Thomas Abraham wrote: > >> > >> The following is a snippet from the dts file used

Re: [PATCH 3/3] of/irq: Add interrupts-names property to name an irq resource

2012-01-03 Thread Grant Likely
> index. > > Add a interrupts-names property to allow the possiblity to provide a name > to any interrupts entries. > If the name is available, use it to name the resource, otherwise > keep the legacy device full name. > > Signed-off-by: Benoit Cousson > Cc: Grant Like

Re: [PATCH 1/3] of/base: Take NULL string into account for property with multiple strings

2012-01-03 Thread Grant Likely
ot;safe_mode"; > >> > >>Do no skip NULL string and take them into account in > >>of_property_read_string_index and of_property_count_strings. > >> > >>Reported-by: Tony Lindgren > >>Signed-off-by: Benoit Cousson

Re: [PATCHv3 1/3] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2012-01-04 Thread Grant Likely
On Mon, Jan 02, 2012 at 01:25:00PM +, Mark Brown wrote: > On Mon, Jan 02, 2012 at 12:53:16PM +, Jamie Iles wrote: > > The Synopsys DesignWare block is used in some ARM devices (picoxcell) > > and can be configured to provide multiple banks of GPIO pins. > > > > v3: - depend on rather than

Re: [PATCH v2 03/10] mfd: twl-core: Add initial DT support for twl4030/twl6030

2012-01-04 Thread Grant Likely
oller. > + */ > + if ((id->driver_data) & TWL6030_CLASS) { > + pdata->irq_base = TWL6030_IRQ_BASE; > + pdata->irq_end = pdata->irq_base + TWL6030_BASE_NR_IRQS; > + } else {

Re: [PATCH v2 07/10] arm/dts: omap4-panda: Add twl6030 and i2c EEPROM

2012-01-04 Thread Grant Likely
ards > without any crash. > The support for all the features included in this MFD will be > added later. > > Add a generic i2c EEPROM entry. > > Signed-off-by: Benoit Cousson > Cc: Grant Likely Acked-by: Grant Likely > --

Re: [PATCH v2 09/10] arm/dts: omap3-beagle: Add twl4030 and i2c EEPROM

2012-01-04 Thread Grant Likely
patch from Manju: > http://www.spinics.net/lists/linux-omap/msg55831.html > > Signed-off-by: Benoit Cousson > Cc: Grant Likely > Cc: Rob Herring Acked-by: Grant Likely > --- > arch/arm/boot/dts/omap3-beagle.dts | 38 > > 1 files

Re: [PATCH v2 06/10] arm/dts: OMAP3: Add i2c controller nodes

2012-01-04 Thread Grant Likely
On Fri, Dec 09, 2011 at 03:02:37PM +0100, Benoit Cousson wrote: > Add i2c controllers nodes into the main ocp bus. > > Signed-off-by: Benoit Cousson > Cc: Grant Likely > Cc: Rob Herring Acked-by: Grant Likely > --- > arch/arm/boot/dts/omap3.dtsi | 28

Re: [PATCH v2 10/10] ARM: OMAP2+: board-generic: Remove i2c static init

2012-01-04 Thread Grant Likely
gt; Cc: Tony Lindgren Acked-by: Grant Likely > --- > arch/arm/mach-omap2/board-generic.c | 48 +- > 1 files changed, 2 insertions(+), 46 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-generic.c > b/arch/arm/mach-omap2/board-ge

Re: [PATCH v2 04/10] rtc: rtc-twl: Add DT support for RTC inside twl4030/twl6030

2012-01-04 Thread Grant Likely
On Fri, Dec 09, 2011 at 03:02:35PM +0100, Benoit Cousson wrote: > Add the DT support for the TI rtc-twl present in the twl4030 > and twl6030 devices. > > Signed-off-by: Benoit Cousson > Cc: Alessandro Zummo Acked-by: Grant Likely > --- > Documentation/devicetree/bin

Re: [PATCH v2 01/10] ARM: OMAP2+: pm: Do not init statically the SR and voltage layer with DT

2012-01-04 Thread Grant Likely
On Fri, Dec 09, 2011 at 03:02:32PM +0100, Benoit Cousson wrote: > In the case of DT, the PMIC and SR initialization will be done using > a completely different mechanism. > > Disable this part if a DT blob is available. > > Signed-off-by: Benoit Cousson Acked-by: Grant Li

Re: [PATCHv3 1/3] gpio: add a driver for the Synopsys DesignWare APB GPIO block

2012-01-04 Thread Grant Likely
;       - use reg property to indicate bank index > >>       - support irqs on both edges based on LinusW's u300 driver > > > > Put stuff like this after the ---, it shouldn't end up in git history. > > The other day I was being told the exact opposite by Grant >

Re: [PATCH v2 05/10] arm/dts: OMAP4: Add i2c controller nodes

2012-01-04 Thread Grant Likely
On Fri, Dec 09, 2011 at 03:02:36PM +0100, Benoit Cousson wrote: > Add i2c controllers nodes into the main ocp bus. > > Signed-off-by: Benoit Cousson > Cc: Grant Likely > Cc: Rob Herring Acked-by: Grant Likely > --- > arch/arm/boot/dts/omap4.dtsi | 28

Re: [RFC 1/8] gpio/microblaze: Eliminate duplication of of_get_named_gpio_flags()

2012-01-04 Thread Grant Likely
On Wed, Dec 21, 2011 at 11:22:34AM +0100, Michal Simek wrote: > Grant Likely wrote: > >of_reset_gpio_handle() is largely a cut-and-paste copy of > >of_get_named_gpio_flags(). There really isn't any reason for the > >split, so this patch deletes the duplicate function &

Re: [REPOST RFC PATCH 2/3] of_gpio: Add new helpers for easily requesting lots of GPIOs

2012-01-04 Thread Grant Likely
On Tue, Dec 13, 2011 at 01:23:33PM -0500, Kyle Moffett wrote: > Mirroring the new gpio_request_array() interface, we add several a few > helper functions for operating on entire arrays of GPIOs. > > Also, to make it easier to write various combinations of "of_get_gpio()" > followed by "gpio_reques

Re: [PATCH v2 02/10] i2c: OMAP: Add DT support for i2c controller

2012-01-04 Thread Grant Likely
the > >I2C maintainers along with some other OMAP I2C changes for v3.3. > > I removed the nasty bindings and got the Reviewed-by: from Rob for > the v4 [1]. > > Could you take it in your branch? I've just tried merging your > for_3.3/i2c/misc on t

Re: [PATCH v2 08/10] arm/dts: omap4-sdp: Add twl6030, i2c3 and i2c4 devices

2012-01-04 Thread Grant Likely
in i2c4 > > Signed-off-by: Benoit Cousson > Cc: Grant Likely Acked-by: Grant Likely > --- > arch/arm/boot/dts/omap4-sdp.dts | 63 > +++ > 1 files changed, 63 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/oma

Re: [PATCH v4 1/6] ARM: at91/aic: add irq domain and device tree support

2012-01-04 Thread Grant Likely
mpatible = "atmel,at91rm9200-aic", .data = __at91_aic_of_init }, > + { /*sentinel*/ } > +}; > + > +static void __init at91_aic_of_init(void) > +{ > + of_irq_init(aic_ids); > +} > +#else > +static void __init at91_aic_of_init(void) {}

Re: [PATCH 2/6] ARM: at91/gpio: add irqdomain to gpio interrupts

2012-01-04 Thread Grant Likely
On Thu, Dec 15, 2011 at 08:16:04PM +0100, Nicolas Ferre wrote: > Signed-off-by: Nicolas Ferre > Acked-by: Jean-Christophe PLAGNIOL-VILLARD Acked-by: Grant Likely > --- > arch/arm/mach-at91/gpio.c | 34 +- > 1 files changed, 29 insertions(

Re: [PATCH v2 3/6] ARM: at91/gpio: add DT support

2012-01-04 Thread Grant Likely
On Tue, Jan 03, 2012 at 07:34:48PM +0100, Nicolas Ferre wrote: > From: Jean-Christophe PLAGNIOL-VILLARD > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > [nicolas.fe...@atmel.com: modify DT initialization] > Signed-off-by: Nicolas Ferre Acked-by: Grant Likely > ---

Re: [PATCH 4/6] ARM: at91/gpio: add .to_irq gpio_chip handler and rework irq_to_gpio

2012-01-04 Thread Grant Likely
he irqdomain to translate hardware to Linux > IRQ numbers. > > Signed-off-by: Nicolas Ferre Acked-by: Grant Likely > --- > arch/arm/mach-at91/gpio.c | 23 +++ > arch/arm/mach-at91/include/mach/gpio.h | 12 > 2 files cha

Re: [PATCH 5/6] ARM: at91/gpio: remove the static specification of gpio_chip.base

2012-01-04 Thread Grant Likely
On Thu, Dec 15, 2011 at 08:16:07PM +0100, Nicolas Ferre wrote: > This value is determined at runtime using device tree or platform data > information. > > Signed-off-by: Nicolas Ferre Acked-by: Grant Likely > --- > arch/arm/mach-at91/gpio.c | 13 ++--- >

Re: [PATCH 6/6] ARM: at91/board-dt: remove AIC irq domain from board file

2012-01-04 Thread Grant Likely
On Thu, Dec 15, 2011 at 08:16:08PM +0100, Nicolas Ferre wrote: > Adding of irqdomain in AIC code make the specification > of the irq domain in board file useless. > > Signed-off-by: Nicolas Ferre Acked-by: Grant Likely > --- > arch/arm/mach-at91/board-dt.c | 15 +---

Re: [PATCH 3/6] ARM: dt: tegra30.dtsi: Reformat gpio's interrupts property

2012-01-04 Thread Grant Likely
owing form convenient (even if it doesn't change the data generation): interrupts = < 0 32 0x04 >, < 0 33 0x04 >, < 0 34 0x04 >, < 0 35 0x04 >, < 0 55 0x04 >,

Re: [PATCH 1/6] ARM: tegra: Remove use of TEGRA_GPIO_TO_IRQ

2012-01-04 Thread Grant Likely
Stephen Warren For the whole series: Acked-by: Grant Likely > --- > This series is 3.4 material (obviously I guess!) > > arch/arm/mach-tegra/board-harmony.c |2 +- > arch/arm/mach-tegra/board-seaboard.c |5 +++-- > 2 files changed, 4 insertions(+), 3 deletions(-

Re: [PATCH 1/2] mt_ventoux: very basic support for TeeJet Mt.Ventoux board

2012-01-04 Thread Grant Likely
27;t have twl4030 installed. > > Signed-off-by: Ilya Yanok Comment below, but otherwise: Acked-by: Grant Likely > --- > arch/arm/boot/dts/am3517_mt_ventoux.dts | 27 +++ > 1 files changed, 27 insertions(+), 0 deletions(-) > create mode 100644 arch

Re: [PATCH 2/3] arm/dts: OMAP: Remove bootargs node from board files

2012-01-04 Thread Grant Likely
On Tue, Dec 06, 2011 at 05:49:08PM +0100, Benoit Cousson wrote: > Since 3.2, the CONFIG_ARM_ATAG_DTB_COMPAT config allows > an old bootloader to still use ATAG to provide cmdline. > > Remove chosen/bootargs from the DTS board files. > > Signed-off-by: Benoit Cousson > C

Re: [PATCH 1/3] ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems

2012-01-04 Thread Grant Likely
TB_COMPAT to allow legacy > boot loader to keep working properly. > > Enable PROC_DEVICETREE as well. > > Signed-off-by: Benoit Cousson > Cc: Tony Lindgren Acked-by: Grant Likely > --- >  arch/arm/mach-omap2/Kconfig |    1 - >  arch/arm/plat-omap/Kconfig  |    4

Re: [PATCH v2 02/10] i2c: OMAP: Add DT support for i2c controller

2012-01-04 Thread Grant Likely
ueue. > > Note that Ben Dooks has not responded to any of my queries or pull > requests, either for v3.2 fixes or for the v3.3 merge window, so > unfortunately it doesn't look like this will make it for v3.3 unless Ben > starts responding.  :( > > Kevin Get it into linux-ne

Re: [PATCH 6/6] gpio: tegra: Parameterize the number of banks

2012-01-04 Thread Grant Likely
On Wed, Jan 4, 2012 at 1:00 PM, Stephen Warren wrote: > Rob Herring wrote at Wednesday, January 04, 2012 12:54 PM: >> On 01/04/2012 12:39 PM, Stephen Warren wrote: >> > Tegra20's GPIO controller has 7 banks, and Tegra30's controller has 8 >> > banks. Allow the number of banks to be configured at r

[GIT PULL] devicetree changes for v3.3

2012-01-04 Thread Grant Likely
-devices.txt -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH 5/6] gpio: tegra: Dynamically allocate IRQ base, and support DT

2012-01-05 Thread Grant Likely
On Thu, Jan 05, 2012 at 09:47:44AM -0800, Stephen Warren wrote: > Thierry Reding wrote at Thursday, January 05, 2012 12:23 AM: > > * Stephen Warren wrote: > > > @@ -343,6 +344,16 @@ static int __devinit tegra_gpio_probe(struct > > > platform_device *pdev) > > > int i; > > > int j; > > > > > >

Re: [PATCH v3] ARM: at91: pit add DT support

2012-01-05 Thread Grant Likely
On Thu, Jan 05, 2012 at 06:25:48PM +0100, Nicolas Ferre wrote: > From: Jean-Christophe PLAGNIOL-VILLARD > > Retreive registers address and IRQ from device tree entry. Fall back > to built-in values if an error occurs. > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > [nicolas.fe...@atmel.co

Re: [PATCH v4 1/6] ARM: at91/aic: add irq domain and device tree support

2012-01-05 Thread Grant Likely
On Thu, Jan 05, 2012 at 05:26:48PM +0100, Nicolas Ferre wrote: > Hi Grant, > > Thanks for your review. > > Some answer following... > > On 01/04/2012 08:40 PM, Grant Likely : > > [..] > > >> --- a/arch/arm/mach-at91/irq.c > >> +++

Re: [PATCH-V1] arm/dts: Add support for TI OMAP3 EVM board

2012-01-05 Thread Grant Likely
t;memory"; > >>+ reg =<0x8000 0x1000>; /* 256 MB */ > >>+ }; > >>+}; > >Can this merged? OR anybody has any comments here? > > I guess that with Rob or Grant's ack, Tony

Re: [PATCH] irqdomain: Initialize number of IRQs for simple domains

2012-01-06 Thread Grant Likely
Hi Thierry, On Fri, Jan 6, 2012 at 7:28 AM, Thierry Reding wrote: > The irq_domain_add() function needs the number of interrupts in the > domain to properly initialize them. In addition the allocated domain > is now returned by the irq_domain_{add,generate}_simple() helpers. The commit text shou

Re: [PATCH v2 1/5] arm/dts: OMAP4: Update DTS file with new GIC bindings

2012-01-06 Thread Grant Likely
On Tue, Dec 20, 2011 at 02:39:54PM +0100, Benoit Cousson wrote: > The GIC binding was updated in 3.2 and expect 3 interrupt-cells. > - Update the #interrupt-cells > - interrupt-parent seems to be needed as well for the top level GIC Hmmm... it shouldn't be. If it is then it is a bug. g. > > Si

Re: [PATCH v2 2/5] ARM: OMAP2/3: intc: Add irqdomain support

2012-01-06 Thread Grant Likely
domain_add_simple() accepts a nr_irqs parameter and returns the allocated irq domain. However, that isn't enough reason for me to reject this patch if there is any opportunity to get it into v3.3 provided you promise to fix it up later. Acked-by: Grant Likely > + > for (i = 0; i

Re: [PATCH v2 3/5] ARM: OMAP2/3: intc: Add DT support for TI interrupt controller

2012-01-06 Thread Grant Likely
en > Cc: Rob Herring Acked-by: Grant Likely > --- > .../devicetree/bindings/arm/omap/intc.txt | 27 ++ > arch/arm/mach-omap2/common.h | 10 ++ > arch/arm/mach-omap2/irq.c | 30 > ++--

Re: [PATCH v2 4/5] arm/dts: OMAP3: Add interrupt-controller bindings for INTC

2012-01-06 Thread Grant Likely
On Tue, Dec 20, 2011 at 02:39:57PM +0100, Benoit Cousson wrote: > Update the DTS with the proper information required by the > INTC bindings. > > - Add the number of interrupt lines > - Add the reg and the compatible entries. > > Signed-off-by: Benoit Cousson > Cc: Rob H

Re: [PATCH v2 5/5] ARM: OMAP2+: board-generic: Use of_irq_init API

2012-01-06 Thread Grant Likely
ousson > Cc: Tony Lindgren > Cc: Rob Herring Acked-by: Grant Likely > --- > arch/arm/mach-omap2/board-generic.c | 30 -- > 1 files changed, 16 insertions(+), 14 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-generic.c > b/arch/arm/

Re: [PATCH] irqdomain: Initialize number of IRQs for simple domains

2012-01-06 Thread Grant Likely
On Fri, Jan 06, 2012 at 05:20:16PM +0100, Thierry Reding wrote: > * Grant Likely wrote: > > Hi Thierry, > > > > On Fri, Jan 6, 2012 at 7:28 AM, Thierry Reding > > wrote: > > > The irq_domain_add() function needs the number of interrupts in the > >

Re: Device tree bindings for linux ramoops use

2012-01-06 Thread Grant Likely
On Fri, Jan 06, 2012 at 05:53:57PM +, Jamie Iles wrote: > On Fri, Jan 06, 2012 at 09:47:22AM -0800, Olof Johansson wrote: > > On Fri, Jan 6, 2012 at 8:58 AM, Jamie Iles wrote: > > > On Fri, Jan 06, 2012 at 08:28:51AM -0800, Olof Johansson wrote: > > >> On Thu, Jan 5, 2012 at 11:22 PM, Mitch Br

Re: Device tree bindings for linux ramoops use

2012-01-06 Thread Grant Likely
On Thu, Jan 05, 2012 at 08:39:50PM -0800, Olof Johansson wrote: > Hi, > > I'm considering how to best describe the data that ramoops needs in > the device tree. > > The idea is really about describing a memory area that is (likely to > be) nonvolatile across reboots. Said area is not to be includ

Re: Device tree bindings for linux ramoops use

2012-01-06 Thread Grant Likely
On Fri, Jan 6, 2012 at 3:24 PM, Mitch Bradley wrote: > On 1/6/2012 12:09 PM, Grant Likely wrote: >> >> On Thu, Jan 05, 2012 at 08:39:50PM -0800, Olof Johansson wrote: >>> >>> Hi, >>> >>> I'm considering how to best describe the data that r

Re: [RFC v2 4/9] of: add clock providers

2012-01-11 Thread Grant Likely
On Tue, Jan 10, 2012 at 2:33 PM, Jamie Iles wrote: > Hi Grant, > > On Mon, Dec 12, 2011 at 03:02:04PM -0700, Grant Likely wrote: >> Based on work by Ben Herrenschmidt and Jeremy Kerr, this patch adds an >> of_clk_get function to allow platforms to retrieve clock data fr

Re: [RFC v2 4/9] of: add clock providers

2012-01-12 Thread Grant Likely
On Thu, Jan 12, 2012 at 11:44 AM, Turquette, Mike wrote: > On Thu, Jan 12, 2012 at 2:07 AM, Jamie Iles wrote: >> On Wed, Jan 11, 2012 at 09:46:58PM -0700, Grant Likely wrote: >>> On Tue, Jan 10, 2012 at 2:33 PM, Jamie Iles wrote: >>> > On Mon, Dec 12, 2011 at

Re: [PATCH 0/2] Full DT IRQ support for versatile

2012-01-12 Thread Grant Likely
-versatile/include/plat/fpga-irq.h    |    6 ++ >  7 files changed, 106 insertions(+), 22 deletions(-) >  create mode 100644 Documentation/devicetree/bindings/arm/versatile-sic.txt > > -- > 1.7.5.4 > > > ___ > linux-arm-kernel m

Re: [PATCH 1/2] versatile: sic: add device tree bindings

2012-01-12 Thread Grant Likely
On Fri, Jan 13, 2012 at 12:44:00AM +, Jamie Iles wrote: > Add a device tree binding for the FPGA SIC on versatile platforms. This > also requires the addition of irq domain support for mapping to Linux > IRQs. > > Cc: Grant Likely > Cc: Rob Herring > Cc: Russell

Re: [PATCH 0/2] Full DT IRQ support for versatile

2012-01-12 Thread Grant Likely
On Fri, Jan 13, 2012 at 01:42:50AM +, Jamie Iles wrote: > On Thu, Jan 12, 2012 at 06:20:37PM -0700, Grant Likely wrote: > > On Thu, Jan 12, 2012 at 5:43 PM, Jamie Iles wrote: > > > These patches move versatile over to instantiating both interrupt > > > controllers

Re: [PATCH] USB: EHCI: Don't use NO_IRQ in xilinx ehci driver

2012-01-13 Thread Grant Likely
croblaze has removed it. > >> > >>Signed-off-by: Michal Simek > >>CC: Alan Stern > >>CC: Greg Kroah-Hartman > >>CC: Grant Likely > >>CC: linux-...@vger.kernel.org > >>CC: devicetree-discuss@lists.ozlabs.org > >>--- > >>

Re: [PATCH 1/2] versatile: sic: add device tree bindings

2012-01-13 Thread Grant Likely
On Fri, Jan 13, 2012 at 10:58:34AM +, Jamie Iles wrote: > On Fri, Jan 13, 2012 at 10:48:42AM +, Russell King - ARM Linux wrote: > > On Fri, Jan 13, 2012 at 12:44:00AM +, Jamie Iles wrote: > > > +#ifdef CONFIG_OF > > > +int __init sic_of_init(struct device_node *np, struct device_node >

Re: [PATCH 1/2] versatile: sic: add device tree bindings

2012-01-13 Thread Grant Likely
On Fri, Jan 13, 2012 at 10:35:54AM +, Jamie Iles wrote: > On Thu, Jan 12, 2012 at 07:29:32PM -0700, Grant Likely wrote: > > On Fri, Jan 13, 2012 at 12:44:00AM +, Jamie Iles wrote: > > > @@ -53,6 +59,10 @@ void __init fpga_irq_init(int parent_irq, u32 > > > val

  1   2   3   4   5   6   7   8   9   10   >