RE: [PATCH v4 5/8] MFD: ti_am335x_tscadc: Add DT support

2013-02-06 Thread Patil, Rachna
Hi Koen, SNIP Since AM335x is DT only, why is there a platform data codepath and why is it the first branch it tries? And I guess the next question is related to the first: why doesn't it work when used with DT? When I copy over the nodes from the evm.dts to my board I get tsc

RE: [PATCH v4 5/8] MFD: ti_am335x_tscadc: Add DT support

2013-01-30 Thread Patil, Rachna
On Wed, Jan 30, 2013 at 16:10:09, Koen Kooi wrote: Op 24 jan. 2013, om 04:45 heeft Patil, Rachna rac...@ti.com het volgende geschreven: From: Patil, Rachna rac...@ti.com Make changes to add DT support in the MFD core driver. Signed-off-by: Patil, Rachna rac...@ti.com

[PATCH v4 0/8] MFD: ti_am335x_tscadc: DT support and TSC features addition

2013-01-23 Thread Patil, Rachna
From: Patil, Rachna rac...@ti.com This patch set is a cumulative set of [1] and [2] sent earlier. Note that there are no code changes in either of the patch set, only rebased on top of Linus's v3.8-rc3 tag to make sure that all the patches apply without any conflicts. This patch set has been

[PATCH v4 1/8] input: ti_am335x_tsc: Step enable bits made configurable

2013-01-23 Thread Patil, Rachna
From: Patil, Rachna rac...@ti.com Current code has hard coded value written to step enable bits. Now the bits are updated based on how many steps are needed to be configured got from platform data. The user needs to take care not to exceed the count more than 16. While using ADC and TSC one

[PATCH v4 2/8] input: ti_am335x_tsc: Order of TSC wires, made configurable

2013-01-23 Thread Patil, Rachna
From: Patil, Rachna rac...@ti.com The current driver expected touchscreen input wires(XP,XN,YP,YN) to be connected in a particular order. Making changes to accept this as platform data. Signed-off-by: Patil, Rachna rac...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c | 156

[PATCH v4 4/8] MFD: ti_am335x_tscadc: add device tree binding information

2013-01-23 Thread Patil, Rachna
From: Patil, Rachna rac...@ti.com Signed-off-by: Patil, Rachna rac...@ti.com --- Changes in v4: Subnodes and their properties documentation added. Non-standard properties prefixed with vendor name. .../devicetree/bindings/mfd/ti_am335x_tscadc.txt | 52 1

[PATCH v4 3/8] input: touchscreen: ti_tsc: remove unwanted fifo flush

2013-01-23 Thread Patil, Rachna
From: Patil, Rachna rac...@ti.com When touchscreen and ADC are used together, this unwanted fifo flush leads to loss of ADC data. Signed-off-by: Patil, Rachna rac...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers

[PATCH v4 6/8] input: ti_am335x_tsc: Add DT support

2013-01-23 Thread Patil, Rachna
From: Patil, Rachna rac...@ti.com Add DT support for client touchscreen driver Signed-off-by: Patil, Rachna rac...@ti.com --- Changes in v4: Non-standard properties prefixed with vendor name. drivers/input/touchscreen/ti_am335x_tsc.c | 94 + 1 file changed

[PATCH v4 5/8] MFD: ti_am335x_tscadc: Add DT support

2013-01-23 Thread Patil, Rachna
From: Patil, Rachna rac...@ti.com Make changes to add DT support in the MFD core driver. Signed-off-by: Patil, Rachna rac...@ti.com --- Changes in v4: Non-standard properties prefixed with vendor name. drivers/mfd/ti_am335x_tscadc.c | 28 +++- 1 file changed

[PATCH v4 7/8] IIO: ti_am335x_adc: Add DT support

2013-01-23 Thread Patil, Rachna
From: Patil, Rachna rac...@ti.com Add DT support for client ADC driver. Signed-off-by: Patil, Rachna rac...@ti.com --- Changes in v4: Non-standard properties prefixed with vendor name. drivers/iio/adc/ti_am335x_adc.c | 26 ++ 1 file changed, 22 insertions

[PATCH v4 8/8] arm/dts: AM335x-evm: Add TSC/ADC MFD device support

2013-01-23 Thread Patil, Rachna
From: Patil, Rachna rac...@ti.com Add support for core multifunctional device along with its clients touchscreen and ADC. Signed-off-by: Patil, Rachna rac...@ti.com --- Changes in v4: Non-standard properties prefixed with vendor name. arch/arm/boot/dts/am335x-evm.dts | 13

[PATCH v3 0/8] MFD: ti_am335x_tscadc: DT support and TSC features addition

2013-01-18 Thread Patil, Rachna
From: Patil, Rachna rac...@ti.com This patch set is a cumulative set of [1] and [2] sent earlier. Note that there are no code changes in either of the patch set, only rebased on top of Linus's v3.8-rc3 tag to make sure that all the patches apply without any conflicts. This patch set has been

[PATCH v3 1/8] input: ti_am335x_tsc: Step enable bits made configurable

2013-01-18 Thread Patil, Rachna
From: Patil, Rachna rac...@ti.com Current code has hard coded value written to step enable bits. Now the bits are updated based on how many steps are needed to be configured got from platform data. The user needs to take care not to exceed the count more than 16. While using ADC and TSC one

[PATCH v3 2/8] input: ti_am335x_tsc: Order of TSC wires, made configurable

2013-01-18 Thread Patil, Rachna
From: Patil, Rachna rac...@ti.com The current driver expected touchscreen input wires(XP,XN,YP,YN) to be connected in a particular order. Making changes to accept this as platform data. Signed-off-by: Patil, Rachna rac...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c | 156

[PATCH v3 3/8] input: touchscreen: ti_tsc: remove unwanted fifo flush

2013-01-18 Thread Patil, Rachna
From: Patil, Rachna rac...@ti.com When touchscreen and ADC are used together, this unwanted fifo flush leads to loss of ADC data. Signed-off-by: Patil, Rachna rac...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers

[PATCH v3 4/8] MFD: ti_am335x_tscadc: add device tree binding information

2013-01-18 Thread Patil, Rachna
From: Patil, Rachna rac...@ti.com Signed-off-by: Patil, Rachna rac...@ti.com --- .../devicetree/bindings/mfd/ti_am335x_tscadc.txt | 35 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/ti_am335x_tscadc.txt diff --git

[PATCH v3 5/8] MFD: ti_am335x_tscadc: Add DT support

2013-01-18 Thread Patil, Rachna
From: Patil, Rachna rac...@ti.com Make changes to add DT support in the MFD core driver. Signed-off-by: Patil, Rachna rac...@ti.com --- drivers/mfd/ti_am335x_tscadc.c | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/drivers/mfd

[PATCH v3 6/8] input: ti_am335x_tsc: Add DT support

2013-01-18 Thread Patil, Rachna
From: Patil, Rachna rac...@ti.com Add DT support for client touchscreen driver Signed-off-by: Patil, Rachna rac...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c | 94 + 1 file changed, 81 insertions(+), 13 deletions(-) diff --git a/drivers/input/touchscreen

[PATCH v3 7/8] IIO: ti_am335x_adc: Add DT support

2013-01-18 Thread Patil, Rachna
From: Patil, Rachna rac...@ti.com Add DT support for client ADC driver. Signed-off-by: Patil, Rachna rac...@ti.com --- drivers/iio/adc/ti_am335x_adc.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio

[PATCH v3 8/8] arm/dts: AM335x-evm: Add TSC/ADC MFD device support

2013-01-18 Thread Patil, Rachna
From: Patil, Rachna rac...@ti.com Add support for core multifunctional device along with its clients touchscreen and ADC. Signed-off-by: Patil, Rachna rac...@ti.com --- arch/arm/boot/dts/am335x-evm.dts | 13 + arch/arm/boot/dts/am33xx.dtsi|8 2 files changed, 21

RE: [PATCH RESEND 3/7] input: ti_am335x_tsc: Add variance filter

2012-11-26 Thread Patil, Rachna
On Thu, Nov 22, 2012 at 00:03:50, Dmitry Torokhov wrote: Hi Rachna, Hi Dmitry, On Wed, Nov 07, 2012 at 12:22:00PM +0530, Patil, Rachna wrote: Only fine tuning variance parameter present in tslib utility does not help in removing all the ADC noise. This logic of filtering is necessary

RE: [PATCH RESEND 6/7] input: ti_am335x_tsc: Add DT support

2012-11-26 Thread Patil, Rachna
Hi Dmitry, On Thu, Nov 22, 2012 at 00:02:23, Dmitry Torokhov wrote: Hi Rachna, On Wed, Nov 07, 2012 at 12:22:03PM +0530, Patil, Rachna wrote: Add DT support for client touchscreen driver Signed-off-by: Patil, Rachna rac...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c

RE: [PATCH RESEND 0/7] MFD: ti_am335x_tscadc: DT support and TSC features addition

2012-11-16 Thread Patil, Rachna
and DT support for the MFD core and its clients. Regards, Rachna On Wed, Nov 07, 2012 at 12:21:57, Patil, Rachna wrote: This patch set is a cumulative set of [1] and [2] sent earlier. Note that there are no code changes in either of the patch set, only rebased on top of MFD-next to make

[PATCH RESEND 1/7] input: ti_am335x_tsc: Step enable bits made configurable

2012-11-14 Thread Patil, Rachna
correctly. Signed-off-by: Patil, Rachna rac...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c | 10 -- include/linux/mfd/ti_am335x_tscadc.h |1 - 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input

[PATCH RESEND 4/7] MFD: ti_am335x_tscadc: add device tree binding information

2012-11-14 Thread Patil, Rachna
Signed-off-by: Patil, Rachna rac...@ti.com --- .../devicetree/bindings/mfd/ti_am335x_tscadc.txt | 35 1 files changed, 35 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/ti_am335x_tscadc.txt diff --git a/Documentation/devicetree

[PATCH RESEND 0/7] MFD: ti_am335x_tscadc: DT support and TSC features addition

2012-11-14 Thread Patil, Rachna
]. [1] http://www.spinics.net/lists/linux-input/msg23060.html [2] http://www.spinics.net/lists/linux-input/msg23090.html [3] https://lkml.org/lkml/2012/11/6/67 Patil, Rachna (7): input: ti_am335x_tsc: Step enable bits made configurable input: ti_am335x_tsc: Order of TSC wires, made configurable

[PATCH RESEND 3/7] input: ti_am335x_tsc: Add variance filter

2012-11-14 Thread Patil, Rachna
Only fine tuning variance parameter present in tslib utility does not help in removing all the ADC noise. This logic of filtering is necessary to get this touchscreen to work finely. Signed-off-by: Patil, Rachna rac...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c | 15

[PATCH RESEND 2/7] input: ti_am335x_tsc: Order of TSC wires, made configurable

2012-11-14 Thread Patil, Rachna
The current driver expected touchscreen input wires(XP,XN,YP,YN) to be connected in a particular order. Making changes to accept this as platform data. Signed-off-by: Patil, Rachna rac...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c | 156 ++--- include/linux

[PATCH RESEND 6/7] input: ti_am335x_tsc: Add DT support

2012-11-14 Thread Patil, Rachna
Add DT support for client touchscreen driver Signed-off-by: Patil, Rachna rac...@ti.com --- drivers/input/touchscreen/ti_am335x_tsc.c | 60 - 1 files changed, 50 insertions(+), 10 deletions(-) diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input

[PATCH RESEND 5/7] MFD: ti_am335x_tscadc: Add DT support

2012-11-14 Thread Patil, Rachna
Make changes to add DT support in the MFD core driver. Signed-off-by: Patil, Rachna rac...@ti.com --- drivers/mfd/ti_am335x_tscadc.c | 28 +++- 1 files changed, 23 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd

[PATCH RESEND 7/7] IIO: ti_am335x_adc: Add DT support

2012-11-14 Thread Patil, Rachna
Add DT support for client ADC driver. Signed-off-by: Patil, Rachna rac...@ti.com --- drivers/iio/adc/ti_am335x_adc.c | 24 1 files changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c index 02a43c8