Ulrich,
On Sat, 6 Jul 2013, Ulrich Prinz wrote:
> I got the message. With modifying the existing driver to support more
> function pointers in its system struct and assigning them at the
> beginning, and using them on runtime, these quirks are obsolete.
Correct.
> Again, this is the first time
On Sat, 6 Jul 2013, Heiko Stübner wrote:
> + if (of_device_is_compatible(np, "rockchip,rk3188-dw-apb-timer-osc"))
> + *quirks |= APBTMR_QUIRK_64BIT_COUNTER | APBTMR_QUIRK_NO_EOI |
> +APBTMR_QUIRK_INVERSE_INTMASK |
> +APBTMR_QUIRK_INVER
On Sat, 6 Jul 2013, Heiko Stübner wrote:
> Some timer variants use an inverted setting to mask the timer interrupt.
> Therefore add a quirk to handle these variants.
And by that add even more pointless conditionals into critical code
pathes.
___
device
On Sat, 6 Jul 2013, Heiko Stübner wrote:
> - dw_ced->eoi = apbt_eoi;
> + if (quirks & APBTMR_QUIRK_NO_EOI)
> + dw_ced->eoi = apbt_eoi_int_status;
> + else
> + dw_ced->eoi = apbt_eoi;
No again. This has nothing to do with quirks. We use quirks for
workarounds and
On Sat, 6 Jul 2013, Heiko Stübner wrote:
> This adds a quirk for IP variants containing two load_count and value
> registers that are used to provide 64bit accuracy on 32bit systems.
>
> The added accuracy is currently not used, the driver is only adapted to
> handle the different register layout
On Tue, 25 Jun 2013, Christian Ruppert wrote:
> On Tue, Jun 25, 2013 at 03:58:43PM +0200, Thomas Gleixner wrote:
> > On Fri, 31 May 2013, Christian Ruppert wrote:
> > > The SOC interrupt controller driver for the Abilis Systems TB10x series of
> > > SOCs based on ARC
On Tue, 25 Jun 2013, Srinivas KANDAGATLA wrote:
> On 25/06/13 14:17, Thomas Gleixner wrote:
> > On Tue, 25 Jun 2013, Srinivas KANDAGATLA wrote:
> >> +static void gt_compare_set(unsigned long delta, int periodic)
> >> +{
> >> + u64 counter = gt_counter_read()
On Fri, 31 May 2013, Christian Ruppert wrote:
> The SOC interrupt controller driver for the Abilis Systems TB10x series of
> SOCs based on ARC700 CPUs.
>
> This patch depends on commits eb76bdd407d8a90e59a06cb0158886df390e5d1c and
> 712bc93df9e7f14b8a163148d2aa7c778e151627 from branch irq/for-arm
On Tue, 25 Jun 2013, Srinivas KANDAGATLA wrote:
> If its not too late can this patch be considered for 3.11 via clocksource
> tree?
Sure. No worry, though I noticed a little detail when reading through it
again. See below.
> +/**
> + * To ensure that updates to comparator value register do not s
gt; banked ID, ID27, for this interrupt. ID27 is sent to the Interrupt
> Controller as a Private Peripheral Interrupt. The global timer is
> clocked by PERIPHCLK.
>
> Signed-off-by: Stuart Menefy
> Signed-off-by: Srinivas Kandagatla
> CC: Arnd Bergmann
> CC: Rob Herring
>
On Fri, 21 Jun 2013, Stephen Boyd wrote:
> On 06/21/13 08:56, Thomas Gleixner wrote:
> >
> >> +static irqreturn_t gt_clockevent_interrupt(int irq, void *dev_id)
> >> +{
> >> + struct clock_event_device *evt = *(struct clock_event_device **)dev_id;
> > W
On Fri, 21 Jun 2013, Srinivas KANDAGATLA wrote:
> +static void gt_clockevent_set_mode(enum clock_event_mode mode,
> +struct clock_event_device *clk)
> +{
> + unsigned long ctrl;
> +
> + ctrl = readl(gt_base + GT_CONTROL);
> + switch (mode) {
> + case
er (ibmvscsi) seems to be doing that from softirq context.
>
> This converts the few non-irqsafe locks into irqsafe ones, making them
> consistent with the rest of the code.
Fun. https://lkml.org/lkml/2013/2/4/416 seems to have got lost
> Signed-off-by: Benjamin Herrenschmidt
> CC:
t context, why is devtree_lock usually
> acquired in an irqsafe manner but sometimes not?
>
> Both types of usage were added by the same commit:
>
> commit d6d3c4e656513dcea61ce900f0ecb9ca820ee7cd
> Author: Thomas Gleixner
> Date: Wed Feb 6 15:30:56 2013 -0500
>
>
On Tue, 11 Jun 2013, Sebastian Hesselbarth wrote:
> On 06/11/13 15:45, Thomas Gleixner wrote:
> > But what about the bit in of that first irq in the cause register? If
> > it's set on entry you call generic_handle_irq() for that as well. So
> > if it's set you need t
On Tue, 11 Jun 2013, Sebastian Hesselbarth wrote:
> On 06/11/13 15:30, Thomas Gleixner wrote:
> > On Tue, 11 Jun 2013, Thomas Gleixner wrote:
> >
> > > On Thu, 6 Jun 2013, Sebastian Hesselbarth wrote:
> > >
> > > > This patch adds an irq
On Tue, 11 Jun 2013, Thomas Gleixner wrote:
> On Thu, 6 Jun 2013, Sebastian Hesselbarth wrote:
>
> > This patch adds an irqchip driver for the main interrupt controller found
> > on Marvell Orion SoCs (Kirkwood, Dove, Orion5x, Discovery Innovation).
> > Corresponding devi
On Tue, 11 Jun 2013, Sebastian Hesselbarth wrote:
> On 06/11/13 14:35, Ezequiel Garcia wrote:
> With Thomas Gleixner's Review now only somebody has to take the irqchip
> patch then all three drivers are queued for next release.
I can take it through tip if nobody else wants it :)
_
ian Hesselbarth
Reviewed-by: Thomas Gleixner
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
On Thu, 6 Jun 2013, Sebastian Hesselbarth wrote:
> This patch set introduces DT-aware irqchip and clocksource drivers for
> Marvell Orion SoCs (Kirkwood, Dove, Orion5x, MV78x00) and corresponding
> patches for Dove and Kirkwood to enable them for DT-boards.
>
> The irqchip driver, of course, depe
On Fri, 31 May 2013, Christian Ruppert wrote:
> The SOC interrupt controller driver for the Abilis Systems TB10x series of
> SOCs based on ARC700 CPUs.
>
> This patch depends on commits eb76bdd407d8a90e59a06cb0158886df390e5d1c and
> 712bc93df9e7f14b8a163148d2aa7c778e151627 from branch irq/for-arm
On Wed, 29 May 2013, Grant Likely wrote:
> > --- linux-2.6.orig/include/linux/irq.h
> > +++ linux-2.6/include/linux/irq.h
> > @@ -678,6 +678,8 @@ struct irq_chip_type {
> > * @wake_active: Interrupt is marked as an wakeup from suspend source
> > * @num_ct:Number of available i
On Tue, 7 May 2013, Christian Ruppert wrote:
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include
> +#include "../../drivers/irqchip/irqchip.h"
#include "irqchip.h" perhaps?
> +#define AB_IRQCTL_INT_ENABLE (0x00)
What's the purpose of the parens? Decrease
On Mon, 13 May 2013, Linus Walleij wrote:
> On Wed, May 8, 2013 at 4:11 PM, Srinivas KANDAGATLA
> > + clk->features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT;
> > + clk->set_mode = gt_clockevent_set_mode;
> > + clk->set_next_event = gt_clockevent_set_next_event;
> > +
Proof of concept patch to demonstrate the new irqdomain support for
the generic irq chip. Untested !!
Signed-off-by: Thomas Gleixner
Cc: Maxime Ripard
---
drivers/irqchip/irq-sun4i.c | 100
1 file changed, 29 insertions(+), 71 deletions(-)
Index
function to install the chip for a particular
interrupt.
Note: This lacks a removal function for now, but this is a draft patch
the ARM folks to work on.
[ Sebastian Hesselbarth: Mask cache and pointer math fixups ]
Signed-off-by: Thomas Gleixner
---
include/linux/irq.h | 30
Some chips have weird bit mask access patterns instead of the linear
you expect. Allow them to calculate the cached mask themself.
Signed-off-by: Thomas Gleixner
---
include/linux/irq.h |3 +++
kernel/irq/generic-chip.c |8 ++--
2 files changed, 9 insertions(+), 2 deletions
Cache the per irq bit mask instead of recalculating it over and over.
Signed-off-by: Thomas Gleixner
---
include/linux/irq.h |4
kernel/irq/generic-chip.c | 23 ++-
2 files changed, 18 insertions(+), 9 deletions(-)
Index: linux-2.6/include/linux/irq.h
Preparatory patch for linear interrupt domains.
Signed-off-by: Thomas Gleixner
---
kernel/irq/generic-chip.c | 50 +++---
1 file changed, 34 insertions(+), 16 deletions(-)
Index: linux-2.6/kernel/irq/generic-chip.c
-by: Thomas Gleixner
---
include/linux/irq.h |2 ++
kernel/irq/generic-chip.c | 17 ++---
2 files changed, 12 insertions(+), 7 deletions(-)
Index: linux-2.6/include/linux/irq.h
===
--- linux-2.6.orig/include
Changes vs. V1:
- Fixed the generic chip pointer thinko (Sebastian Hesselbarth)
- Proper support for mask cache
- Read mask hardware only for the first map of an generic chip
instance
- sun4i prefix irq functions proper
Thanks,
tglx
__
-by: Gerlando Falauto
Cc: Lennert Buytenhek
Cc: Simon Guinot
Cc: Ben Dooks
Cc: Nicolas Pitre
Cc: Jason Cooper
Cc: Andrew Lunn
Cc: Holger Brunck
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Thomas Gleixner
---
include/linux/irq.h |6 +-
kernel/irq/generic-chip.c
Cooper
Cc: Andrew Lunn
Cc: Holger Brunck
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Thomas Gleixner
---
kernel/irq/generic-chip.c | 31 +--
1 file changed, 17 insertions(+), 14 deletions(-)
Index: tip/kernel/irq/generic-chip.c
On Mon, 6 May 2013, Sebastian Hesselbarth wrote:
> mask_cache pointer also needs to be initialized for domain generic
> chips.
It's not only the mask cache pointer. We also need to initialize the
mask cache itself. I solved it by spitting out that code from
irq_setup_generic_chip().
Thanks,
On Mon, 6 May 2013, Sebastian Hesselbarth wrote:
> irq_domain_chip_generic is allocating and indexing irq_chip_generic
> itself. However, the size of irq_chip_generic varies with number of
> irq_chip_types. This fixup moves irq_chip_generic helt by
> irq_domain_chip_generic to array of ptr and fix
On Sat, 4 May 2013, Sebastian Hesselbarth wrote:
> On 05/03/2013 11:50 PM, Thomas Gleixner wrote:
> > Provide infrastructure for irq chip implementations which work on
> > linear irq domains.
>
> Thomas,
>
> I am happy that I put you into rant mode. It took me little
On Fri, 3 May 2013, Russell King - ARM Linux wrote:
> On Fri, May 03, 2013 at 09:50:50PM -0000, Thomas Gleixner wrote:
> > - u32 mask = ~(1 << (d->irq - gc->irq_base));
> > + u32 mask = ~(d->mask);
>
> I suspect the above changes are all a result of a s
On Fri, 3 May 2013, Russell King - ARM Linux wrote:
> On Fri, May 03, 2013 at 09:50:53PM -0000, Thomas Gleixner wrote:
> > + /* Init mask cache ? */
> > + if (dgc->gc_flags & IRQ_GC_INIT_MASK_CACHE) {
> > + raw_spin_lock_irqsave(&gc->lock, fla
Preparatory patch for linear interrupt domains.
Signed-off-by: Thomas Gleixner
---
kernel/irq/generic-chip.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
Index: linux-2.6/kernel/irq/generic-chip.c
function to install the chip for a particular
interrupt.
Note: This lacks a removal function for now, but this is a draft patch
the ARM folks to work on.
Signed-off-by: Thomas Gleixner
---
include/linux/irq.h | 30 +++
include/linux/irqdomain.h | 12 +++
kernel/irq/generic-chip.c
Proof of concept patch to demonstrate the new irqdomain support for
the generic irq chip. Untested !!
Signed-off-by: Thomas Gleixner
Cc: Maxime Ripard
---
drivers/irqchip/irq-sun4i.c | 100
1 file changed, 29 insertions(+), 71 deletions(-)
Index
The ongoing device tree support for ARM is creating new irq chip
drivers in drivers/irqchip/ in a frenzy. Quite some of them are
ripping out the generic irq chip implementation from arch/arm/* and
just creating the same mess of duplicated code again, which was
cleaned up with the generic irq chip i
Some chips have weird bit mask access patterns instead of the linear
you expect. Allow them to calculate the cached mask themself.
Signed-off-by: Thomas Gleixner
---
include/linux/irq.h |3 +++
kernel/irq/generic-chip.c |8 ++--
2 files changed, 9 insertions(+), 2 deletions
Cache the per irq bit mask instead of recalculating it over and over.
Signed-off-by: Thomas Gleixner
---
include/linux/irq.h |4
kernel/irq/generic-chip.c | 23 ++-
2 files changed, 18 insertions(+), 9 deletions(-)
Index: linux-2.6/include/linux/irq.h
-by: Thomas Gleixner
---
include/linux/irq.h |2 ++
kernel/irq/generic-chip.c | 17 ++---
2 files changed, 12 insertions(+), 7 deletions(-)
Index: linux-2.6/include/linux/irq.h
===
--- linux-2.6.orig/include
-by: Gerlando Falauto
Cc: Lennert Buytenhek
Cc: Simon Guinot
Cc: Ben Dooks
Cc: Nicolas Pitre
Cc: Jason Cooper
Cc: Andrew Lunn
Cc: Holger Brunck
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Thomas Gleixner
---
include/linux/irq.h |6 +-
kernel/irq/generic-chip.c
Cooper
Cc: Andrew Lunn
Cc: Holger Brunck
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Thomas Gleixner
---
kernel/irq/generic-chip.c | 31 +--
1 file changed, 17 insertions(+), 14 deletions(-)
Index: tip/kernel/irq/generic-chip.c
On Fri, 3 May 2013, Sebastian Hesselbarth wrote:
> On 05/03/13 14:55, Russell King - ARM Linux wrote:
> > This is where it starts to get tricky, because I can't see how you'd
> > merge the irq_alloc_generic_chip() and irq_setup_generic_chip() with
> > this. Maybe you don't need to do anything here
Sebastian,
please do not take the rant below personally. You just happen to
trigger it.
On Thu, 2 May 2013, Sebastian Hesselbarth wrote:
> +static void orion_irq_mask(struct irq_data *irqd)
> +{
> + unsigned int irq = irqd_to_hwirq(irqd);
> + unsigned int irq_off = irq % 32;
> + int
On Wed, 24 Apr 2013, James Hogan wrote:
> Thanks for the review Thomas!
>
> On 23/04/13 16:09, Thomas Gleixner wrote:
> > On Tue, 23 Apr 2013, James Hogan wrote:
>> + spinlock_t lock;
> >
> > raw_spinlock_t please
>
> Okay.
>
> If
On Tue, 23 Apr 2013, James Hogan wrote:
> +/**
> + * struct pdc_intc_priv - private pdc interrupt data.
> + * @nr_perips: Number of peripheral interrupt signals.
> + * @nr_syswakes: Number of syswake signals.
> + * @perip_irqs: List of peripheral IRQ numbers handled.
On Wed, 13 Mar 2013, John Stultz wrote:
> On 03/13/2013 02:27 PM, Christian Daudt wrote:
> > This adds support for the Broadcom timer, used in the following SoCs:
> > BCM11130, BCM11140, BCM11351, BCM28145, BCM28155
> [snip]
> > Signed-off-by: Christian Daudt
> > Acked-by: Arnd Bergmann
> > Acked
On Fri, 25 Jan 2013, Paul Gortmaker wrote:
> From: Thomas Gleixner
>
> There is no real reason to use a rwlock for devtree_lock. It even
> could be a mutex, but unfortunately it's locked from cpu hotplug
> paths which can't schedule :(
>
> So it needs to become
On Thu, 12 Apr 2012, Benjamin Herrenschmidt wrote:
> On Wed, 2012-04-11 at 14:57 -0600, Grant Likely wrote:
> >
> > Yeah, I've got a different way to fix it though. There is exactly one
> > user of irq_virq_count in-tree right now: PS3. Also, irq_virq_count
> > is only useful for the NOMAP map
On Fri, 6 Apr 2012, Andreas Schwab wrote:
> Thomas Gleixner writes:
>
> > And it looks like the irqdomain code is the real culprit.
> >
> > void irq_set_virq_count(unsigned int count)
> > {
> > pr_debug("irq: Trying to set virq count to %d
On Fri, 6 Apr 2012, Andreas Schwab wrote:
> Grant Likely writes:
>
> > Can you attach console output logs for each of configs above and also
> > with NR_IRQS=128? That might give me some clues as to which specific
> > code is causing the issues.
>
> It really looks like the issue starts when i
On Thu, 5 Apr 2012, Andreas Schwab wrote:
> Grant Likely writes:
>
> > I bet it is NR_IRQS related. You have SPARSE_IRQ enabled, which means
> > the maximum number of irq_descs is IRQ_BITMAP_BITS (NR_IRQS + 8192).
>
> The actual definition uses NR_IRQS + 8196. Guess that's a typo. (Does
> it
On Mon, 2 Apr 2012, Russell King - ARM Linux wrote:
> If we want to fix it a better way, then sure, that'll be good. But what
> we shouldn't do is re-introduce one regression to fix a different
> regression.
>
> So, Thomas, what do you think about providing a way that a disabled
> interrupt could
On Tue, 3 Apr 2012, Benjamin Herrenschmidt wrote:
> On Mon, 2012-04-02 at 22:55 +0100, Russell King - ARM Linux wrote:
> > Well, presumably someone is calling irq_set_irq_type() asking explicitly
> > for IRQ_TYPE_NONE. The code will now (as it always used to before David's
> > change) do exactly
On Tue, 3 Apr 2012, Benjamin Herrenschmidt wrote:
> On Mon, 2012-04-02 at 22:52 +0200, Thomas Gleixner wrote:
> > > When I revert a09b659cd68c10ec6a30cb91ebd2c327fcd5bfe5 ("genirq: Fix
> > > long-term regression in genirq irq_set_irq_type() handling") on top
&g
On Mon, 2 Apr 2012, Andreas Schwab wrote:
> Andreas Schwab writes:
>
> > Grant Likely writes:
> >
> >> This patch drops the powerpc-specific irq_map table and replaces it with
> >> directly using the irq_alloc_desc()/irq_free_desc() interfaces for
> >> allocating
> >> and freeing irq_desc stru
ou should look at both anything that defines an "interrupt-controller"
> property as an example including Documentation/devicetree/bindings/arm/vic.txt
> and Documentation/devicetree/bindings/arm/gic.txt.
>
> (taking Thomas Gleixner on Cc)
>
> Since the orion irq chip i
On Wed, 14 Sep 2011, Rob Herring wrote:
> From: Rob Herring
>
> irq_data will normally exist, so the domain was prevented from being set.
> The simple domain code did not hit this as nr_irq is always 0.
>
> Signed-off-by: Rob Herring
> Cc: Grant Likely
> Cc: Thomas Gl
to be merged but for this infrastructure.
Looks reasonable, please merge them through your tree.
Reviewed-by: Thomas Gleixner
Thanks,
tglx
___
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss
On Thu, 5 May 2011, Benjamin Herrenschmidt wrote:
> > As for the mapping, I agree that the functionality is generally
> > useful, I'm just not fond of the current implementation. I think it
> > is more complex than it needs to be and I'm not excited about bring it
> > over to the other architectur
ecause the 2.6.37 merge window
> has already been open for almost a week.
Fine with me. That's sufficiently self contained :) So
Acked-by: Thomas Gleixner
> The promtree patches have been merged though.
>
> Comments below.
>
> g.
>
> > ---
> > arch
On Mon, 4 Oct 2010, Grant Likely wrote:
> On Mon, Oct 4, 2010 at 5:09 PM, Benjamin Herrenschmidt
> wrote:
> > On Mon, 2010-10-04 at 10:52 -0600, Grant Likely wrote:
> >> On Sun, Oct 03, 2010 at 02:03:57PM -0500, Jon Loeliger wrote:
> >> >
> >> > Just rename the irq_host structure as irq_domain to
On Fri, 24 Sep 2010, Benjamin Herrenschmidt wrote:
> On Thu, 2010-09-23 at 19:31 +0200, Richard Cochran wrote:
> > The new syscall, clock_adjtime, takes two parameters, the clock ID,
> > and a pointer to a struct timex. The semantics of the timex struct
> > have been expanded by one additional mode
On Tue, 21 Sep 2010, Grant Likely wrote:
> On Tue, Sep 21, 2010 at 7:25 AM, Shaju Abraham
> wrote:
> > Hi Grant
> >
> > Since there does not exist a mechanism to map the hw irq to linux irq
> > on ARM (device tree), I would like to discuss with you the plans or
> > ideas to implement the same.
>
On Tue, 21 Sep 2010, Andres Salomon wrote:
> On Tue, 21 Sep 2010 11:45:37 +0200 (CEST)
> Thomas Gleixner wrote:
>
> > > Any additional comments (ACKs, NACKs, etc) on the patches? If I
> > > need to rework it (or them), I can certainly make the patch
> > > de
On Mon, 20 Sep 2010, Andres Salomon wrote:
> On Fri, 10 Sep 2010 12:21:35 -0600
> Grant Likely wrote:
>
> > On Fri, Sep 10, 2010 at 08:14:58PM +0200, Ingo Molnar wrote:
> > >
> > > * Grant Likely wrote:
> > >
> > > > On Fri, Sep 10, 2010 at 06:01:51AM -0700, Andres Salomon wrote:
> > > > >
>
On Fri, 10 Sep 2010, Grant Likely wrote:
> On Fri, Sep 10, 2010 at 08:14:58PM +0200, Ingo Molnar wrote:
> >
> > * Grant Likely wrote:
> >
> > > On Fri, Sep 10, 2010 at 06:01:51AM -0700, Andres Salomon wrote:
> > > >
> > > > - Define a stub irq_create_of_mapping for x86 as a stop-gap solution
On Wed, 28 Jul 2010, Ian Campbell wrote:
> Continue to provide IRQF_TIMER as an alias to IRQF_NO_SUSPEND since I
> think it is worth preserving the nice self-documenting name (where it
> is used appropriately). It also avoid needing to patch all the many
> users who are using the flag for an actua
73 matches
Mail list logo
