Re: [PATCH 1/3] dmaengine: add dma_get_slave_sg_limits()

2013-07-18 Thread Vinod Koul
On Thu, Jul 18, 2013 at 11:46:39AM -0500, Joel Fernandes wrote: > From: Matt Porter > > Add a dmaengine API to retrieve slave SG transfer limits. > > The API is optionally implemented by dmaengine drivers and when > unimplemented will return a NULL pointer. A client driver using > this API provi

Re: [PATCH v3] DMA: shdma: add DT support

2013-06-25 Thread Vinod Koul
On Tue, Jun 18, 2013 at 06:16:57PM +0200, Guennadi Liakhovetski wrote: > This patch adds Device Tree support to the shdma driver. No special DT > properties are used, only standard DMA DT bindings are implemented. Since > shdma controllers reside on SoCs, their configuration is SoC-specific and > s

Re: [PATCH] dmaengine: Add hisilicon k3 DMA engine driver

2013-06-21 Thread Vinod Koul
On Tue, Jun 18, 2013 at 05:08:01PM +0200, Arnd Bergmann wrote: > On Tuesday 18 June 2013 22:22:17 zhangfei wrote: > > > With no need to have a filter function. > > > > Cool, then I would like to wait for the patch. > > Maybe you can try to add the dma_get_slave_channel() function I proposed here

Re: [PATCH] dmaengine: Add hisilicon k3 DMA engine driver

2013-06-21 Thread Vinod Koul
On Tue, Jun 18, 2013 at 04:09:14PM +0200, Arnd Bergmann wrote: > On Tuesday 18 June 2013, zhangfei gao wrote: > > On Tue, Jun 18, 2013 at 4:58 AM, Arnd Bergmann wrote: > > > > > >> +static struct of_dma_filter_info k3_dma_filter; > > >> +static bool k3_dma_filter_fn(struct dma_chan *chan, void *pa

Re: [PATCH] dmaengine: Add hisilicon k3 DMA engine driver

2013-06-21 Thread Vinod Koul
On Mon, Jun 17, 2013 at 10:58:07PM +0200, Arnd Bergmann wrote: > On Monday 17 June 2013, Zhangfei Gao wrote: > > Add dmaengine driver for hisilicon k3 platform based on virt_dma > > > > Signed-off-by: Zhangfei Gao > > Tested-by: Kai Yang > > Acked-by: Arnd Bergmann > > > This filter function

Re: [PATCH] dmaengine: Add hisilicon k3 DMA engine driver

2013-06-21 Thread Vinod Koul
On Mon, Jun 17, 2013 at 12:54:32PM +0800, Zhangfei Gao wrote: > Add dmaengine driver for hisilicon k3 platform based on virt_dma > > Signed-off-by: Zhangfei Gao > Tested-by: Kai Yang > --- [snip] > +#define to_k3_dma(dmadev) container_of(dmadev, struct k3_dma_dev, slave) > + > +static struct k3

Re: [PATCH -next v2] dmaengine: ste_dma40: fix error return code in d40_probe()

2013-06-17 Thread Vinod Koul
On Thu, Jun 13, 2013 at 09:49:04AM +0200, Linus Walleij wrote: > On Wed, Jun 12, 2013 at 11:54 AM, Vinod Koul wrote: > > >> Let me know how you want it, I've removed it from my > >> dma40 branch for the time being. > > > > Have you removed, Also I see a v

Re: [PATCH 0/3] dma: add support for DMA multiplexer DT nodes

2013-06-17 Thread Vinod Koul
On Wed, Jun 12, 2013 at 12:38:44PM +0200, Guennadi Liakhovetski wrote: > On Wed, 12 Jun 2013, Vinod Koul wrote: > > > On Wed, Jun 12, 2013 at 02:53:49PM +0530, Vinod Koul wrote: > > > On Thu, Jun 06, 2013 at 05:47:22PM +0200, Guennadi Liakhovetski wrote: > > > >

Re: [PATCH -next v2] dmaengine: ste_dma40: fix error return code in d40_probe()

2013-06-12 Thread Vinod Koul
On Tue, Jun 04, 2013 at 11:14:16AM +0200, Linus Walleij wrote: > On Thu, May 30, 2013 at 7:33 PM, Vinod Koul wrote: > > On Thu, May 30, 2013 at 09:41:38AM +0200, Linus Walleij wrote: > >> On Thu, May 30, 2013 at 6:32 AM, Wei Yongjun wrote: > >> > >> > From

Re: [PATCH 0/3] dma: add support for DMA multiplexer DT nodes

2013-06-12 Thread Vinod Koul
On Wed, Jun 12, 2013 at 02:53:49PM +0530, Vinod Koul wrote: > On Thu, Jun 06, 2013 at 05:47:22PM +0200, Guennadi Liakhovetski wrote: > > Next re-send of an earlier work. This series adds support for multiple > > compatible DMAC instances, capable of serving the same DMA slaves. &

Re: [PATCH 0/3] dma: add support for DMA multiplexer DT nodes

2013-06-12 Thread Vinod Koul
On Thu, Jun 06, 2013 at 05:47:22PM +0200, Guennadi Liakhovetski wrote: > Next re-send of an earlier work. This series adds support for multiple > compatible DMAC instances, capable of serving the same DMA slaves. > Currently to specify such a configuration in DT, slaves would have to add > DMA t

Re: [PATCH 2/9] dma: pl330: use dma_addr_t for describing bus addresses

2013-06-11 Thread Vinod Koul
> > > > This patch uses dma_addr_t to represent the address instead. > > > > Acked-by: Jassi Brar > > > > Cc: Jassi Brar > > Cc: Vinod Koul > > Signed-off-by: Will Deacon Applied, thanks -- ~Vinod > > --- > > drivers/dma/pl330.c | 2 +- >

Re: [PATCH 1/9] dma: pl330: rip out broken, redundant ID probing

2013-06-11 Thread Vinod Koul
rs, which is either UNPREDICTABLE or generates an alignment fault > (depending on the presence of the virtualisation extensions). > > Rather than fix this code, we can actually rip most of it out and let > the AMBA bus driver correctly do the probing for us. > > Cc: Jassi Brar >

Re: [PATCH 0/3] at_hdmac: dt dma bindings update

2013-05-30 Thread Vinod Koul
On Thu, May 30, 2013 at 06:08:20PM +0200, ludovic.desroc...@atmel.com wrote: > From: Ludovic Desroches > > Hi, > > This set of patches update the dt dma binding for at_hdmac since we need one > more parameter. In order to keep backward compatibility, an existing cell will > be used to add this p

Re: [PATCH -next v2] dmaengine: ste_dma40: fix error return code in d40_probe()

2013-05-30 Thread Vinod Koul
.git > > I've tentatively applied this to my dma40 branch, waiting for Vinod > to ACK it. I though you wanted me to apply this :) Nevertheless, Acked-by: Vinod Koul Can you CC stable too, pls. -- ~Vinod -- ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH v7 0/2] dma: imx-dma: OFTree support

2013-05-27 Thread Vinod Koul
On Sun, May 26, 2013 at 11:53:19AM +0200, Markus Pargmann wrote: > Hi, > > this series adds support for the generic DMA DT bindings for imx-dma. > > Regards, > > Markus > > > Changes in v7: > - rebased onto v3.10-rc2 Applied thanks... -- ~Vinod > > Markus Pargmann (2): > dma: imx-dma:

Re: [PATCH 26/63] dmaengine: ste_dma40: Supply full Device Tree parsing support

2013-05-23 Thread Vinod Koul
request and allocate a channel in the correct manner. > > Cc: Vinod Koul > Cc: Dan Williams > Cc: Per Forlin > Cc: Rabin Vincent > Cc: Rob Herring > Cc: devicetree-discuss@lists.ozlabs.org > Reviewed-by: Arnd Bergmann > Signed-off-by: Lee Jones Acked-by: Vinod K

Re: [PATCH/RFC 0/4] dmaengine: add DT support for DMA multiplexers

2013-05-02 Thread Vinod Koul
On Tue, Apr 30, 2013 at 02:17:13PM +0200, Guennadi Liakhovetski wrote: > (added Russell to CC, sorry for not including initially) > > Hi Vinod > > On Tue, 30 Apr 2013, Vinod Koul wrote: > > > On Tue, Apr 30, 2013 at 09:11:19AM +0200, Guennadi Liakhovetski wrote: >

Re: [PATCH/RFC 0/4] dmaengine: add DT support for DMA multiplexers

2013-04-30 Thread Vinod Koul
On Tue, Apr 30, 2013 at 09:11:19AM +0200, Guennadi Liakhovetski wrote: > Previously an issue has been discussed, arising on sh-/r-mobile ARM-based > systems. There we typically have multiple DMA controller instances with > exactly equal or very similar capabilities. Each of them can serve the sam

Re: [PATCH 7/6] DMA: shdma: add DT binding documentation

2013-04-30 Thread Vinod Koul
On Fri, Apr 26, 2013 at 08:26:16AM +0200, Guennadi Liakhovetski wrote: > SHDMA uses only standard DMA Device Tree bindings. This patch adds > documentation, exactly describing the use of the bindings and providing > examples. > > Signed-off-by: Guennadi Liakhovetski > --- > > This patch adds the

Re: [PATCH 18/23] dma: coh901318: add devicetree support

2013-04-22 Thread Vinod Koul
On Mon, Apr 22, 2013 at 11:59:30AM +0200, Linus Walleij wrote: > From: Linus Walleij > > This adds support for probing the COH 901 318 DMA controller > from the device tree. > > Cc: Vinod Koul > Signed-off-by: Linus Walleij Acked-by: Vinod Koul -- ~Vinod > --- > H

Re: [PATCH 1/2] dmaengine: mpc512x_dma: use generic DMA DT bindings

2013-04-02 Thread Vinod Koul
On Sun, Mar 31, 2013 at 06:17:59PM +0200, Anatolij Gustschin wrote: > Add generic DMA bindings and register the DMA controller > to DT DMA helpers. I need someone who understands DT better than me to comment/ack... Arnd...? > > Signed-off-by: Anatolij Gustschin > --- > arch/powerpc/boot/dts/mpc

Re: [PATCH V3] DMA: PL330: Add check if device tree compatible

2013-04-02 Thread Vinod Koul
--- > > Based on Vinod Koul next branch. > > Changes since V2: > - Removed pl330_free_chan_resources for error handling in probe. > > Changes since V1: > - return silently when of_dma_controller_register fails, as > sugges

Re: [PATCH V3 2/2] dmaengine: OMAP: Register SDMA controller with Device Tree DMA driver

2013-04-01 Thread Vinod Koul
On Mon, Apr 01, 2013 at 12:48:26PM -0500, Jon Hunter wrote: > Vinod, > > On 03/20/2013 11:36 AM, Tony Lindgren wrote: > > * Jon Hunter [130319 09:08]: > >> Vinod, Tony, Benoit, > >> > >> On 02/26/2013 12:27 PM, Jon Hunter wrote: > >>> If the device-tree blob is present during boot, then register

Re: [PATCH V2] DMA: PL330: Add check if device tree compatible

2013-04-01 Thread Vinod Koul
On Mon, Apr 01, 2013 at 08:13:31AM -0500, Rob Herring wrote: > On Thu, Mar 21, 2013 at 4:39 AM, Vinod Koul wrote: > > On Tue, Mar 05, 2013 at 02:55:31PM +0530, Padmavathi Venna wrote: > >> This patch register the dma controller with generic dma helpers only > >> in D

Re: [PATCH V2] DMA: PL330: Add check if device tree compatible

2013-03-21 Thread Vinod Koul
--- > > Based on Vinod Koul next branch. > > Changes since V1: > - return silently when of_dma_controller_register fails, as > suggested by Arnd. > > drivers/dma/pl330.c | 38 +++--- > 1 files changed, 27 insertions(+),

Re: [PATCH] DMA: of: Constant names

2013-03-21 Thread Vinod Koul
On Sun, Feb 24, 2013 at 04:36:09PM +0100, Markus Pargmann wrote: > No DMA of-function alters the name, so this patch changes the name arguments > to be constant. Most drivers will probably request DMA channels using a > constant name. > > Signed-off-by: Markus Pargmann Applied thanks -- ~Vinod >

Re: [PATCH] dma: Remove erroneous __exit and __exit_p() references

2013-03-07 Thread Vinod Koul
On Thu, Mar 07, 2013 at 03:17:35PM +0530, Vinod Koul wrote: > On Thu, Mar 07, 2013 at 10:17:40AM +0100, Maxin B. John wrote: > > Hi, > > > > On Fri, Feb 22, 2013 at 7:29 PM, Linus Walleij > > wrote: > > > On Wed, Feb 20, 2013 at 1:07 AM, wrot

Re: [PATCH] dma: Remove erroneous __exit and __exit_p() references

2013-03-07 Thread Vinod Koul
On Thu, Mar 07, 2013 at 10:17:40AM +0100, Maxin B. John wrote: > Hi, > > On Fri, Feb 22, 2013 at 7:29 PM, Linus Walleij > wrote: > > On Wed, Feb 20, 2013 at 1:07 AM, wrote: > > > >> From: "Maxin B. John" > >> > >> Removing the annotation with __exit and referencing with __exit_p() > >> presen

Re: [PATCH 1/2] of: dma: make #dma-cells optional

2013-03-06 Thread Vinod Koul
On Wed, Feb 27, 2013 at 06:57:57PM -0600, Rob Herring wrote: > From: Rob Herring > > For controllers with no requests/clients (memory to memory only), the Change log is truncated... > > Signed-off-by: Rob Herring > Cc: Vinod Koul > Cc: Dan Williams > Cc: Grant Likely

Re: [PATCH 0/4] dw_dmac: introduce generic DMA binding for DT

2013-02-20 Thread Vinod Koul
On Wed, Feb 20, 2013 at 09:50:25AM +, Arnd Bergmann wrote: > On Wednesday 20 February 2013, Vinod Koul wrote: > > Since there is still churn, would it make sense if I just revert the > > SPEAr13xx > > patch (your first patch) and send a pull request to Linus. > > S

Re: [PATCH 0/4] dw_dmac: introduce generic DMA binding for DT

2013-02-20 Thread Vinod Koul
On Fri, Feb 15, 2013 at 07:21:48PM +0100, Arnd Bergmann wrote: > Hi Vinod, > > As Andy pointed out today, we don't have a good solution for the > dw_dmac DT binding in linux-next yet. I have posted my series > once before and then got distracted after getting feedback from > Viresh, Andy and Russe

Re: [PATCH V4 0/4] Add generic DMA DT binding support

2013-02-14 Thread Vinod Koul
- Filter the dma channel based on channel number and dma_device > > This patch set adds support for generic dma device tree bindings for > Samsung platforms and is dependent on the following patches from > Vinod Koul next branch > 1)of: Add generic device tree DMA helpers

Re: [PATCH v2] dma: of-dma.c: fix memory leakage

2013-02-14 Thread Vinod Koul
On Thu, Feb 14, 2013 at 11:16:10AM +0100, Cong Ding wrote: > The memory allocated to ofdma might be a leakage when error occurs. > > Signed-off-by: Cong Ding Applied, thanks -- ~Vinod > --- > drivers/dma/of-dma.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/dma/of-dma.c

Re: [PATCH V4 0/5] Add generic DMA DT binding support

2013-02-14 Thread Vinod Koul
On Thu, Feb 14, 2013 at 11:12:51AM +0530, Padma Venkat wrote: > Hi Vinod, > > On Thu, Feb 14, 2013 at 10:17 AM, Vinod Koul wrote: > > On Wed, Feb 13, 2013 at 09:52:30AM +0530, Padma Venkat wrote: > >> Hi Vinod, > >> > >> On Tue, Feb 12, 2013 at 8:19 PM

Re: [PATCH V4 0/5] Add generic DMA DT binding support

2013-02-13 Thread Vinod Koul
On Wed, Feb 13, 2013 at 09:52:30AM +0530, Padma Venkat wrote: > Hi Vinod, > > On Tue, Feb 12, 2013 at 8:19 PM, Vinod Koul wrote: > > On Mon, Feb 11, 2013 at 02:08:20PM +0530, Padmavathi Venna wrote: > > > > This looks fine, I have only question. The code seems to

Re: [PATCH] of: dma.c: fix memory leakage

2013-02-13 Thread Vinod Koul
On Wed, Feb 13, 2013 at 12:26:23PM +0100, Cong Ding wrote: > > > > You need to send this to whomever is working on DMA bindings. > > > Thank you bob, I added Vinod the the receiver list. > > I have moved the of/dma.c to dma/of-dma.c, can you regenerate this patch and > > resend to me > Sorry Vinod,

Re: [PATCH] of: dma: protect list write operation by spin_lock

2013-02-13 Thread Vinod Koul
On Wed, Feb 13, 2013 at 09:48:29AM +0200, Andy Shevchenko wrote: > On Tue, 2013-02-12 at 09:20 -0800, Vinod Koul wrote: > > On Tue, Jan 29, 2013 at 09:36:45AM -0600, Rob Herring wrote: > > > >> Vinod, it's probably better to move drivers/of/dma.c to drivers/dma. >

Re: [PATCH] of: dma.c: fix memory leakage

2013-02-12 Thread Vinod Koul
On Tue, Jan 22, 2013 at 10:10:53AM +, Cong Ding wrote: > On Sun, Jan 20, 2013 at 04:24:49PM -0600, Rob Herring wrote: > > On 01/19/2013 07:06 AM, Cong Ding wrote: > > > The memory allocated to ofdma might be a leakage when error occurs. > > > > > > Signed-off-by: Cong Ding > > > > You need t

Re: [PATCH] of: dma: protect list write operation by spin_lock

2013-02-12 Thread Vinod Koul
t; > ok, do you have any patches on your tree for this if not then I can update > > my tree > > for this change and then we can apply changes thru slave-dma tree. > > No, I don't have one prepared. Okay, I have committed and pushed drivers/of/dma.c to be moved to driver

Re: [PATCH v7 07/10] dmaengine: add dma_request_slave_channel_compat()

2013-02-12 Thread Vinod Koul
gt; Acked-by: Tony Lindgren > Acked-by: Arnd Bergmann Acked-by: Vinod Koul > --- > include/linux/dmaengine.h | 16 > 1 file changed, 16 insertions(+) > > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h > index bfcdecb..17d8ffd 10

Re: [PATCH V4 0/5] Add generic DMA DT binding support

2013-02-12 Thread Vinod Koul
? > This patch set adds support for generic dma device tree bindings for > Samsung platforms and is dependent on the following patches from > Vinod Koul next branch > 1)of: Add generic device tree DMA helpers > 2)dmaengine: add helper function to request a slave DMA channel > > T

Re: [PATCH] of: dma: protect list write operation by spin_lock

2013-01-28 Thread Vinod Koul
On Mon, Jan 28, 2013 at 09:52:00AM -0600, Rob Herring wrote: > On 01/28/2013 09:24 AM, Andy Shevchenko wrote: > > Signed-off-by: Andy Shevchenko > > --- > > drivers/of/dma.c |2 ++ > > 1 file changed, 2 insertions(+) > > You need to cc whomever has this file in their tree which is Vinod. >

Re: [PATCH V6 10/10] dmaengine: Fix compilation error in non-DT case

2013-01-28 Thread Vinod Koul
On Fri, Jan 18, 2013 at 05:17:09PM +0530, Padmavathi Venna wrote: > Signed-off-by: Padmavathi Venna > --- > include/linux/dmaengine.h |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h > index 8cd0e25..c88f302 1006

Re: [PATCH 0/4] Add generic DMA DT binding support

2013-01-28 Thread Vinod Koul
On Fri, Jan 18, 2013 at 05:03:40PM +0530, Padmavathi Venna wrote: > This patch set adds support for generic dma device tree bindings for > Samsung platforms and is dependent on the following patches from > Vinod Koul next branch > 1)of: Add generic device tree DMA helpers > 2)dmaeng

Re: [PATCH V6 2/2] dmaengine: add helper function to request a slave DMA channel

2012-12-20 Thread Vinod Koul
#x27;s changes, just merged and pushed those. Pull request should show up in couple of days. Thanks -- Vinod Koul Intel Corp. ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH] of: dma: Fix-up for warnings !CONFIG_OF

2012-11-29 Thread Vinod Koul
On Thu, 2012-11-29 at 16:24 -0600, Jon Hunter wrote: > When compiling the kernel with DMA engine support enabled and device-tree > support disabled, the following warnings are observed. Thanks, already committed same change last night. > > In file included from drivers/dma/dmaengine.c:65:0: > incl

Re: [PATCH V6 2/2] dmaengine: add helper function to request a slave DMA channel

2012-11-28 Thread Vinod Koul
p;m=134998461526129&w=2 > Applied both and merged the branch to my next. It should show up in linux-next tomorrow Please check Thanks -- Vinod Koul Intel Corp. ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH V6 2/2] dmaengine: add helper function to request a slave DMA channel

2012-11-15 Thread Vinod Koul
On Fri, 2012-11-09 at 14:01 -0600, Jon Hunter wrote: > Hi Vinod, > > A few people have been asking me if getting device-tree support for DMA > engine is plan for record for v3.8. I know that you were working through > implementing a common interface and so I wanted to check how that is > going. Do

Re: [PATCH V3 2/3] dmaengine: dw_dmac: Enhance device tree support

2012-10-26 Thread Vinod Koul
bisect to work. Done, it should reflect now. Sorry for the mess. -- Vinod Koul Intel Corp. ___ devicetree-discuss mailing list devicetree-discuss@lists.ozlabs.org https://lists.ozlabs.org/listinfo/devicetree-discuss

Re: [PATCH V3 2/3] dmaengine: dw_dmac: Enhance device tree support

2012-10-26 Thread Vinod Koul
lter routine. > > - Update binding document > > I can see that you applied these patches and they are present in > linux-next. But i feel > the order of patches is bad. Yes looks like I forgot to sort the mbox series :( since all patches were applied nicely, and they seem fairly

Re: [PATCH V6 2/2] dmaengine: add helper function to request a slave DMA channel

2012-10-15 Thread Vinod Koul
On Tue, 2012-10-16 at 10:43 +0800, Shawn Guo wrote: > On Tue, Sep 25, 2012 at 10:05:01AM +0530, Vinod Koul wrote: > > On Mon, 2012-09-24 at 17:25 -0500, Jon Hunter wrote: > > > > For DT bindings, I think the binding itself shouldn't change based on my > > >

Re: [RFC PATCH 08/13] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC

2012-10-02 Thread Vinod Koul
On Mon, 2012-10-01 at 12:39 -0400, Matt Porter wrote: > Anything you can show at this point? ;) I'd be happy to drop the > half-hack > for a real API. If not, I'm going to carry that to v2 atm. This is what I had done sometime back. Feel free to update diff --git a/include/linux/dmaengine.h

Re: [RFC PATCH 08/13] mmc: omap_hsmmc: limit max_segs with the EDMA DMAC

2012-09-27 Thread Vinod Koul
On Fri, 2012-09-21 at 19:47 +0100, Russell King - ARM Linux wrote: > On Fri, Sep 21, 2012 at 10:45:29PM +0530, S, Venkatraman wrote: > > On Thu, Sep 20, 2012 at 8:13 PM, Matt Porter wrote: > > > The EDMA DMAC has a hardware limitation that prevents supporting > > > scatter gather lists with any nu

Re: [RFC PATCH 10/13] spi: omap2-mcspi: dma_request_slave_channel() support for DT platforms

2012-09-27 Thread Vinod Koul
On Fri, 2012-09-21 at 14:37 -0400, Matt Porter wrote: > On Fri, Sep 21, 2012 at 08:42:47AM -0700, Tony Lindgren wrote: > > > > Can't we come up with a version of dma_request_slave_channel that works > > both ways for now: > > > > mcspi_dma->dma_rx = > > dma_request_slave_channel_c

Re: [PATCH V6 2/2] dmaengine: add helper function to request a slave DMA channel

2012-09-24 Thread Vinod Koul
On Mon, 2012-09-24 at 17:25 -0500, Jon Hunter wrote: > > For DT bindings, I think the binding itself shouldn't change based on my > > work but I would like these same bindings to help build the DMA engine > > code mappings. > > > > Now would it make sense to NOT merge these changes for 3.7 and pos

Re: [PATCH V6 2/2] dmaengine: add helper function to request a slave DMA channel

2012-09-17 Thread Vinod Koul
On Mon, 2012-09-17 at 23:36 +0100, Russell King - ARM Linux wrote: > > > > I believe that Jon is on vacation this week, so if this is the only issue > > holding up the merge, maybe you can change this in his patch directly, or > > I can send an updated version if you prefer. > > I worry that too

Re: [PATCH V6 2/2] dmaengine: add helper function to request a slave DMA channel

2012-09-17 Thread Vinod Koul
On Mon, 2012-09-17 at 11:59 +, Arnd Bergmann wrote: > On Monday 17 September 2012, Vinod Koul wrote: > > I believe that Jon is on vacation this week, so if this is the only issue > holding up the merge, maybe you can change this in his patch directly, or > I can send an updated

Re: [PATCH V6 2/2] dmaengine: add helper function to request a slave DMA channel

2012-09-16 Thread Vinod Koul
On Fri, 2012-09-14 at 17:41 -0500, Jon Hunter wrote: > +/** > + * dma_request_slave_channel - try to allocate an exclusive slave > channel > + * @dev: pointer to client device structure > + * @name: slave channel name > + */ > +struct dma_chan *dma_request_slave_channel(struct device *de

Re: [PATCH] dma: tegra: use list_move_tail instead of list_del/list_add_tail

2012-09-13 Thread Vinod Koul
On Wed, 2012-09-05 at 15:08 +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Using list_move_tail() instead of list_del() + list_add_tail(). > > spatch with a semantic match is used to found this problem. > (http://coccinelle.lip6.fr/) > > Signed-off-by: Wei Yongjun Applied thanks > --- > dr

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-08-03 Thread Vinod Koul
On Wed, 2012-08-01 at 15:43 -0500, Jon Hunter wrote: > Hi Vinod, > > On 07/31/2012 06:12 AM, Vinod Koul wrote: > > On Thu, 2012-07-26 at 12:43 -0500, Jon Hunter wrote: > >>>> So yes I can see that a channel itself could be configured to > >> support a > &

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-07-31 Thread Vinod Koul
On Thu, 2012-07-26 at 12:43 -0500, Jon Hunter wrote: > >> So yes I can see that a channel itself could be configured to > support a > >> given direction, but when we ask for a channel via > dma_request_channel() > >> we are going to get a channel that matches the criteria we pass > using > >> the f

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-07-31 Thread Vinod Koul
On Thu, 2012-07-26 at 10:53 -0500, Jon Hunter wrote: > On 07/26/2012 06:28 AM, Vinod Koul wrote: > > On Thu, 2012-07-26 at 07:14 +, Arnd Bergmann wrote: > >> On Thursday 26 July 2012, Vinod Koul wrote: > >>>>> But from a client POV it makes sense as with t

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-07-26 Thread Vinod Koul
On Thu, 2012-07-26 at 07:14 +, Arnd Bergmann wrote: > On Thursday 26 July 2012, Vinod Koul wrote: > > > > But from a client POV it makes sense as with the given direction you > > > > would need a specific request line for a channel. So this is right. > > >

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-07-25 Thread Vinod Koul
On Tue, 2012-07-24 at 14:07 -0500, Jon Hunter wrote: > Hi Vinod, > Required property: > dmas: list of one or more dma specifiers, each consisting of > - phandle pointing to dma controller node > - flags word, a bit map that can hold these flags > * 0x00

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-07-20 Thread Vinod Koul
On Fri, 2012-07-20 at 11:08 +0200, Robert Jarzmik wrote: > Vinod Koul writes: > > >> 4. A dma controller requiring complex configuration: > >> > >>dma: dmaengine@4800 { > >>compatible = "foo,foo-sdm

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-07-20 Thread Vinod Koul
On Fri, 2012-07-20 at 08:39 +, Arnd Bergmann wrote: > On Friday 20 July 2012, Vinod Koul wrote: > > > Required property: > > > dmas: list of one or more dma specifiers, each consisting of > > > - phandle pointing to dma controller node > > >

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-07-19 Thread Vinod Koul
On Tue, 2012-07-17 at 19:24 +, Arnd Bergmann wrote: > On Friday 13 July 2012, Vinod Koul wrote: > > > Do you mean there must be a global table, or are you ok with putting > > > the information about a channel into the device that uses the channel, > > > as we do

Re: [PATCH 07/11] dmaengine: at_hdmac: add a few const qualifiers

2012-07-15 Thread Vinod Koul
On Fri, 2012-07-13 at 14:32 +0200, y...@pengutronix.de wrote: > From: Uwe Kleine-König > > This prepares of_device_id.data becoming const. Without this change > the following warning would occur: > > drivers/dma/at_hdmac.c: In function 'at_dma_get_driver_data': > drivers/dma/at_hdmac

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-07-12 Thread Vinod Koul
On Fri, 2012-07-06 at 13:36 +0200, Guennadi Liakhovetski wrote: > On Mon, 25 Jun 2012, Arnd Bergmann wrote: > > [snip] > > > The channel data in the device tree is still in a format > > that is specific to that dmaengine driver and interpreted > > by it. Using the regular dma_filter_fn prototype

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-07-12 Thread Vinod Koul
On Wed, 2012-06-27 at 15:20 +, Arnd Bergmann wrote: Back from vacation... so restart the pending discussion > > Sorry, I believe I was just using the wrong terminology, and what I named > the slave here would just be the client. > > This may have contributed to a lot of confusion before, so

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-27 Thread Vinod Koul
On Tue, 2012-06-26 at 20:27 +, Arnd Bergmann wrote: > On Tuesday 26 June 2012, Vinod Koul wrote: > > On Tue, 2012-06-26 at 14:59 +, Arnd Bergmann wrote: > > > On Tuesday 26 June 2012, Vinod Koul wrote: > > > > Today, we just ask for a channel with sp

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-26 Thread Vinod Koul
On Tue, 2012-06-26 at 14:59 +, Arnd Bergmann wrote: > On Tuesday 26 June 2012, Vinod Koul wrote: > > Today, we just ask for a channel with specific mask. Further filtering > > is done in filter function as we request a channel, not a specific one. > > In most slave case

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-26 Thread Vinod Koul
On Mon, 2012-06-25 at 20:30 +, Arnd Bergmann wrote: > dma_request_channel is called with some information about the channel > provided in its arguments, and the driver might get that from a number > of places. Today, we just ask for a channel with specific mask. Further filtering is done in fil

Re: [PATCH V3 1/2] of: Add generic device tree DMA helpers

2012-06-25 Thread Vinod Koul
On Mon, 2012-06-25 at 11:51 -0500, Jon Hunter wrote: > Hi Russell, > > On 06/22/2012 06:12 PM, Russell King - ARM Linux wrote: > > Before this goes much further... one fairly obvious and important point > > must be made. > > > > You're designing an API here. You're designing it *WITHOUT* involvi

Re: [PATCH V2 2/2] dmaengine: tegra: add dma driver

2012-05-11 Thread Vinod Koul
On Thu, 2012-05-10 at 10:35 +0530, Laxman Dewangan wrote: > But when we update the chan->completed_cookie for aborted cookie? > Otherwise I will get the DMA_IN_PROGRSS when I call dma_cookie_status() > but actually it is aborted. no in .device_tx_status, you should check if the descriptor is abor

Re: [PATCH V2 2/2] dmaengine: tegra: add dma driver

2012-05-09 Thread Vinod Koul
On Wed, 2012-05-09 at 16:31 +0530, Laxman Dewangan wrote: > Thanks Vinod for reviewing code. > I am removing the code from this thread which is not require. Only > keeping code surrounding our discussion. > > On Wednesday 09 May 2012 03:44 PM, Vinod Koul wrote: > > On Thu

Re: [PATCH V2 2/2] dmaengine: tegra: add dma driver

2012-05-09 Thread Vinod Koul
On Thu, 2012-05-03 at 13:11 +0530, Laxman Dewangan wrote: > Adding dmaengine based NVIDIA's Tegra APB dma driver. > This driver support the slave mode of data transfer from > peripheral to memory and vice versa. > The driver supports for the cyclic and non-cyclic mode > of data transfer. > > Signe

Re: [PATCH V2 1/2] dma: dmaengine: add slave req id in slave_config

2012-05-09 Thread Vinod Koul
On Thu, 2012-05-03 at 13:11 +0530, Laxman Dewangan wrote: > The dma controller like Nvidia's Tegra Dma controller > supports the different slave requestor id from different slave. > This need to be configure in dma controller to handle the request > properly. > > Adding the slave-id in the slave c

Re: [PATCH V1] dmaengine: tegra: add dma driver

2012-04-25 Thread Vinod Koul
On Wed, 2012-04-25 at 15:12 +0530, Laxman Dewangan wrote: > On Wednesday 25 April 2012 03:03 PM, Vinod Koul wrote: > > On Wed, 2012-04-25 at 14:31 +0530, Laxman Dewangan wrote: > >> I had a communication with Russell on another change thread and > >> understand that som

Re: [PATCH V1] dmaengine: tegra: add dma driver

2012-04-25 Thread Vinod Koul
On Wed, 2012-04-25 at 14:31 +0530, Laxman Dewangan wrote: > > I had a communication with Russell on another change thread and > understand that some more work need to be done in virt_chan to support > cyclic one. > > I want to have the cyclic dma support in my driver so I want to go on > foll

Re: [PATCH V1] dmaengine: tegra: add dma driver

2012-04-23 Thread Vinod Koul
On Mon, 2012-04-23 at 17:47 +0530, Laxman Dewangan wrote: > Hi Russell, > On Monday 23 April 2012 02:11 PM, Vinod Koul wrote: > > On Fri, 2012-04-20 at 17:46 +0530, Laxman Dewangan wrote: > >> Thanks Vinod for quick review. > > Since I was on vacation, I hadn't noti

Re: [PATCH V1] dmaengine: tegra: add dma driver

2012-04-23 Thread Vinod Koul
orts are coordinated. Btw I like the virtual channel support introduced by Russell > > On Friday 20 April 2012 04:44 PM, Vinod Koul wrote: > > On Fri, 2012-04-20 at 14:38 +0530, Laxman Dewangan wrote: > > + * dma_transfer_mode: Different dma transfer mode. > >> + * DMA_MOD

Re: [PATCH V1] dmaengine: tegra: add dma driver

2012-04-20 Thread Vinod Koul
On Fri, 2012-04-20 at 14:38 +0530, Laxman Dewangan wrote: > Adding dmaengine based NVIDIA's Tegra APB dma driver. > This driver support the slave mode of data transfer from > peripheral to memory and vice versa. > The driver supports for the cyclic and non-cyclic mode > of data transfer. > > Signe

Re: [PATCH v3 0/4] dmaengine: Device Tree support for Atmel DMA

2011-11-10 Thread Vinod Koul
On Mon, 2011-10-17 at 14:54 +0200, Nicolas Ferre wrote: > On 10/12/2011 06:57 PM, Nicolas Ferre : > > This series add the device tree support to Atmel DMA controller driver: > > at_hdmac. > > The removal of platform data ease the conversion to device tree. It also > > have > > the additional benef

Re: [PATCH v3 0/4] dmaengine: Device Tree support for Atmel DMA

2011-10-23 Thread Vinod Koul
On Mon, 2011-10-17 at 14:54 +0200, Nicolas Ferre wrote: > On 10/12/2011 06:57 PM, Nicolas Ferre : > > This series add the device tree support to Atmel DMA controller driver: > > at_hdmac. > > The removal of platform data ease the conversion to device tree. It also > > have > > the additional benef

Re: [PATCH v3 0/4] dmaengine: Device Tree support for Atmel DMA

2011-10-23 Thread Vinod Koul
On Sun, 2011-10-23 at 16:30 +0200, Nicolas Ferre wrote: > On 10/17/2011 02:54 PM, Nicolas Ferre : > > On 10/12/2011 06:57 PM, Nicolas Ferre : > >> This series add the device tree support to Atmel DMA controller driver: > >> at_hdmac. > >> The removal of platform data ease the conversion to device t

Re: [PATCH 3/4] ARM: at91/dma: remove platform data from DMA controller

2011-10-11 Thread Vinod Koul
On Mon, 2011-10-10 at 18:37 +0200, Nicolas Ferre wrote: > DMA controller can deduce its configuration data from > the platform. Remove the platform data and match device > types with the compatible ones. This looks like remove, you should fix the changelog of patch 1 then. > > Signed-off-by: Nicol

Re: [PATCH 1/4] dmaengine: at_hdmac: platform data move to use .id_table

2011-10-11 Thread Vinod Koul
On Mon, 2011-10-10 at 18:37 +0200, Nicolas Ferre wrote: > We remove platform data from DMA controller and move > to the use of .id_table to distinguish between compatible > types. The two implementations allow to determine the > number of channels and the capabilities of the controller. > > Signed

Re: [PATCH 0/6] Add device tree support for PL330 dma controller driver

2011-09-05 Thread Vinod Koul
On Tue, 2011-08-30 at 17:58 +0530, Thomas Abraham wrote: > Hi Vinod, > > On 29 August 2011 22:59, Vinod Koul wrote: > > On Fri, 2011-08-26 at 14:10 +0530, Thomas Abraham wrote: > >> This patchset adds device tree support for PL330 driver and uses it > >> to ad

Re: [PATCH 0/6] Add device tree support for PL330 dma controller driver

2011-08-30 Thread Vinod Koul
On Fri, 2011-08-26 at 14:10 +0530, Thomas Abraham wrote: > This patchset adds device tree support for PL330 driver and uses it > to add device tree support for Samsung platforms, specifically Exynos4. The DMA patches looks good to me. Do you want this to go thru slave-dma tree or somewhere else. I

Re: [PATCH v2 0/3] Add device tree probe for imx-sdma driver

2011-07-25 Thread Vinod Koul
8 +- > > arch/arm/plat-mxc/devices/platform-imx-dma.c |4 +- > > arch/arm/plat-mxc/include/mach/devices-common.h|2 +- > > arch/arm/plat-mxc/include/mach/dma.h |3 +- > > arch/arm/plat-mxc/include/mach/sdma.h |2 - >