> However, I've completely devoted to this work for at least the next
> two months, so there are plenty more patches to follow. Once I've
\o/ Thanks, Grant! A seperate tree would be great. Patches look good to me:
Acked-by: Wolfram Sang
--
to the hardware and I
have seen devices with equal name and still having different pagesizes. Not too
sure about 'read-only' though, I just copied it from flash-partitions :)
Tested on a phyCORE-MPC5200-IO and build-tested on x86.
Signed-off-by: Wolfram Sang
Cc: Grant Likely
Cc: Anton
> > into the generic code. Take a look at mmc_spi case again, it can be
> > easily extended to any arch, because there is no arch-specific stuff,
> > but a "get/put" pattern for platform data.
Will check this tomorrow.
--
Pengutronix e.K. | W
ch and every driver, uh, the bloat :(
> will take a bit of experimentation to come up with the best form for
> the pdata fetching function, but it will be better contained if it is
> all at a single place.
I might have a try :)
--
Pengutronix e.K. | Wolfram San
;...
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
___
devicetree-discuss
s keyword based approach is
proposed.
Signed-off-by: Wolfram Sang
Cc: Joe Perches
Cc: Grant Likely
Cc: Anton Vorontsov
---
scripts/get_maintainer.pl | 24
1 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.p
olution yet. The archdata surely helps for this
issue, it just seems that a bit more generalization is needed.
Kind regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
si
change afterwards), I
try to make sure this will not so easily happen again (thus the
get_maintainer-patch on lkml).
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
27;d say. Especially as Grant Likely recently said he wants to take
care about OF.
> +K: of_get_property
F: drivers/of/
Will check the script later this weekend.
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions
> settings). I have CCed the devicetree-discuss ML for clarification.
I second Wolfgang's opinion. Pity I can't provide a suitable alternative.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions
ons".
> + * unflatten the tree
> + */
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
___
dev
___
> Linuxppc-dev mailing list
> linuxppc-...@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.d
On Thu, Nov 12, 2009 at 09:36:42PM +0100, Albrecht Dreß wrote:
> Hi Wolfram:
>
> Am 12.11.09 20:56 schrieb(en) Wolfram Sang:
>> > Note: The file drivers/watchdog/mpc5200_wdt.c is now obsolete and should
>> > be removed.
>>
>> Ehrm, this is possible within a p
Signed-off-by: Wolfram Sang
Cc: devicetree-disc...@ozlabs.org
---
Documentation/powerpc/dts-bindings/fsl/mpc5200.txt |9 +
drivers/net/can/mscan/mpc52xx_can.c|3 +--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/powerpc/dts-bindings
> And it turned out that the only sane solution is to write
> OF-pdata-hooks for the each driver (that we do for many drivers
> already):
Or to support Grant in getting rid of of_platform :)
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux
ards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
___
devicetree-discuss mailing list
devicetree-discuss@lis
, microblaze, sparc64, sparc32.
> Boot tested on mpc5200 (ppc32) platform.
test-devicetree as of today also works fine on my phyCORE-MPC5200B-IO.
Tested-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions
ving a look will follow.
Happy new 2010,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital sig
rame lenght and data size and returns
> now correctly. Furthermore, a typo has been fixed.
A few little things, but in general:
Acked-by: Wolfram Sang
>
> Signed-off-by: Wolfgang Grandegger
> ---
> drivers/net/can/mscan/mscan.c | 11 ---
> 1 files changed, 8 insert
/* + 0x64 0x32 */
> - _MSCAN_RESERVED_(25, 2); /* + 0x66 */
> + _MSCAN_RESERVED_(26, 2);/* + 0x66 */
> u16 dsr1_0; /* + 0x68 0x34 */
> - _MSCAN_RESERVED_(26, 2);
bindings/fsl/can.txt".
>
> Signed-off-by: Wolfgang Grandegger
Looks good to me (except for the typos ;))
Acked-by: Wolfram Sang
> ---
> Documentation/powerpc/dts-bindings/fsl/can.txt | 53
>
> Documentation/powerpc/dts-bindings/fsl/mpc5200.txt |
could use 'of_iomap' again in the probe_routine.
>
> I understood that "cell-index" is deprecated and it has been removed
> from many nodes. That's why I used the address to derive the index.
Well, the arguments in your other mail make sense to me, so keep it this
t there with v1 CPUs. If necessary,
> this could be fixed later on demand. But it should be documented, e.g.
> in the KConfig and dts bindings doc, of course.
Yup, documenting it will do.
> Did you have a chance to test bus-off recovery? I just real
should be documented IMHO, and, if
possible, the bindings should allow V1 support in case anyone dares.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description
rame lenght and data size and returns
> now correctly. Furthermore, a typo has been fixed.
>
> Signed-off-by: Wolfgang Grandegger
> Acked-by: Wolfram Sang
> ---
> drivers/net/can/mscan/mscan.c | 11 ---
> 1 files changed, 8 insertions(+), 3 deletions(-)
>
> di
> Wolfram, is it OK from your point of view now? I will roll out v3 after
> some more thorough testing tomorrow.
It still works here and, as I see it, all issues were resolved as discussed.
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfra
> > It still works here and, as I see it, all issues were resolved as discussed.
>
> OK, fine if I add your acked-by then?
I wanted to add a 'Reviewed-by' after I checked V3.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang
y MPC5121 Rev. 2 and later is supported.
>
> Signed-off-by: Wolfgang Grandegger
Reviewed-by: Wolfram Sang
It still works with our board and I didn't find anything else to comment on.
Thanks, Wolfgang!
--
Pengutronix e.K. | Wolfram Sang
= {
> - .setclock = mpc_i2c_setclock_8xxx,
> + .setup = mpc_i2c_setup_8xxx,
> .prescaler = 3,
> };
>
> @@ -606,6 +659,7 @@ static const struct of_device_id mpc_i2c_of_match[] = {
> {.compatible = "mpc5200-i2c", .data = &mpc_i2c_dat
-index = <1>;
> compatible = "fsl,mpc8544-i2c", "fsl-i2c";
> reg = <0x3100 0x100>;
> interrupts = <43 2>;
> --
> 1.6.2.5
>
> --
> To unsubscribe from this lis
tested on a MPC5121ADS, TQM5200 and TQM8560 board
Nice :) BTW, is there a git-tree meanwhile for your or Anatolij's
MPC5121-development?
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/
_i2c_setup_52xx())
'clock == 0' means 'safe divider' (and is checked in mpc_i2c_get_fdr_52xx())
This is not a beauty ;)
What about adding a flags variable to the setup-functions?
Regards,
Wolfram
--
Pengutronix e.K.
d be close
together. That could be a compromise until more quirks are needed ;)
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signatur
> I just sent v2. Hope it's OK now.
Thanks, will check tomorrow.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital s
a. Though, I
have to admit that in the last weeks I haven't followed of-related things due
to other commitments.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signatu
ed to "mpc_i2c_data", which is even the better name.
>
> Signed-off-by: Wolfgang Grandegger
Tested-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de
Grandegger
One minor thing and you can add my
Reviewed-by: Wolfram Sang
> ---
> drivers/i2c/busses/Kconfig |7 +-
> drivers/i2c/busses/i2c-mpc.c | 127
> ++
> 2 files changed, 94 insertions(+), 40 deletions(-)
>
> diff --git a
ot; property from the example nodes.
> Furthermore and example for the MPC5121 has been added.
>
> Signed-off-by: Wolfgang Grandegger
Reviewed-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | h
(u32 *)*p);
> pp->name = pname;
>
> --
> David Gibson | I'll have my music baroque, and my code
> david AT gibson.dropbear.id.au| minimalist, thank you. NOT _the_
> _other_
> | _way_ _around_!
> http://www.ozlabs.org/~dg
must be enabled for the MPC512x by this
> function as well.
>
> Signed-off-by: Wolfgang Grandegger
Acked-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
nts. GPIO controllers may have private xlate-functions, so
'1' could theoretically mean something else than "low-active" (although in
practice it hopefully won't).
> };
>
>
> _______
> devicetree-discuss mailing list
> devicetree-discuss@lists.ozlabs.org
&
the original patch already, it might be necessary to
convert this into a follow-up patch. He will surely tell you. For both
versions, you can add my
Reviewed-by: Wolfram Sang
...
> ---
> diff -upr a/Documentation/powerpc/dts-bindings/fsl/spi.txt
> b/Documentation/powerpc/dts-b
e sense.
Leave those two function pointers empty and fill them during probe (probe has
access to the compatible-property it was matched against, see its arguments).
So it should be a matter of:
if (matched_property == 5200b)
ops->func = this_one;
else
ops->func = th
of the driver would not change by missing your
driver improvement, so there is also no regression.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
On Wed, Jun 02, 2010 at 09:06:54PM -0600, Grant Likely wrote:
> Updated pull request. Added more fixes from Anatolij of the same sort.
Just a second. I think I found two more (using coccinelle)...
--
Pengutronix e.K. | Wolfram Sang|
Industrial Li
Signed-off-by: Wolfram Sang
Cc: Grant Likely
---
arch/powerpc/sysdev/fsl_msi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c
index 0f5bee9..962c2d8 100644
--- a/arch/powerpc/sysdev/fsl_msi.c
+++ b/arch
Signed-off-by: Wolfram Sang
Cc: Grant Likely
---
drivers/crypto/n2_core.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/n2_core.c b/drivers/crypto/n2_core.c
index 8566be8..3f813d3 100644
--- a/drivers/crypto/n2_core.c
+++ b/drivers/crypto
dev)
> return NULL;
>
> diff --git a/include/linux/of_i2c.h b/include/linux/of_i2c.h
> index 34974b5..0efe8d4 100644
> --- a/include/linux/of_i2c.h
> +++ b/include/linux/of_i2c.h
> @@ -12,12 +12,19 @@
> #ifndef __LINUX_OF_I2C_H
> #define __LINUX_OF_I2C_H
>
> Can you email me, perhaps in one tarball, all of the patches I need?
Or push a git tree :)
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signat
node
> )(...);
> ...
> if (x == NULL) S
> <... when != x = E
> *if (...) {
> ... when != of_node_put(x)
> when != if (...) { ... of_node_put(x); ... }
> (
> return <+...x...+>;
> |
> * return ...;
> )
> }
> ...>
> of_node_put
is as
well? You could then add my
Reviewed-by: Wolfram Sang
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @r exists@
> local idexpression x;
> expression E,E1,E2;
> statement S;
> @@
&g
> |of_find_matching_node
> |of_parse_phandle
> )(...);
> ...
> if (x == NULL) S
> <... when != x = E
> *if (...) {
> ... when != of_node_put(x)
> when != if (...) { ... of_node_put(x); ... }
> (
> return <+...x...+>;
> |
> * return ...;
&g
nt_main("call",p1)
> cocci.print_secs("free",p2)
> //
>
> Signed-off-by: Julia Lawall
Acked-by: Wolfram Sang
>
> ---
> drivers/net/fs_enet/fs_enet-main.c |3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drive
Signed-off-by: Wolfram Sang
---
arch/powerpc/boot/dts/pcm030.dts |1 +
arch/powerpc/boot/dts/pcm032.dts |3 ++-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/boot/dts/pcm030.dts b/arch/powerpc/boot/dts/pcm030.dts
index 8a4ec30..e7c36bc 100644
--- a/arch
: Wolfram Sang
---
Grant: As mentioned at ELCE10, I could pretty much respin this old approach I
tried roughly a year ago (just with archdata then). If the approach and docs
are good, I am fine with the patches entering via one of your trees.
Documentation/powerpc/dts-bindings/eeprom.txt | 28
at everything
else is possible :) Thus, this approach. Thus, this approach.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
___
t platform_device *ofdev,
> --
> 1.7.1
>
> ___
> devicetree-discuss mailing list
> devicetree-discuss@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/devicetree-discuss
--
Pen
long ago, so I can't proof it right now. Will try to dig
> up some datasheets when in the office tomorrow.
Had a look, couldn't find anything :( And now?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions
On Tue, Nov 16, 2010 at 02:33:53PM -0600, Rob Herring wrote:
> From: Rob Herring
>
> The base sdhci driver requires a valid ops struct. Add empty struct to
> sdhci-of to allow generic controllers which don't need custom ops functions.
>
> Signed-off-by: Rob Herring
Side-effects happen when passing 0 to either io_limit or page_size. Give
an error in case of this misconfiguration.
Signed-off-by: Wolfram Sang
---
drivers/misc/eeprom/at24.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers
Signed-off-by: Wolfram Sang
---
arch/powerpc/boot/dts/pcm030.dts |1 +
arch/powerpc/boot/dts/pcm032.dts |3 ++-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/boot/dts/pcm030.dts b/arch/powerpc/boot/dts/pcm030.dts
index 8a4ec30..e7c36bc 100644
--- a/arch
: Wolfram Sang
---
Changes since last version:
- use __be32 instead of u32
Documentation/powerpc/dts-bindings/eeprom.txt | 28 +
drivers/misc/eeprom/at24.c| 33
2 files changed, 55 insertions(+), 6 deletions(-)
create mode 100644
Here is the second round of this series:
* 1/3 now uses __be32 instead of u32.
* 2/3 is new and adds some more sanity checks
* 3/3 is unchanged
Grant, I hope you can pick 2/3 as well. Should make things easier and it is
just a misc-driver (which I maintain) :)
Wolfram Sang (3):
misc: at24
upport multiple
> devices, but where probing is difficult (e.g. lm90 driver).
>
> I'm in the process of getting employer approval to get these patches
> upstream.
I hope you will get it approved, it is a lot easier to talk about code :)
Best regards,
Wolfram
--
Pengut
plug */
> MODULE_ALIAS("platform:ocores-i2c");
>
> @@ -355,6 +399,9 @@ static struct platform_driver ocores_i2c_driver = {
> .driver = {
> .owner = THIS_MODULE,
> .name = "ocores-i2c",
> +#ifdef CONFIG_OF
> +.of_match_table
t; > > + i2c->adap.dev.of_node = pdev->dev.of_node;
> > > +#endif
> >
> > No need for the ifdef here.
> >
>
> Why? of_node is protected by CONFIG_OF in linux/device.h
Ehrm, seems my mind broke :( Apologies, I probably was mixing it up with
anot
kernel (PCMCIA being the third user I am aware of). I
wondered if it was feasible to make the "new-id"-code generic and make
those subsystems just use it. I haven't started working on it, though.
Kind regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sa
Introduce a function equivalent to platform_driver_probe() for of. This is
needed to keep some SoC devices in the __init section.
Signed-off-by: Wolfram Sang
---
drivers/of/platform.c | 30 +++---
include/linux/of_platform.h |2 ++
2 files changed, 29
Done by using of_probe_platform_driver() instead of
of_register_platform_driver().
Signed-off-by: Wolfram Sang
---
drivers/spi/mpc52xx_psc_spi.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/mpc52xx_psc_spi.c b/drivers/spi/mpc52xx_psc_spi.c
index
Since of_probe_platform_driver(), this SoC-device can be moved from
__devinit to __init because it is not hotpluggable.
Signed-off-by: Wolfram Sang
---
drivers/spi/mpc512x_psc_spi.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/spi/mpc512x_psc_spi.c b
early, right? :)
All the best,
Wolfram
Wolfram Sang (3):
of: platform: introduce of_probe_platform_driver()
spi: mpc52xx_psc_spi: fix section mismatch warning
spi: mpc512x_psc_spi: move init-routines to __init
drivers/of/platform.c | 30 +++---
driver
> 2- of_platform_driver is deprecated. Drivers should be converted to
> use platform_driver directly.
Ouch, I really should have remembered that. /me grabs a brown paper bag. Sorry
for the noise, dunno what carried me away.
--
Pengutronix e.K. | Wolfra
> + return err;
It may pay off to use managed devices (devm_*), so this part will become
very simple.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.
quot; would be better; then the OS could decide what to do
with the active channels. Then again, what is the drawback of exporting
all channels? Is there another hwmon-driver doing so (couldn't find
one)?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram
vicetree is primarily a hardware
description language) Or maybe we go specific and say "ads1015,channel1
= 1"? Maybe somebody knows of a similar chips as a reference?
Regards,
Wolfram
--
Pengutronix e.K. | Wolfr
It turns out to be useful to have the revision history in the commit
> text that actually gets merged into mainline.
Is this common sense meanwhile? (That is quite many additional lines per
commit)
Regards,
Wolfram
--
Pengutronix e.K.
eleased in 1982). Still BASIC,
though :)) SCNR, I love the 8-bit era...
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Di
> If you don't get any other feedback and Chris is happy with the
I would like to have a look at it, please give me a few days.
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengut
On Tue, Mar 22, 2011 at 09:27:27AM +0100, Heiko Schocher wrote:
> Signed-off-by: Heiko Schocher
> Acked-by: Benjamin Herrenschmidt
> cc: Wolfram Sang
> cc: Grant Likely
> cc: Benjamin Herrenschmidt
> cc: linux-fb...@vger.kernel.org
> cc: devicetree-disc...@ozlabs.org
> As this board is tqm5200 based, added necessary changes
> to the tqm5200_defconfig. In previous patchserie I added
> the changes to mpc5200_defconfig, as Wolfram Sang mentioned,
> but as tqm5200_defconfig is in mainline, and the board is
> tqm5200 based, I t
uio_pdrv_genirq_probe,
> .remove = uio_pdrv_genirq_remove,
> @@ -222,6 +275,7 @@ static struct platform_driver uio_pdrv_genirq = {
> .name = DRIVER_NAME,
> .owner = THIS_MODULE,
> .pm = &uio_pdrv_genirq_dev_pm_ops,
> +
is
>so simple, clean, and elegant.
Simple, yes (I do understand I wrote the first approach ;)) . Elegant,
not really, because it breaks core conventions of the device tree. For
your case it is a very conveniant hack, but it is still a hack.
Regards,
Wolfram
--
Pengutr
up connected to the selected version.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
___
opulating function-pointers which also can't be expressed in a device-tree.
I just wanted to make sure this approach doesn't get overlooked.
So, the solution for now is to simply add a default value and we can check
later if it can be modified at runtime?
Regards,
Wolfram
--
Peng
m, it still deosn't technically have to be empty. So, mabye drop this
comment and add something like "/* empty for now */" to the table?
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solution
r question for the
> >if()-block above). Try platform_get_irq().
>
> I wasn't aware about platform_get_irq. You are right.
>
> What "if()-block above" are you talking about?
The one I quoted: if (pdev->num_resources > 1)
--
Pengutronix e.K.
nfo messages,
only err and warn. So, I'd think these messages should go, too, but this is up
to Hans.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
D
Also, I think the next version of this series should have all makers of
a sdhci-pltfm user CCed so we give them a chance to report breakage. Or
donate acks or tested-by.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Soluti
);
> err_request:
> sdhci_free_host(host);
> err:
> - printk(KERN_ERR"Probing of sdhci-pltfm failed: %d\n", ret);
> - return ret;
> + pr_err("%s failed %d\n", __func__, ret);
dev_err?
> + return NULL;
> }
>
I d
to handle quirks across io-accessor calls */
> +
> + /* migrate from sdhci_of_host */
> + unsigned int clock;
> + u16 xfer_mode_shadow;
xfer_mode_shadow can be merged into scratchpad. They both fix the same
issue.
--
Pengutronix e.K. | Wo
");
> +MODULE_LICENSE("GPL v2");
Please double check the authors. It is based on the fsl driver, but the
copyright should go to
* Copyright (C) 2009 The GameCube Linux Team
* Copyright (C) 2009 Albert Herranz
I think.
--
Pengutronix e.K. | Wolfram
sta Software, Inc.
> + * Author: Anton Vorontsov
> + *
> + * Copyright (c) 2010 Pengutronix e.K.
> + * Author: Wolfram Sang
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published b
f-by: Shawn Guo
Reviewed-by: Wolfram Sang
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
___
dev
his is very much
welcome. I'd suggest waiting for Shawn's interface to stabilize, though.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Descrip
ally I do not even know how v2+ is stated. Do you have an example
> for me to refer?
Check davinci_mmc.c (or grep for 'any later version').
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://w
c devices which also have multiple functions
and have seperate bindings for these functions. It fits the "hardware
description" character of a dt, because it says this PSC is a UART or an
SPI or whatever.
Regards,
Wolfram
--
Pengutronix e.K.
the devicetree, the hardware did
not change.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
ose users anyway, it's not an argument here.
sdhci-dove needs to overload readw/readl. If there is a user not
needings such, i.e. only plain quirks (or even nothing, what a dream!),
then a generic driver might be worthwhile. Can wait until we see such a
user, though.
Regards,
Wolfram
--
Pen
+ /* alloc uioinfo for one device */
> + uioinfo = kzalloc(sizeof(*uioinfo), GFP_KERNEL);
kfree in remove?
--
Pengutronix e.K. | Wolfram Sang|
Industrial Linux Solutions | h
> For example with "vendor,device" compatible string:
> static const struct of_device_id __devinitconst uio_of_genirq_match[] = {
> { .compatible = "vendor,device", },
> { /* empty for now */ },
> };
>
> Signed-o
1 - 100 of 178 matches
Mail list logo
