Re: [PATCH 1/3] ARM: at91: dt: add header to define at_hdmac configuration

2013-06-04 Thread Nicolas Ferre
On 03/06/2013 09:32, Ludovic Desroches : On Fri, May 31, 2013 at 11:30:29PM +0200, Arnd Bergmann wrote: On Thursday 30 May 2013, ludovic.desroc...@atmel.com wrote: +/* + * Source and/or destination peripheral ID + */ +#define AT91_DMA_CFG_PER_ID_MASK (0xff) +#define AT91_DMA_CFG_PER_ID(id

Re: [PATCH 1/3] ARM: at91: dt: add header to define at_hdmac configuration

2013-06-03 Thread Ludovic Desroches
On Fri, May 31, 2013 at 11:30:29PM +0200, Arnd Bergmann wrote: > On Thursday 30 May 2013, ludovic.desroc...@atmel.com wrote: > > +/* > > + * Source and/or destination peripheral ID > > + */ > > +#define AT91_DMA_CFG_PER_ID_MASK (0xff) > > +#define AT91_DMA_CFG_PER_ID(id)(id &

Re: [PATCH 1/3] ARM: at91: dt: add header to define at_hdmac configuration

2013-05-31 Thread Arnd Bergmann
On Thursday 30 May 2013, ludovic.desroc...@atmel.com wrote: > +/* > + * Source and/or destination peripheral ID > + */ > +#define AT91_DMA_CFG_PER_ID_MASK (0xff) > +#define AT91_DMA_CFG_PER_ID(id)(id & > AT91_DMA_CFG_PER_ID_MASK) > + I'm a little worried about macros like th

[PATCH 1/3] ARM: at91: dt: add header to define at_hdmac configuration

2013-05-30 Thread ludovic.desroches
From: Ludovic Desroches DMA-cell content is a concatenation of several values. In order to keep this stuff human readable, macros are introduced. The values for the FIFO configuration are not the same as the ones used in the configuration register in order to keep backward compatibility. Most de