Re: [PATCH v2 4/4] iio: Add OF support

2013-02-04 Thread Guenter Roeck
On Sun, Feb 03, 2013 at 08:22:13AM -0800, Guenter Roeck wrote: [ ... ] + + /* NULL terminated array to save passing size */ + chans = kzalloc(sizeof(*chans)*(nummaps + 1), GFP_KERNEL); I think using kcalloc makes sense here. that would leave chan-data uninitialized, and I would

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-04 Thread Guenter Roeck
On Mon, Feb 04, 2013 at 12:14:52AM +0100, Tomasz Figa wrote: On Sunday 03 of February 2013 19:55:47 Lars-Peter Clausen wrote: On 02/03/2013 06:30 PM, Tomasz Figa wrote: On Sunday 03 of February 2013 09:01:07 Guenter Roeck wrote: On Sun, Feb 03, 2013 at 12:52:40PM +0100, Tomasz Figa wrote:

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-04 Thread Lars-Peter Clausen
On 02/04/2013 06:12 PM, Guenter Roeck wrote: On Mon, Feb 04, 2013 at 12:14:52AM +0100, Tomasz Figa wrote: On Sunday 03 of February 2013 19:55:47 Lars-Peter Clausen wrote: On 02/03/2013 06:30 PM, Tomasz Figa wrote: On Sunday 03 of February 2013 09:01:07 Guenter Roeck wrote: On Sun, Feb 03,

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-04 Thread Guenter Roeck
On Mon, Feb 04, 2013 at 09:12:14AM -0800, Guenter Roeck wrote: On Mon, Feb 04, 2013 at 12:14:52AM +0100, Tomasz Figa wrote: On Sunday 03 of February 2013 19:55:47 Lars-Peter Clausen wrote: On 02/03/2013 06:30 PM, Tomasz Figa wrote: On Sunday 03 of February 2013 09:01:07 Guenter Roeck

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-04 Thread Tomasz Figa
On Monday 04 of February 2013 09:51:34 Guenter Roeck wrote: On Mon, Feb 04, 2013 at 09:12:14AM -0800, Guenter Roeck wrote: On Mon, Feb 04, 2013 at 12:14:52AM +0100, Tomasz Figa wrote: On Sunday 03 of February 2013 19:55:47 Lars-Peter Clausen wrote: On 02/03/2013 06:30 PM, Tomasz Figa

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-04 Thread Guenter Roeck
On Mon, Feb 04, 2013 at 07:00:55PM +0100, Tomasz Figa wrote: On Monday 04 of February 2013 09:51:34 Guenter Roeck wrote: On Mon, Feb 04, 2013 at 09:12:14AM -0800, Guenter Roeck wrote: On Mon, Feb 04, 2013 at 12:14:52AM +0100, Tomasz Figa wrote: On Sunday 03 of February 2013 19:55:47

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Lars-Peter Clausen
On 02/03/2013 03:06 AM, Guenter Roeck wrote: On Sun, Feb 03, 2013 at 02:30:24AM +0100, Tomasz Figa wrote: Hi Guenter, Some comments inline. On Saturday 02 of February 2013 16:59:40 Guenter Roeck wrote: Provide bindings and parse OF data during initialization. Signed-off-by: Guenter Roeck

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Tomasz Figa
On Sunday 03 of February 2013 12:29:23 Lars-Peter Clausen wrote: On 02/03/2013 03:06 AM, Guenter Roeck wrote: On Sun, Feb 03, 2013 at 02:30:24AM +0100, Tomasz Figa wrote: Hi Guenter, Some comments inline. On Saturday 02 of February 2013 16:59:40 Guenter Roeck wrote: Provide

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Lars-Peter Clausen
On 02/03/2013 12:52 PM, Tomasz Figa wrote: On Sunday 03 of February 2013 12:29:23 Lars-Peter Clausen wrote: On 02/03/2013 03:06 AM, Guenter Roeck wrote: On Sun, Feb 03, 2013 at 02:30:24AM +0100, Tomasz Figa wrote: Hi Guenter, Some comments inline. On Saturday 02 of February 2013 16:59:40

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Lars-Peter Clausen
On 02/03/2013 01:59 AM, Guenter Roeck wrote: Provide bindings and parse OF data during initialization. Signed-off-by: Guenter Roeck li...@roeck-us.net --- - Documentation update per feedback - Dropped io-channel-output-names from the bindings document. The property is not used in the

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Guenter Roeck
On Sun, Feb 03, 2013 at 03:17:57PM +0100, Lars-Peter Clausen wrote: On 02/03/2013 01:59 AM, Guenter Roeck wrote: Provide bindings and parse OF data during initialization. Signed-off-by: Guenter Roeck li...@roeck-us.net --- - Documentation update per feedback - Dropped

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Guenter Roeck
On Sun, Feb 03, 2013 at 12:29:23PM +0100, Lars-Peter Clausen wrote: On 02/03/2013 03:06 AM, Guenter Roeck wrote: On Sun, Feb 03, 2013 at 02:30:24AM +0100, Tomasz Figa wrote: Hi Guenter, Some comments inline. On Saturday 02 of February 2013 16:59:40 Guenter Roeck wrote: Provide

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Guenter Roeck
On Sun, Feb 03, 2013 at 12:52:40PM +0100, Tomasz Figa wrote: On Sunday 03 of February 2013 12:29:23 Lars-Peter Clausen wrote: On 02/03/2013 03:06 AM, Guenter Roeck wrote: On Sun, Feb 03, 2013 at 02:30:24AM +0100, Tomasz Figa wrote: Hi Guenter, Some comments inline. On

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Tomasz Figa
On Sunday 03 of February 2013 09:01:07 Guenter Roeck wrote: On Sun, Feb 03, 2013 at 12:52:40PM +0100, Tomasz Figa wrote: On Sunday 03 of February 2013 12:29:23 Lars-Peter Clausen wrote: On 02/03/2013 03:06 AM, Guenter Roeck wrote: On Sun, Feb 03, 2013 at 02:30:24AM +0100, Tomasz Figa

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Lars-Peter Clausen
On 02/03/2013 06:30 PM, Tomasz Figa wrote: On Sunday 03 of February 2013 09:01:07 Guenter Roeck wrote: On Sun, Feb 03, 2013 at 12:52:40PM +0100, Tomasz Figa wrote: On Sunday 03 of February 2013 12:29:23 Lars-Peter Clausen wrote: On 02/03/2013 03:06 AM, Guenter Roeck wrote: On Sun, Feb 03,

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Lars-Peter Clausen
On 02/03/2013 05:31 PM, Guenter Roeck wrote: On Sun, Feb 03, 2013 at 12:29:23PM +0100, Lars-Peter Clausen wrote: On 02/03/2013 03:06 AM, Guenter Roeck wrote: On Sun, Feb 03, 2013 at 02:30:24AM +0100, Tomasz Figa wrote: Hi Guenter, Some comments inline. On Saturday 02 of February 2013

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Jonathan Cameron
On 02/03/2013 06:55 PM, Lars-Peter Clausen wrote: On 02/03/2013 06:30 PM, Tomasz Figa wrote: On Sunday 03 of February 2013 09:01:07 Guenter Roeck wrote: On Sun, Feb 03, 2013 at 12:52:40PM +0100, Tomasz Figa wrote: On Sunday 03 of February 2013 12:29:23 Lars-Peter Clausen wrote: On 02/03/2013

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Lars-Peter Clausen
On 02/03/2013 09:58 PM, Jonathan Cameron wrote: On 02/03/2013 06:55 PM, Lars-Peter Clausen wrote: On 02/03/2013 06:30 PM, Tomasz Figa wrote: On Sunday 03 of February 2013 09:01:07 Guenter Roeck wrote: On Sun, Feb 03, 2013 at 12:52:40PM +0100, Tomasz Figa wrote: On Sunday 03 of February 2013

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-03 Thread Tomasz Figa
On Sunday 03 of February 2013 19:55:47 Lars-Peter Clausen wrote: On 02/03/2013 06:30 PM, Tomasz Figa wrote: On Sunday 03 of February 2013 09:01:07 Guenter Roeck wrote: On Sun, Feb 03, 2013 at 12:52:40PM +0100, Tomasz Figa wrote: On Sunday 03 of February 2013 12:29:23 Lars-Peter Clausen

[PATCH v2 4/4] iio: Add OF support

2013-02-02 Thread Guenter Roeck
Provide bindings and parse OF data during initialization. Signed-off-by: Guenter Roeck li...@roeck-us.net --- - Documentation update per feedback - Dropped io-channel-output-names from the bindings document. The property is not used in the code, and it is not entirely clear what it would be

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-02 Thread Tomasz Figa
Hi Guenter, Some comments inline. On Saturday 02 of February 2013 16:59:40 Guenter Roeck wrote: Provide bindings and parse OF data during initialization. Signed-off-by: Guenter Roeck li...@roeck-us.net --- - Documentation update per feedback - Dropped io-channel-output-names from the

Re: [PATCH v2 4/4] iio: Add OF support

2013-02-02 Thread Guenter Roeck
On Sun, Feb 03, 2013 at 02:30:24AM +0100, Tomasz Figa wrote: Hi Guenter, Some comments inline. On Saturday 02 of February 2013 16:59:40 Guenter Roeck wrote: Provide bindings and parse OF data during initialization. Signed-off-by: Guenter Roeck li...@roeck-us.net --- -