Re: [PATCH v4 4/4] arm: add basic support for Rockchip RK3066a boards

2013-06-18 Thread Arnd Bergmann
On Tuesday 18 June 2013, Heiko Stübner wrote: Side comment: I think it would be nice if the generic code did this init if a l2x0 device node was in the device tree, since the only reason to override init_machine is to do this call in addition to of_platform_populate(). Arnd said similar

Re: [PATCH v4 4/4] arm: add basic support for Rockchip RK3066a boards

2013-06-17 Thread Olof Johansson
Hi, Just some small comments below. Once fixed: Acked-by: Olof Johansson o...@lixom.net On Thu, Jun 13, 2013 at 05:02:13PM +0200, Heiko Stübner wrote: + dwmmc@10214000 { + compatible = rockchip,rk2928-dw-mshc; does it make sense to fall back and also specify

[PATCH v4 4/4] arm: add basic support for Rockchip RK3066a boards

2013-06-13 Thread Heiko Stübner
This adds a generic devicetree board file and a dtsi for boards based on the RK3066a SoCs from Rockchip. Apart from the generic parts (gic, clocks, pinctrl) the only components currently supported are the timers, uarts and mmc ports (all DesignWare- based). Signed-off-by: Heiko Stuebner