Re: [xwiki-devs] [Discussion] What the "templates" directory should contain?

2014-10-08 Thread Guillaume "Louis-Marie" Delhumeau
Yes. I rephrase: we rely on the new skin descriptor that Thomas is working on to be able to specify a *different* base skin for every file system skins ;) 2014-10-08 13:26 GMT+02:00 Thomas Mortagne : > On Wed, Oct 8, 2014 at 12:27 PM, Guillaume "Louis-Marie" Delhumeau > wrote: > > My conclusions

Re: [xwiki-devs] [Discussion] What the "templates" directory should contain?

2014-10-08 Thread Thomas Mortagne
On Wed, Oct 8, 2014 at 12:27 PM, Guillaume "Louis-Marie" Delhumeau wrote: > My conclusions. > > We should keep in the /templates/ directory the files that are sufficiently > generic to be shared with nearly all skins. > > For example: extensions.vm, accessdenied.vm, addnewgroup.vm, etc... > > Then

Re: [xwiki-devs] [Discussion] What the "templates" directory should contain?

2014-10-08 Thread Jean SIMARD
Sounds good to me, at least with my level of comprehension :-) On Wed, Oct 08, 2014 at 12:27:02PM +0200, Guillaume "Louis-Marie" Delhumeau wrote: > My conclusions. > > We should keep in the /templates/ directory the files that are sufficiently > generic to be shared with nearly all skins. > > Fo

Re: [xwiki-devs] [Discussion] What the "templates" directory should contain?

2014-10-08 Thread Guillaume "Louis-Marie" Delhumeau
My conclusions. We should keep in the /templates/ directory the files that are sufficiently generic to be shared with nearly all skins. For example: extensions.vm, accessdenied.vm, addnewgroup.vm, etc... Then, we move all other files to the /colibri/ and the /flamingo/ folders. Finally, we rely

Re: [xwiki-devs] [Discussion] What the "templates" directory should contain?

2014-10-01 Thread Thomas Mortagne
(note that I'm currently working on a descriptor file to allow a skin to declare its own base skin but it's a surprise) On Wed, Oct 1, 2014 at 6:12 PM, Thomas Mortagne wrote: > On Wed, Oct 1, 2014 at 5:43 PM, Ecaterina Moraru (Valica) > wrote: >> On Wed, Oct 1, 2014 at 6:02 PM, Guillaume "Louis-

Re: [xwiki-devs] [Discussion] What the "templates" directory should contain?

2014-10-01 Thread Thomas Mortagne
On Wed, Oct 1, 2014 at 5:43 PM, Ecaterina Moraru (Valica) wrote: > On Wed, Oct 1, 2014 at 6:02 PM, Guillaume "Louis-Marie" Delhumeau < > gdelhum...@xwiki.com> wrote: > >> 2014-10-01 16:41 GMT+02:00 Ecaterina Moraru (Valica) : >> >> > Hi, >> > >> > IMO /templates/ folder makes sense when there are

Re: [xwiki-devs] [Discussion] What the "templates" directory should contain?

2014-10-01 Thread Ecaterina Moraru (Valica)
On Wed, Oct 1, 2014 at 6:02 PM, Guillaume "Louis-Marie" Delhumeau < gdelhum...@xwiki.com> wrote: > 2014-10-01 16:41 GMT+02:00 Ecaterina Moraru (Valica) : > > > Hi, > > > > IMO /templates/ folder makes sense when there are multiple skins > supported. > > Now that Colibri is not the default skin any

Re: [xwiki-devs] [Discussion] What the "templates" directory should contain?

2014-10-01 Thread Guillaume "Louis-Marie" Delhumeau
2014-10-01 16:41 GMT+02:00 Ecaterina Moraru (Valica) : > Hi, > > IMO /templates/ folder makes sense when there are multiple skins supported. > Now that Colibri is not the default skin anymore, we should copy all the > templates specific to Colibri in /colibri/ folder. > Flamingo should contain jus

Re: [xwiki-devs] [Discussion] What the "templates" directory should contain?

2014-10-01 Thread Ecaterina Moraru (Valica)
Hi, IMO /templates/ folder makes sense when there are multiple skins supported. Now that Colibri is not the default skin anymore, we should copy all the templates specific to Colibri in /colibri/ folder. Flamingo should contain just templates specific to it. /templates/ should contain templates s

Re: [xwiki-devs] [Discussion] What the "templates" directory should contain?

2014-10-01 Thread Thomas Mortagne
The location of this folder only make sense when it contains only generic content. All skins inherit from it and having Flamingo inherit from a partial Colibri (which is the current situation) does not make any sense. Having this folder not containing much is not an issue but having it filled with

Re: [xwiki-devs] [Discussion] What the "templates" directory should contain?

2014-10-01 Thread Jean SIMARD
The solution of putting anything *skin-dependent* in the 'skins' directories make sense. And then, let *.vm files that are *not skin-dependent* in the 'templates' directory. In JIRA[1], you argue that files in 'templates' may break one of the skin without noticing it (because you were testing on

[xwiki-devs] [Discussion] What the "templates" directory should contain?

2014-10-01 Thread Guillaume "Louis-Marie" Delhumeau
Hi. Since 6.2, we have the following issue: http://jira.xwiki.org/browse/XWIKI-11027 "The templates directory has VMs from Colibri". Until now, we used to have all *.vm files in this directory, and nothing in the "colibri" one, because Colibri was the default skin. Now that Flamingo is the defau