Re: [xwiki-devs] [Brainstorming] Failing build when deprecated APIs are used in scripts?

2019-04-03 Thread Alex Cotiugă
+1 Thanks, Alex On Wed, Apr 3, 2019 at 11:29 AM Marius Dumitru Florea < mariusdumitru.flo...@xwiki.com> wrote: > +1 > > Thanks, > Marius > > On Fri, Mar 29, 2019 at 11:27 AM Vincent Massol > wrote: > > > Hi devs, > > > > I'd like to discuss about introducing a checker in the tests to fail the

Re: [xwiki-devs] [Brainstorming] Failing build when deprecated APIs are used in scripts?

2019-04-03 Thread Marius Dumitru Florea
+1 Thanks, Marius On Fri, Mar 29, 2019 at 11:27 AM Vincent Massol wrote: > Hi devs, > > I'd like to discuss about introducing a checker in the tests to fail the > test if there's a warning message about a deprecated APIs being used in > scripts. > > For example: > > ``` > 23:59:28.308 [main]

Re: [xwiki-devs] [Brainstorming] Failing build when deprecated APIs are used in scripts?

2019-03-29 Thread Thomas Mortagne
+1 I'm pretty sure we used to have something like this. On Fri, Mar 29, 2019 at 10:27 AM Vincent Massol wrote: > > Hi devs, > > I'd like to discuss about introducing a checker in the tests to fail the test > if there's a warning message about a deprecated APIs being used in scripts. > > For

Re: [xwiki-devs] [Brainstorming] Failing build when deprecated APIs are used in scripts?

2019-03-29 Thread Simon Urli
On 29/03/2019 10:37, Vincent Massol wrote: On 29 Mar 2019, at 10:33, Simon Urli wrote: Hi Vincent, On 29/03/2019 10:27, Vincent Massol wrote: Hi devs, I'd like to discuss about introducing a checker in the tests to fail the test if there's a warning message about a deprecated APIs

Re: [xwiki-devs] [Brainstorming] Failing build when deprecated APIs are used in scripts?

2019-03-29 Thread Vincent Massol
On this same topic, I thought I had fixed all places calling Document#getName() but apparently not: ghts] WARN o.x.v.i.DefaultVelocityEngine - Deprecated usage of getter [com.xpn.xwiki.api.Document.getName] in 20:/templates/getusersandgroups.vm@146,46 10:47:06.975 [Exec Stream Pumper] ERROR

Re: [xwiki-devs] [Brainstorming] Failing build when deprecated APIs are used in scripts?

2019-03-29 Thread Vincent Massol
> On 29 Mar 2019, at 10:37, Vincent Massol wrote: > > > >> On 29 Mar 2019, at 10:33, Simon Urli wrote: >> >> Hi Vincent, >> >> On 29/03/2019 10:27, Vincent Massol wrote: >>> Hi devs, >>> I'd like to discuss about introducing a checker in the tests to fail the >>> test if there's a

Re: [xwiki-devs] [Brainstorming] Failing build when deprecated APIs are used in scripts?

2019-03-29 Thread Vincent Massol
> On 29 Mar 2019, at 10:33, Simon Urli wrote: > > Hi Vincent, > > On 29/03/2019 10:27, Vincent Massol wrote: >> Hi devs, >> I'd like to discuss about introducing a checker in the tests to fail the >> test if there's a warning message about a deprecated APIs being used in >> scripts. >> For

Re: [xwiki-devs] [Brainstorming] Failing build when deprecated APIs are used in scripts?

2019-03-29 Thread Simon Urli
Hi Vincent, On 29/03/2019 10:27, Vincent Massol wrote: Hi devs, I'd like to discuss about introducing a checker in the tests to fail the test if there's a warning message about a deprecated APIs being used in scripts. For example: ``` 23:59:28.308 [main] INFO org.xwiki.test.ui.TestDebugger