Re: DIP 1004 Preliminary Review Round 1

2017-05-10 Thread Mike Parker via Digitalmars-d
On Monday, 8 May 2017 at 08:25:24 UTC, Andrej Mitrovic wrote: On Monday, 1 May 2017 at 14:55:28 UTC, Mike Parker wrote: DIP 1004 is titled "Inherited Constructors. Mike, given the general feedback I've received here, I think the next best take of action is to split the implicit inheritance

Re: DIP 1004 Preliminary Review Round 1

2017-05-09 Thread Mike Parker via Digitalmars-d
On Tuesday, 9 May 2017 at 12:52:38 UTC, deadalnix wrote: On Monday, 8 May 2017 at 08:25:24 UTC, Andrej Mitrovic wrote: Thoughts? It seems like the most sensible path forward. Mike ? Works for me.

Re: DIP 1004 Preliminary Review Round 1

2017-05-09 Thread deadalnix via Digitalmars-d
On Monday, 8 May 2017 at 08:25:24 UTC, Andrej Mitrovic wrote: Thoughts? It seems like the most sensible path forward. Mike ?

Re: DIP 1004 Preliminary Review Round 1

2017-05-08 Thread Andrej Mitrovic via Digitalmars-d
On Monday, 1 May 2017 at 14:55:28 UTC, Mike Parker wrote: DIP 1004 is titled "Inherited Constructors. Mike, given the general feedback I've received here, I think the next best take of action is to split the implicit inheritance proposal into a separate, smaller DIP, and update DIP 1004 with

Re: DIP 1004 Preliminary Review Round 1

2017-05-04 Thread deadalnix via Digitalmars-d
On Tuesday, 2 May 2017 at 11:13:35 UTC, Andrej Mitrovic wrote: On Tuesday, 2 May 2017 at 09:03:27 UTC, deadalnix wrote: 100% in favor of the constructor behavior change in case no constructor is in the derived class. I think we could even split this up into two separate proposals, because thi

Re: DIP 1004 Preliminary Review Round 1

2017-05-03 Thread Daniel N via Digitalmars-d
On Wednesday, 3 May 2017 at 15:09:03 UTC, Andrej Mitrovic wrote: On Wednesday, 3 May 2017 at 12:58:17 UTC, Daniel N wrote: The trick is that your child class need to have defined at least 1 constructor before the alias. This should work: this() {} alias __ctor = super.__ctor; This will give t

Re: DIP 1004 Preliminary Review Round 1

2017-05-03 Thread Mike Wey via Digitalmars-d
On 05/03/2017 05:09 PM, Andrej Mitrovic wrote: On Wednesday, 3 May 2017 at 12:58:17 UTC, Daniel N wrote: The trick is that your child class need to have defined at least 1 constructor before the alias. This should work: this() {} alias __ctor = super.__ctor; This will give the error message y

Re: DIP 1004 Preliminary Review Round 1

2017-05-03 Thread Andrej Mitrovic via Digitalmars-d
On Wednesday, 3 May 2017 at 12:58:17 UTC, Daniel N wrote: The trick is that your child class need to have defined at least 1 constructor before the alias. This should work: this() {} alias __ctor = super.__ctor; This will give the error message you saw: alias __ctor = super.__ctor; this() {}

Re: DIP 1004 Preliminary Review Round 1

2017-05-03 Thread Daniel N via Digitalmars-d
On Wednesday, 3 May 2017 at 12:46:19 UTC, Andrej Mitrovic wrote: On Wednesday, 3 May 2017 at 09:13:54 UTC, Daniel N wrote: However I oppose the other part of the DIP since it's already possible today. class FileException : Exception { this(ErrorCode error_code, string file = __FILE__, uint

Re: DIP 1004 Preliminary Review Round 1

2017-05-03 Thread Andrej Mitrovic via Digitalmars-d
On Wednesday, 3 May 2017 at 09:13:54 UTC, Daniel N wrote: However I oppose the other part of the DIP since it's already possible today. class FileException : Exception { this(ErrorCode error_code, string file = __FILE__, uint line = __LINE__ ) { super("FileNotFound", file, lin

Re: DIP 1004 Preliminary Review Round 1

2017-05-03 Thread Daniel N via Digitalmars-d
On Tuesday, 2 May 2017 at 18:02:15 UTC, Adam D. Ruppe wrote: On Tuesday, 2 May 2017 at 09:03:27 UTC, deadalnix wrote: 100% in favor of the constructor behavior change in case no constructor is in the derived class. I agree. So do I. However I oppose the other part of the DIP since it's alre

Re: DIP 1004 Preliminary Review Round 1

2017-05-02 Thread Adam D. Ruppe via Digitalmars-d
On Tuesday, 2 May 2017 at 09:03:27 UTC, deadalnix wrote: 100% in favor of the constructor behavior change in case no constructor is in the derived class. I agree.

Re: DIP 1004 Preliminary Review Round 1

2017-05-02 Thread Andrej Mitrovic via Digitalmars-d
On Tuesday, 2 May 2017 at 09:03:27 UTC, deadalnix wrote: 100% in favor of the constructor behavior change in case no constructor is in the derived class. I think we could even split this up into two separate proposals, because this part of the DIP is fairly non-controversial and could be appr

Re: DIP 1004 Preliminary Review Round 1

2017-05-02 Thread Basile B. via Digitalmars-d
On Monday, 1 May 2017 at 16:08:36 UTC, Andrej Mitrovic wrote: On Monday, 1 May 2017 at 15:33:47 UTC, Basile B. wrote: On Monday, 1 May 2017 at 14:55:28 UTC, Mike Parker wrote: DIP 1004 is titled "Inherited Constructors. [...] All review-related feedback on and discussion of the DIP should occu

Re: DIP 1004 Preliminary Review Round 1

2017-05-02 Thread Dmitry Olshansky via Digitalmars-d
On 5/2/17 11:03 AM, deadalnix wrote: On Monday, 1 May 2017 at 14:55:28 UTC, Mike Parker wrote: DIP 1004 is titled "Inherited Constructors. https://github.com/dlang/DIPs/blob/master/DIPs/DIP1004.md All review-related feedback on and discussion of the DIP should occur in this thread. Due to DCon

Re: DIP 1004 Preliminary Review Round 1

2017-05-02 Thread deadalnix via Digitalmars-d
On Monday, 1 May 2017 at 14:55:28 UTC, Mike Parker wrote: DIP 1004 is titled "Inherited Constructors. https://github.com/dlang/DIPs/blob/master/DIPs/DIP1004.md All review-related feedback on and discussion of the DIP should occur in this thread. Due to DConf taking place during the review per

Re: DIP 1004 Preliminary Review Round 1

2017-05-01 Thread Andrej Mitrovic via Digitalmars-d
On Monday, 1 May 2017 at 19:02:11 UTC, H. S. Teoh wrote: 1) Suppose my base class has 3 ctors, and I only want my derived class to inherit 1 of them. Does this DIP allow for that? Initially when designing the DIP I haven't thought about this use-case, but I've had more thought put into it rec

Re: DIP 1004 Preliminary Review Round 1

2017-05-01 Thread Andrej Mitrovic via Digitalmars-d
On Monday, 1 May 2017 at 18:34:43 UTC, H. S. Teoh wrote: so the fact that they now have different syntaxes was seen as an advantage. Yeah, I remember that decision. I don't think I've ever agreed with it, though. :o) We'll see.. I don't personally find it very important, I'm fine with eithe

Re: DIP 1004 Preliminary Review Round 1

2017-05-01 Thread H. S. Teoh via Digitalmars-d
On Mon, May 01, 2017 at 02:55:28PM +, Mike Parker via Digitalmars-d wrote: > DIP 1004 is titled "Inherited Constructors. > > https://github.com/dlang/DIPs/blob/master/DIPs/DIP1004.md [...] I'm appalled that the only discussion that has come up so far is related to syntax rather than semantics

Re: DIP 1004 Preliminary Review Round 1

2017-05-01 Thread H. S. Teoh via Digitalmars-d
On Mon, May 01, 2017 at 04:08:36PM +, Andrej Mitrovic via Digitalmars-d wrote: > On Monday, 1 May 2017 at 15:33:47 UTC, Basile B. wrote: > > On Monday, 1 May 2017 at 14:55:28 UTC, Mike Parker wrote: > > > DIP 1004 is titled "Inherited Constructors. [...] > > > All review-related feedback on an

Re: DIP 1004 Preliminary Review Round 1

2017-05-01 Thread Andrej Mitrovic via Digitalmars-d
On Monday, 1 May 2017 at 15:33:47 UTC, Basile B. wrote: On Monday, 1 May 2017 at 14:55:28 UTC, Mike Parker wrote: DIP 1004 is titled "Inherited Constructors. [...] All review-related feedback on and discussion of the DIP should occur in this thread. [...] Destroy! An obvious omission in the

Re: DIP 1004 Preliminary Review Round 1

2017-05-01 Thread Basile B. via Digitalmars-d
On Monday, 1 May 2017 at 15:33:47 UTC, Basile B. wrote: On Monday, 1 May 2017 at 14:55:28 UTC, Mike Parker wrote: DIP 1004 is titled "Inherited Constructors. [...] All review-related feedback on and discussion of the DIP should occur in this thread. [...] Destroy! An obvious omission in the

Re: DIP 1004 Preliminary Review Round 1

2017-05-01 Thread Basile B. via Digitalmars-d
On Monday, 1 May 2017 at 14:55:28 UTC, Mike Parker wrote: DIP 1004 is titled "Inherited Constructors. [...] All review-related feedback on and discussion of the DIP should occur in this thread. [...] Destroy! An obvious omission in the syntax variations [1] - alias this() = super.this(); or

DIP 1004 Preliminary Review Round 1

2017-05-01 Thread Mike Parker via Digitalmars-d
DIP 1004 is titled "Inherited Constructors. https://github.com/dlang/DIPs/blob/master/DIPs/DIP1004.md All review-related feedback on and discussion of the DIP should occur in this thread. Due to DConf taking place during the review period, the period will be extended by a week. The review peri