Re: Request for review: std.net.isemail

2011-03-29 Thread Jacob Carlborg
On 2011-03-28 07:36, Walter Bright wrote: On 3/22/2011 3:04 PM, Jacob Carlborg wrote: I've now finished the port of Dominic Sayers' PHP is_email function (http://www.dominicsayers.com/isemail) and sending it for review. I think it looks nice. I'd add a note saying it is derived from Dominic's

Re: Request for review: std.net.isemail

2011-03-27 Thread Walter Bright
On 3/22/2011 3:04 PM, Jacob Carlborg wrote: I've now finished the port of Dominic Sayers' PHP is_email function (http://www.dominicsayers.com/isemail) and sending it for review. I think it looks nice. I'd add a note saying it is derived from Dominic's php code, I'd add your name to the copyrig

Re: Request for review: std.net.isemail

2011-03-25 Thread dsimcha
On 3/22/2011 6:04 PM, Jacob Carlborg wrote: I've now finished the port of Dominic Sayers' PHP is_email function (http://www.dominicsayers.com/isemail) and sending it for review. A few comments: * Due to limitations in std.regex some unit tests fail and are out commented * Due to some bugs (467

Re: Request for review: std.net.isemail

2011-03-24 Thread Jacob Carlborg
On 2011-03-23 22:20, Dmitry Olshansky wrote: On 23.03.2011 1:04, Jacob Carlborg wrote: I've now finished the port of Dominic Sayers' PHP is_email function (http://www.dominicsayers.com/isemail) and sending it for review. A few comments: * Due to limitations in std.regex some unit tests fail an

Re: Request for review: std.net.isemail

2011-03-24 Thread Jacob Carlborg
On 2011-03-23 18:09, Jonathan M Davis wrote: On 2011-03-22 23:21, dsimcha wrote: On 3/22/2011 6:04 PM, Jacob Carlborg wrote: I've now finished the port of Dominic Sayers' PHP is_email function (http://www.dominicsayers.com/isemail) and sending it for review. A few comments: * Due to limitatio

Re: Request for review: std.net.isemail

2011-03-23 Thread Jonathan M Davis
> On 23.03.2011 1:04, Jacob Carlborg wrote: > > I've now finished the port of Dominic Sayers' PHP is_email function > > (http://www.dominicsayers.com/isemail) and sending it for review. > > > > A few comments: > > > > * Due to limitations in std.regex some unit tests fail and are out > > commente

Re: Request for review: std.net.isemail

2011-03-23 Thread Dmitry Olshansky
On 23.03.2011 1:04, Jacob Carlborg wrote: I've now finished the port of Dominic Sayers' PHP is_email function (http://www.dominicsayers.com/isemail) and sending it for review. A few comments: * Due to limitations in std.regex some unit tests fail and are out commented I have tried that with

Re: Request for review: std.net.isemail

2011-03-23 Thread Jonathan M Davis
> On 2011-03-22 23:21, dsimcha wrote: > > On 3/22/2011 6:04 PM, Jacob Carlborg wrote: > >> I've now finished the port of Dominic Sayers' PHP is_email function > >> (http://www.dominicsayers.com/isemail) and sending it for review. > >> > >> A few comments: > >> > >> * Due to limitations in std.reg

Re: Request for review: std.net.isemail

2011-03-23 Thread Jacob Carlborg
On 2011-03-23 11:46, Nick Sabalausky wrote: "Jacob Carlborg" wrote in message news:imcgim$1sk4$1...@digitalmars.com... On 2011-03-22 23:21, dsimcha wrote: 3. What are EmailStatusCode.On and EmailStatusCode.Off? I had some problem figuring out how I wanted to solve this. In the PHP version t

Re: Request for review: std.net.isemail

2011-03-23 Thread Nick Sabalausky
"Jacob Carlborg" wrote in message news:imcgim$1sk4$1...@digitalmars.com... > On 2011-03-22 23:21, dsimcha wrote: > >> 3. What are EmailStatusCode.On and EmailStatusCode.Off? > > I had some problem figuring out how I wanted to solve this. In the PHP > version the function takes a parameter, error

Re: Request for review: std.net.isemail

2011-03-23 Thread Jacob Carlborg
On 2011-03-22 23:21, dsimcha wrote: On 3/22/2011 6:04 PM, Jacob Carlborg wrote: I've now finished the port of Dominic Sayers' PHP is_email function (http://www.dominicsayers.com/isemail) and sending it for review. A few comments: * Due to limitations in std.regex some unit tests fail and are o

Re: Request for review: std.net.isemail

2011-03-22 Thread dsimcha
On 3/22/2011 6:04 PM, Jacob Carlborg wrote: I've now finished the port of Dominic Sayers' PHP is_email function (http://www.dominicsayers.com/isemail) and sending it for review. A few comments: * Due to limitations in std.regex some unit tests fail and are out commented * Due to some bugs (467

Request for review: std.net.isemail

2011-03-22 Thread Jacob Carlborg
I've now finished the port of Dominic Sayers' PHP is_email function (http://www.dominicsayers.com/isemail) and sending it for review. A few comments: * Due to limitations in std.regex some unit tests fail and are out commented * Due to some bugs (4673, 5744) in Phobos this module contains priv