Re: The delang is using merge instead of rebase/squash

2018-02-02 Thread timotheecour via Digitalmars-d
On Sunday, 19 November 2017 at 04:44:24 UTC, Meta wrote: On Friday, 24 March 2017 at 16:34:46 UTC, Martin Nowak wrote: On Tuesday, 21 March 2017 at 20:16:00 UTC, Atila Neves wrote: git rebase master my_branch git checkout master git merge --no-ff my_branch Yes, that's about what we aim for, r

Re: The delang is using merge instead of rebase/squash

2017-11-18 Thread Meta via Digitalmars-d
On Friday, 24 March 2017 at 16:34:46 UTC, Martin Nowak wrote: On Tuesday, 21 March 2017 at 20:16:00 UTC, Atila Neves wrote: git rebase master my_branch git checkout master git merge --no-ff my_branch Yes, that's about what we aim for, rebase w/ --autosquash though, so that people can `git com

Re: The delang is using merge instead of rebase/squash

2017-03-24 Thread Martin Nowak via Digitalmars-d
On Tuesday, 21 March 2017 at 20:16:00 UTC, Atila Neves wrote: git rebase master my_branch git checkout master git merge --no-ff my_branch Yes, that's about what we aim for, rebase w/ --autosquash though, so that people can `git commit --fixup` new fixup commits to open PRs w/o leaving noise b

Re: The delang is using merge instead of rebase/squash

2017-03-22 Thread Daniel N via Digitalmars-d
On Wednesday, 22 March 2017 at 01:25:37 UTC, Vladimir Panteleev wrote: On Tuesday, 21 March 2017 at 17:58:06 UTC, deadalnix wrote: On Tuesday, 21 March 2017 at 12:45:45 UTC, Vladimir Panteleev wrote: On Tuesday, 21 March 2017 at 11:59:42 UTC, deadalnix wrote: It's not good either. Why would I w

Re: The delang is using merge instead of rebase/squash

2017-03-21 Thread Sebastien Alaiwan via Digitalmars-d
It's common practice for "merge" commits to have the form: "merge work from some/branch, fix PR #somenumber". This basically tells me nothing about what this commit does. We already know it's a merge commit, we don't care so much what branch it's from, and we don't want to dig into the bug trac

Re: The delang is using merge instead of rebase/squash

2017-03-21 Thread Vladimir Panteleev via Digitalmars-d
On Tuesday, 21 March 2017 at 17:58:06 UTC, deadalnix wrote: On Tuesday, 21 March 2017 at 12:45:45 UTC, Vladimir Panteleev wrote: On Tuesday, 21 March 2017 at 11:59:42 UTC, deadalnix wrote: It's not good either. Why would I want to look at a DAG when the serie of event is strictly linear to begi

Re: The delang is using merge instead of rebase/squash

2017-03-21 Thread Atila Neves via Digitalmars-d
On Monday, 20 March 2017 at 05:10:04 UTC, Martin Nowak wrote: On Wednesday, 15 March 2017 at 13:14:31 UTC, deadalnix wrote: This is making the history very spaghettified. Is that possible to have the bot rebase/squash commits and then pushing ? I don't really agree with the argument. A merge

Re: The delang is using merge instead of rebase/squash

2017-03-21 Thread deadalnix via Digitalmars-d
On Tuesday, 21 March 2017 at 12:45:45 UTC, Vladimir Panteleev wrote: On Tuesday, 21 March 2017 at 11:59:42 UTC, deadalnix wrote: It's not good either. Why would I want to look at a DAG when the serie of event is strictly linear to begin with ? Not sure what you mean here. The way it's presente

Re: The delang is using merge instead of rebase/squash

2017-03-21 Thread Vladimir Panteleev via Digitalmars-d
On Tuesday, 21 March 2017 at 11:59:42 UTC, deadalnix wrote: It's not good either. Why would I want to look at a DAG when the serie of event is strictly linear to begin with ? Not sure what you mean here. The way it's presented is not a DAG. Yes, that's why rebasing makes thing clearer. Nobody

Re: The delang is using merge instead of rebase/squash

2017-03-21 Thread deadalnix via Digitalmars-d
On Tuesday, 21 March 2017 at 01:39:39 UTC, Vladimir Panteleev wrote: On Monday, 20 March 2017 at 12:25:22 UTC, deadalnix wrote: Because a picture is clearer than a thousand words: What this tells me is that the default way git-log presents history is not very useful. Consider this presentatio

Re: The delang is using merge instead of rebase/squash

2017-03-20 Thread Vladimir Panteleev via Digitalmars-d
On Monday, 20 March 2017 at 12:25:22 UTC, deadalnix wrote: Because a picture is clearer than a thousand words: What this tells me is that the default way git-log presents history is not very useful. Consider this presentation of the same information: 08ae52d8 The Dlang Bot: Merge pull reque

Re: The delang is using merge instead of rebase/squash

2017-03-20 Thread Martin Nowak via Digitalmars-d
On Monday, 20 March 2017 at 12:25:22 UTC, deadalnix wrote: In addition there are a bunch of practical issues with this way of doing things. First there is no given that any intermediate state is sound, or even builds at all. That makes it very hard to bissect anything. You bissect on master a

Re: The delang is using merge instead of rebase/squash

2017-03-20 Thread deadalnix via Digitalmars-d
On Monday, 20 March 2017 at 05:10:04 UTC, Martin Nowak wrote: On Wednesday, 15 March 2017 at 13:14:31 UTC, deadalnix wrote: This is making the history very spaghettified. Is that possible to have the bot rebase/squash commits and then pushing ? I don't really agree with the argument. A merge

Re: The delang is using merge instead of rebase/squash

2017-03-19 Thread Martin Nowak via Digitalmars-d
On Wednesday, 15 March 2017 at 13:14:31 UTC, deadalnix wrote: This is making the history very spaghettified. Is that possible to have the bot rebase/squash commits and then pushing ? I don't really agree with the argument. A merge commit is a clear way to integrate changes from a PR/branch. Ju

Re: The delang is using merge instead of rebase/squash

2017-03-15 Thread Seb via Digitalmars-d
On Wednesday, 15 March 2017 at 13:23:00 UTC, deadalnix wrote: On Wednesday, 15 March 2017 at 13:14:31 UTC, deadalnix wrote: This is making the history very spaghettified. Is that possible to have the bot rebase/squash commits and then pushing ? Arf I fat fingered the title, i meant the dlang

Re: The delang is using merge instead of rebase/squash

2017-03-15 Thread deadalnix via Digitalmars-d
On Wednesday, 15 March 2017 at 13:14:31 UTC, deadalnix wrote: This is making the history very spaghettified. Is that possible to have the bot rebase/squash commits and then pushing ? Arf I fat fingered the title, i meant the dlang bot.

The delang is using merge instead of rebase/squash

2017-03-15 Thread deadalnix via Digitalmars-d
This is making the history very spaghettified. Is that possible to have the bot rebase/squash commits and then pushing ?