Re: [ODL Discuss] Gerrit verify changes

2023-11-07 Thread Robert Varga
On 07/11/2023 19.48, Andrew Grimberg wrote: Greetings Robert, Hello Andy, [snip] So, if for some reason the GHA started failing this would require a Gerrit admin (LFRE) to disable the hard requirement that the odl.required.gha account has voted. Please note, that LFRE gets every single fa

Re: [ODL Discuss] Gerrit verify changes

2023-11-07 Thread Andrew Grimberg
Greetings Robert, On 11/7/23 10:32, Robert Varga wrote: On 07/11/2023 18.23, Andrew Grimberg wrote: Greetings Robert, Hello Andy, On 11/7/23 06:56, Robert Varga wrote: Hello Andy, On 07/11/2023 15.45, Andrew Grimberg wrote: This job will vote Verified+/-1 depending on the status on all c

Re: [ODL Discuss] Gerrit verify changes

2023-11-07 Thread Robert Varga
On 07/11/2023 18.23, Andrew Grimberg wrote: Greetings Robert, Hello Andy, On 11/7/23 06:56, Robert Varga wrote: Hello Andy, On 07/11/2023 15.45, Andrew Grimberg wrote: This job will vote Verified+/-1 depending on the status on all changes and the vote will come in as the 'ODL Required.GHA'

Re: [ODL Discuss] Gerrit verify changes

2023-11-07 Thread Andrew Grimberg
Greetings Robert, On 11/7/23 06:56, Robert Varga wrote: Hello Andy, On 07/11/2023 15.45, Andrew Grimberg wrote: This job will vote Verified+/-1 depending on the status on all changes and the vote will come in as the 'ODL Required.GHA' account. Gerrit has been updated to _require_ that that us

Re: [ODL Discuss] Gerrit verify changes

2023-11-07 Thread Robert Varga
Hello Andy, On 07/11/2023 15.45, Andrew Grimberg wrote: This job will vote Verified+/-1 depending on the status on all changes and the vote will come in as the 'ODL Required.GHA' account. Gerrit has been updated to _require_ that that user has voted +1 for a change to be submittable. It also r

[ODL Discuss] Gerrit verify changes

2023-11-07 Thread Andrew Grimberg
Greetings folks, TLDR; Changes now require 2 Verify+1 votes to be submittable. One of the votes must come from the 'ODL Required GHA' user. You may or may not be aware that the LF Release Engineering team has been rolling out the ability to use GitHub Actions (GHA) for change verification an