Hi Martin,
do not worry:
No discouragement took place, and I've just added a few lines of doc to
https://github.com/marcusmueller/include-guard-convert,
and I'm totally happy about how much constructive feedback I've got from
everyone!
I really just agree with you that we shouldn't put to much e
On 02/28/2014 10:02 AM, Marcus Müller wrote:
> Hi Martin,
>
> "optimizable guards": #ifndef at start, matching #endif at semantic
> end-of-file; sorry to be unclear on that.
> These are the include guards gcc cpp recognizes as such, which
> suppresses repeated opening & parsing of that header. Agr
Hi Martin,
"optimizable guards": #ifndef at start, matching #endif at semantic
end-of-file; sorry to be unclear on that.
These are the include guards gcc cpp recognizes as such, which suppresses repeated
opening & parsing of that header. Agreeing, though, that this is least
priority. Also, alm
On 02/27/2014 11:42 PM, Marcus Müller wrote:
> As I see things now, I'd just not convert the files to #pragma once.
> However, I do see usefulness in the possibility to analyze headers to
> find 'convertible' include guards, because it is a feasible method of
> ensuring that files don't have errone
Hi Tom, hi fellow GR crowd,
thanks for your feedback and being so considerate :)
Ok, I see all your points and in fact, by now, agree to them.
By the way, to add to your argumentative advantage here:
I didn't expect *any* compile time decrease; in fact, GCC documentation says that iff the
#ifnde
On Sun, Feb 23, 2014 at 3:22 PM, Marcus Müller wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Hi Moritz,
>
> thanks :) I agree on the "let's not break builds for the pure beauty
> of #pragma once" approach. I tried this only to find existing bugs,
> and actually found very little; ho
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Moritz,
thanks :) I agree on the "let's not break builds for the pure beauty
of #pragma once" approach. I tried this only to find existing bugs,
and actually found very little; however, they could be completely
avoided by #pragma once, and therefor
Oh #pragma once - that old chesnut: if you have a few hours you can follow
the various discussions on stackoverflow on it. I think it is at least
enlightening to read through this answer on why it is *not* part of the ISO
C/C++ standards: http://stackoverflow.com/a/1696194
I will note that on MSVC
I'll second what Moritz wrote: Since this pragma is "non standard but widely
supported", let's stick with the header guards since they are guaranteed to
work even with very old C / C++ compilers ... if someone wants to -also- use
this pragma that's fine; having both should not hurt. I'd prefer
Hi Marcus,
some quick Google research found several contradictory sources. [1]
calls it 'non standard but widely supported'.
Since we build on weird platforms I think we should make absolutely
sure that this is the way things should be done ^{TM}.
Some other sources listed this as a potential spee
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hello community,
after finding a minor mistake in a header include file this week, I've
wanted to make sure that the GR header files have proper,
non-conflicting include guards.
So I want to open the discussion whether GR would want to change from
#i
11 matches
Mail list logo
