Re: [Distutils] how sdist generation works in enscons

2017-07-05 Thread Nick Coghlan
On 6 July 2017 at 12:19, Daniel Holth wrote: > Enscons itself doesn't have a way to know whether sdist generation will > succeed other than trying to run 'SCons sdist' against the user provided > build script. Right, so the most `enscons` would be able to do to help prepare the build environment

[Distutils] how sdist generation works in enscons

2017-07-05 Thread Daniel Holth
Here's how sdist generation works in enscons. enscons, a build tool that exists to prototype new Python packaging features, is just a set of tools for SCons that makes it easier to generate wheels and sdists. If targets with certain names exist (sdist, bdist_wheel) then the provide setup.py shim a

Re: [Distutils] A possible refactor/streamlining of PEP 517

2017-07-05 Thread Nick Coghlan
On 6 July 2017 at 07:45, Nathaniel Smith wrote: > On Wed, Jul 5, 2017 at 9:14 AM, Thomas Kluyver wrote: >> On Wed, Jul 5, 2017, at 05:08 PM, Paul Moore wrote: >>> is that flit doesn't handle scenarios like "I unpacked a sdist" or "I >>> downloaded the project archive from github and unpacked that

Re: [Distutils] A possible refactor/streamlining of PEP 517

2017-07-05 Thread Nathaniel Smith
On Wed, Jul 5, 2017 at 9:14 AM, Thomas Kluyver wrote: > On Wed, Jul 5, 2017, at 05:08 PM, Paul Moore wrote: >> is that flit doesn't handle scenarios like "I unpacked a sdist" or "I >> downloaded the project archive from github and unpacked that" well. > > Flit handles these fine for everything *ap

Re: [Distutils] A possible refactor/streamlining of PEP 517

2017-07-05 Thread Paul Moore
On 5 July 2017 at 17:14, Thomas Kluyver wrote: > On Wed, Jul 5, 2017, at 05:08 PM, Paul Moore wrote: >> is that flit doesn't handle scenarios like "I unpacked a sdist" or "I >> downloaded the project archive from github and unpacked that" well. > > Flit handles these fine for everything *apart* fr

Re: [Distutils] A possible refactor/streamlining of PEP 517

2017-07-05 Thread Jeremy Stanley
On 2017-07-05 12:40:08 -0400 (-0400), Donald Stufft wrote: [...] > That doesn’t solve the “I downloaded a archive from GitHub” or “I > mounted my VCS checkout into a docker container without my VCS > installed”, but those can only be solved by the backend tool > itself and IMO it’s perfectly accept

Re: [Distutils] A possible refactor/streamlining of PEP 517

2017-07-05 Thread Donald Stufft
> On Jul 5, 2017, at 12:08 PM, Paul Moore wrote: > > I have to say I still have deep reservations about flit's approach of > assuming/requiring that you're using VCS (git) to maintain your > project. I know that in practical terms most people will be, but it > still seems like a strong assumptio

Re: [Distutils] A possible refactor/streamlining of PEP 517

2017-07-05 Thread Thomas Kluyver
On Wed, Jul 5, 2017, at 05:08 PM, Paul Moore wrote: > is that flit doesn't handle scenarios like "I unpacked a sdist" or "I > downloaded the project archive from github and unpacked that" well. Flit handles these fine for everything *apart* from making an sdist. It can make a wheel, install the pa

Re: [Distutils] A possible refactor/streamlining of PEP 517

2017-07-05 Thread Paul Moore
On 5 July 2017 at 16:19, Donald Stufft wrote: > Quite literally, the only case I can think of that fits into this is flit’s > “I will use git to figure out additional files, but you will have to > configure in a static file the name of the Python package (as in import > package) that you’re distri

Re: [Distutils] A possible refactor/streamlining of PEP 517

2017-07-05 Thread Donald Stufft
> On Jul 5, 2017, at 11:19 AM, Donald Stufft wrote: > > The more I dig into this, the more I think Nathaniel is correct and we’re > trying to add a hook without any real world experience guiding it’s inclusion > that doesn’t actually solve the problem it’s trying to solve and which it’s > pri

Re: [Distutils] A possible refactor/streamlining of PEP 517

2017-07-05 Thread Donald Stufft
> On Jul 5, 2017, at 2:02 AM, Nick Coghlan wrote: > > On 5 July 2017 at 15:49, Donald Stufft wrote: >> I’ve had a niggling feeling about this hook from the beginning, but I >> couldn’t quite put my finger on it until Nathaniel’s email made me realize >> it. I feel like this hook is really *only